@shipfox/client-workflows 19.0.0 → 21.0.0

package/src/pages/workflow-run-list-page.tsx

@@ -49,17 +49,15 @@ export function WorkflowRunsPage({
   );
 
   return (
-    <div className="flex min-h-0 flex-1 overflow-hidden bg-background-neutral-base">
-      <div className="mx-auto flex min-h-0 w-full max-w-[1120px] flex-1 flex-col px-frame py-frame">
-        <WorkflowRunList
-          projectId={projectId}
-          workspaceSlug={workspaceSlug}
-          projectSlug={projectSlug}
-          search={search}
-          onFiltersChange={onFiltersChange}
-          onClearFilters={onClearFilters}
-        />
-      </div>
+    <div data-workflow-page-root="runs" className="flex min-h-0 flex-1 flex-col overflow-hidden">
+      <WorkflowRunList
+        projectId={projectId}
+        workspaceSlug={workspaceSlug}
+        projectSlug={projectSlug}
+        search={search}
+        onFiltersChange={onFiltersChange}
+        onClearFilters={onClearFilters}
+      />
     </div>
   );
 }

package/src/pages/workflow-run-pages.test.tsx

@@ -72,6 +72,19 @@ describe('WorkflowRunPages', () => {
     expect(screen.queryByLabelText('Loading workflow run')).not.toBeInTheDocument();
   });
 
+  test('lets the list route inherit its shell canvas and width', async () => {
+    configureApiClient({fetchImpl: vi.fn(() => new Promise<Response>(() => undefined))});
+
+    const {container} = renderRunsPath();
+
+    await screen.findByLabelText('Workflow runs');
+    const pageRoot = container.querySelector('[data-workflow-page-root="runs"]');
+
+    expect(pageRoot).not.toBeNull();
+    expect(pageRoot).not.toHaveClass('bg-background-neutral-base');
+    expect(pageRoot).not.toHaveClass('max-w-[1120px]');
+  });
+
   test('keeps the list route and filters in place instead of redirecting to a run', async () => {
     configureApiClient({fetchImpl: createRunsListFetch()});
 
@@ -184,6 +197,19 @@ describe('WorkflowRunPages', () => {
     expect(currentSearch(router).tab).toBeUndefined();
   });
 
+  test('lets the run detail route inherit its shell canvas', async () => {
+    configureApiClient({fetchImpl: vi.fn(() => new Promise<Response>(() => undefined))});
+
+    const {container} = renderRunPath();
+
+    expect(await screen.findByRole('region', {name: 'Loading workflow run'})).toBeInTheDocument();
+
+    const pageRoot = container.querySelector('[data-workflow-page-root="run-detail"]');
+
+    expect(pageRoot).not.toBeNull();
+    expect(pageRoot).not.toHaveClass('bg-background-subtle-base');
+  });
+
   test('maps the removed Jobs tab URL to the graph Summary', async () => {
     configureApiClient({fetchImpl: createRunDetailFetch()});
 

package/src/routes/job-detail.tsx

@@ -4,7 +4,7 @@ import {validateWorkflowJobSearch, workflowJobRouteParams} from './inputs.js';
 import {ProjectRoute} from './project-route.js';
 
 export default defineRoute({
-  staticData: {layout: 'full-bleed'},
+  staticData: {frame: 'data'},
   validateSearch: validateWorkflowJobSearch,
   component: () => {
     const {workspaceSlug, projectSlug, workflowRunId, jobId} =

package/src/routes/run-detail.tsx

@@ -4,7 +4,7 @@ import {validateWorkflowRunsSearch, workflowRouteParams} from './inputs.js';
 import {ProjectRoute} from './project-route.js';
 
 export default defineRoute({
-  staticData: {layout: 'full-bleed'},
+  staticData: {frame: 'data'},
   validateSearch: validateWorkflowRunsSearch,
   component: () => {
     const {workspaceSlug, projectSlug, workflowRunId} = useRouteParams(workflowRouteParams);

package/src/routes/runs.tsx

@@ -4,7 +4,7 @@ import {validateWorkflowRunsSearch, workflowRouteParams} from './inputs.js';
 import {ProjectRoute} from './project-route.js';
 
 export default defineRoute({
-  staticData: {layout: 'full-bleed'},
+  staticData: {frame: 'data'},
   validateSearch: validateWorkflowRunsSearch,
   component: () => {
     const {workspaceSlug, projectSlug} = useRouteParams(workflowRouteParams);

package/src/routes/workflows.tsx

@@ -3,6 +3,7 @@ import {ProjectWorkflowsPage} from '#pages/project-workflows-page.js';
 import {ProjectRoute} from './project-route.js';
 
 export default defineRoute({
+  staticData: {frame: 'data'},
   component: () => {
     return (
       <ProjectRoute>{(project) => <ProjectWorkflowsPage projectId={project.id} />}</ProjectRoute>

package/test/fixtures/workflow-run.ts

@@ -82,6 +82,7 @@ export function workflowRunDto(
     jobs: [],
     job_status_counts: [],
     job_display_status_counts: [],
+    has_started_job_execution: false,
     ...overrides,
   };
 }
@@ -136,10 +137,18 @@ function executionStatusForFixtureStatus(
  *
  * Built from one list so the two can never disagree. A fixture whose counts contradicted its
  * preview would hide exactly the bug the split exists to prevent.
+ *
+ * `has_started_job_execution` follows the statuses where they settle it: `succeeded` and `failed`
+ * cannot be reached without running. `pending`, `skipped`, and `cancelled` leave it open, which is
+ * the ambiguity the server flag exists to resolve, so those default to not started and a case that
+ * needs the other reading overrides it.
  */
 export function workflowRunJobsFixture(
   statuses: readonly JobStatusDto[],
-): Pick<WorkflowRunListItemDto, 'jobs' | 'job_status_counts' | 'job_display_status_counts'> {
+): Pick<
+  WorkflowRunListItemDto,
+  'jobs' | 'job_status_counts' | 'job_display_status_counts' | 'has_started_job_execution'
+> {
   const counts = new Map<JobStatusDto, number>();
   for (const status of statuses) counts.set(status, (counts.get(status) ?? 0) + 1);
 
@@ -152,6 +161,9 @@ export function workflowRunJobsFixture(
     jobs: preview,
     job_status_counts: [...counts.entries()].map(([status, count]) => ({status, count})),
     job_display_status_counts: [...counts.entries()].map(([status, count]) => ({status, count})),
+    has_started_job_execution: statuses.some(
+      (status) => status === 'running' || status === 'succeeded' || status === 'failed',
+    ),
   };
 }
 
@@ -159,7 +171,10 @@ export function workflowRunJobsFixture(
 export function workflowRunJobsOfStatus(
   count: number,
   status: JobStatusDto = 'succeeded',
-): Pick<WorkflowRunListItemDto, 'jobs' | 'job_status_counts' | 'job_display_status_counts'> {
+): Pick<
+  WorkflowRunListItemDto,
+  'jobs' | 'job_status_counts' | 'job_display_status_counts' | 'has_started_job_execution'
+> {
   return workflowRunJobsFixture(Array.from({length: count}, () => status));
 }
 
@@ -189,7 +204,12 @@ export function workflowRunListPage(
 export function workflowRunDetailDto(
   overrides: Partial<WorkflowRunDetailResponseDto> = {},
 ): WorkflowRunDetailResponseDto {
-  const {jobs, run_attempt: runAttemptOverride, ...runOverrides} = overrides;
+  const {
+    jobs,
+    run_attempt: runAttemptOverride,
+    has_started_job_execution: hasStartedOverride,
+    ...runOverrides
+  } = overrides;
   const run = workflowRunDto(runOverrides);
 
   return {
@@ -205,6 +225,13 @@ export function workflowRunDetailDto(
         finished_at: run.finished_at,
       }),
     jobs: jobs ?? [],
+    // Follows the executions the case actually built, so the fixture cannot claim a run started
+    // while carrying no execution that did.
+    has_started_job_execution:
+      hasStartedOverride ??
+      (jobs ?? []).some((job) =>
+        job.job_executions.some((execution) => execution.started_at != null),
+      ),
   };
 }