@shipfox/client-workflows 18.0.0 → 20.0.0

package/src/hooks/api/workflow-run-mapper.ts

@@ -96,7 +96,10 @@ export function toWorkflowRunRecord(dto: WorkflowRunResponseDto): WorkflowRunRec
 }
 
 export function toWorkflowRunListItem(dto: WorkflowRunListItemDto): WorkflowRunListItem {
-  const statusCounts = dto.job_status_counts.map(({status, count}) => ({status, count}));
+  const hasDisplayStatusCounts = dto.job_display_status_counts !== undefined;
+  const statusCounts = (dto.job_display_status_counts ?? dto.job_status_counts).map(
+    ({status, count}) => ({status, count}),
+  );
   return {
     ...toWorkflowRunRecord(dto),
     jobs: {
@@ -105,9 +108,18 @@ export function toWorkflowRunListItem(dto: WorkflowRunListItemDto): WorkflowRunL
         key: job.key,
         name: job.name,
         status: job.status,
+        mode: job.mode ?? 'one_shot',
+        listenerStatus: job.listener_status ?? 'inactive',
+        // The optional display-count field is the rollout capability signal. Pre-display API
+        // responses only carry raw verdict counts, so mirror their non-terminal verdict into
+        // execution evidence to keep each legacy glyph aligned with those fallback counts.
+        executionStatus: hasDisplayStatusCounts
+          ? (job.execution_status ?? null)
+          : legacyExecutionStatus(job.status),
         position: job.position,
       })),
       statusCounts,
+      hasStartedJobExecution: dto.has_started_job_execution ?? true,
       // Derived rather than sent: the counts already cover every job, and a separate total
       // would be a second source of truth that could disagree with them.
       total: statusCounts.reduce((sum, entry) => sum + entry.count, 0),
@@ -115,6 +127,12 @@ export function toWorkflowRunListItem(dto: WorkflowRunListItemDto): WorkflowRunL
   };
 }
 
+function legacyExecutionStatus(
+  status: WorkflowRunListItemDto['jobs'][number]['status'],
+): 'pending' | 'running' | null {
+  return status === 'pending' || status === 'running' ? status : null;
+}
+
 export function toWorkflowRunListPage(dto: WorkflowRunListResponseDto): WorkflowRunListPage {
   return {
     runs: dto.runs.map(toWorkflowRunListItem),
@@ -129,6 +147,7 @@ export function toWorkflowRunDetail(dto: WorkflowRunDetailResponseDto): Workflow
     latestAttempt: dto.latest_attempt,
     runAttempt: toWorkflowRunAttempt(dto.run_attempt),
     jobs: dto.jobs.map(toJob),
+    hasStartedJobExecution: dto.has_started_job_execution ?? true,
   };
 }
 

package/src/hooks/api/workflow-runs.ts

@@ -358,7 +358,7 @@ function buildTempRun({
     updatedAt: createdAt,
     isTemporary: true,
     // The optimistic row genuinely has no jobs yet: the server has not planned the graph.
-    jobs: {preview: [], statusCounts: [], total: 0},
+    jobs: {preview: [], statusCounts: [], hasStartedJobExecution: false, total: 0},
     runAttempt: new WorkflowRunAttemptSummary({
       workflowRunId: id,
       attempt: 1,

package/test/fixtures/workflow-run.ts

@@ -81,6 +81,8 @@ export function workflowRunDto(
     finished_at: null,
     jobs: [],
     job_status_counts: [],
+    job_display_status_counts: [],
+    has_started_job_execution: false,
     ...overrides,
   };
 }
@@ -89,11 +91,15 @@ export function workflowRunJobSummaryDto(
   overrides: Partial<WorkflowRunJobSummaryDto> = {},
 ): WorkflowRunJobSummaryDto {
   jobSummarySequence += 1;
+  const status = overrides.status ?? 'succeeded';
   return {
     id: `${JOB_SUMMARY_ID_PREFIX}${String(jobSummarySequence).padStart(11, '0')}`,
     key: `job-${jobSummarySequence}`,
     name: null,
-    status: 'succeeded',
+    status,
+    mode: 'one_shot',
+    listener_status: 'inactive',
+    execution_status: executionStatusForFixtureStatus(status),
     position: jobSummarySequence - 1,
     ...overrides,
   };
@@ -104,13 +110,25 @@ export function workflowRunJobSummaryDtos(
   count: number,
   statuses: readonly JobStatusDto[] = [],
 ): WorkflowRunJobSummaryDto[] {
-  return Array.from({length: count}, (_, index) =>
-    workflowRunJobSummaryDto({
+  return Array.from({length: count}, (_, index) => {
+    const status = statuses[index];
+    return workflowRunJobSummaryDto({
       key: `job-${index + 1}`,
       position: index,
-      ...(statuses[index] ? {status: statuses[index]} : {}),
-    }),
-  );
+      ...(status
+        ? {
+            status,
+            execution_status: executionStatusForFixtureStatus(status),
+          }
+        : {}),
+    });
+  });
+}
+
+function executionStatusForFixtureStatus(
+  status: JobStatusDto,
+): WorkflowRunJobSummaryDto['execution_status'] {
+  return status === 'pending' || status === 'running' ? status : null;
 }
 
 /**
@@ -119,19 +137,33 @@ export function workflowRunJobSummaryDtos(
  *
  * Built from one list so the two can never disagree. A fixture whose counts contradicted its
  * preview would hide exactly the bug the split exists to prevent.
+ *
+ * `has_started_job_execution` follows the statuses where they settle it: `succeeded` and `failed`
+ * cannot be reached without running. `pending`, `skipped`, and `cancelled` leave it open, which is
+ * the ambiguity the server flag exists to resolve, so those default to not started and a case that
+ * needs the other reading overrides it.
  */
 export function workflowRunJobsFixture(
   statuses: readonly JobStatusDto[],
-): Pick<WorkflowRunListItemDto, 'jobs' | 'job_status_counts'> {
+): Pick<
+  WorkflowRunListItemDto,
+  'jobs' | 'job_status_counts' | 'job_display_status_counts' | 'has_started_job_execution'
+> {
   const counts = new Map<JobStatusDto, number>();
   for (const status of statuses) counts.set(status, (counts.get(status) ?? 0) + 1);
 
+  const preview = workflowRunJobSummaryDtos(
+    Math.min(statuses.length, WORKFLOW_RUN_JOB_PREVIEW_LIMIT),
+    statuses,
+  );
+
   return {
-    jobs: workflowRunJobSummaryDtos(
-      Math.min(statuses.length, WORKFLOW_RUN_JOB_PREVIEW_LIMIT),
-      statuses,
-    ),
+    jobs: preview,
     job_status_counts: [...counts.entries()].map(([status, count]) => ({status, count})),
+    job_display_status_counts: [...counts.entries()].map(([status, count]) => ({status, count})),
+    has_started_job_execution: statuses.some(
+      (status) => status === 'running' || status === 'succeeded' || status === 'failed',
+    ),
   };
 }
 
@@ -139,7 +171,10 @@ export function workflowRunJobsFixture(
 export function workflowRunJobsOfStatus(
   count: number,
   status: JobStatusDto = 'succeeded',
-): Pick<WorkflowRunListItemDto, 'jobs' | 'job_status_counts'> {
+): Pick<
+  WorkflowRunListItemDto,
+  'jobs' | 'job_status_counts' | 'job_display_status_counts' | 'has_started_job_execution'
+> {
   return workflowRunJobsFixture(Array.from({length: count}, () => status));
 }
 
@@ -169,7 +204,12 @@ export function workflowRunListPage(
 export function workflowRunDetailDto(
   overrides: Partial<WorkflowRunDetailResponseDto> = {},
 ): WorkflowRunDetailResponseDto {
-  const {jobs, run_attempt: runAttemptOverride, ...runOverrides} = overrides;
+  const {
+    jobs,
+    run_attempt: runAttemptOverride,
+    has_started_job_execution: hasStartedOverride,
+    ...runOverrides
+  } = overrides;
   const run = workflowRunDto(runOverrides);
 
   return {
@@ -185,6 +225,13 @@ export function workflowRunDetailDto(
         finished_at: run.finished_at,
       }),
     jobs: jobs ?? [],
+    // Follows the executions the case actually built, so the fixture cannot claim a run started
+    // while carrying no execution that did.
+    has_started_job_execution:
+      hasStartedOverride ??
+      (jobs ?? []).some((job) =>
+        job.job_executions.some((execution) => execution.started_at != null),
+      ),
   };
 }