@shipfox/client-workflows 12.0.2 → 14.0.0

package/test/fixtures/workflow-run.ts

@@ -6,11 +6,13 @@ import type {
   WorkflowRunDetailResponseDto,
   WorkflowRunJobDetailDto,
   WorkflowRunJobExecutionDetailDto,
+  WorkflowRunJobSummaryDto,
+  WorkflowRunListItemDto,
   WorkflowRunListResponseDto,
-  WorkflowRunResponseDto,
   WorkflowRunStatusDto,
   WorkflowRunStepDetailDto,
 } from '@shipfox/api-workflows-dto';
+import {WORKFLOW_RUN_JOB_PREVIEW_LIMIT} from '@shipfox/api-workflows-dto';
 import type {
   Job,
   Step,
@@ -35,9 +37,11 @@ const DEFINITION_ID = '33333333-3333-4333-8333-333333333333';
 const JOB_ID = '44444444-4444-4444-8444-000000000001';
 const JOB_EXECUTION_ID = '77777777-7777-4777-8777-000000000001';
 const STEP_ID = '55555555-5555-4555-8555-000000000001';
+const JOB_SUMMARY_ID_PREFIX = '44444444-4444-4444-8444-1';
 
 let runSequence = 0;
 let jobSequence = 0;
+let jobSummarySequence = 0;
 let jobExecutionSequence = 0;
 let stepSequence = 0;
 let attemptSequence = 0;
@@ -49,14 +53,18 @@ export type JobDtoOverrides = Partial<Omit<WorkflowRunJobDetailDto, 'job_executi
 
 type JobDtoBase = Omit<WorkflowRunJobDetailDto, 'job_executions'>;
 
+// Built as a list item, the widest run shape, so one factory serves both the list endpoint
+// and the single-run endpoints; the narrower response schemas drop the extra key.
 export function workflowRunDto(
-  overrides: Partial<WorkflowRunResponseDto> = {},
-): WorkflowRunResponseDto {
+  overrides: Partial<WorkflowRunListItemDto> = {},
+): WorkflowRunListItemDto {
   return {
     id: RUN_ID,
     project_id: PROJECT_ID,
     definition_id: DEFINITION_ID,
+    number: 1,
     name: 'deploy-web',
+    workflow_name: 'deploy-web',
     status: 'running',
     current_attempt: 1,
     latest_attempt: 1,
@@ -64,18 +72,79 @@ export function workflowRunDto(
     trigger_source: 'manual',
     trigger_event: 'fire',
     trigger_payload: {},
+    trigger_reference: null,
     inputs: null,
     source_snapshot: null,
     created_at: '2026-06-21T12:00:00.000Z',
     updated_at: '2026-06-21T12:01:00.000Z',
     started_at: null,
     finished_at: null,
+    jobs: [],
+    job_status_counts: [],
     ...overrides,
   };
 }
 
+export function workflowRunJobSummaryDto(
+  overrides: Partial<WorkflowRunJobSummaryDto> = {},
+): WorkflowRunJobSummaryDto {
+  jobSummarySequence += 1;
+  return {
+    id: `${JOB_SUMMARY_ID_PREFIX}${String(jobSummarySequence).padStart(11, '0')}`,
+    key: `job-${jobSummarySequence}`,
+    name: null,
+    status: 'succeeded',
+    position: jobSummarySequence - 1,
+    ...overrides,
+  };
+}
+
+/** A strip of `count` job glyphs, with `statuses` applied from the left. */
+export function workflowRunJobSummaryDtos(
+  count: number,
+  statuses: readonly JobStatusDto[] = [],
+): WorkflowRunJobSummaryDto[] {
+  return Array.from({length: count}, (_, index) =>
+    workflowRunJobSummaryDto({
+      key: `job-${index + 1}`,
+      position: index,
+      ...(statuses[index] ? {status: statuses[index]} : {}),
+    }),
+  );
+}
+
+/**
+ * A run's jobs as the API sends them: the preview truncated at the server's bound, and counts
+ * over every status given.
+ *
+ * Built from one list so the two can never disagree. A fixture whose counts contradicted its
+ * preview would hide exactly the bug the split exists to prevent.
+ */
+export function workflowRunJobsFixture(
+  statuses: readonly JobStatusDto[],
+): Pick<WorkflowRunListItemDto, 'jobs' | 'job_status_counts'> {
+  const counts = new Map<JobStatusDto, number>();
+  for (const status of statuses) counts.set(status, (counts.get(status) ?? 0) + 1);
+
+  return {
+    jobs: workflowRunJobSummaryDtos(
+      Math.min(statuses.length, WORKFLOW_RUN_JOB_PREVIEW_LIMIT),
+      statuses,
+    ),
+    job_status_counts: [...counts.entries()].map(([status, count]) => ({status, count})),
+  };
+}
+
+/** `count` jobs that all share one status, for density cases where the mix does not matter. */
+export function workflowRunJobsOfStatus(
+  count: number,
+  status: JobStatusDto = 'succeeded',
+): Pick<WorkflowRunListItemDto, 'jobs' | 'job_status_counts'> {
+  return workflowRunJobsFixture(Array.from({length: count}, () => status));
+}
+
 export function workflowRunListItem(
-  overrides: Partial<WorkflowRunResponseDto> = {},
+  overrides: Partial<WorkflowRunListItemDto> = {},
 ): WorkflowRunListItem {
   return toWorkflowRunListItem(workflowRunDto(overrides));
 }
@@ -276,8 +345,8 @@ export function sequencedWorkflowRunDto(
   status: WorkflowRunStatusDto,
   name: string,
   minutesAgo: number,
-  overrides: Partial<WorkflowRunResponseDto> = {},
-): WorkflowRunResponseDto {
+  overrides: Partial<WorkflowRunListItemDto> = {},
+): WorkflowRunListItemDto {
   runSequence += 1;
   return workflowRunDto({
     id: `run-${String(runSequence).padStart(8, '0')}`,
@@ -298,7 +367,7 @@ export function sequencedWorkflowRunListItem(
   status: WorkflowRunStatusDto,
   name: string,
   minutesAgo: number,
-  overrides: Partial<WorkflowRunResponseDto> = {},
+  overrides: Partial<WorkflowRunListItemDto> = {},
 ): WorkflowRunListItem {
   return toWorkflowRunListItem(sequencedWorkflowRunDto(status, name, minutesAgo, overrides));
 }

package/test/pages.tsx

@@ -1,5 +1,10 @@
 import {configureApiClient} from '@shipfox/client-api';
-import {type AuthState, authStateAtom} from '@shipfox/client-shell/runtime';
+import {
+  type AuthState,
+  authStateAtom,
+  parseAppSearch,
+  stringifyAppSearch,
+} from '@shipfox/client-shell/runtime';
 import {Toaster} from '@shipfox/react-ui/toast';
 import {QueryClient, QueryClientProvider} from '@tanstack/react-query';
 import {
@@ -19,18 +24,19 @@ import {validateWorkflowRunsSearch} from '#routes/inputs.js';
 
 // The workflow run page navigates with the router (run rows are links and the page redirects
 // to the first run), so the harness mounts the page under a memory router whose route tree
-// carries the `/workspaces/$wid/projects/$pid/runs/$workflowRunId` params the components read. The
+// carries the `/w/$workspaceSlug/p/$projectSlug/runs/$workflowRunId` params the components read. The
 // page is supplied as a factory the detail route calls with the current `workflowRunId`, mirroring
 // the real route wiring so a redirect re-renders the page with the run it landed on.
 export const PROJECT_TEST_WID = '11111111-1111-4111-8111-111111111111';
+export const PROJECT_TEST_WSLUG = 'acme';
 
 // Pages that render components depending on `useActiveWorkspace()` (e.g. the project source
-// strip) need an authenticated workspace matching `$wid` in the atom `client-shell/runtime`
+// strip) need an authenticated workspace matching `$workspaceSlug` in the atom `client-shell/runtime`
 // reads. A fixed membership id is fine here: nothing in these tests asserts on it.
 const authState: AuthState = {
   status: 'authenticated',
   token: 'token',
-  workspaces: [{id: PROJECT_TEST_WID, name: 'Acme', membershipId: 'm-1'}],
+  workspaces: [{id: PROJECT_TEST_WID, name: 'Acme', slug: PROJECT_TEST_WSLUG, membershipId: 'm-1'}],
 };
 
 export function jsonResponse(body: unknown, init: ResponseInit = {}) {
@@ -51,7 +57,7 @@ function createTestRouter(
   const rootRoute = createRootRoute({component: Outlet});
   const runsRoute = createRoute({
     getParentRoute: () => rootRoute,
-    path: '/workspaces/$wid/projects/$pid/runs',
+    path: '/w/$workspaceSlug/p/$projectSlug/runs',
     component: function RunsRoute() {
       return renderPage({
         search: validateWorkflowRunsSearch(useSearch({strict: false}) as Record<string, unknown>),
@@ -60,7 +66,7 @@ function createTestRouter(
   });
   const runDetailRoute = createRoute({
     getParentRoute: () => rootRoute,
-    path: '/workspaces/$wid/projects/$pid/runs/$workflowRunId',
+    path: '/w/$workspaceSlug/p/$projectSlug/runs/$workflowRunId',
     component: function RunDetailRoute() {
       const {workflowRunId} = useParams({strict: false}) as {workflowRunId?: string};
       return renderPage({
@@ -71,17 +77,21 @@ function createTestRouter(
   });
   const workflowsRoute = createRoute({
     getParentRoute: () => rootRoute,
-    path: '/workspaces/$wid/projects/$pid/workflows',
+    path: '/w/$workspaceSlug/p/$projectSlug/workflows',
     component: () => renderPage({search: {}}),
   });
   const modelProviderSettingsRoute = createRoute({
     getParentRoute: () => rootRoute,
-    path: '/workspaces/$wid/settings/agents',
+    path: '/w/$workspaceSlug/settings/agents',
     component: () => <div>Agent settings placeholder</div>,
   });
 
   return createRouter({
     history: createMemoryHistory({initialEntries: [path]}),
+    // Mirrors the generated app router so repeated search keys behave here as they do in
+    // production; the default encoder would JSON-encode a multi-select instead.
+    parseSearch: parseAppSearch,
+    stringifySearch: stringifyAppSearch,
     routeTree: rootRoute.addChildren([
       runsRoute,
       runDetailRoute,

package/test/render.tsx

@@ -19,13 +19,19 @@ function createComponentRouter(element: ReactElement) {
   // Workflow run rows link here; TanStack Router needs the target route to build hrefs.
   const runDetailRoute = createRoute({
     getParentRoute: () => rootRoute,
-    path: '/workspaces/$wid/projects/$pid/runs/$workflowRunId',
+    path: '/w/$workspaceSlug/p/$projectSlug/runs/$workflowRunId',
+    component: () => null,
+  });
+  // The unfiltered empty state links here.
+  const workflowsRoute = createRoute({
+    getParentRoute: () => rootRoute,
+    path: '/w/$workspaceSlug/p/$projectSlug/workflows',
     component: () => null,
   });
 
   return createRouter({
     history: createMemoryHistory({initialEntries: ['/']}),
-    routeTree: rootRoute.addChildren([indexRoute, runDetailRoute]),
+    routeTree: rootRoute.addChildren([indexRoute, runDetailRoute, workflowsRoute]),
   });
 }