@shipfox/client-triggers 4.0.0 → 6.0.1

package/src/pages/events-page.test.tsx

@@ -1,9 +1,9 @@
 import type {
   TriggerEventDetailResponseDto,
   TriggerEventListItemDto,
-  TriggerEventListResponseDto,
 } from '@shipfox/api-triggers-dto';
 import {fireEvent, render, screen, waitFor} from '@testing-library/react';
+import {toTriggerEventDetail, toTriggerEventListPage} from '#hooks/api/trigger-event-mapper.js';
 import {
   useTriggerEventFacetsQuery,
   useTriggerEventQuery,
@@ -49,10 +49,10 @@ function makeDetail(overrides: Partial<TriggerEventDetailResponseDto> = {}) {
 }
 
 function makeListQuery(triggerEvents: TriggerEventListItemDto[]) {
-  const page: TriggerEventListResponseDto = {
+  const page = toTriggerEventListPage({
     trigger_events: triggerEvents,
     next_cursor: null,
-  };
+  });
 
   return {
     data: {pages: [page], pageParams: [undefined]},
@@ -75,7 +75,7 @@ describe('EventsPage', () => {
     useTriggerEventQueryMock.mockImplementation(
       (eventId) =>
         ({
-          data: eventId ? makeDetail({id: eventId}) : undefined,
+          data: eventId ? toTriggerEventDetail(makeDetail({id: eventId})) : undefined,
           isError: false,
           refetch: vi.fn(),
         }) as unknown as ReturnType<typeof useTriggerEventQuery>,

package/src/pages/events-page.tsx

@@ -1,12 +1,11 @@
-import type {TriggerEventListItemDto} from '@shipfox/api-triggers-dto';
 import {RelativeTimeProvider} from '@shipfox/react-ui/relative-time';
 import {Header, Text} from '@shipfox/react-ui/typography';
 import {cn} from '@shipfox/react-ui/utils';
 import {useEffect, useMemo, useState} from 'react';
 import {EventsList} from '#components/events-list.js';
 import {TriggerEventDetail} from '#components/trigger-event-detail.js';
+import type {TriggerEventFilters, TriggerEventSummary} from '#core/trigger-event.js';
 import {
-  type TriggerEventFilters,
   useTriggerEventFacetsQuery,
   useTriggerEventsInfiniteQuery,
 } from '#hooks/api/trigger-events.js';
@@ -26,8 +25,8 @@ export function EventsPage({workspaceId, filters, onFiltersChange}: EventsPagePr
   const facetsQuery = useTriggerEventFacetsQuery(workspaceId);
   const [selectedEventId, setSelectedEventId] = useState<string | undefined>();
 
-  const events = useMemo<TriggerEventListItemDto[]>(
-    () => query.data?.pages.flatMap((page) => page.trigger_events) ?? [],
+  const events = useMemo<TriggerEventSummary[]>(
+    () => query.data?.pages.flatMap((page) => page.events) ?? [],
     [query.data],
   );
 

package/src/routes/events-settings.tsx

@@ -0,0 +1,30 @@
+import {defineRoute, useActiveWorkspace} from '@shipfox/client-shell/runtime';
+import {getRouteApi} from '@tanstack/react-router';
+import type {TriggerEventFilters} from '#core/trigger-event.js';
+import {EventsPage} from '#pages/events-page.js';
+import {type TriggerEventsSearch, validateTriggerEventsSearch} from '#search.js';
+
+const routeApi = getRouteApi('/workspaces/$wid/settings/events');
+
+// Wrapped (not just re-typed) so the search validator's own type is portable outside this
+// package: TanStack Router's `const` generics capture the exact declared function, and a
+// route module consumed from another package (apps/client's composed router) can't print a
+// type that only resolves through this package's internal `#search.js` path.
+function validateSearch(search: Record<string, unknown>): TriggerEventsSearch {
+  return validateTriggerEventsSearch(search);
+}
+
+export default defineRoute({
+  validateSearch,
+  component: () => {
+    const workspace = useActiveWorkspace();
+    const search = routeApi.useSearch();
+    const navigate = routeApi.useNavigate();
+    const onFiltersChange = (patch: Partial<TriggerEventFilters>) => {
+      void navigate({search: {...search, ...patch}, replace: true});
+    };
+    return (
+      <EventsPage workspaceId={workspace.id} filters={search} onFiltersChange={onFiltersChange} />
+    );
+  },
+});

package/src/search.ts

@@ -1,5 +1,5 @@
-import {triggerEventOutcomeSchema} from '@shipfox/api-triggers-dto';
 import {z} from 'zod';
+import {type TriggerEventFilters, triggerEventOutcomes} from '#core/trigger-event.js';
 
 const stringListSearchSchema = z
   .preprocess((value) => (typeof value === 'string' ? [value] : value), z.array(z.string()))
@@ -9,14 +9,13 @@ const stringListSearchSchema = z
 const outcomeListSearchSchema = z
   .preprocess(
     (value) => (typeof value === 'string' ? [value] : value),
-    z.array(triggerEventOutcomeSchema),
+    z.array(z.enum(triggerEventOutcomes)),
   )
   .optional()
   .catch(undefined);
 
 /**
- * URL search params for the Events page. Reuses the DTO outcome enum so the page and the
- * read API share one source of truth, and matches the `TriggerEventFilters` shape the data
+ * URL search params for the Events page. Matches the `TriggerEventFilters` shape the data
  * hook consumes. Every field uses `.catch(undefined)` so a hand-edited or stale URL drops
  * the bad param rather than throwing inside the router's `validateSearch`.
  */
@@ -31,7 +30,7 @@ export const triggerEventsSearchSchema = z.object({
   to: z.string().datetime().optional().catch(undefined),
 });
 
-export type TriggerEventsSearch = z.infer<typeof triggerEventsSearchSchema>;
+export type TriggerEventsSearch = z.infer<typeof triggerEventsSearchSchema> & TriggerEventFilters;
 
 export function validateTriggerEventsSearch(search: Record<string, unknown>): TriggerEventsSearch {
   return triggerEventsSearchSchema.parse(search);