@shipfox/api-workflows 10.1.0 → 11.0.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@shipfox/api-workflows",
   "license": "MIT",
-  "version": "10.1.0",
+  "version": "11.0.0",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/ShipfoxHQ/shipfox.git",
@@ -22,29 +22,29 @@
     "@temporalio/workflow": "1.18.1",
     "drizzle-orm": "^0.45.2",
     "zod": "^4.4.3",
-    "@shipfox/api-auth-context": "10.1.0",
-    "@shipfox/api-auth-dto": "10.1.0",
+    "@shipfox/api-auth-context": "11.0.0",
+    "@shipfox/api-auth-dto": "10.2.0",
     "@shipfox/api-agent-dto": "10.0.0",
     "@shipfox/annotations-dto": "9.0.2",
-    "@shipfox/api-definitions-dto": "10.0.0",
+    "@shipfox/api-definitions-dto": "11.0.0",
     "@shipfox/api-projects-dto": "10.1.0",
     "@shipfox/api-integration-core-dto": "9.0.2",
-    "@shipfox/api-runners-dto": "10.0.0",
     "@shipfox/api-secrets-dto": "9.0.2",
     "@shipfox/api-workflows-dto": "10.0.0",
-    "@shipfox/api-workspaces-dto": "10.0.0",
     "@shipfox/inter-module": "0.2.2",
-    "@shipfox/expression": "1.2.0",
+    "@shipfox/expression": "1.2.1",
+    "@shipfox/api-workspaces-dto": "11.0.0",
+    "@shipfox/api-runners-dto": "10.2.0",
     "@shipfox/node-drizzle": "0.3.4",
     "@shipfox/node-error-monitoring": "0.3.0",
-    "@shipfox/node-fastify": "0.4.0",
     "@shipfox/node-module": "1.0.4",
     "@shipfox/node-opentelemetry": "0.6.3",
     "@shipfox/node-outbox": "0.2.6",
     "@shipfox/node-postgres": "0.4.4",
     "@shipfox/node-temporal": "0.4.4",
     "@shipfox/runner-labels": "0.1.3",
-    "@shipfox/workflow-document": "2.1.3"
+    "@shipfox/workflow-document": "2.1.3",
+    "@shipfox/node-fastify": "0.4.0"
   },
   "imports": {
     "#*": "./dist/*"

package/src/presentation/routes/cancel-run.test.ts

@@ -34,7 +34,7 @@ describe('POST /api/workflows/runs/:id/cancel', () => {
         buildUserContext({
           userId: crypto.randomUUID(),
           email: 'user@example.com',
-          memberships: [{workspaceId, role: 'admin'}],
+          memberships: [{workspaceId, role: 'admin', workspaceStatus: 'active'}],
         }),
       );
       done();

package/src/presentation/routes/get-run-aggregates.test.ts

@@ -39,7 +39,7 @@ describe('GET /api/workflows/runs/aggregates', () => {
         buildUserContext({
           userId: crypto.randomUUID(),
           email: 'user@example.com',
-          memberships: [{workspaceId, role: 'admin'}],
+          memberships: [{workspaceId, role: 'admin', workspaceStatus: 'active'}],
         }),
       );
       done();

package/src/presentation/routes/get-run.test.ts

@@ -49,6 +49,7 @@ const projects = {
 describe('GET /api/workflows/runs/:id', () => {
   let app: FastifyInstance;
   let workspaceId: string;
+  let workspaceStatus: 'active' | 'deleted';
 
   beforeAll(async () => {
     app = Fastify();
@@ -60,7 +61,7 @@ describe('GET /api/workflows/runs/:id', () => {
         buildUserContext({
           userId: crypto.randomUUID(),
           email: 'user@example.com',
-          memberships: [{workspaceId, role: 'admin'}],
+          memberships: [{workspaceId, role: 'admin', workspaceStatus}],
         }),
       );
       done();
@@ -71,6 +72,7 @@ describe('GET /api/workflows/runs/:id', () => {
 
   beforeEach(() => {
     workspaceId = crypto.randomUUID();
+    workspaceStatus = 'active';
     projectAccessState.workspaceId = workspaceId;
     getProjectById.mockImplementation(({projectId}) =>
       Promise.resolve({
@@ -368,6 +370,30 @@ jobs:
     expect(detailSpy).not.toHaveBeenCalled();
   });
 
+  test('preserves workspace-inactive for a deleted membership claim', async () => {
+    workspaceStatus = 'deleted';
+    const run = await createWorkflowRun({
+      workspaceId,
+      projectId: crypto.randomUUID(),
+      definitionId: crypto.randomUUID(),
+      model: workflowModel({name: 'Test'}),
+      triggerPayload: {
+        source: 'manual',
+        event: 'fire',
+        subscriptionId: crypto.randomUUID(),
+        userId: crypto.randomUUID(),
+      },
+    });
+
+    const res = await app.inject({
+      method: 'GET',
+      url: `/api/workflows/runs/${run.id}`,
+    });
+
+    expect(res.statusCode).toBe(403);
+    expect(res.json().code).toBe('workspace-inactive');
+  });
+
   test('propagates unexpected errors from project access check', async () => {
     const run = await createWorkflowRun({
       workspaceId,

package/src/presentation/routes/list-run-attempts.test.ts

@@ -36,7 +36,7 @@ describe('GET /api/workflows/runs/:id/attempts', () => {
         buildUserContext({
           userId: crypto.randomUUID(),
           email: 'user@example.com',
-          memberships: [{workspaceId, role: 'admin'}],
+          memberships: [{workspaceId, role: 'admin', workspaceStatus: 'active'}],
         }),
       );
       done();

package/src/presentation/routes/list-runs.test.ts

@@ -43,7 +43,7 @@ describe('GET /api/workflows/runs', () => {
         buildUserContext({
           userId: crypto.randomUUID(),
           email: 'user@example.com',
-          memberships: [{workspaceId, role: 'admin'}],
+          memberships: [{workspaceId, role: 'admin', workspaceStatus: 'active'}],
         }),
       );
       done();

package/src/presentation/routes/require-accessible-run.ts

@@ -20,7 +20,10 @@ export async function requireAccessibleRun({
   }
 
   await requireProjectAccess(request, run.projectId, projects).catch((err: unknown) => {
-    if (err instanceof ClientError && (err.status === 403 || err.status === 404)) {
+    if (
+      err instanceof ClientError &&
+      (err.status === 404 || (err.status === 403 && err.code === 'forbidden'))
+    ) {
       throw new ClientError('Run not found', 'not-found', {status: 404});
     }
     throw err;

package/src/presentation/routes/rerun-run.test.ts

@@ -43,7 +43,7 @@ describe('POST /api/workflows/runs/:id/rerun', () => {
         buildUserContext({
           userId: crypto.randomUUID(),
           email: 'user@example.com',
-          memberships: [{workspaceId, role: 'admin'}],
+          memberships: [{workspaceId, role: 'admin', workspaceStatus: 'active'}],
         }),
       );
       done();