@shipfox/api-server 9.2.0 → 9.3.0

package/package.json

@@ -2,7 +2,7 @@
   "name": "@shipfox/api-server",
   "license": "MIT",
   "private": false,
-  "version": "9.2.0",
+  "version": "9.3.0",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/ShipfoxHQ/shipfox.git",
@@ -22,36 +22,36 @@
     }
   },
   "dependencies": {
-    "@shipfox/annotations": "9.2.0",
     "@shipfox/annotations-dto": "9.0.2",
-    "@shipfox/api-agent": "9.2.0",
+    "@shipfox/annotations": "9.3.0",
     "@shipfox/api-agent-dto": "9.0.2",
-    "@shipfox/api-auth": "9.2.0",
-    "@shipfox/api-auth-dto": "9.2.0",
-    "@shipfox/api-definitions": "9.2.0",
+    "@shipfox/api-agent": "9.3.0",
+    "@shipfox/api-auth": "9.3.0",
+    "@shipfox/api-auth-dto": "9.3.0",
+    "@shipfox/api-definitions": "9.3.0",
+    "@shipfox/api-dispatcher": "9.3.0",
     "@shipfox/api-definitions-dto": "9.0.2",
-    "@shipfox/api-dispatcher": "9.0.3",
-    "@shipfox/api-email-challenges": "1.1.4",
-    "@shipfox/api-integration-core": "9.2.0",
+    "@shipfox/api-integration-core": "9.3.0",
     "@shipfox/api-integration-core-dto": "9.0.2",
-    "@shipfox/api-logs": "9.2.0",
-    "@shipfox/api-projects": "9.2.0",
+    "@shipfox/api-email-challenges": "1.1.5",
+    "@shipfox/api-projects": "9.3.0",
+    "@shipfox/api-runners": "9.3.0",
     "@shipfox/api-projects-dto": "9.2.0",
-    "@shipfox/api-runners": "9.2.0",
     "@shipfox/api-runners-dto": "9.0.2",
-    "@shipfox/api-secrets": "9.2.0",
+    "@shipfox/api-secrets": "9.3.0",
     "@shipfox/api-secrets-dto": "9.0.2",
-    "@shipfox/api-triggers": "9.2.0",
-    "@shipfox/api-workflows": "9.2.0",
-    "@shipfox/api-workflows-dto": "9.0.2",
-    "@shipfox/api-workspaces-dto": "9.2.0",
-    "@shipfox/api-workspaces": "9.2.0",
-    "@shipfox/config": "1.2.4",
+    "@shipfox/api-logs": "9.3.0",
+    "@shipfox/api-triggers": "9.3.0",
+    "@shipfox/api-workflows": "9.3.0",
+    "@shipfox/api-workflows-dto": "9.3.0",
+    "@shipfox/api-workspaces": "9.3.0",
+    "@shipfox/api-workspaces-dto": "9.3.0",
     "@shipfox/node-error-monitoring": "0.3.0",
-    "@shipfox/node-fastify": "0.3.3",
+    "@shipfox/config": "1.2.4",
+    "@shipfox/node-fastify": "0.3.4",
     "@shipfox/node-jwt": "0.3.2",
-    "@shipfox/node-module": "1.0.2",
-    "@shipfox/node-opentelemetry": "0.6.2",
+    "@shipfox/node-module": "1.0.3",
+    "@shipfox/node-opentelemetry": "0.6.3",
     "@shipfox/node-postgres": "0.4.4"
   },
   "imports": {

package/src/index.ts

@@ -1,4 +1,5 @@
 export {
+  type DefaultAuthModuleFactory,
   type DefaultModulesExtension,
   type DefaultModulesOptions,
   type DefaultRunnersModuleFactory,

package/src/instrumentation.ts

@@ -8,5 +8,5 @@ const {version} = createRequire(import.meta.url)('../package.json') as {version:
 await startInstanceInstrumentation({
   serviceName: 'api',
   serviceVersion: version,
-  instrumentations: {fastify: true, http: true, pg: true, awsSdk: true},
+  instrumentations: {fastify: true, http: true, pg: true, awsSdk: true, pino: true},
 });

package/src/modules.test.ts

@@ -21,6 +21,7 @@ const mocks = vi.hoisted(() => ({
   buildAgentToolCatalogs: vi.fn(),
   buildAgentToolSelectionCatalogs: vi.fn(),
   createAgentModule: vi.fn(),
+  createAuthModule: vi.fn(),
   createDefinitionsModule: vi.fn(),
   createIntegrationsContext: vi.fn(),
   createLogsModule: vi.fn(),
@@ -34,6 +35,7 @@ const mocks = vi.hoisted(() => ({
   getIntegrationConnectionById: vi.fn(),
   getSecret: vi.fn(),
   getWorkspaceCreator: vi.fn(),
+  getWorkspaceOperatingState: vi.fn(),
   listMembershipsForTokenClaims: vi.fn(),
   setSecrets: vi.fn(),
 }));
@@ -50,20 +52,7 @@ vi.mock('@shipfox/annotations', () => ({
   },
 }));
 vi.mock('@shipfox/api-auth', () => ({
-  createAuthModule: () => ({
-    name: 'auth',
-    interModulePresentations: [
-      {
-        contract: authInterModuleContract,
-        handlers: {
-          mintJobLeaseToken: vi.fn(),
-          mintRunnerSessionToken: vi.fn(),
-          getCurrentAdminRole: vi.fn(),
-          requireAdminRole: vi.fn(),
-        },
-      },
-    ],
-  }),
+  createAuthModule: mocks.createAuthModule,
 }));
 vi.mock('@shipfox/api-agent', () => ({createAgentModule: mocks.createAgentModule}));
 vi.mock('@shipfox/api-auth/config', () => ({
@@ -105,6 +94,7 @@ vi.mock('@shipfox/api-workspaces', () => ({
         handlers: {
           listMembershipsForTokenClaims: mocks.listMembershipsForTokenClaims,
           getWorkspaceCreator: mocks.getWorkspaceCreator,
+          getWorkspaceOperatingState: mocks.getWorkspaceOperatingState,
           preflightInvitationAcceptance: vi.fn(),
           acceptInvitation: vi.fn(),
           requireActiveMembership: vi.fn(),
@@ -119,6 +109,7 @@ describe('defaultModules', () => {
     mocks.buildAgentToolCatalogs.mockReset();
     mocks.buildAgentToolSelectionCatalogs.mockReset();
     mocks.createAgentModule.mockReset();
+    mocks.createAuthModule.mockReset();
     mocks.createDefinitionsModule.mockReset();
     mocks.createIntegrationsContext.mockReset();
     mocks.createLogsModule.mockReset();
@@ -155,6 +146,20 @@ describe('defaultModules', () => {
     mocks.buildAgentToolCatalogs.mockResolvedValue(new Map());
     mocks.buildAgentToolSelectionCatalogs.mockResolvedValue(new Map());
     mocks.createWorkspaceConnectionSnapshotLoader.mockReturnValue(vi.fn());
+    mocks.createAuthModule.mockReturnValue({
+      name: 'auth',
+      interModulePresentations: [
+        {
+          contract: authInterModuleContract,
+          handlers: {
+            mintJobLeaseToken: vi.fn(),
+            mintRunnerSessionToken: vi.fn(),
+            getCurrentAdminRole: vi.fn(),
+            requireAdminRole: vi.fn(),
+          },
+        },
+      ],
+    });
     mocks.deleteSecrets.mockResolvedValue({deleted: 1});
     mocks.getSecret.mockResolvedValue({value: 'secret'});
     mocks.listMembershipsForTokenClaims.mockResolvedValue({memberships: []});
@@ -291,6 +296,43 @@ describe('defaultModules', () => {
     expect(mocks.createRunnersModule).toHaveBeenCalledWith({auth: expect.any(Object)});
   });
 
+  it('uses the default Auth module factory when none is supplied', async () => {
+    await defaultModules();
+
+    expect(mocks.createAuthModule).toHaveBeenCalledWith({workspaces: expect.any(Object)});
+  });
+
+  it('composes Auth with the shared Workspaces client and registers the supplied module', async () => {
+    const signupPolicy = {isSignupAllowed: vi.fn().mockResolvedValue({allowed: true})};
+    const customAuthModule = mocks.createAuthModule();
+    mocks.createAuthModule.mockClear();
+    let extensionWorkspaces: WorkspacesInterModuleClient | undefined;
+    const extension = vi.fn(({workspaces}: {workspaces: WorkspacesInterModuleClient}) => {
+      extensionWorkspaces = workspaces;
+      return [];
+    });
+    const authModule = vi.fn(({workspaces}: {workspaces: WorkspacesInterModuleClient}) =>
+      mocks.createAuthModule({workspaces, signupPolicy}),
+    );
+
+    const modules = await defaultModules({authModule, extension});
+    const authWorkspaces = authModule.mock.calls[0]?.[0].workspaces;
+
+    expect(authModule).toHaveBeenCalledWith({workspaces: expect.any(Object)});
+    expect(mocks.createAuthModule).toHaveBeenCalledWith({
+      workspaces: authWorkspaces,
+      signupPolicy,
+    });
+    expect(extension).toHaveBeenCalledWith({workspaces: authWorkspaces});
+    expect(extensionWorkspaces).toBe(authWorkspaces);
+    expect(modules).toContain(customAuthModule);
+    expect(
+      modules.flatMap((module) =>
+        (module.interModulePresentations ?? []).map(({contract}) => contract.module),
+      ),
+    ).toContain(authInterModuleContract.module);
+  });
+
   it('lets a host replace only the Runners module with the composed Auth client', async () => {
     const policy = {filterEligibleWorkspaceIds: vi.fn().mockResolvedValue(new Set<string>())};
     const runnersModule = mocks.createRunnersModule({});

package/src/modules.ts

@@ -40,10 +40,14 @@ import {logger} from '@shipfox/node-opentelemetry';
 
 export interface DefaultModulesOptions {
   webhookDeliverySource?: WebhookDeliverySource | undefined;
+  authModule?: DefaultAuthModuleFactory | undefined;
   runnersModule?: DefaultRunnersModuleFactory | undefined;
   extension?: DefaultModulesExtension | undefined;
 }
 
+export type DefaultAuthModuleFactory = (options: {
+  workspaces: WorkspacesInterModuleClient;
+}) => ShipfoxModule;
 export type DefaultRunnersModuleFactory = (options: {auth: AuthInterModuleClient}) => ShipfoxModule;
 export type DefaultModulesExtension = (options: {
   workspaces: WorkspacesInterModuleClient;
@@ -165,7 +169,7 @@ export async function defaultModules(
 
   const modules = [
     emailChallengesModule,
-    createAuthModule({workspaces: workspacesClient}),
+    (options.authModule ?? createAuthModule)({workspaces: workspacesClient}),
     workspacesModule,
     createSecretsModule(projectsClient),
     createAgentModule({secrets: secretsClient}),
@@ -180,6 +184,7 @@ export async function defaultModules(
       projects: projectsClient,
       runners: runnersClient,
       secrets: secretsClient,
+      workspaces: workspacesClient,
       integrations: integrationsClient,
     }),
     annotationsModule,