@shipfox/api-runners 7.0.2 → 7.1.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@shipfox/api-runners",
   "license": "MIT",
-  "version": "7.0.2",
+  "version": "7.1.0",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/ShipfoxHQ/shipfox.git",
@@ -25,21 +25,22 @@
     "@temporalio/workflow": "1.18.1",
     "drizzle-orm": "^0.45.2",
     "zod": "^4.4.3",
-    "@shipfox/api-auth-context": "6.0.0",
-    "@shipfox/api-auth-dto": "6.0.0",
+    "@shipfox/api-auth-context": "7.1.0",
+    "@shipfox/api-auth-dto": "7.1.0",
     "@shipfox/api-runners-dto": "7.0.1",
     "@shipfox/api-workflows-dto": "6.0.0",
     "@shipfox/config": "1.2.2",
     "@shipfox/inter-module": "0.2.0",
     "@shipfox/node-drizzle": "0.3.2",
+    "@shipfox/node-error-monitoring": "0.2.0",
     "@shipfox/node-auth-root-key": "0.2.1",
-    "@shipfox/node-fastify": "0.2.4",
-    "@shipfox/node-module": "0.4.0",
-    "@shipfox/node-opentelemetry": "0.5.2",
+    "@shipfox/node-fastify": "0.3.0",
+    "@shipfox/node-module": "0.5.0",
+    "@shipfox/node-opentelemetry": "0.6.0",
     "@shipfox/node-outbox": "0.2.4",
     "@shipfox/node-postgres": "0.4.2",
     "@shipfox/node-rate-limit": "0.3.0",
-    "@shipfox/node-temporal": "0.3.2",
+    "@shipfox/node-temporal": "0.4.0",
     "@shipfox/node-tokens": "0.3.0",
     "@shipfox/runner-labels": "0.1.1"
   },

package/src/db/runner-instances.test.ts

@@ -1822,6 +1822,53 @@ describe('reconcileRunnerInstances', () => {
 });
 
 describe('runner instance provider attachment', () => {
+  it('updates the pre-created runner instance before its first lifecycle report', async () => {
+    const provisionerId = crypto.randomUUID();
+    const providerRunnerId = 'ec2-runner-1';
+    const [instance] = await db()
+      .insert(providerRunners)
+      .values({
+        provisionerId,
+        providerKind: 'ec2',
+        templateKey: 'linux',
+        labels: ['linux'],
+        state: 'starting',
+        reportedAt: new Date(),
+      })
+      .returning({id: providerRunners.id});
+    if (!instance) throw new Error('Runner instance insert returned no row');
+
+    const attached = await attachRunnerInstanceProviderId({
+      runnerInstanceId: instance.id,
+      provisionerId,
+      providerRunnerId,
+    });
+    await reportRunnerInstances({
+      workspaceId: null,
+      provisionerId,
+      events: [
+        {
+          providerRunnerId,
+          reservationId: null,
+          templateKey: 'linux',
+          labels: ['linux'],
+          state: 'starting',
+          reason: null,
+          runnerSessionId: null,
+          providerKind: 'ec2',
+          reportedAt: new Date(),
+        },
+      ],
+    });
+    const rows = await db()
+      .select()
+      .from(providerRunners)
+      .where(eq(providerRunners.provisionerId, provisionerId));
+
+    expect(attached).toBe(true);
+    expect(rows).toMatchObject([{id: instance.id, providerRunnerId, state: 'starting'}]);
+  });
+
   it('belongs to its provisioner until it receives one provider runner identity', async () => {
     const provisionerId = crypto.randomUUID();
     const [instance] = await db()

package/src/presentation/routes/poll-demand.ts

@@ -4,7 +4,9 @@ import {
 } from '@shipfox/api-auth-context';
 import type {PollDemandTemplateDto} from '@shipfox/api-runners-dto';
 import {pollDemandBodySchema, pollDemandResponseSchema} from '@shipfox/api-runners-dto';
+import {reportError} from '@shipfox/node-error-monitoring';
 import {ClientError, defineRoute} from '@shipfox/node-fastify';
+import {logger} from '@shipfox/node-opentelemetry';
 import {config} from '#config.js';
 import {pollDemand, releaseReservationGrants} from '#core/demand.js';
 import {publishWorkspaceProvisionerCapabilitySnapshot} from '#db/provisioner-capability-snapshots.js';
@@ -50,7 +52,17 @@ export function createPollDemandRoute(options: CreateRunnersModuleOptions = {})
       reply.raw.on('close', () => {
         if (!responseFinished) {
           abortController.abort();
-          void releaseReservationGrants(responseReservations).catch(() => undefined);
+          void releaseReservationGrants(responseReservations).catch((error) => {
+            logger().error(
+              {err: error, reservationCount: responseReservations.length},
+              'Failed to release reservations after provisioner disconnect',
+            );
+            reportError(error, {
+              boundary: 'runners.cleanup',
+              operation: 'release-disconnected-reservations',
+              extra: {reservationCount: responseReservations.length},
+            });
+          });
         }
       });
       const provisionerContext = requireProvisionerContext(request);