@shipfox/api-logs 5.0.0 → 6.0.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@shipfox/api-logs",
   "license": "MIT",
-  "version": "5.0.0",
+  "version": "6.0.0",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/ShipfoxHQ/shipfox.git",
@@ -29,19 +29,18 @@
     "@temporalio/workflow": "1.18.1",
     "drizzle-orm": "^0.45.2",
     "zod": "^4.4.3",
-    "@shipfox/api-auth-context": "5.0.0",
-    "@shipfox/api-agent-dto": "5.0.0",
+    "@shipfox/api-auth-context": "6.0.0",
+    "@shipfox/api-agent-dto": "6.0.0",
     "@shipfox/api-logs-dto": "5.0.0",
-    "@shipfox/api-workflows": "5.0.0",
-    "@shipfox/api-workflows-dto": "5.0.0",
+    "@shipfox/api-workflows-dto": "6.0.0",
     "@shipfox/config": "1.2.2",
-    "@shipfox/node-drizzle": "0.3.1",
-    "@shipfox/node-fastify": "0.2.3",
-    "@shipfox/node-module": "0.3.2",
+    "@shipfox/node-drizzle": "0.3.2",
+    "@shipfox/node-fastify": "0.2.4",
+    "@shipfox/node-module": "0.4.0",
     "@shipfox/node-opentelemetry": "0.5.2",
-    "@shipfox/node-outbox": "0.2.3",
+    "@shipfox/node-outbox": "0.2.4",
     "@shipfox/node-postgres": "0.4.2",
-    "@shipfox/node-temporal": "0.3.1"
+    "@shipfox/node-temporal": "0.3.2"
   },
   "devDependencies": {
     "@temporalio/client": "1.18.1",
@@ -53,10 +52,13 @@
     "fastify": "^5.3.3",
     "fastify-type-provider-zod": "^6.0.0",
     "fishery": "^2.4.0",
-    "@shipfox/api-auth": "5.0.0",
-    "@shipfox/api-auth-dto": "5.0.0",
+    "@shipfox/node-auth-root-key": "0.2.0",
+    "@shipfox/api-auth": "6.0.0",
+    "@shipfox/api-auth-dto": "6.0.0",
+    "@shipfox/inter-module": "0.2.0",
     "@shipfox/biome": "1.8.2",
-    "@shipfox/node-jwt": "0.2.1",
+    "@shipfox/depcruise": "1.0.2",
+    "@shipfox/node-jwt": "0.3.0",
     "@shipfox/swc": "1.2.6",
     "@shipfox/ts-config": "1.3.8",
     "@shipfox/typescript": "1.1.7",
@@ -66,6 +68,7 @@
     "build": "shipfox-swc && shipfox-temporal-bundle dist/temporal/workflows/index.js",
     "check": "shipfox-biome-check",
     "check:fix": "shipfox-biome-check --write",
+    "depcruise": "shipfox-depcruise",
     "test": "shipfox-vitest-run",
     "test:watch": "shipfox-vitest-watch",
     "type": "shipfox-tsc-check",

package/src/config.test.ts

@@ -47,48 +47,24 @@ describe('LOG_STREAM_REAP_AFTER_SECONDS validation', () => {
     vi.resetModules();
   });
 
-  // Reaping a stream a still-valid lease is appending to silently truncates live logs, so a value
-  // at or below the job lease TTL (default 90m = 5400s) must fail startup.
   it.each([
-    '0',
-    '-100',
-    '5400',
-  ])('fails startup when LOG_STREAM_REAP_AFTER_SECONDS is %s (at or below the default lease TTL)', async (value) => {
-    vi.stubEnv('LOG_STREAM_REAP_AFTER_SECONDS', value);
+    0, -100, 5400,
+  ])('rejects a reaper window of %d seconds for a 90-minute Auth lease', async (value) => {
+    vi.stubEnv('LOG_STREAM_REAP_AFTER_SECONDS', String(value));
     vi.resetModules();
 
-    await expect(import('#config.js')).rejects.toThrow('LOG_STREAM_REAP_AFTER_SECONDS');
-  });
-
-  it('accepts a value above the lease TTL', async () => {
-    vi.stubEnv('LOG_STREAM_REAP_AFTER_SECONDS', '9000');
-    vi.resetModules();
-
-    const {config} = await import('#config.js');
+    const {validateLogStreamReapAfterSeconds} = await import('#config.js');
 
-    expect(config.LOG_STREAM_REAP_AFTER_SECONDS).toBe(9000);
+    expect(() => validateLogStreamReapAfterSeconds(5400)).toThrow('LOG_STREAM_REAP_AFTER_SECONDS');
   });
 
-  // The check reads the actual configured lease TTL, not a hardcoded floor: raising the lease past
-  // the reaper window must fail startup even though the value clears the default lease.
-  it('fails when AUTH_JOB_LEASE_TOKEN_EXPIRES_IN is raised above the reaper window', async () => {
-    vi.stubEnv('AUTH_JOB_LEASE_TOKEN_EXPIRES_IN', '180m');
-    vi.stubEnv('LOG_STREAM_REAP_AFTER_SECONDS', '9000');
-    vi.resetModules();
-
-    await expect(import('#config.js')).rejects.toThrow('LOG_STREAM_REAP_AFTER_SECONDS');
-  });
-
-  // The converse: a small reaper window is fine when the lease is correspondingly small, proving
-  // the bound tracks the lease rather than a fixed 5400s floor.
-  it('accepts a small reaper window when the lease TTL is correspondingly small', async () => {
-    vi.stubEnv('AUTH_JOB_LEASE_TOKEN_EXPIRES_IN', '5m');
+  it('accepts a reaper window above the Auth lease lifetime', async () => {
     vi.stubEnv('LOG_STREAM_REAP_AFTER_SECONDS', '600');
     vi.resetModules();
 
-    const {config} = await import('#config.js');
+    const {validateLogStreamReapAfterSeconds} = await import('#config.js');
 
-    expect(config.LOG_STREAM_REAP_AFTER_SECONDS).toBe(600);
+    expect(() => validateLogStreamReapAfterSeconds(300)).not.toThrow();
   });
 });
 

package/src/config.ts

@@ -1,6 +1,4 @@
-import {config as authConfig} from '@shipfox/api-auth/config';
 import {bool, createConfig, num, str, url} from '@shipfox/config';
-import {durationToSeconds} from '@shipfox/node-jwt';
 
 export const config = createConfig({
   LOG_STORAGE_S3_ENDPOINT: url({
@@ -48,7 +46,7 @@ export const config = createConfig({
     default: 900,
   }),
   LOG_STREAM_REAP_AFTER_SECONDS: num({
-    desc: 'How long a log stream may stay open before the reaper cron force-closes it as abandoned. This is the backstop for a stream a runner started after its job already went terminal (the one-shot close sweep had already run); the reaper marks it truncated so it re-enters the compaction and retention lifecycle. Must be greater than AUTH_JOB_LEASE_TOKEN_EXPIRES_IN (the job lease lifetime, default 90 minutes) so a still-valid lease can never be force-closed mid-append, which would silently truncate live logs. Defaults to 7200 seconds (2 hours).',
+    desc: 'How long a log stream may stay open before the reaper cron force-closes it as abandoned. This is the backstop for a stream a runner started after its job already went terminal (the one-shot close sweep had already run); the reaper marks it truncated so it re-enters the compaction and retention lifecycle. The application validates that this exceeds the Auth job lease lifetime. Defaults to 7200 seconds (2 hours).',
     default: 7200,
   }),
   LOG_APPEND_BODY_LIMIT_BYTES: num({
@@ -115,16 +113,13 @@ if (!Number.isInteger(config.LOG_RETENTION_DAYS) || config.LOG_RETENTION_DAYS <
   );
 }
 
-// A stream still accepts appends until its job lease expires, so reaping it any sooner would
-// truncate live logs. Validate against the real lease TTL read from auth's config (not a
-// hardcoded floor), so raising AUTH_JOB_LEASE_TOKEN_EXPIRES_IN can never silently outrun the
-// reaper window.
-const jobLeaseTtlSeconds = durationToSeconds(authConfig.AUTH_JOB_LEASE_TOKEN_EXPIRES_IN);
-if (
-  !Number.isFinite(config.LOG_STREAM_REAP_AFTER_SECONDS) ||
-  config.LOG_STREAM_REAP_AFTER_SECONDS <= jobLeaseTtlSeconds
-) {
-  throw new Error(
-    `LOG_STREAM_REAP_AFTER_SECONDS (${config.LOG_STREAM_REAP_AFTER_SECONDS}) must be greater than the job lease TTL (${jobLeaseTtlSeconds}s, from AUTH_JOB_LEASE_TOKEN_EXPIRES_IN=${authConfig.AUTH_JOB_LEASE_TOKEN_EXPIRES_IN}); a smaller value would let the reaper force-close a stream a still-valid lease is appending to and silently truncate live logs.`,
-  );
+export function validateLogStreamReapAfterSeconds(jobLeaseTokenTtlSeconds: number): void {
+  if (
+    !Number.isFinite(config.LOG_STREAM_REAP_AFTER_SECONDS) ||
+    config.LOG_STREAM_REAP_AFTER_SECONDS <= jobLeaseTokenTtlSeconds
+  ) {
+    throw new Error(
+      `LOG_STREAM_REAP_AFTER_SECONDS (${config.LOG_STREAM_REAP_AFTER_SECONDS}) must be greater than the Auth job lease TTL (${jobLeaseTokenTtlSeconds}s); a smaller value would let the reaper force-close a stream a still-valid lease is appending to and silently truncate live logs.`,
+    );
+  }
 }

package/src/core/append-logs.test.ts

@@ -1,5 +1,8 @@
 import {type LogRecord, parseLogRecordLine} from '@shipfox/api-logs-dto';
-import {appendLogs, setStepLookupForTesting} from '#core/append-logs.js';
+import {workflowsInterModuleContract} from '@shipfox/api-workflows-dto/inter-module';
+import {defineInterModulePresentation} from '@shipfox/inter-module';
+import {createFakeInterModuleClients} from '@shipfox/node-module/inter-module/testing';
+import {appendLogs} from '#core/append-logs.js';
 import {LeaseStreamMismatchError, MalformedLogChunkError, OffsetGapError} from '#core/errors.js';
 import {jobAccountingFactory} from '#test/factories/job-accounting.js';
 import {
@@ -13,8 +16,6 @@ import {
 } from '#test/fixtures/ndjson.js';
 import {findAccounting, findStream, listChunks, listStreamClosedEvents} from '#test/queries.js';
 
-const mockSteps = new Map<string, {config: Record<string, unknown>}>();
-
 interface Ctx {
   jobId: string;
   stepId: string;
@@ -48,20 +49,6 @@ function recordsFromChunks(chunks: Awaited<ReturnType<typeof listChunks>>): LogR
 }
 
 describe('appendLogs', () => {
-  let restoreStepLookup: () => void;
-
-  beforeAll(() => {
-    restoreStepLookup = setStepLookupForTesting((stepId) => Promise.resolve(mockSteps.get(stepId)));
-  });
-
-  afterAll(() => {
-    restoreStepLookup();
-  });
-
-  beforeEach(() => {
-    mockSteps.clear();
-  });
-
   describe('offset-CAS', () => {
     it('extends committed_length and stores one runner chunk on an in-order append', async () => {
       const ctx = newCtx();
@@ -203,7 +190,14 @@ describe('appendLogs', () => {
     it('selects the Claude parser from the step harness', async () => {
       const ctx = newCtx();
       await allowLargeLogBudget(ctx);
-      mockSteps.set(ctx.stepId, {config: {harness: 'claude'}});
+      const workflows = createFakeInterModuleClients({
+        workflows: defineInterModulePresentation(workflowsInterModuleContract, {
+          startRunFromTrigger: vi.fn(),
+          deliverEventToJobListener: vi.fn(),
+          getStepLogContext: () => ({harness: 'claude' as const}),
+          getLeasedAgentToolContext: vi.fn(),
+        }),
+      }).workflows;
       const body = ndjsonBody(
         sessionLine(
           JSON.stringify({
@@ -216,7 +210,7 @@ describe('appendLogs', () => {
         ),
       );
 
-      await appendLogs({...ctx, attempt: 1, offset: 0, body});
+      await appendLogs({...ctx, attempt: 1, offset: 0, body}, workflows);
 
       const stream = await findStream({...ctx, attempt: 1});
       const rows = recordsFromChunks(await listChunks(stream?.id as string)).map((record) => {

package/src/core/append-logs.ts

@@ -1,12 +1,12 @@
 import {Buffer} from 'node:buffer';
-import {DEFAULT_HARNESS, type Harness, harnessSchema} from '@shipfox/api-agent-dto';
+import {DEFAULT_HARNESS, type Harness} from '@shipfox/api-agent-dto';
 import {
   type LogRecord,
   parseLogRecordLine,
   parseRawLogRecordLine,
   type RawLogRecord,
 } from '@shipfox/api-logs-dto';
-import {getStepById} from '@shipfox/api-workflows';
+import type {WorkflowsModuleClient} from '@shipfox/api-workflows-dto/inter-module';
 import {logger} from '@shipfox/node-opentelemetry';
 import {config} from '#config.js';
 import {accrueStoredBytes, claimCap, ensureJobAccounting, isJobCapped} from '#db/accounting.js';
@@ -30,18 +30,6 @@ import {MalformedLogChunkError, OffsetGapError} from './errors.js';
 import {parseSessionRecord} from './session/parse-session.js';
 import type {AgentSessionRecord} from './session/session-record.js';
 
-type StepLookup = (stepId: string) => Promise<{config: Record<string, unknown>} | undefined>;
-
-let stepLookup: StepLookup = getStepById;
-
-export function setStepLookupForTesting(lookup: StepLookup): () => void {
-  const previous = stepLookup;
-  stepLookup = lookup;
-  return () => {
-    stepLookup = previous;
-  };
-}
-
 export interface AppendLogsParams {
   jobId: string;
   workspaceId: string;
@@ -137,10 +125,11 @@ function detectForgedType(line: string): string | undefined {
   }
 }
 
-async function getSessionHarness(stepId: string): Promise<Harness> {
-  const step = await stepLookup(stepId);
-  const parsed = harnessSchema.safeParse(step?.config.harness);
-  return parsed.success ? parsed.data : DEFAULT_HARNESS;
+async function getSessionHarness(
+  workflows: WorkflowsModuleClient | undefined,
+  stepId: string,
+): Promise<Harness> {
+  return workflows ? (await workflows.getStepLogContext({stepId})).harness : DEFAULT_HARNESS;
 }
 
 /**
@@ -273,7 +262,10 @@ function agentSessionRecord(
  * job contend on its single accounting row, so the path is multi-instance safe
  * but not lock-free.
  */
-export async function appendLogs(params: AppendLogsParams): Promise<AppendLogsResult> {
+export async function appendLogs(
+  params: AppendLogsParams,
+  workflows?: WorkflowsModuleClient,
+): Promise<AppendLogsResult> {
   let parsed: ParsedBody;
   try {
     parsed = parseAppendBody(params.body);
@@ -293,7 +285,7 @@ export async function appendLogs(params: AppendLogsParams): Promise<AppendLogsRe
   }
   const {declaredTotalBytes} = parsed;
   const sessionHarness = parsed.hasAgentSessionRecord
-    ? await getSessionHarness(params.stepId)
+    ? await getSessionHarness(workflows, params.stepId)
     : DEFAULT_HARNESS;
   const stored = buildStoredBody(parsed.records, sessionHarness);
   const commitByteLen = params.body.length;

package/src/index.ts

@@ -6,12 +6,14 @@ import {
   WORKFLOWS_STEP_ATTEMPT_TERMINATED,
   type WorkflowsEventMapDto,
 } from '@shipfox/api-workflows-dto';
+import type {WorkflowsModuleClient} from '@shipfox/api-workflows-dto/inter-module';
 import {type ShipfoxModule, subscriberFactory} from '@shipfox/node-module';
+import {validateLogStreamReapAfterSeconds} from '#config.js';
 import {db} from '#db/db.js';
 import {migrationsPath} from '#db/index.js';
 import {logsOutbox} from '#db/schema/outbox.js';
 import {registerLogsServiceMetrics} from '#metrics/service.js';
-import {logsRoutes} from '#presentation/routes/index.js';
+import {createLogsRoutes} from '#presentation/routes/index.js';
 import {onJobTerminated} from '#presentation/subscribers/on-job-terminated.js';
 import {onLogStreamClosed} from '#presentation/subscribers/on-log-stream-closed.js';
 import {onStepAttemptTerminated} from '#presentation/subscribers/on-step-attempt-terminated.js';
@@ -25,53 +27,63 @@ const workflowsPath = resolve(packageRoot, 'dist/temporal/workflows/index.js');
 
 const subscriber = subscriberFactory<WorkflowsEventMapDto & LogsEventMap>();
 
-export const logsModule: ShipfoxModule = {
-  name: 'logs',
-  database: {db, migrationsPath},
-  routes: logsRoutes,
-  metrics: registerLogsServiceMetrics,
-  // `logs.stream.closed` is written by the close paths: the job-terminated subscriber
-  // force-closes streams the runner never ended, and the closed event drives compaction.
-  publishers: [{name: 'logs', table: logsOutbox, db, eventSchemas: logsEventSchemas}],
-  subscribers: [
-    subscriber(WORKFLOWS_STEP_ATTEMPT_TERMINATED, onStepAttemptTerminated),
-    subscriber(WORKFLOWS_JOB_TERMINATED, onJobTerminated),
-    subscriber(LOG_STREAM_CLOSED, onLogStreamClosed),
-  ],
-  workers: [
-    {
-      taskQueue: LOGS_LIFECYCLE_TASK_QUEUE,
-      workflowsPath,
-      activities: createLogsActivities,
-      // Temporal cron schedules are fixed after creation, so making cadence configurable would
-      // look adjustable while keeping the old schedule. Tune LOG_RETENTION_DAYS for the horizon.
-      workflows: [
-        {
-          name: 'retentionSweepCron',
-          id: 'logs-retention-sweep',
-          cronSchedule: '0 * * * *',
-        },
-        // Offset from retention's top-of-hour sweep; stale-stream age is governed by
-        // LOG_STREAM_REAP_AFTER_SECONDS.
-        {
-          name: 'reapStaleOpenStreamsCron',
-          id: 'logs-reap-stale-open-streams',
-          cronSchedule: '5,15,25,35,45,55 * * * *',
-        },
-      ],
-    },
-    // Compaction runs on its own queue so long uploads cannot starve the lifecycle sweep.
-    {
-      taskQueue: LOGS_COMPACTION_TASK_QUEUE,
-      workflowsPath,
-      activities: createLogsActivities,
-      workflows: [
-        {
-          name: 'compactionReconcileCron',
-          id: 'logs-compaction-reconcile',
-          cronSchedule: '*/10 * * * *',
-        },
-      ],
-    },
-  ],
-};
+export function createLogsModule({
+  workflows,
+  jobLeaseTokenTtlSeconds,
+}: {
+  workflows: WorkflowsModuleClient;
+  jobLeaseTokenTtlSeconds: number;
+}): ShipfoxModule {
+  validateLogStreamReapAfterSeconds(jobLeaseTokenTtlSeconds);
+
+  return {
+    name: 'logs',
+    database: {db, migrationsPath},
+    routes: createLogsRoutes(workflows),
+    metrics: registerLogsServiceMetrics,
+    // `logs.stream.closed` is written by the close paths: the job-terminated subscriber
+    // force-closes streams the runner never ended, and the closed event drives compaction.
+    publishers: [{name: 'logs', table: logsOutbox, db, eventSchemas: logsEventSchemas}],
+    subscribers: [
+      subscriber(WORKFLOWS_STEP_ATTEMPT_TERMINATED, onStepAttemptTerminated),
+      subscriber(WORKFLOWS_JOB_TERMINATED, onJobTerminated),
+      subscriber(LOG_STREAM_CLOSED, onLogStreamClosed),
+    ],
+    workers: [
+      {
+        taskQueue: LOGS_LIFECYCLE_TASK_QUEUE,
+        workflowsPath,
+        activities: createLogsActivities,
+        // Temporal cron schedules are fixed after creation, so making cadence configurable would
+        // look adjustable while keeping the old schedule. Tune LOG_RETENTION_DAYS for the horizon.
+        workflows: [
+          {
+            name: 'retentionSweepCron',
+            id: 'logs-retention-sweep',
+            cronSchedule: '0 * * * *',
+          },
+          // Offset from retention's top-of-hour sweep; stale-stream age is governed by
+          // LOG_STREAM_REAP_AFTER_SECONDS.
+          {
+            name: 'reapStaleOpenStreamsCron',
+            id: 'logs-reap-stale-open-streams',
+            cronSchedule: '5,15,25,35,45,55 * * * *',
+          },
+        ],
+      },
+      // Compaction runs on its own queue so long uploads cannot starve the lifecycle sweep.
+      {
+        taskQueue: LOGS_COMPACTION_TASK_QUEUE,
+        workflowsPath,
+        activities: createLogsActivities,
+        workflows: [
+          {
+            name: 'compactionReconcileCron',
+            id: 'logs-compaction-reconcile',
+            cronSchedule: '*/10 * * * *',
+          },
+        ],
+      },
+    ],
+  };
+}

package/src/presentation/routes/append-logs.test.ts

@@ -4,7 +4,8 @@ import {AUTH_USER} from '@shipfox/api-auth-context';
 import {type AuthMethod, closeApp, createApp, type FastifyInstance} from '@shipfox/node-fastify';
 import {mintLeaseToken} from '#test/fixtures/lease-token.js';
 import {endLine, ndjsonBody, outputLine, recordLine} from '#test/fixtures/ndjson.js';
-import {logsRoutes} from './index.js';
+import {createTestWorkflowsClient} from '#test/fixtures/workflows-client.js';
+import {createLogsRoutes} from './index.js';
 
 const NDJSON = 'application/x-ndjson';
 const JOB_EXECUTION_ID = '00000000-0000-4000-8000-0000000000ee';
@@ -36,7 +37,7 @@ describe('POST /runs/jobs/current/steps/:stepId/logs', () => {
   beforeAll(async () => {
     app = await createApp({
       auth: [createLeaseTokenAuthMethod(), stubUserAuth],
-      routes: logsRoutes,
+      routes: createLogsRoutes(createTestWorkflowsClient()),
       swagger: false,
     });
     await app.ready();

package/src/presentation/routes/append-logs.ts

@@ -5,62 +5,66 @@ import {
   appendLogsResponseSchema,
   offsetGapResponseSchema,
 } from '@shipfox/api-logs-dto';
+import type {WorkflowsModuleClient} from '@shipfox/api-workflows-dto/inter-module';
 import {ClientError, defineRoute} from '@shipfox/node-fastify';
 import {z} from 'zod';
 import {appendLogs} from '#core/append-logs.js';
 import {LeaseStreamMismatchError, MalformedLogChunkError, OffsetGapError} from '#core/errors.js';
 
-export const appendLogsRoute = defineRoute({
-  method: 'POST',
-  path: '/steps/:stepId/logs',
-  description: 'Append a chunk of logs for a step attempt of the leased job.',
-  schema: {
-    params: z.object({stepId: z.string().uuid()}),
-    querystring: appendLogsQuerySchema,
-    response: {
-      200: appendLogsResponseSchema,
-      409: offsetGapResponseSchema,
+export function createAppendLogsRoute(workflows: WorkflowsModuleClient) {
+  return defineRoute({
+    method: 'POST',
+    path: '/steps/:stepId/logs',
+    description: 'Append a chunk of logs for a step attempt of the leased job.',
+    schema: {
+      params: z.object({stepId: z.string().uuid()}),
+      querystring: appendLogsQuerySchema,
+      response: {
+        200: appendLogsResponseSchema,
+        409: offsetGapResponseSchema,
+      },
     },
-  },
-  errorHandler: (error) => {
-    if (error instanceof OffsetGapError) {
-      throw new ClientError('Append offset is ahead of the committed length', 'offset-gap', {
-        status: 409,
-        details: {committed_length: error.committedLength},
-      });
-    }
-    if (error instanceof MalformedLogChunkError) {
-      throw new ClientError(error.message, 'malformed-log-chunk', {status: 400});
-    }
-    if (error instanceof LeaseStreamMismatchError) {
-      throw new ClientError(error.message, 'lease-stream-mismatch', {status: 403});
-    }
-    throw error;
-  },
-  handler: async (request) => {
-    const leasedJob = requireLeasedJobContext(request);
-    const {stepId} = request.params;
-    const {attempt, offset} = request.query;
+    errorHandler: (error) => {
+      if (error instanceof OffsetGapError) {
+        throw new ClientError('Append offset is ahead of the committed length', 'offset-gap', {
+          status: 409,
+          details: {committed_length: error.committedLength},
+        });
+      }
+      if (error instanceof MalformedLogChunkError) {
+        throw new ClientError(error.message, 'malformed-log-chunk', {status: 400});
+      }
+      if (error instanceof LeaseStreamMismatchError) {
+        throw new ClientError(error.message, 'lease-stream-mismatch', {status: 403});
+      }
+      throw error;
+    },
+    handler: async (request) => {
+      const leasedJob = requireLeasedJobContext(request);
+      const {stepId} = request.params;
+      const {attempt, offset} = request.query;
 
-    // The scoped lease proves membership in the dispatched step attempt; active-step
-    // completion remains governed by workflow/report state, not the log append route.
-    if (leasedJob.currentStepId !== stepId || leasedJob.currentStepAttempt !== attempt) {
-      throw new ClientError('Step not found for leased job execution', 'step-not-found', {
-        status: 404,
-      });
-    }
+      if (leasedJob.currentStepId !== stepId || leasedJob.currentStepAttempt !== attempt) {
+        throw new ClientError('Step not found for leased job execution', 'step-not-found', {
+          status: 404,
+        });
+      }
 
-    const result = await appendLogs({
-      jobId: leasedJob.jobId,
-      workspaceId: leasedJob.workspaceId,
-      projectId: leasedJob.projectId,
-      workflowRunAttemptId: leasedJob.workflowRunAttemptId,
-      stepId,
-      attempt,
-      offset,
-      body: (request.body as Buffer | undefined) ?? Buffer.alloc(0),
-    });
+      const result = await appendLogs(
+        {
+          jobId: leasedJob.jobId,
+          workspaceId: leasedJob.workspaceId,
+          projectId: leasedJob.projectId,
+          workflowRunAttemptId: leasedJob.workflowRunAttemptId,
+          stepId,
+          attempt,
+          offset,
+          body: (request.body as Buffer | undefined) ?? Buffer.alloc(0),
+        },
+        workflows,
+      );
 
-    return {committed_length: result.committedLength, capped: result.capped};
-  },
-});
+      return {committed_length: result.committedLength, capped: result.capped};
+    },
+  });
+}

package/src/presentation/routes/index.ts

@@ -1,27 +1,30 @@
 import {AUTH_LEASED_JOB, AUTH_USER} from '@shipfox/api-auth-context';
+import type {WorkflowsModuleClient} from '@shipfox/api-workflows-dto/inter-module';
 import {createRawBodyPlugin, type RouteGroup} from '@shipfox/node-fastify';
 import {config} from '#config.js';
-import {appendLogsRoute} from './append-logs.js';
+import {createAppendLogsRoute} from './append-logs.js';
 import {readLogsRoute} from './read-logs.js';
 
 // Keep the lease-authed append in its own Fastify scope so the raw NDJSON parser does not
 // disturb the JSON read route (or workflow routes). The body limit also bounds one-append
 // budget overshoot. The read route is session-authed and workspace-scoped via the row.
-export const logsRoutes: RouteGroup[] = [
-  {
-    prefix: '/runs/jobs/current',
-    auth: AUTH_LEASED_JOB,
-    plugins: [
-      createRawBodyPlugin({
-        contentType: 'application/x-ndjson',
-        bodyLimit: config.LOG_APPEND_BODY_LIMIT_BYTES,
-      }),
-    ],
-    routes: [appendLogsRoute],
-  },
-  {
-    prefix: '/steps',
-    auth: AUTH_USER,
-    routes: [readLogsRoute],
-  },
-];
+export function createLogsRoutes(workflows: WorkflowsModuleClient): RouteGroup[] {
+  return [
+    {
+      prefix: '/runs/jobs/current',
+      auth: AUTH_LEASED_JOB,
+      plugins: [
+        createRawBodyPlugin({
+          contentType: 'application/x-ndjson',
+          bodyLimit: config.LOG_APPEND_BODY_LIMIT_BYTES,
+        }),
+      ],
+      routes: [createAppendLogsRoute(workflows)],
+    },
+    {
+      prefix: '/steps',
+      auth: AUTH_USER,
+      routes: [readLogsRoute],
+    },
+  ];
+}

package/src/presentation/routes/read-logs.test.ts

@@ -35,9 +35,10 @@ import {
   compactStreamActivity,
 } from '#temporal/activities/compact-stream.js';
 import {ndjsonBody, outputLine, recordLine} from '#test/fixtures/ndjson.js';
+import {createTestWorkflowsClient} from '#test/fixtures/workflows-client.js';
 import {findStream} from '#test/queries.js';
 import {onStepAttemptTerminated} from '../subscribers/on-step-attempt-terminated.js';
-import {logsRoutes} from './index.js';
+import {createLogsRoutes} from './index.js';
 
 // AUTH_USER stub: a `Bearer user` request is a member of whatever workspace it names in the
 // `x-test-workspace` header, so each test grants or withholds access against the arranged
@@ -159,7 +160,7 @@ describe('GET /steps/:stepId/attempts/:attempt/logs', () => {
   beforeAll(async () => {
     app = await createApp({
       auth: [fakeUserAuth, stubLeaseAuth],
-      routes: logsRoutes,
+      routes: createLogsRoutes(createTestWorkflowsClient()),
       swagger: false,
     });
     await app.ready();