@shipfox/api-logs 4.0.0 → 6.0.0

package/src/presentation/routes/index.ts

@@ -1,27 +1,30 @@
 import {AUTH_LEASED_JOB, AUTH_USER} from '@shipfox/api-auth-context';
+import type {WorkflowsModuleClient} from '@shipfox/api-workflows-dto/inter-module';
 import {createRawBodyPlugin, type RouteGroup} from '@shipfox/node-fastify';
 import {config} from '#config.js';
-import {appendLogsRoute} from './append-logs.js';
+import {createAppendLogsRoute} from './append-logs.js';
 import {readLogsRoute} from './read-logs.js';
 
 // Keep the lease-authed append in its own Fastify scope so the raw NDJSON parser does not
 // disturb the JSON read route (or workflow routes). The body limit also bounds one-append
 // budget overshoot. The read route is session-authed and workspace-scoped via the row.
-export const logsRoutes: RouteGroup[] = [
-  {
-    prefix: '/runs/jobs/current',
-    auth: AUTH_LEASED_JOB,
-    plugins: [
-      createRawBodyPlugin({
-        contentType: 'application/x-ndjson',
-        bodyLimit: config.LOG_APPEND_BODY_LIMIT_BYTES,
-      }),
-    ],
-    routes: [appendLogsRoute],
-  },
-  {
-    prefix: '/steps',
-    auth: AUTH_USER,
-    routes: [readLogsRoute],
-  },
-];
+export function createLogsRoutes(workflows: WorkflowsModuleClient): RouteGroup[] {
+  return [
+    {
+      prefix: '/runs/jobs/current',
+      auth: AUTH_LEASED_JOB,
+      plugins: [
+        createRawBodyPlugin({
+          contentType: 'application/x-ndjson',
+          bodyLimit: config.LOG_APPEND_BODY_LIMIT_BYTES,
+        }),
+      ],
+      routes: [createAppendLogsRoute(workflows)],
+    },
+    {
+      prefix: '/steps',
+      auth: AUTH_USER,
+      routes: [readLogsRoute],
+    },
+  ];
+}

package/src/presentation/routes/read-logs.test.ts

@@ -35,9 +35,10 @@ import {
   compactStreamActivity,
 } from '#temporal/activities/compact-stream.js';
 import {ndjsonBody, outputLine, recordLine} from '#test/fixtures/ndjson.js';
+import {createTestWorkflowsClient} from '#test/fixtures/workflows-client.js';
 import {findStream} from '#test/queries.js';
 import {onStepAttemptTerminated} from '../subscribers/on-step-attempt-terminated.js';
-import {logsRoutes} from './index.js';
+import {createLogsRoutes} from './index.js';
 
 // AUTH_USER stub: a `Bearer user` request is a member of whatever workspace it names in the
 // `x-test-workspace` header, so each test grants or withholds access against the arranged
@@ -159,7 +160,7 @@ describe('GET /steps/:stepId/attempts/:attempt/logs', () => {
   beforeAll(async () => {
     app = await createApp({
       auth: [fakeUserAuth, stubLeaseAuth],
-      routes: logsRoutes,
+      routes: createLogsRoutes(createTestWorkflowsClient()),
       swagger: false,
     });
     await app.ready();

package/test/env.ts

@@ -4,9 +4,7 @@ process.env.POSTGRES_USERNAME ??= 'shipfox';
 process.env.POSTGRES_PASSWORD ??= 'password';
 process.env.POSTGRES_DATABASE = 'api_test';
 process.env.POSTGRES_MAX_CONNECTIONS ??= '5';
-process.env.AUTH_JWT_SECRET = 'test-secret';
-process.env.AUTH_JOB_LEASE_TOKEN_SECRET = 'test-lease-secret';
-process.env.AUTH_RUNNER_SESSION_TOKEN_SECRET = 'test-runner-session-secret';
+process.env.AUTH_ROOT_KEY = 'MDEyMzQ1Njc4OWFiY2RlZjAxMjM0NTY3ODlhYmNkZWY=';
 process.env.SECRETS_ENCRYPTION_KEK = 'ZmVkY2JhOTg3NjU0MzIxMGZlZGNiYTk4NzY1NDMyMTA=';
 
 // Small accrual budget so cap/budget tests use tiny payloads: base 100 bytes,

package/test/fixtures/lease-token.ts

@@ -1,8 +1,9 @@
 import {JOB_LEASE_TOKEN_AUDIENCE} from '@shipfox/api-auth-dto';
+import {jobLeaseTokenKey} from '@shipfox/node-auth-root-key';
 import {signHs256} from '@shipfox/node-jwt';
 
 // Matches test/env.ts; the lease-token auth method reads this same value from config.
-const SECRET = process.env.AUTH_JOB_LEASE_TOKEN_SECRET ?? 'test-lease-secret';
+const SECRET = jobLeaseTokenKey();
 
 export interface MintLeaseTokenParams {
   jobId: string;

package/test/fixtures/workflows-client.ts

@@ -0,0 +1,17 @@
+import {
+  type WorkflowsModuleClient,
+  workflowsInterModuleContract,
+} from '@shipfox/api-workflows-dto/inter-module';
+import {defineInterModulePresentation} from '@shipfox/inter-module';
+import {createFakeInterModuleClients} from '@shipfox/node-module/inter-module/testing';
+
+export function createTestWorkflowsClient(): WorkflowsModuleClient {
+  return createFakeInterModuleClients({
+    workflows: defineInterModulePresentation(workflowsInterModuleContract, {
+      startRunFromTrigger: vi.fn(),
+      deliverEventToJobListener: vi.fn(),
+      getStepLogContext: () => ({harness: 'pi' as const}),
+      getLeasedAgentToolContext: vi.fn(),
+    }),
+  }).workflows;
+}