@shipfox/api-definitions 10.2.0 → 12.0.0

package/src/temporal/activities/sync-activities.ts

@@ -3,7 +3,7 @@ import type {IntegrationsModuleClient} from '@shipfox/api-integration-core-dto/i
 import {markErrorReported} from '@shipfox/node-error-monitoring';
 import {Context} from '@temporalio/activity';
 import {ApplicationFailure} from '@temporalio/common';
-import type {DefinitionSyncErrorCode} from '#core/entities/sync-state.js';
+import type {DefinitionSyncErrorCode, DefinitionSyncWarning} from '#core/entities/sync-state.js';
 import {
   classifySyncFailure,
   discoverWorkflowFiles,
@@ -50,6 +50,11 @@ export interface DiscoverWorkflowsActivityResult {
 export interface FetchAndApplyActivityResult {
   appliedCount: number;
   deletedCount: number;
+  warnings: DefinitionSyncWarning[];
+}
+
+export interface MarkSyncSucceededActivityInput extends SyncRefScopedInput {
+  warnings?: readonly DefinitionSyncWarning[] | undefined;
 }
 
 export interface DefinitionSyncActivityOptions {
@@ -93,6 +98,7 @@ function createPrepareDefinitionSyncActivity(sourceControl: DefinitionsSourceCon
         status: 'syncing',
         lastErrorCode: null,
         lastErrorMessage: null,
+        warnings: [],
         startedAt: new Date(),
         finishedAt: null,
       });
@@ -147,7 +153,7 @@ function createFetchAndApplyActivity(
               },
       });
 
-      return await applyVcsDefinitionsBatch({
+      const result = await applyVcsDefinitionsBatch({
         projectId: input.projectId,
         workspaceId: input.workspaceId,
         ref: input.sourceRef,
@@ -160,12 +166,19 @@ function createFetchAndApplyActivity(
           contentHash: entry.contentHash,
         })),
       });
+
+      return {
+        ...result,
+        warnings: definitions.flatMap((entry) => entry.warnings),
+      };
     });
   };
 }
 
 function createMarkSyncSucceededActivity() {
-  return async function markDefinitionSyncSucceeded(input: SyncRefScopedInput): Promise<void> {
+  return async function markDefinitionSyncSucceeded(
+    input: MarkSyncSucceededActivityInput,
+  ): Promise<void> {
     await markDefinitionSyncState({
       projectId: input.projectId,
       sourceConnectionId: input.sourceConnectionId,
@@ -174,6 +187,7 @@ function createMarkSyncSucceededActivity() {
       status: 'succeeded',
       lastErrorCode: null,
       lastErrorMessage: null,
+      warnings: input.warnings ?? [],
       finishedAt: new Date(),
     });
   };
@@ -191,6 +205,7 @@ function createMarkSyncFailedActivity() {
       status: 'failed',
       lastErrorCode: input.code,
       lastErrorMessage: input.message,
+      warnings: [],
       finishedAt: new Date(),
     });
   };

package/src/temporal/workflows/definition-sync.ts

@@ -65,7 +65,7 @@ export async function definitionSyncWorkflow(
     const {paths} = await discoverDefinitionWorkflows(source);
     const applied = await fetchAndApplyDefinitionWorkflows({...source, paths});
 
-    await markDefinitionSyncSucceeded(source);
+    await markDefinitionSyncSucceeded({...source, warnings: applied.warnings});
 
     return {
       sourceRef,

package/test/agent-validation-catalog.ts

@@ -7,6 +7,21 @@ import {
 } from '@shipfox/api-agent-dto';
 import type {AgentValidationCatalog} from '@shipfox/api-agent-dto/inter-module';
 
+const piModelIdsByProvider = Object.fromEntries(
+  MODEL_PROVIDER_CATALOG_SEED.filter((entry) => entry.support_status === 'supported').map(
+    (entry) => [
+      entry.id,
+      entry.id === 'anthropic'
+        ? ['claude-opus-4-8']
+        : entry.id === 'openai'
+          ? ['gpt-4.1', 'gpt-5.5-pro']
+          : entry.default_model === null
+            ? []
+            : [entry.default_model],
+    ],
+  ),
+);
+
 export const agentValidationCatalog: AgentValidationCatalog = {
   version: 1,
   providers: MODEL_PROVIDER_IDS.map((id) => ({
@@ -17,6 +32,8 @@ export const agentValidationCatalog: AgentValidationCatalog = {
   harnesses: listHarnessDescriptors().map((harness) => ({
     id: harness.id,
     supported_provider_ids: [...harness.supportedProviderIds],
+    model_ids_by_provider:
+      harness.id === 'pi' ? piModelIdsByProvider : {anthropic: ['claude-opus-4-8']},
     thinking_levels: [...harness.thinkingLevels],
     effective_tools: listEnabledHarnessTools(
       harness.id,

package/test/fixtures/valid-listening-job.yml

@@ -2,7 +2,8 @@ name: Listening workflow
 runner: ubuntu-latest
 jobs:
   review:
-    name: Review batch ${{ execution.index }}
+    name: Review batch
+    execution_name: Review batch ${{ execution.index }}
     listening:
       on:
         - source: github