@shipfox/api-auth 9.3.0 → 10.1.0

package/src/presentation/routes/administration.test.ts

@@ -1,8 +1,10 @@
 import {ADMINISTRATION_ACTION_PERFORMED} from '@shipfox/api-common-dto';
 import {sql} from 'drizzle-orm';
 import type {FastifyInstance} from 'fastify';
+import {type AuthRateLimitAction, hashAuthRateLimitIdentifier} from '#core/rate-limit.js';
 import {db} from '#db/db.js';
 import {authOutbox} from '#db/schema/outbox.js';
+import {authRateLimits} from '#db/schema/rate-limits.js';
 import {createAuthTestApp, createVerifiedSession, resetCapturedMail} from '#test/routes.js';
 
 const BOOTSTRAP_TOKEN = 'test-bootstrap-token';
@@ -20,6 +22,30 @@ function authHeaders(token: string, idempotencyKey: string) {
   };
 }
 
+async function seedExhaustedIpBucket(params: {
+  action: AuthRateLimitAction;
+  identifier: string;
+  limit: number;
+  windowSeconds: number;
+}): Promise<void> {
+  const windowMs = params.windowSeconds * 1000;
+  const windowStart = new Date(Math.floor(Date.now() / windowMs) * windowMs);
+  await db()
+    .insert(authRateLimits)
+    .values({
+      action: params.action,
+      scope: 'ip',
+      identifierHmac: hashAuthRateLimitIdentifier({
+        action: params.action,
+        scope: 'ip',
+        identifier: params.identifier,
+      }),
+      windowStart,
+      count: params.limit,
+      expiresAt: new Date(windowStart.getTime() + windowMs),
+    });
+}
+
 describe('Auth administration routes', () => {
   let app: FastifyInstance;
 
@@ -40,7 +66,7 @@ describe('Auth administration routes', () => {
   test('requires an authenticated session for bootstrap', async () => {
     const response = await app.inject({
       method: 'POST',
-      url: '/admin/v1/auth/admin-grants/bootstrap',
+      url: '/admin/auth/admin-grants/bootstrap',
       headers: {'idempotency-key': 'anonymous-bootstrap'},
       payload: {bootstrap_token: BOOTSTRAP_TOKEN},
     });
@@ -48,12 +74,93 @@ describe('Auth administration routes', () => {
     expect(response.statusCode).toBe(401);
   });
 
+  test('requires an authenticated session for bootstrap state', async () => {
+    const response = await app.inject({
+      method: 'GET',
+      url: '/admin/auth/bootstrap-state',
+    });
+
+    expect(response.statusCode).toBe(401);
+  });
+
+  test('reports only available or closed bootstrap state', async () => {
+    const account = await createVerifiedSession('admin-bootstrap-state');
+
+    const available = await app.inject({
+      method: 'GET',
+      url: '/admin/auth/bootstrap-state',
+      headers: {authorization: `Bearer ${account.token}`},
+    });
+
+    expect(available.statusCode).toBe(200);
+    expect(available.json()).toEqual({state: 'available'});
+
+    const bootstrap = await app.inject({
+      method: 'POST',
+      url: '/admin/auth/admin-grants/bootstrap',
+      headers: authHeaders(account.token, 'bootstrap-state-bootstrap'),
+      payload: {bootstrap_token: BOOTSTRAP_TOKEN},
+    });
+    expect(bootstrap.statusCode).toBe(201);
+
+    const closed = await app.inject({
+      method: 'GET',
+      url: '/admin/auth/bootstrap-state',
+      headers: {authorization: `Bearer ${account.token}`},
+    });
+
+    expect(closed.statusCode).toBe(200);
+    expect(closed.json()).toEqual({state: 'closed'});
+    expect(JSON.stringify(closed.json())).not.toContain(BOOTSTRAP_TOKEN);
+  });
+
+  test('keeps bootstrap-state reads separate from the bootstrap write limit', async () => {
+    const account = await createVerifiedSession('admin-bootstrap-state-rate-limit');
+    const ip = '127.0.0.1';
+
+    await seedExhaustedIpBucket({
+      action: 'bootstrap',
+      identifier: ip,
+      limit: 5,
+      windowSeconds: 15 * 60,
+    });
+    const state = await app.inject({
+      method: 'GET',
+      url: '/admin/auth/bootstrap-state',
+      headers: {authorization: `Bearer ${account.token}`},
+    });
+    expect(state.statusCode).toBe(200);
+
+    await resetAdministrationState();
+    await seedExhaustedIpBucket({
+      action: 'bootstrap-state',
+      identifier: ip,
+      limit: 60,
+      windowSeconds: 5 * 60,
+    });
+    const blocked = await app.inject({
+      method: 'GET',
+      url: '/admin/auth/bootstrap-state',
+      headers: {authorization: `Bearer ${account.token}`},
+    });
+    expect(blocked.statusCode).toBe(429);
+  });
+
+  test('does not register the removed versioned administration namespace', async () => {
+    const response = await app.inject({
+      method: 'GET',
+      url: '/admin/v1/auth/users?user_id=00000000-0000-4000-8000-000000000000',
+    });
+
+    expect(response.statusCode).toBe(404);
+  });
+
   test('rejects an invalid bootstrap token without writing a grant or event', async () => {
     const account = await createVerifiedSession('admin-bootstrap-invalid');
 
     const response = await app.inject({
       method: 'POST',
-      url: '/admin/v1/auth/admin-grants/bootstrap',
+      url: '/admin/auth/admin-grants/bootstrap',
       headers: authHeaders(account.token, 'invalid-bootstrap'),
       payload: {bootstrap_token: 'wrong-token'},
     });
@@ -69,7 +176,7 @@ describe('Auth administration routes', () => {
     for (let attempt = 0; attempt < 5; attempt += 1) {
       const response = await app.inject({
         method: 'POST',
-        url: '/admin/v1/auth/admin-grants/bootstrap',
+        url: '/admin/auth/admin-grants/bootstrap',
         headers: authHeaders(account.token, `bootstrap-rate-limit-${attempt}`),
         payload: {bootstrap_token: 'wrong-token'},
       });
@@ -78,7 +185,7 @@ describe('Auth administration routes', () => {
 
     const blocked = await app.inject({
       method: 'POST',
-      url: '/admin/v1/auth/admin-grants/bootstrap',
+      url: '/admin/auth/admin-grants/bootstrap',
       headers: authHeaders(account.token, 'bootstrap-rate-limit-blocked'),
       payload: {bootstrap_token: 'wrong-token'},
     });
@@ -92,7 +199,7 @@ describe('Auth administration routes', () => {
 
     const response = await app.inject({
       method: 'POST',
-      url: '/admin/v1/auth/admin-grants/bootstrap',
+      url: '/admin/auth/admin-grants/bootstrap',
       headers: authHeaders(first.token, 'bootstrap-first'),
       payload: {bootstrap_token: BOOTSTRAP_TOKEN},
     });
@@ -102,7 +209,7 @@ describe('Auth administration routes', () => {
 
     const repeated = await app.inject({
       method: 'POST',
-      url: '/admin/v1/auth/admin-grants/bootstrap',
+      url: '/admin/auth/admin-grants/bootstrap',
       headers: authHeaders(first.token, 'bootstrap-first'),
       payload: {bootstrap_token: BOOTSTRAP_TOKEN},
     });
@@ -111,7 +218,7 @@ describe('Auth administration routes', () => {
 
     const secondAttempt = await app.inject({
       method: 'POST',
-      url: '/admin/v1/auth/admin-grants/bootstrap',
+      url: '/admin/auth/admin-grants/bootstrap',
       headers: authHeaders(second.token, 'bootstrap-second'),
       payload: {bootstrap_token: BOOTSTRAP_TOKEN},
     });
@@ -131,13 +238,43 @@ describe('Auth administration routes', () => {
     expect(JSON.stringify(events[0]?.payload)).not.toContain(BOOTSTRAP_TOKEN);
   });
 
+  test('serializes concurrent bootstrap attempts to one active first owner', async () => {
+    const first = await createVerifiedSession('admin-bootstrap-race-first');
+    const second = await createVerifiedSession('admin-bootstrap-race-second');
+
+    const responses = await Promise.all(
+      [first, second].map((account, index) =>
+        app.inject({
+          method: 'POST',
+          url: '/admin/auth/admin-grants/bootstrap',
+          headers: authHeaders(account.token, `bootstrap-race-${index}`),
+          payload: {bootstrap_token: BOOTSTRAP_TOKEN},
+        }),
+      ),
+    );
+
+    expect(responses.map((response) => response.statusCode).sort()).toEqual([201, 409]);
+    const activeOwnerRoles = await Promise.all(
+      [first, second].map(async (account) => {
+        const response = await app.inject({
+          method: 'GET',
+          url: `/admin/auth/users?user_id=${account.userId}`,
+          headers: {authorization: `Bearer ${account.token}`},
+        });
+        return response.statusCode === 200 && response.json().admin_role === 'admin-owner';
+      }),
+    );
+
+    expect(activeOwnerRoles.filter(Boolean)).toHaveLength(1);
+  });
+
   test('lets an owner list, grant, and revoke roles with idempotent audited mutations', async () => {
     const owner = await createVerifiedSession('admin-grant-owner');
     const target = await createVerifiedSession('admin-grant-target');
 
     const bootstrap = await app.inject({
       method: 'POST',
-      url: '/admin/v1/auth/admin-grants/bootstrap',
+      url: '/admin/auth/admin-grants/bootstrap',
       headers: authHeaders(owner.token, 'grant-bootstrap'),
       payload: {bootstrap_token: BOOTSTRAP_TOKEN},
     });
@@ -145,7 +282,7 @@ describe('Auth administration routes', () => {
 
     const grant = await app.inject({
       method: 'POST',
-      url: '/admin/v1/auth/admin-grants',
+      url: '/admin/auth/admin-grants',
       headers: authHeaders(owner.token, 'grant-observer'),
       payload: {
         user_id: target.userId,
@@ -157,7 +294,7 @@ describe('Auth administration routes', () => {
 
     const repeatedGrant = await app.inject({
       method: 'POST',
-      url: '/admin/v1/auth/admin-grants',
+      url: '/admin/auth/admin-grants',
       headers: authHeaders(owner.token, 'grant-observer'),
       payload: {
         user_id: target.userId,
@@ -170,17 +307,19 @@ describe('Auth administration routes', () => {
 
     const grants = await app.inject({
       method: 'GET',
-      url: '/admin/v1/auth/admin-grants',
+      url: '/admin/auth/admin-grants',
       headers: {authorization: `Bearer ${owner.token}`},
     });
     expect(grants.statusCode).toBe(200);
     expect(grants.json().grants).toEqual(
-      expect.arrayContaining([expect.objectContaining({user_id: target.userId})]),
+      expect.arrayContaining([
+        expect.objectContaining({user: expect.objectContaining({id: target.userId})}),
+      ]),
     );
 
     const revoked = await app.inject({
       method: 'DELETE',
-      url: `/admin/v1/auth/admin-grants/${grant.json().id}`,
+      url: `/admin/auth/admin-grants/${grant.json().id}`,
       headers: authHeaders(owner.token, 'revoke-observer'),
       payload: {reason: 'Support investigation complete'},
     });
@@ -189,7 +328,7 @@ describe('Auth administration routes', () => {
 
     const repeatedRevoke = await app.inject({
       method: 'DELETE',
-      url: `/admin/v1/auth/admin-grants/${grant.json().id}`,
+      url: `/admin/auth/admin-grants/${grant.json().id}`,
       headers: authHeaders(owner.token, 'revoke-observer'),
       payload: {reason: 'Support investigation complete'},
     });
@@ -203,20 +342,293 @@ describe('Auth administration routes', () => {
     );
   });
 
+  test('lets an observer find exact IDs and normalized emails without exposing user secrets', async () => {
+    const owner = await createVerifiedSession('admin-user-lookup-owner');
+    const observer = await createVerifiedSession('admin-user-lookup-observer');
+
+    await app.inject({
+      method: 'POST',
+      url: '/admin/auth/admin-grants/bootstrap',
+      headers: authHeaders(owner.token, 'user-lookup-bootstrap'),
+      payload: {bootstrap_token: BOOTSTRAP_TOKEN},
+    });
+    await app.inject({
+      method: 'POST',
+      url: '/admin/auth/admin-grants',
+      headers: authHeaders(owner.token, 'user-lookup-grant'),
+      payload: {
+        user_id: observer.userId,
+        role: 'admin-observer',
+        reason: 'Support lookup access',
+      },
+    });
+
+    const byId = await app.inject({
+      method: 'GET',
+      url: `/admin/auth/users?user_id=${observer.userId}`,
+      headers: {authorization: `Bearer ${observer.token}`},
+    });
+
+    expect(byId.statusCode).toBe(200);
+    expect(byId.json()).toEqual({
+      id: observer.userId,
+      email: observer.email,
+      name: 'admin-user-lookup-observer',
+      status: 'active',
+      email_verified_at: expect.any(String),
+      created_at: expect.any(String),
+      admin_role: 'admin-observer',
+    });
+    expect(byId.json()).not.toHaveProperty('hashed_password');
+    expect(byId.json()).not.toHaveProperty('sessions');
+    expect(byId.json()).not.toHaveProperty('provider_payload');
+
+    const byEmail = await app.inject({
+      method: 'GET',
+      url: `/admin/auth/users?email=${encodeURIComponent(` ${observer.email.toUpperCase()} `)}`,
+      headers: {authorization: `Bearer ${observer.token}`},
+    });
+
+    expect(byEmail.statusCode).toBe(200);
+    expect(byEmail.json().id).toBe(observer.userId);
+    expect(byEmail.json().email).toBe(observer.email);
+  });
+
+  test('bounds and deterministically paginates administrator grant summaries for observers', async () => {
+    const owner = await createVerifiedSession('admin-summary-owner');
+    const observer = await createVerifiedSession('admin-summary-observer');
+
+    await app.inject({
+      method: 'POST',
+      url: '/admin/auth/admin-grants/bootstrap',
+      headers: authHeaders(owner.token, 'summary-bootstrap'),
+      payload: {bootstrap_token: BOOTSTRAP_TOKEN},
+    });
+    const grant = await app.inject({
+      method: 'POST',
+      url: '/admin/auth/admin-grants',
+      headers: authHeaders(owner.token, 'summary-grant'),
+      payload: {
+        user_id: observer.userId,
+        role: 'admin-observer',
+        reason: 'Read-only support access',
+      },
+    });
+
+    const firstPage = await app.inject({
+      method: 'GET',
+      url: '/admin/auth/admin-grants?limit=1',
+      headers: {authorization: `Bearer ${observer.token}`},
+    });
+
+    expect(firstPage.statusCode).toBe(200);
+    expect(firstPage.json().grants).toHaveLength(1);
+    expect(firstPage.json().grants[0]).toEqual({
+      grant_id: grant.json().id,
+      role: 'admin-observer',
+      created_at: expect.any(String),
+      revoked_at: null,
+      user: {
+        id: observer.userId,
+        email: observer.email,
+        name: 'admin-summary-observer',
+        status: 'active',
+      },
+    });
+    expect(firstPage.json().next_cursor).toEqual(expect.any(String));
+
+    const secondPage = await app.inject({
+      method: 'GET',
+      url: `/admin/auth/admin-grants?limit=1&cursor=${firstPage.json().next_cursor}`,
+      headers: {authorization: `Bearer ${observer.token}`},
+    });
+
+    expect(secondPage.statusCode).toBe(200);
+    expect(secondPage.json().grants).toHaveLength(1);
+    expect(secondPage.json().grants[0].user.id).toBe(owner.userId);
+    expect(secondPage.json().next_cursor).toBeNull();
+  });
+
+  test('rejects ordinary users and unchecked user lookup filters', async () => {
+    const ordinary = await createVerifiedSession('admin-lookup-ordinary');
+
+    const forbidden = await app.inject({
+      method: 'GET',
+      url: `/admin/auth/users?id=${ordinary.userId}`,
+      headers: {authorization: `Bearer ${ordinary.token}`},
+    });
+    expect(forbidden.statusCode).toBe(403);
+
+    const missingFilter = await app.inject({
+      method: 'GET',
+      url: '/admin/auth/users',
+      headers: {authorization: `Bearer ${ordinary.token}`},
+    });
+    expect(missingFilter.statusCode).toBe(400);
+
+    const multipleFilters = await app.inject({
+      method: 'GET',
+      url: `/admin/auth/users?id=${ordinary.userId}&email=${encodeURIComponent(ordinary.email)}`,
+      headers: {authorization: `Bearer ${ordinary.token}`},
+    });
+    expect(multipleFilters.statusCode).toBe(400);
+  });
+
+  test('returns 404 for a well-formed but unknown user lookup', async () => {
+    const owner = await createVerifiedSession('admin-lookup-unknown-owner');
+    const observer = await createVerifiedSession('admin-lookup-unknown-observer');
+
+    await app.inject({
+      method: 'POST',
+      url: '/admin/auth/admin-grants/bootstrap',
+      headers: authHeaders(owner.token, 'unknown-lookup-bootstrap'),
+      payload: {bootstrap_token: BOOTSTRAP_TOKEN},
+    });
+    await app.inject({
+      method: 'POST',
+      url: '/admin/auth/admin-grants',
+      headers: authHeaders(owner.token, 'unknown-lookup-grant'),
+      payload: {
+        user_id: observer.userId,
+        role: 'admin-observer',
+        reason: 'Support lookup access',
+      },
+    });
+
+    const response = await app.inject({
+      method: 'GET',
+      url: '/admin/auth/users?user_id=00000000-0000-4000-8000-000000000000',
+      headers: {authorization: `Bearer ${observer.token}`},
+    });
+
+    expect(response.statusCode).toBe(404);
+    expect(response.json().code).toBe('not-found');
+  });
+
+  test('rejects a malformed pagination cursor', async () => {
+    const owner = await createVerifiedSession('admin-grants-bad-cursor-owner');
+    const observer = await createVerifiedSession('admin-grants-bad-cursor-observer');
+
+    await app.inject({
+      method: 'POST',
+      url: '/admin/auth/admin-grants/bootstrap',
+      headers: authHeaders(owner.token, 'bad-cursor-bootstrap'),
+      payload: {bootstrap_token: BOOTSTRAP_TOKEN},
+    });
+    await app.inject({
+      method: 'POST',
+      url: '/admin/auth/admin-grants',
+      headers: authHeaders(owner.token, 'bad-cursor-grant'),
+      payload: {
+        user_id: observer.userId,
+        role: 'admin-observer',
+        reason: 'Support lookup access',
+      },
+    });
+
+    const response = await app.inject({
+      method: 'GET',
+      url: '/admin/auth/admin-grants?cursor=not-a-real-cursor',
+      headers: {authorization: `Bearer ${observer.token}`},
+    });
+
+    expect(response.statusCode).toBe(400);
+    expect(response.json().code).toBe('invalid-cursor');
+  });
+
+  test('rate-limits repeated user lookups by source IP', async () => {
+    const owner = await createVerifiedSession('admin-lookup-rate-limit-owner');
+    const observer = await createVerifiedSession('admin-lookup-rate-limit-observer');
+
+    await app.inject({
+      method: 'POST',
+      url: '/admin/auth/admin-grants/bootstrap',
+      headers: authHeaders(owner.token, 'lookup-rate-limit-bootstrap'),
+      payload: {bootstrap_token: BOOTSTRAP_TOKEN},
+    });
+    await app.inject({
+      method: 'POST',
+      url: '/admin/auth/admin-grants',
+      headers: authHeaders(owner.token, 'lookup-rate-limit-grant'),
+      payload: {
+        user_id: observer.userId,
+        role: 'admin-observer',
+        reason: 'Support lookup access',
+      },
+    });
+
+    for (let attempt = 0; attempt < 60; attempt += 1) {
+      const response = await app.inject({
+        method: 'GET',
+        url: `/admin/auth/users?user_id=${observer.userId}`,
+        headers: {authorization: `Bearer ${observer.token}`},
+      });
+      expect(response.statusCode).toBe(200);
+    }
+
+    const blocked = await app.inject({
+      method: 'GET',
+      url: `/admin/auth/users?user_id=${observer.userId}`,
+      headers: {authorization: `Bearer ${observer.token}`},
+    });
+
+    expect(blocked.statusCode).toBe(429);
+    expect(blocked.json().code).toBe('rate-limited');
+  });
+
+  test('checks the administrator role before consuming the lookup IP bucket', async () => {
+    const owner = await createVerifiedSession('admin-lookup-authz-order-owner');
+    const observer = await createVerifiedSession('admin-lookup-authz-order-observer');
+    const ordinary = await createVerifiedSession('admin-lookup-authz-order-ordinary');
+
+    await app.inject({
+      method: 'POST',
+      url: '/admin/auth/admin-grants/bootstrap',
+      headers: authHeaders(owner.token, 'authz-order-bootstrap'),
+      payload: {bootstrap_token: BOOTSTRAP_TOKEN},
+    });
+    await app.inject({
+      method: 'POST',
+      url: '/admin/auth/admin-grants',
+      headers: authHeaders(owner.token, 'authz-order-grant'),
+      payload: {
+        user_id: observer.userId,
+        role: 'admin-observer',
+        reason: 'Support lookup access',
+      },
+    });
+
+    for (let attempt = 0; attempt < 60; attempt += 1) {
+      const response = await app.inject({
+        method: 'GET',
+        url: `/admin/auth/users?user_id=${ordinary.userId}`,
+        headers: {authorization: `Bearer ${ordinary.token}`},
+      });
+      expect(response.statusCode).toBe(403);
+    }
+
+    const observerResponse = await app.inject({
+      method: 'GET',
+      url: `/admin/auth/users?user_id=${observer.userId}`,
+      headers: {authorization: `Bearer ${observer.token}`},
+    });
+    expect(observerResponse.statusCode).toBe(200);
+  });
+
   test('protects the final active owner and rejects idempotency-key reuse', async () => {
     const owner = await createVerifiedSession('admin-final-owner');
     const target = await createVerifiedSession('admin-final-target');
 
     await app.inject({
       method: 'POST',
-      url: '/admin/v1/auth/admin-grants/bootstrap',
+      url: '/admin/auth/admin-grants/bootstrap',
       headers: authHeaders(owner.token, 'final-bootstrap'),
       payload: {bootstrap_token: BOOTSTRAP_TOKEN},
     });
 
     const firstGrant = await app.inject({
       method: 'POST',
-      url: '/admin/v1/auth/admin-grants',
+      url: '/admin/auth/admin-grants',
       headers: authHeaders(owner.token, 'role-key'),
       payload: {user_id: target.userId, role: 'admin-observer', reason: 'Initial review'},
     });
@@ -224,7 +636,7 @@ describe('Auth administration routes', () => {
 
     const reusedKey = await app.inject({
       method: 'POST',
-      url: '/admin/v1/auth/admin-grants',
+      url: '/admin/auth/admin-grants',
       headers: authHeaders(owner.token, 'role-key'),
       payload: {user_id: target.userId, role: 'admin-operator', reason: 'Different command'},
     });
@@ -233,16 +645,16 @@ describe('Auth administration routes', () => {
 
     const finalOwnerRevoke = await app.inject({
       method: 'DELETE',
-      url: `/admin/v1/auth/admin-grants/${
+      url: `/admin/auth/admin-grants/${
         (
           await app.inject({
             method: 'GET',
-            url: '/admin/v1/auth/admin-grants',
+            url: '/admin/auth/admin-grants',
             headers: {authorization: `Bearer ${owner.token}`},
           })
         )
           .json()
-          .grants.find((grant: {user_id: string}) => grant.user_id === owner.userId).id
+          .grants.find((grant: {user: {id: string}}) => grant.user.id === owner.userId).grant_id
       }`,
       headers: authHeaders(owner.token, 'revoke-final-owner'),
       payload: {reason: 'Attempt to remove final owner'},