@shepherdjerred/helm-types 1.5.0 → 1.6.0-dev.7909

package/dist/cli.js

@@ -21309,7 +21309,7 @@ function isPartOfYAMLBlock(line, trimmed) {
   return line.startsWith(" ") || line.startsWith("\t") || trimmed.startsWith("-") || trimmed.startsWith("#");
 }
 function isSectionHeaderForCommentedBlock(nextLine) {
-  if (nextLine == null || nextLine === "") {
+  if (nextLine === "" || nextLine == null) {
     return false;
   }
   const nextTrimmed = nextLine.trim();
@@ -21375,7 +21375,7 @@ function parseCommentsWithRegex(yamlContent) {
   lines.forEach((line, lineNum) => {
     const trimmed = line.trim();
     if (!trimmed) {
-      if (pendingComment.length > 0 && pendingCommentIndent === -1) {
+      if (pendingCommentIndent === -1 && pendingComment.length > 0) {
         pendingDebugInfo.push(`Line ${String(lineNum)}: Blank line after commented-out key, resetting pending`);
         pendingComment = [];
         pendingDebugInfo = [];
@@ -21418,7 +21418,7 @@ function parseCommentsWithRegex(yamlContent) {
     const keyMatch = keyMatchRegex.exec(trimmed);
     if (keyMatch && pendingComment.length > 0) {
       const key = keyMatch[1];
-      if (key != null && key !== "") {
+      if (key !== "" && key != null) {
         const keyIndent = line.search(/\S/);
         if (pendingCommentIndent === -1 || Math.abs(keyIndent - pendingCommentIndent) <= 2) {
           const commentText = pendingComment.join(`
@@ -21508,7 +21508,7 @@ function tryUncommentLine(line, lines, i, state) {
     return { uncommented: null, newConsecutive: 0 };
   }
   const [, indent, keyValue] = commentedKeyMatch;
-  if (keyValue == null || keyValue === "" || indent == null || indent === "") {
+  if (keyValue === "" || indent === "" || keyValue == null || indent == null) {
     return {
       uncommented: null,
       newConsecutive: state.consecutiveCommentedKeys
@@ -21593,7 +21593,7 @@ function isSimpleYAMLValue(line) {
   return /^[\w.-]+:\s[^:]+$/.test(line) && !hasURL && !isRef;
 }
 function isSectionHeader(line, nextLine) {
-  if (nextLine == null || nextLine === "") {
+  if (nextLine === "" || nextLine == null) {
     return false;
   }
   const isFollowedByYAMLKey = /^[\w.-]+:\s*\|/.test(nextLine) || /^[\w.-]+:\s*$/.test(nextLine) || /^[\w.-]+:\s+/.test(nextLine);
@@ -21622,7 +21622,7 @@ function looksLikeProse(line, wordCount) {
   const hasURL = line.includes("http://") || line.includes("https://");
   const startsWithCapital = /^[A-Z]/.test(line);
   const hasEndPunctuation = /[.!?:]$/.test(line);
-  const notYamlKey = !(isYAMLKey(line) && !hasURL && !/^ref:/i.test(line));
+  const notYamlKey = !(!hasURL && isYAMLKey(line) && !/^ref:/i.test(line));
   const reasonableLength = line.length > 10;
   const hasMultipleWords = wordCount >= 3;
   const startsWithArticle = /^(?:This|The|A|An)\s/i.test(line);
@@ -21702,7 +21702,7 @@ function parseBitnamiParams(comment) {
     const paramMatch = /^@param\s+([\w.-]+)\s+(\S.*)$/.exec(trimmedLine);
     if (paramMatch) {
       const [, paramKey, description] = paramMatch;
-      if (paramKey != null && paramKey !== "" && description != null && description !== "") {
+      if (paramKey !== "" && description !== "" && paramKey != null && description != null) {
         params.set(paramKey, description);
       }
     } else if (trimmedLine) {
@@ -21740,7 +21740,7 @@ ${comment}` : pairComment;
         comment = comment ? `${comment}
 ${inlineComment}` : inlineComment;
       }
-      if (context.index === 0 && !comment && context.mapComment) {
+      if (!comment && context.index === 0 && context.mapComment) {
         comment = context.mapComment;
       }
       if (comment) {
@@ -22117,7 +22117,7 @@ function shouldAllowArbitraryProps(keyPath, chartName, propertyName, yamlComment
   if (lowerPath.includes("persistence") || lowerPath.includes("storage")) {
     return true;
   }
-  if (yamlComment != null && yamlComment !== "") {
+  if (yamlComment !== "" && yamlComment != null) {
     const commentLower = yamlComment.toLowerCase();
     if (/\b(?:arbitrary|custom|additional|extra|any)\s+(?:keys?|properties?|fields?|values?)\b/i.test(commentLower) || /\bkey[\s-]?value\s+pairs?\b/i.test(commentLower)) {
       return true;
@@ -22178,10 +22178,10 @@ function capitalizeFirst(str) {
 
 // src/type-converter-helpers.ts
 function mergeDescriptions(schemaDescription, yamlComment) {
-  if (yamlComment == null || yamlComment === "") {
+  if (yamlComment === "" || yamlComment == null) {
     return schemaDescription;
   }
-  return schemaDescription != null && schemaDescription !== "" ? `${yamlComment}
+  return schemaDescription !== "" && schemaDescription != null ? `${yamlComment}
 
 ${schemaDescription}` : yamlComment;
 }
@@ -22346,21 +22346,21 @@ function typesAreCompatible(inferredType, schemaType) {
   const schemaTypes = schemaType.split("|").map((t) => t.trim().replaceAll(/^["']|["']$/g, ""));
   if (schemaTypes.length > 1) {
     for (const st of schemaTypes) {
-      if (st.startsWith('"') && st.endsWith('"') && inferredType === "string") {
+      if (inferredType === "string" && st.startsWith('"') && st.endsWith('"')) {
         return true;
       }
       if (st === inferredType) {
         return true;
       }
-      if (st.endsWith("[]") && inferredType === "array") {
+      if (inferredType === "array" && st.endsWith("[]")) {
         return true;
       }
     }
   }
-  if (schemaType.endsWith("[]") && inferredType === "array") {
+  if (inferredType === "array" && schemaType.endsWith("[]")) {
     return true;
   }
-  if (schemaType.includes('"') && inferredType === "string") {
+  if (inferredType === "string" && schemaType.includes('"')) {
     return true;
   }
   if (schemaType === "unknown" || inferredType === "unknown") {
@@ -22409,8 +22409,8 @@ function convertWithSchema(ctx) {
   } = ctx;
   const inferredType = inferTypeFromValue(value);
   const schemaType = jsonSchemaToTypeScript(schema);
-  if (inferredType != null && inferredType !== "" && !typesAreCompatible(inferredType, schemaType)) {
-    const propName = propertyName != null && propertyName !== "" ? `'${propertyName}': ` : "";
+  if (inferredType !== "" && inferredType != null && !typesAreCompatible(inferredType, schemaType)) {
+    const propName = propertyName !== "" && propertyName != null ? `'${propertyName}': ` : "";
     console.warn(`  ⚠️  Type mismatch for ${propName}Schema says '${schemaType}' but value suggests '${inferredType}' (value: ${String(value).slice(0, 50)})`);
   }
   const description = mergeDescriptions(schema.description, yamlComment);
@@ -22486,12 +22486,12 @@ function inferUniformArrayType(ctx, elementTypes, elementTypeProps) {
   const { nestedTypeName, chartName, fullKey, propertyName, yamlComment } = ctx;
   const elementType = [...elementTypes][0];
   const elementProp = elementTypeProps[0];
-  if (elementType == null || elementType === "" || !elementProp) {
+  if (elementType === "" || !elementProp || elementType == null) {
     return { type: "unknown[]", optional: true };
   }
   if (elementProp.nested) {
     const arrayElementTypeName = `${nestedTypeName}Element`;
-    const allowArbitraryProps = chartName != null && chartName !== "" && fullKey != null && fullKey !== "" ? shouldAllowArbitraryProps(fullKey, chartName, propertyName ?? "", yamlComment) : false;
+    const allowArbitraryProps = chartName !== "" && fullKey !== "" && chartName != null && fullKey != null ? shouldAllowArbitraryProps(fullKey, chartName, propertyName ?? "", yamlComment) : false;
     const arrayElementInterface = {
       name: arrayElementTypeName,
       properties: elementProp.nested.properties,
@@ -22522,7 +22522,7 @@ function convertValueToProperty(opts) {
   if (NullSchema.safeParse(value).success || UndefinedSchema.safeParse(value).success) {
     return { type: "unknown", optional: true };
   }
-  if (propertyName != null && propertyName !== "") {
+  if (propertyName !== "" && propertyName != null) {
     const wellKnown = getWellKnownK8sFieldType(propertyName, value);
     if (wellKnown) {
       return {
@@ -22626,11 +22626,11 @@ function generateInterfaceCode(iface) {
       if (prop.default !== undefined) {
         const defaultStr = formatDefaultValue(prop.default);
         const hasDescription = prop.description != null && prop.description !== "";
-        if (defaultStr != null && defaultStr !== "" && hasDescription) {
+        if (defaultStr !== "" && hasDescription && defaultStr != null) {
           code += `   *
 `;
         }
-        if (defaultStr != null && defaultStr !== "") {
+        if (defaultStr !== "" && defaultStr != null) {
           code += `   * @default ${defaultStr}
 `;
         }
@@ -22793,7 +22793,7 @@ function parseCliArgs(args) {
   const result = {};
   for (let i = 0;i < args.length; i++) {
     const arg = args[i];
-    if (arg == null || arg === "") {
+    if (arg === "" || arg == null) {
       continue;
     }
     if (HELP_FLAGS.has(arg)) {
@@ -22803,7 +22803,7 @@ function parseCliArgs(args) {
     const key = FLAG_MAP[arg];
     if (key != null) {
       const value = args[i + 1];
-      if (value != null && value !== "") {
+      if (value !== "" && value != null) {
         result[key] = value;
         i += 1;
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@shepherdjerred/helm-types",
-  "version": "1.5.0",
+  "version": "1.6.0-dev.7909",
   "description": "Generate TypeScript types from Helm chart values.yaml and values.schema.json",
   "type": "module",
   "main": "dist/index.js",
@@ -27,10 +27,12 @@
     "test:cli": "bun test src/cli.test.ts",
     "lint": "bunx eslint .",
     "lint:fix": "bunx eslint . --fix",
-    "typecheck": "bunx tsc --noEmit",
+    "typecheck": "PATH=node_modules/@typescript/native/bin:$PATH tsc --noEmit",
     "prepublishOnly": "bun run build",
     "generate:live": "bun run src/cli.ts",
-    "publish:npm": "bun ../../../../scripts/publish-npm.ts ."
+    "publish:npm": "bun ../../../../scripts/publish-npm.ts .",
+    "test:ci": "bun ../../../../scripts/run-ci-test.ts",
+    "test:report": "CI_TEST_COVERAGE=1 bun ../../../../scripts/run-ci-test.ts"
   },
   "keywords": [
     "helm",
@@ -65,6 +67,7 @@
     "@shepherdjerred/eslint-config": "0.3.0",
     "@types/bun": "^1.3.13",
     "eslint": "^10.3.0",
-    "jiti": "^2.7.0"
+    "jiti": "^2.7.0",
+    "@typescript/native": "npm:typescript@7.0.2"
   }
 }

package/src/__fixtures__/sample-chart/values.yaml

@@ -7,7 +7,7 @@ image:
   # -- Image pull policy.
   pullPolicy: IfNotPresent
   # -- Image tag; defaults to the chart appVersion when empty.
-  tag: "@sha256:ec4ed8b5299e5e90694af7750eb6dffd2627317d30544d056b0371f8082f7bce"
+  tag: "@sha256:5a88c9c45479443d7be2eadc894b4ed0a9801bae03d97a5760ae13b5c2005942"
 
 # -- Whether the service is enabled.
 serviceEnabled: true

package/src/chart-info-parser.ts

@@ -16,10 +16,10 @@ export async function parseChartInfoFromVersions(
 
     // Look for renovate comments that indicate Helm charts
     if (
+      nextLine === "" ||
       line == null ||
       !line.includes("renovate: datasource=helm") ||
-      nextLine == null ||
-      nextLine === ""
+      nextLine == null
     ) {
       continue;
     }
@@ -33,10 +33,10 @@ export async function parseChartInfoFromVersions(
     const repoUrl = repoUrlMatch[1];
     const versionKey = versionKeyMatch[1];
     if (
-      repoUrl == null ||
       repoUrl === "" ||
-      versionKey == null ||
-      versionKey === ""
+      versionKey === "" ||
+      repoUrl == null ||
+      versionKey == null
     ) {
       continue;
     }
@@ -48,23 +48,15 @@ export async function parseChartInfoFromVersions(
     }
 
     const version = versionMatch[1];
-    if (version == null || version === "") {
+    if (version === "" || version == null) {
       continue;
     }
 
-    // Try to determine chart name from the version key or URL
-    let chartName = versionKey;
-
-    // Handle special cases like "argo-cd" vs "argocd"
-    if (versionKey === "argo-cd") {
-      chartName = "argo-cd";
-    }
-
     charts.push({
       name: versionKey,
       repoUrl: repoUrl.replace(/\/$/, ""), // Remove trailing slash
       version,
-      chartName,
+      chartName: versionKey,
     });
   }
 

package/src/cli.ts

@@ -92,7 +92,7 @@ function parseCliArgs(args: string[]): CliArgs {
 
   for (let i = 0; i < args.length; i++) {
     const arg = args[i];
-    if (arg == null || arg === "") {
+    if (arg === "" || arg == null) {
       continue;
     }
 
@@ -104,7 +104,7 @@ function parseCliArgs(args: string[]): CliArgs {
     const key = FLAG_MAP[arg];
     if (key != null) {
       const value = args[i + 1];
-      if (value != null && value !== "") {
+      if (value !== "" && value != null) {
         result[key] = value;
         i += 1;
       }

package/src/code-generator.ts

@@ -95,10 +95,10 @@ function generateInterfaceCode(iface: TypeScriptInterface): string {
         const defaultStr = formatDefaultValue(prop.default);
         const hasDescription =
           prop.description != null && prop.description !== "";
-        if (defaultStr != null && defaultStr !== "" && hasDescription) {
+        if (defaultStr !== "" && hasDescription && defaultStr != null) {
           code += `   *\n`;
         }
-        if (defaultStr != null && defaultStr !== "") {
+        if (defaultStr !== "" && defaultStr != null) {
           code += `   * @default ${defaultStr}\n`;
         }
       }

package/src/comment-parser.ts

@@ -121,15 +121,15 @@ export function parseYAMLComments(yamlContent: string): Map<string, string> {
     if (keyMatch) {
       const indent = keyMatch[1]?.length ?? 0;
       const key = keyMatch[2];
-      if (key == null || key === "") {
+      if (key === "" || key == null) {
         continue;
       }
 
       // Update indent stack
       const lastIndent = indentStack.at(-1);
       while (
-        indentStack.length > 0 &&
         lastIndent &&
+        indentStack.length > 0 &&
         lastIndent.indent >= indent
       ) {
         indentStack.pop();

package/src/config.ts

@@ -179,7 +179,7 @@ export function shouldAllowArbitraryProps(
   }
 
   // Check YAML comments for hints
-  if (yamlComment != null && yamlComment !== "") {
+  if (yamlComment !== "" && yamlComment != null) {
     const commentLower = yamlComment.toLowerCase();
     if (
       /\b(?:arbitrary|custom|additional|extra|any)\s+(?:keys?|properties?|fields?|values?)\b/i.test(

package/src/interface-generator.ts

@@ -103,10 +103,10 @@ function generateInterfaceCode(iface: TypeScriptInterface): string {
         const defaultStr = formatDefaultValue(prop.default);
         const hasDescription =
           prop.description != null && prop.description !== "";
-        if (defaultStr != null && defaultStr !== "" && hasDescription) {
+        if (defaultStr !== "" && hasDescription && defaultStr != null) {
           code += `   *\n`;
         }
-        if (defaultStr != null && defaultStr !== "") {
+        if (defaultStr !== "" && defaultStr != null) {
           code += `   * @default ${defaultStr}\n`;
         }
       }

package/src/type-converter-helpers.ts

@@ -24,10 +24,10 @@ export function mergeDescriptions(
   schemaDescription: string | undefined,
   yamlComment: string | undefined,
 ): string | undefined {
-  if (yamlComment == null || yamlComment === "") {
+  if (yamlComment === "" || yamlComment == null) {
     return schemaDescription;
   }
-  return schemaDescription != null && schemaDescription !== ""
+  return schemaDescription !== "" && schemaDescription != null
     ? `${yamlComment}\n\n${schemaDescription}`
     : yamlComment;
 }

package/src/type-converter.ts

@@ -195,26 +195,26 @@ export function typesAreCompatible(
   if (schemaTypes.length > 1) {
     for (const st of schemaTypes) {
       // Handle quoted strings in unions (like "default")
-      if (st.startsWith('"') && st.endsWith('"') && inferredType === "string") {
+      if (inferredType === "string" && st.startsWith('"') && st.endsWith('"')) {
         return true;
       }
       if (st === inferredType) {
         return true;
       }
       // Arrays
-      if (st.endsWith("[]") && inferredType === "array") {
+      if (inferredType === "array" && st.endsWith("[]")) {
         return true;
       }
     }
   }
 
   // Handle array types
-  if (schemaType.endsWith("[]") && inferredType === "array") {
+  if (inferredType === "array" && schemaType.endsWith("[]")) {
     return true;
   }
 
   // Handle specific string literals - if schema expects specific strings and value is a string
-  if (schemaType.includes('"') && inferredType === "string") {
+  if (inferredType === "string" && schemaType.includes('"')) {
     return true;
   }
 
@@ -301,12 +301,12 @@ function convertWithSchema(
 
   // Warn about type mismatches
   if (
-    inferredType != null &&
     inferredType !== "" &&
+    inferredType != null &&
     !typesAreCompatible(inferredType, schemaType)
   ) {
     const propName =
-      propertyName != null && propertyName !== "" ? `'${propertyName}': ` : "";
+      propertyName !== "" && propertyName != null ? `'${propertyName}': ` : "";
     console.warn(
       `  ⚠️  Type mismatch for ${propName}Schema says '${schemaType}' but value suggests '${inferredType}' (value: ${String(value).slice(0, 50)})`,
     );
@@ -417,14 +417,14 @@ function inferUniformArrayType(
   const { nestedTypeName, chartName, fullKey, propertyName, yamlComment } = ctx;
   const elementType = [...elementTypes][0];
   const elementProp = elementTypeProps[0];
-  if (elementType == null || elementType === "" || !elementProp) {
+  if (elementType === "" || !elementProp || elementType == null) {
     return { type: "unknown[]", optional: true };
   }
 
   if (elementProp.nested) {
     const arrayElementTypeName = `${nestedTypeName}Element`;
     const allowArbitraryProps =
-      chartName != null && chartName !== "" && fullKey != null && fullKey !== ""
+      chartName !== "" && fullKey !== "" && chartName != null && fullKey != null
         ? shouldAllowArbitraryProps(
             fullKey,
             chartName,
@@ -478,7 +478,7 @@ function convertValueToProperty(opts: PropertyConversionContext): TypeProperty {
   // only allow cpu). Emit the canonical permissive type instead — but only
   // when the default value's shape is compatible, so RBAC `resources:
   // ["secrets"]` arrays stay arrays.
-  if (propertyName != null && propertyName !== "") {
+  if (propertyName !== "" && propertyName != null) {
     const wellKnown = getWellKnownK8sFieldType(propertyName, value);
     if (wellKnown) {
       return {

package/src/type-inference.ts

@@ -186,26 +186,26 @@ export function typesAreCompatible(
   if (schemaTypes.length > 1) {
     for (const st of schemaTypes) {
       // Handle quoted strings in unions (like "default")
-      if (st.startsWith('"') && st.endsWith('"') && inferredType === "string") {
+      if (inferredType === "string" && st.startsWith('"') && st.endsWith('"')) {
         return true;
       }
       if (st === inferredType) {
         return true;
       }
       // Arrays
-      if (st.endsWith("[]") && inferredType === "array") {
+      if (inferredType === "array" && st.endsWith("[]")) {
         return true;
       }
     }
   }
 
   // Handle array types
-  if (schemaType.endsWith("[]") && inferredType === "array") {
+  if (inferredType === "array" && schemaType.endsWith("[]")) {
     return true;
   }
 
   // Handle specific string literals - if schema expects specific strings and value is a string
-  if (schemaType.includes('"') && inferredType === "string") {
+  if (inferredType === "string" && schemaType.includes('"')) {
     return true;
   }
 
@@ -272,10 +272,10 @@ function mergeDescriptions(
   schemaDescription: string | undefined,
   yamlComment: string | undefined,
 ): string | undefined {
-  if (yamlComment == null || yamlComment === "") {
+  if (yamlComment === "" || yamlComment == null) {
     return schemaDescription;
   }
-  return schemaDescription != null && schemaDescription !== ""
+  return schemaDescription !== "" && schemaDescription != null
     ? `${yamlComment}\n\n${schemaDescription}`
     : yamlComment;
 }
@@ -300,12 +300,12 @@ function convertWithSchema(
   const schemaType = jsonSchemaToTypeScript(schema);
 
   if (
-    inferredType != null &&
     inferredType !== "" &&
+    inferredType != null &&
     !typesAreCompatible(inferredType, schemaType)
   ) {
     const propName =
-      propertyName != null && propertyName !== "" ? `'${propertyName}': ` : "";
+      propertyName !== "" && propertyName != null ? `'${propertyName}': ` : "";
     console.warn(
       `  ⚠️  Type mismatch for ${propName}Schema says '${schemaType}' but value suggests '${inferredType}' (value: ${String(value).slice(0, 50)})`,
     );
@@ -412,7 +412,7 @@ function inferUniformArrayType(
 ): TypeProperty {
   const elementType = [...elementTypes][0];
   const elementProp = elementTypeProps[0];
-  if (elementType == null || elementType === "" || !elementProp) {
+  if (elementType === "" || !elementProp || elementType == null) {
     return { type: "unknown[]", optional: true };
   }
 

package/src/yaml-comment-filters.ts

@@ -18,7 +18,7 @@ function isPartOfYAMLBlock(line: string, trimmed: string): boolean {
 function isSectionHeaderForCommentedBlock(
   nextLine: string | undefined,
 ): boolean {
-  if (nextLine == null || nextLine === "") {
+  if (nextLine === "" || nextLine == null) {
     return false;
   }
   const nextTrimmed = nextLine.trim();

package/src/yaml-comment-regex-parser.ts

@@ -22,7 +22,7 @@ export function parseCommentsWithRegex(
     if (!trimmed) {
       // Only reset if we had a commented-out key (pendingCommentIndent === -1)
       // This allows multi-line comments for real keys to work
-      if (pendingComment.length > 0 && pendingCommentIndent === -1) {
+      if (pendingCommentIndent === -1 && pendingComment.length > 0) {
         pendingDebugInfo.push(
           `Line ${String(lineNum)}: Blank line after commented-out key, resetting pending`,
         );
@@ -98,7 +98,7 @@ export function parseCommentsWithRegex(
     const keyMatch = keyMatchRegex.exec(trimmed);
     if (keyMatch && pendingComment.length > 0) {
       const key = keyMatch[1];
-      if (key != null && key !== "") {
+      if (key !== "" && key != null) {
         const keyIndent = line.search(/\S/);
 
         // Only associate comment if indentation matches closely

package/src/yaml-comments.ts

@@ -45,7 +45,7 @@ export function isSimpleYAMLValue(line: string): boolean {
  * Exported for testing purposes
  */
 export function isSectionHeader(line: string, nextLine?: string): boolean {
-  if (nextLine == null || nextLine === "") {
+  if (nextLine === "" || nextLine == null) {
     return false;
   }
 
@@ -119,7 +119,7 @@ export function looksLikeProse(line: string, wordCount: number): boolean {
   const hasURL = line.includes("http://") || line.includes("https://");
   const startsWithCapital = /^[A-Z]/.test(line);
   const hasEndPunctuation = /[.!?:]$/.test(line);
-  const notYamlKey = !(isYAMLKey(line) && !hasURL && !/^ref:/i.test(line));
+  const notYamlKey = !(!hasURL && isYAMLKey(line) && !/^ref:/i.test(line));
   const reasonableLength = line.length > 10;
   const hasMultipleWords = wordCount >= 3;
   const startsWithArticle = /^(?:This|The|A|An)\s/i.test(line);
@@ -257,10 +257,10 @@ export function parseBitnamiParams(comment: string): {
     if (paramMatch) {
       const [, paramKey, description] = paramMatch;
       if (
-        paramKey != null &&
         paramKey !== "" &&
-        description != null &&
-        description !== ""
+        description !== "" &&
+        paramKey != null &&
+        description != null
       ) {
         params.set(paramKey, description);
       }
@@ -343,7 +343,7 @@ export function parseYAMLCommentsWithMetadata(
         comment = comment ? `${comment}\n${inlineComment}` : inlineComment;
       }
       // First item inherits map comment if it has none
-      if (context.index === 0 && !comment && context.mapComment) {
+      if (!comment && context.index === 0 && context.mapComment) {
         comment = context.mapComment;
       }
       if (comment) {

package/src/yaml-preprocess.ts

@@ -128,7 +128,7 @@ function tryUncommentLine(
   }
 
   const [, indent, keyValue] = commentedKeyMatch;
-  if (keyValue == null || keyValue === "" || indent == null || indent === "") {
+  if (keyValue === "" || indent === "" || keyValue == null || indent == null) {
     return {
       uncommented: null,
       newConsecutive: state.consecutiveCommentedKeys,