@shepai/cli 1.72.9-pr220.b37503f → 1.72.9-pr220.ce0911d

package/web/.next/standalone/src/presentation/web/components/common/index.ts

@@ -31,7 +31,6 @@ export {
 export { FeatureStatusBadges, type FeatureStatusBadgesProps } from './feature-status-badges';
 export { FeatureStatusGroup, type FeatureStatusGroupProps } from './feature-status-group';
 export { LoadingSkeleton } from './loading-skeleton';
-export { NotificationPermissionBanner } from './notification-permission-banner';
 export {
   RepositoryNode,
   type RepositoryNodeData,

package/web/.next/standalone/src/presentation/web/components/features/control-center/control-center-inner.tsx

@@ -7,7 +7,6 @@ import { FeaturesCanvas } from '@/components/features/features-canvas';
 import type { CanvasNodeType } from '@/components/features/features-canvas';
 import type { FeatureNodeData } from '@/components/common/feature-node';
 import type { RepositoryNodeData } from '@/components/common/repository-node';
-import { NotificationPermissionBanner } from '@/components/common/notification-permission-banner';
 import {
   useSidebarFeaturesContext,
   mapNodeStateToSidebarStatus,
@@ -235,28 +234,20 @@ export function ControlCenterInner({ initialNodes, initialEdges }: ControlCenter
   const hasRepositories = nodes.some((n) => n.type === 'repositoryNode');
 
   if (!hasRepositories) {
-    return (
-      <>
-        <NotificationPermissionBanner />
-        <ControlCenterEmptyState onRepositorySelect={handleAddRepository} />
-      </>
-    );
+    return <ControlCenterEmptyState onRepositorySelect={handleAddRepository} />;
   }
 
   return (
-    <>
-      <NotificationPermissionBanner />
-      <FeaturesCanvas
-        nodes={nodes}
-        edges={edges}
-        selectedFeatureId={selectedFeatureId}
-        onNodesChange={onNodesChange}
-        onConnect={handleConnect}
-        onAddFeature={handleAddFeature}
-        onNodeClick={handleNodeClick}
-        onPaneClick={handleClearDrawers}
-        emptyState={<ControlCenterEmptyState onRepositorySelect={handleAddRepository} />}
-      />
-    </>
+    <FeaturesCanvas
+      nodes={nodes}
+      edges={edges}
+      selectedFeatureId={selectedFeatureId}
+      onNodesChange={onNodesChange}
+      onConnect={handleConnect}
+      onAddFeature={handleAddFeature}
+      onNodeClick={handleNodeClick}
+      onPaneClick={handleClearDrawers}
+      emptyState={<ControlCenterEmptyState onRepositorySelect={handleAddRepository} />}
+    />
   );
 }

package/web/.next/standalone/src/presentation/web/components/features/control-center/use-control-center-state.ts

@@ -145,10 +145,12 @@ export function useControlCenterState(
     const newEvents = events.slice(processedEventCountRef.current);
     processedEventCountRef.current = events.length;
 
-    // PhaseCompleted must NOT set state when WaitingApproval is in the same poll batch —
-    // they arrive together and PhaseCompleted → 'running' would revert 'action-required'.
-    // But when PhaseCompleted arrives WITHOUT WaitingApproval (e.g. after approval), we
-    // must allow it to update state as a fallback for any missed AgentStarted event.
+    // When WaitingApproval and PhaseCompleted arrive in the same poll batch for a feature,
+    // PhaseCompleted must be fully suppressed (both state AND lifecycle). Without this,
+    // a phase-timing PhaseCompleted (e.g. phaseName='research') can regress the lifecycle
+    // that WaitingApproval already set correctly (e.g. to 'implementation' for plan gate).
+    // When PhaseCompleted arrives WITHOUT WaitingApproval (e.g. after approval), we allow
+    // it to update both state and lifecycle as a fallback for any missed AgentStarted event.
     const waitingApprovalFeatures = new Set(
       newEvents
         .filter((e) => e.eventType === NotificationEventType.WaitingApproval)
@@ -156,12 +158,15 @@ export function useControlCenterState(
     );
 
     for (const event of newEvents) {
-      const newState =
+      const isSuppressedPhaseCompleted =
         event.eventType === NotificationEventType.PhaseCompleted &&
-        waitingApprovalFeatures.has(event.featureId)
-          ? undefined
-          : mapEventTypeToState(event.eventType);
-      const newLifecycle = mapPhaseNameToLifecycle(event.phaseName);
+        waitingApprovalFeatures.has(event.featureId);
+      const newState = isSuppressedPhaseCompleted
+        ? undefined
+        : mapEventTypeToState(event.eventType);
+      const newLifecycle = isSuppressedPhaseCompleted
+        ? undefined
+        : mapPhaseNameToLifecycle(event.phaseName);
 
       const nodeId = `feat-${event.featureId}`;
       if (newState !== undefined || newLifecycle !== undefined) {

package/web/.next/standalone/src/presentation/web/components/ui/alert-dialog.tsx

@@ -28,10 +28,7 @@ function AlertDialogOverlay({
   return (
     <AlertDialogPrimitive.Overlay
       data-slot="alert-dialog-overlay"
-      className={cn(
-        'data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 fixed inset-0 z-50 bg-black/50',
-        className
-      )}
+      className={cn('fixed inset-0 z-50 bg-black/50', className)}
       onClick={(e) => {
         // Prevent overlay clicks from propagating to document-level handlers
         // (e.g. BaseDrawer outside-click) — only the dialog should dismiss.
@@ -57,7 +54,7 @@ function AlertDialogContent({
         data-slot="alert-dialog-content"
         data-size={size}
         className={cn(
-          'bg-background data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 group/alert-dialog-content fixed top-[50%] left-[50%] z-50 grid w-full max-w-[calc(100%-2rem)] translate-x-[-50%] translate-y-[-50%] gap-4 rounded-lg border p-6 shadow-lg duration-200 data-[size=sm]:max-w-xs data-[size=default]:sm:max-w-lg',
+          'bg-background group/alert-dialog-content fixed top-[50%] left-[50%] z-50 grid w-full max-w-[calc(100%-2rem)] translate-x-[-50%] translate-y-[-50%] gap-4 rounded-lg border p-6 shadow-lg data-[size=sm]:max-w-xs data-[size=default]:sm:max-w-lg',
           className
         )}
         {...props}

package/web/.next/standalone/src/presentation/web/components/ui/dialog.tsx

@@ -20,10 +20,7 @@ const DialogOverlay = React.forwardRef<
 >(({ className, onClick, ...props }, ref) => (
   <DialogPrimitive.Overlay
     ref={ref}
-    className={cn(
-      'data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 fixed inset-0 z-50 bg-black/80',
-      className
-    )}
+    className={cn('fixed inset-0 z-50 bg-black/80', className)}
     onClick={(e) => {
       // Prevent overlay clicks from propagating to document-level handlers
       // (e.g. BaseDrawer outside-click) — only the dialog should dismiss.
@@ -44,7 +41,7 @@ const DialogContent = React.forwardRef<
     <DialogPrimitive.Content
       ref={ref}
       className={cn(
-        'bg-background data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[state=closed]:slide-out-to-left-1/2 data-[state=closed]:slide-out-to-top-[48%] data-[state=open]:slide-in-from-left-1/2 data-[state=open]:slide-in-from-top-[48%] fixed top-[50%] left-[50%] z-50 grid w-full max-w-lg translate-x-[-50%] translate-y-[-50%] gap-4 border p-6 shadow-lg duration-200 sm:rounded-lg',
+        'bg-background fixed top-[50%] left-[50%] z-50 grid w-full max-w-lg translate-x-[-50%] translate-y-[-50%] gap-4 border p-6 shadow-lg sm:rounded-lg',
         className
       )}
       {...props}

package/web/.next/standalone/src/presentation/web/hooks/use-notifications.stories.tsx

@@ -1,4 +1,4 @@
-import { useCallback, useMemo, useState } from 'react';
+import { useCallback, useMemo } from 'react';
 import type { Meta, StoryObj } from '@storybook/react';
 import { toast } from 'sonner';
 import { Toaster } from '@/components/ui/sonner';
@@ -44,45 +44,17 @@ function NotificationDemo() {
       const method = event.severity ?? 'info';
       toast[method](event.featureName, { description: event.message });
 
-      if (globalThis.Notification?.permission === 'granted') {
-        new Notification(event.featureName, { body: event.message });
-      }
-
       const soundName = SEVERITY_SOUNDS[event.severity];
       soundsByName[soundName]?.play();
     },
     [soundsByName]
   );
 
-  const [browserPermission, setBrowserPermission] = useState<NotificationPermission>(
-    typeof globalThis.Notification !== 'undefined' ? globalThis.Notification.permission : 'default'
-  );
-
-  const requestPermission = async () => {
-    if (typeof globalThis.Notification === 'undefined') return;
-    const result = await globalThis.Notification.requestPermission();
-    setBrowserPermission(result);
-  };
-
   return (
     <div className="flex w-[420px] flex-col gap-6">
-      <div className="flex flex-col gap-2">
-        <h3 className="text-sm font-semibold">Browser Notification Permission</h3>
-        <div className="flex items-center gap-3">
-          <span className="text-muted-foreground text-sm">
-            Status: <code className="bg-muted rounded px-1.5 py-0.5">{browserPermission}</code>
-          </span>
-          <Button size="sm" variant="outline" onClick={requestPermission}>
-            Request Permission
-          </Button>
-        </div>
-      </div>
-
       <div className="flex flex-col gap-2">
         <h3 className="text-sm font-semibold">Simulate Notification Events</h3>
-        <p className="text-muted-foreground text-xs">
-          Click a button to fire a toast, browser notification, and sound.
-        </p>
+        <p className="text-muted-foreground text-xs">Click a button to fire a toast and sound.</p>
         <div className="flex flex-wrap gap-2">
           <Button
             size="sm"

package/web/.next/standalone/src/presentation/web/hooks/use-notifications.ts

@@ -1,6 +1,6 @@
 'use client';
 
-import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
+import { useEffect, useMemo, useRef } from 'react';
 import { useRouter } from 'next/navigation';
 import { toast } from 'sonner';
 import type { NotificationEvent } from '@shepai/core/domain/generated/output';
@@ -9,11 +9,6 @@ import { useAgentEventsContext } from './agent-events-provider';
 import { useSoundAction } from './use-sound-action';
 import type { SoundAction } from './use-sound-action';
 
-export interface UseNotificationsResult {
-  requestBrowserPermission: () => Promise<void>;
-  browserPermissionState: NotificationPermission;
-}
-
 const SEVERITY_TO_TOAST: Record<NotificationSeverity, 'success' | 'error' | 'warning' | 'info'> = {
   [NotificationSeverity.Success]: 'success',
   [NotificationSeverity.Error]: 'error',
@@ -38,16 +33,6 @@ function dispatchToast(event: NotificationEvent, navigate?: (path: string) => vo
   });
 }
 
-function dispatchBrowserNotification(event: NotificationEvent): void {
-  if (globalThis.Notification?.permission !== 'granted') {
-    return;
-  }
-  new Notification(`Shep: ${event.featureName}`, {
-    body: event.message,
-    icon: '/favicon-light.svg',
-  });
-}
-
 const SEVERITY_TO_ACTION: Record<NotificationSeverity, SoundAction> = {
   [NotificationSeverity.Success]: 'notification-success',
   [NotificationSeverity.Error]: 'notification-error',
@@ -55,7 +40,7 @@ const SEVERITY_TO_ACTION: Record<NotificationSeverity, SoundAction> = {
   [NotificationSeverity.Info]: 'notification-info',
 };
 
-export function useNotifications(): UseNotificationsResult {
+export function useNotifications(): void {
   const router = useRouter();
   const { events } = useAgentEventsContext();
 
@@ -74,13 +59,6 @@ export function useNotifications(): UseNotificationsResult {
     [successSound, errorSound, warningSound, infoSound]
   );
 
-  const [browserPermissionState, setBrowserPermissionState] = useState<NotificationPermission>(
-    () => {
-      if (typeof globalThis.Notification === 'undefined') return 'default';
-      return globalThis.Notification.permission;
-    }
-  );
-
   // Track how many events from the array we've already processed.
   // Using the array index (instead of lastEvent) prevents React batching
   // from silently dropping events when multiple SSE messages arrive together.
@@ -103,21 +81,9 @@ export function useNotifications(): UseNotificationsResult {
       }
 
       dispatchToast(event, (path) => router.push(path as Parameters<typeof router.push>[0]));
-      dispatchBrowserNotification(event);
 
       const actionName = SEVERITY_TO_ACTION[event.severity];
       soundsByAction[actionName]?.play();
     }
   }, [events, soundsByAction, router]);
-
-  const requestBrowserPermission = useCallback(async () => {
-    if (typeof globalThis.Notification === 'undefined') return;
-    const result = await globalThis.Notification.requestPermission();
-    setBrowserPermissionState(result);
-  }, []);
-
-  return {
-    requestBrowserPermission,
-    browserPermissionState,
-  };
 }