@shepai/cli 1.19.0 → 1.20.0

package/dist/src/presentation/cli/commands/feat/reject.command.js

@@ -0,0 +1,50 @@
+/**
+ * Feature Reject Command
+ *
+ * Rejects a feature waiting for human approval, cancelling
+ * the agent run with an optional reason.
+ *
+ * Usage:
+ *   shep feat reject [id] [--reason <text>]
+ */
+import { Command } from 'commander';
+import { container } from '../../../../infrastructure/di/container.js';
+import { RejectAgentRunUseCase } from '../../../../application/use-cases/agents/reject-agent-run.use-case.js';
+import { resolveWaitingFeature } from './resolve-waiting-feature.js';
+import { colors, messages } from '../../ui/index.js';
+export function createRejectCommand() {
+    return new Command('reject')
+        .description('Reject a feature waiting for review')
+        .argument('[id]', 'Feature ID (auto-resolves if omitted)')
+        .option('--reason <text>', 'Rejection reason')
+        .action(async (featureId, options) => {
+        try {
+            const featureRepo = container.resolve('IFeatureRepository');
+            const runRepo = container.resolve('IAgentRunRepository');
+            const repoPath = process.cwd();
+            const { feature, run } = await resolveWaitingFeature({
+                featureId,
+                repoPath,
+                featureRepo,
+                runRepo,
+            });
+            const rejectUseCase = container.resolve(RejectAgentRunUseCase);
+            const result = await rejectUseCase.execute(run.id, options.reason);
+            if (!result.rejected) {
+                throw new Error(result.reason);
+            }
+            messages.newline();
+            messages.warning(`Rejected: ${feature.name}`);
+            if (options.reason) {
+                console.log(`  ${colors.muted('Reason:')} ${options.reason}`);
+            }
+            console.log(`  ${colors.muted('Agent:')}  cancelled`);
+            messages.newline();
+        }
+        catch (error) {
+            const err = error instanceof Error ? error : new Error(String(error));
+            messages.error('Failed to reject feature', err);
+            process.exitCode = 1;
+        }
+    });
+}

package/dist/src/presentation/cli/commands/feat/resolve-waiting-feature.d.ts

@@ -0,0 +1,30 @@
+/**
+ * Resolve Waiting Feature Helper
+ *
+ * Shared helper for feat review/approve/reject commands.
+ * Given an optional feature ID and repo path, resolves the target
+ * feature that is currently waiting for human approval.
+ */
+import type { Feature, AgentRun } from '../../../../domain/generated/output.js';
+import type { IFeatureRepository } from '../../../../application/ports/output/repositories/feature-repository.interface.js';
+import type { IAgentRunRepository } from '../../../../application/ports/output/agents/agent-run-repository.interface.js';
+export interface ResolveWaitingFeatureOptions {
+    featureId?: string;
+    repoPath: string;
+    featureRepo: IFeatureRepository;
+    runRepo: IAgentRunRepository;
+}
+export interface ResolvedWaitingFeature {
+    feature: Feature;
+    run: AgentRun;
+}
+/**
+ * Resolve the target feature waiting for approval.
+ *
+ * If featureId is provided, looks it up directly.
+ * Otherwise, lists features for the repo and finds the single waiting one.
+ *
+ * @throws When feature not found, not waiting, or ambiguous (0 or 2+)
+ */
+export declare function resolveWaitingFeature(options: ResolveWaitingFeatureOptions): Promise<ResolvedWaitingFeature>;
+//# sourceMappingURL=resolve-waiting-feature.d.ts.map

package/dist/src/presentation/cli/commands/feat/resolve-waiting-feature.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"resolve-waiting-feature.d.ts","sourceRoot":"","sources":["../../../../../../src/presentation/cli/commands/feat/resolve-waiting-feature.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAEH,OAAO,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,MAAM,wCAAwC,CAAC;AAEhF,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,mFAAmF,CAAC;AAC5H,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,+EAA+E,CAAC;AAEzH,MAAM,WAAW,4BAA4B;IAC3C,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,QAAQ,EAAE,MAAM,CAAC;IACjB,WAAW,EAAE,kBAAkB,CAAC;IAChC,OAAO,EAAE,mBAAmB,CAAC;CAC9B;AAED,MAAM,WAAW,sBAAsB;IACrC,OAAO,EAAE,OAAO,CAAC;IACjB,GAAG,EAAE,QAAQ,CAAC;CACf;AAED;;;;;;;GAOG;AACH,wBAAsB,qBAAqB,CACzC,OAAO,EAAE,4BAA4B,GACpC,OAAO,CAAC,sBAAsB,CAAC,CAOjC"}

package/dist/src/presentation/cli/commands/feat/resolve-waiting-feature.js

@@ -0,0 +1,57 @@
+/**
+ * Resolve Waiting Feature Helper
+ *
+ * Shared helper for feat review/approve/reject commands.
+ * Given an optional feature ID and repo path, resolves the target
+ * feature that is currently waiting for human approval.
+ */
+import { AgentRunStatus } from '../../../../domain/generated/output.js';
+/**
+ * Resolve the target feature waiting for approval.
+ *
+ * If featureId is provided, looks it up directly.
+ * Otherwise, lists features for the repo and finds the single waiting one.
+ *
+ * @throws When feature not found, not waiting, or ambiguous (0 or 2+)
+ */
+export async function resolveWaitingFeature(options) {
+    const { featureId, repoPath, featureRepo, runRepo } = options;
+    if (featureId) {
+        return resolveExplicit(featureId, featureRepo, runRepo);
+    }
+    return resolveAuto(repoPath, featureRepo, runRepo);
+}
+async function resolveExplicit(featureId, featureRepo, runRepo) {
+    const feature = (await featureRepo.findById(featureId)) ?? (await featureRepo.findByIdPrefix(featureId));
+    if (!feature) {
+        throw new Error(`Feature not found: "${featureId}"`);
+    }
+    if (!feature.agentRunId) {
+        throw new Error(`Feature "${feature.name}" has no agent run`);
+    }
+    const run = await runRepo.findById(feature.agentRunId);
+    if (!run || run.status !== AgentRunStatus.waitingApproval) {
+        throw new Error(`Feature "${feature.name}" is not waiting for approval (status: ${run?.status ?? 'unknown'})`);
+    }
+    return { feature, run };
+}
+async function resolveAuto(repoPath, featureRepo, runRepo) {
+    const features = await featureRepo.list({ repositoryPath: repoPath });
+    const waiting = [];
+    for (const feature of features) {
+        if (!feature.agentRunId)
+            continue;
+        const run = await runRepo.findById(feature.agentRunId);
+        if (run && run.status === AgentRunStatus.waitingApproval) {
+            waiting.push({ feature, run });
+        }
+    }
+    if (waiting.length === 0) {
+        throw new Error('No features waiting for approval in this repository');
+    }
+    if (waiting.length > 1) {
+        const names = waiting.map((w) => `  - ${w.feature.name} (${w.feature.id.slice(0, 8)})`);
+        throw new Error(`Multiple features waiting for approval. Specify one:\n${names.join('\n')}`);
+    }
+    return waiting[0];
+}

package/dist/src/presentation/cli/commands/feat/review.command.d.ts

@@ -0,0 +1,12 @@
+/**
+ * Feature Review Command
+ *
+ * Shows the current state of a feature waiting for approval,
+ * including which phase triggered the interrupt and generated content.
+ *
+ * Usage:
+ *   shep feat review [id]
+ */
+import { Command } from 'commander';
+export declare function createReviewCommand(): Command;
+//# sourceMappingURL=review.command.d.ts.map

package/dist/src/presentation/cli/commands/feat/review.command.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"review.command.d.ts","sourceRoot":"","sources":["../../../../../../src/presentation/cli/commands/feat/review.command.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG;AAEH,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAOpC,wBAAgB,mBAAmB,IAAI,OAAO,CAqC7C"}

package/dist/src/presentation/cli/commands/feat/review.command.js

@@ -0,0 +1,49 @@
+/**
+ * Feature Review Command
+ *
+ * Shows the current state of a feature waiting for approval,
+ * including which phase triggered the interrupt and generated content.
+ *
+ * Usage:
+ *   shep feat review [id]
+ */
+import { Command } from 'commander';
+import { container } from '../../../../infrastructure/di/container.js';
+import { resolveWaitingFeature } from './resolve-waiting-feature.js';
+import { colors, messages } from '../../ui/index.js';
+export function createReviewCommand() {
+    return new Command('review')
+        .description('Review a feature waiting for approval')
+        .argument('[id]', 'Feature ID (auto-resolves if omitted)')
+        .action(async (featureId) => {
+        try {
+            const featureRepo = container.resolve('IFeatureRepository');
+            const runRepo = container.resolve('IAgentRunRepository');
+            const repoPath = process.cwd();
+            const { feature, run } = await resolveWaitingFeature({
+                featureId,
+                repoPath,
+                featureRepo,
+                runRepo,
+            });
+            const phase = run.result?.startsWith('node:') ? run.result.slice(5) : 'unknown';
+            messages.newline();
+            messages.info(`Feature waiting for approval: ${colors.accent(feature.name)}`);
+            console.log(`  ${colors.muted('ID:')}     ${feature.id.slice(0, 8)}`);
+            console.log(`  ${colors.muted('Phase:')}  ${colors.warning(phase)}`);
+            console.log(`  ${colors.muted('Branch:')} ${colors.accent(feature.branch)}`);
+            if (feature.specPath) {
+                console.log(`  ${colors.muted('Specs:')}  ${feature.specPath}`);
+            }
+            messages.newline();
+            console.log(`  ${colors.muted('To approve:')} shep feat approve ${feature.id.slice(0, 8)}`);
+            console.log(`  ${colors.muted('To reject:')}  shep feat reject ${feature.id.slice(0, 8)}`);
+            messages.newline();
+        }
+        catch (error) {
+            const err = error instanceof Error ? error : new Error(String(error));
+            messages.error('Failed to review feature', err);
+            process.exitCode = 1;
+        }
+    });
+}

package/dist/src/presentation/cli/commands/feat/show.command.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"show.command.d.ts","sourceRoot":"","sources":["../../../../../../src/presentation/cli/commands/feat/show.command.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AA4DpC,wBAAgB,iBAAiB,IAAI,OAAO,CAyE3C"}
+{"version":3,"file":"show.command.d.ts","sourceRoot":"","sources":["../../../../../../src/presentation/cli/commands/feat/show.command.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAuEpC,wBAAgB,iBAAiB,IAAI,OAAO,CAkH3C"}

package/dist/src/presentation/cli/commands/feat/show.command.js

@@ -18,7 +18,7 @@ function computeWorktreePath(repoPath, branch) {
     const slug = branch.replace(/\//g, '-');
     return join(SHEP_HOME_DIR, 'repos', repoHash, 'wt', slug);
 }
-/** Map graph node names to human-readable phase labels. */
+/** Map graph node names to human-readable phase labels (active). */
 const NODE_TO_PHASE = {
     analyze: 'Analyzing',
     requirements: 'Requirements',
@@ -26,14 +26,21 @@ const NODE_TO_PHASE = {
     plan: 'Planning',
     implement: 'Implementing',
 };
+/** Map graph node names to approval action labels. */
+const NODE_TO_APPROVE = {
+    analyze: 'Approve Analysis',
+    requirements: 'Approve PRD',
+    research: 'Approve Research',
+    plan: 'Approve Plan',
+    implement: 'Approve Merge',
+};
 function formatStatus(feature, run) {
     if (!run) {
         return `${colors.muted(symbols.dotEmpty)} ${colors.muted(feature.lifecycle)}`;
     }
     const isRunning = run.status === 'running' || run.status === 'pending';
-    const phase = run.result?.startsWith('node:')
-        ? (NODE_TO_PHASE[run.result.slice(5)] ?? run.result.slice(5))
-        : feature.lifecycle;
+    const nodeName = run.result?.startsWith('node:') ? run.result.slice(5) : undefined;
+    const phase = nodeName ? (NODE_TO_PHASE[nodeName] ?? nodeName) : feature.lifecycle;
     if (isRunning) {
         if (run.pid && !isProcessAlive(run.pid)) {
             return `${colors.error(symbols.error)} ${colors.error('crashed')}`;
@@ -44,8 +51,10 @@ function formatStatus(feature, run) {
         return `${colors.success(symbols.success)} ${colors.success('Completed')}`;
     if (run.status === 'failed')
         return `${colors.error(symbols.error)} ${colors.error('Failed')}`;
-    if (run.status === 'waiting_approval')
-        return `${colors.warning(symbols.warning)} ${colors.warning(phase)}`;
+    if (run.status === 'waiting_approval') {
+        const action = nodeName ? (NODE_TO_APPROVE[nodeName] ?? phase) : phase;
+        return `${colors.warning(symbols.warning)} ${colors.warning(action)}`;
+    }
     if (run.status === 'interrupted')
         return `${colors.error(symbols.error)} ${colors.error('Interrupted')}`;
     return `${colors.muted(symbols.dotEmpty)} ${colors.muted(phase)}`;
@@ -67,8 +76,10 @@ export function createShowCommand() {
         try {
             const useCase = container.resolve(ShowFeatureUseCase);
             const runRepo = container.resolve('IAgentRunRepository');
+            const timingRepo = container.resolve('IPhaseTimingRepository');
             const feature = await useCase.execute(featureId);
             const run = feature.agentRunId ? await runRepo.findById(feature.agentRunId) : null;
+            const timings = feature.agentRunId ? await timingRepo.findByRunId(feature.agentRunId) : [];
             const worktreePath = computeWorktreePath(feature.repositoryPath, feature.branch);
             const formatTs = (ts) => {
                 if (ts instanceof Date)
@@ -92,6 +103,40 @@ export function createShowCommand() {
                     content: last5,
                 });
             }
+            if (timings.length > 0) {
+                const isWaiting = run?.status === 'waiting_approval';
+                const maxDurationMs = Math.max(...timings.map((t) => (t.durationMs != null ? Number(t.durationMs) : 0)));
+                const MAX_BAR = 20;
+                const lines = timings.map((t) => {
+                    const label = (NODE_TO_PHASE[t.phase] ?? t.phase).padEnd(16);
+                    if (t.completedAt && t.durationMs != null) {
+                        const ms = Number(t.durationMs);
+                        const secs = (ms / 1000).toFixed(1);
+                        const barLen = maxDurationMs > 0 ? Math.max(1, Math.round((ms / maxDurationMs) * MAX_BAR)) : 1;
+                        const bar = `${colors.success('█'.repeat(barLen))}${colors.muted('░'.repeat(MAX_BAR - barLen))}`;
+                        return `${label} ${bar} ${secs}s`;
+                    }
+                    if (isWaiting) {
+                        return `${label} ${colors.warning('awaiting review')}`;
+                    }
+                    return `${label} ${colors.info('running...')}`;
+                });
+                textBlocks.push({ title: 'Phase Timing', content: lines.join('\n') });
+            }
+            if (run?.status === 'waiting_approval') {
+                const phase = run.result?.startsWith('node:')
+                    ? (NODE_TO_PHASE[run.result.slice(5)] ?? run.result.slice(5))
+                    : 'current phase';
+                textBlocks.push({
+                    title: 'Awaiting Approval',
+                    content: [
+                        `${phase} is waiting for your review.`,
+                        '',
+                        `  ${colors.accent('shep feat approve')}  Resume the agent`,
+                        `  ${colors.accent('shep feat reject')}   Cancel with feedback`,
+                    ].join('\n'),
+                });
+            }
             renderDetailView({
                 title: `Feature: ${feature.name}`,
                 sections: [