@shenlee/devcrew 0.1.1 → 0.1.2

package/packages/service/src/stdio.ts

@@ -2,14 +2,25 @@ import { callDevCrewTool, listDevCrewTools } from "./tools.js";
 import { DEVCREW_VERSION } from "../../core/src/index.js";
 
 interface JsonRpcRequest {
+  jsonrpc: "2.0";
   id?: string | number | null;
-  method?: string;
+  method: string;
   params?: Record<string, unknown>;
 }
 
 type JsonWriter = (message: unknown) => void;
 type RequestHandler = (request: JsonRpcRequest) => Promise<void>;
 
+function isJsonRpcRequest(value: unknown): value is JsonRpcRequest {
+  return (
+    typeof value === "object" &&
+    value !== null &&
+    !Array.isArray(value) &&
+    (value as { jsonrpc?: unknown }).jsonrpc === "2.0" &&
+    typeof (value as { method?: unknown }).method === "string"
+  );
+}
+
 function writeJson(message: unknown): void {
   process.stdout.write(`${JSON.stringify(message)}\n`);
 }
@@ -61,7 +72,7 @@ async function handleRequest(request: JsonRpcRequest, write: JsonWriter): Promis
       return;
     }
 
-    throw new Error(`Unsupported JSON-RPC method: ${request.method ?? "unknown"}`);
+    throw new Error(`Unsupported JSON-RPC method: ${request.method}`);
   } catch (error) {
     write({
       jsonrpc: "2.0",
@@ -85,9 +96,9 @@ export function createStdioLineProcessor(
       return queue;
     }
 
-    let request: JsonRpcRequest;
+    let request: unknown;
     try {
-      request = JSON.parse(trimmed) as JsonRpcRequest;
+      request = JSON.parse(trimmed) as unknown;
     } catch {
       write({
         jsonrpc: "2.0",
@@ -97,8 +108,18 @@ export function createStdioLineProcessor(
       return queue;
     }
 
-    queue = queue.then(() => handler(request));
-    return queue;
+    if (!isJsonRpcRequest(request)) {
+      write({
+        jsonrpc: "2.0",
+        id: null,
+        error: { code: -32600, message: "Invalid Request" },
+      });
+      return queue;
+    }
+
+    const task = queue.then(() => handler(request));
+    queue = task.catch(() => undefined);
+    return task;
   };
 }
 

package/packages/service/src/tools.ts

@@ -1,5 +1,4 @@
 import {
-  approveWorkflow,
   getArtifact,
   getActiveRunId,
   getWorkflowStatus,
@@ -9,6 +8,7 @@ import {
 } from "../../core/src/index.js";
 import {
   answerOrchestratedWorkflow,
+  approveOrchestratedWorkflow,
   continueOrchestratedWorkflow,
   rejectOrchestratedWorkflow,
   startOrchestratedWorkflow,
@@ -193,7 +193,7 @@ export async function callDevCrewTool(name: string, args: Record<string, unknown
       return success(`${summarizeState(state)}. Answer recorded.`, { state });
     }
     if (name === "devcrew_approve") {
-      const state = await approveWorkflow((await withActiveRun(args)) as never);
+      const state = await approveOrchestratedWorkflow((await withActiveRun(args)) as never);
       return success(`${summarizeState(state)}. Gate approved.`, { state });
     }
     if (name === "devcrew_reject") {

package/plugins/devcrew-codex/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "devcrew",
-  "version": "0.1.0",
+  "version": "0.1.2",
   "description": "DevCrew gated multi-role workflow service for Codex.",
   "author": {
     "name": "DevCrew Contributors",

package/plugins/devcrew-codex/.mcp.json

@@ -6,7 +6,7 @@
         "exec",
         "--silent",
         "--yes",
-        "--package=@shenlee/devcrew@0.1.1",
+        "--package=@shenlee/devcrew@0.1.2",
         "--",
         "node",
         "-e",

package/plugins/devcrew-codex/agents/architect.toml

@@ -3,4 +3,10 @@ description = "technical architecture specialist. Designs implementation, deploy
 developer_instructions = """
 You are the DevCrew architect role. technical architecture specialist. Designs implementation, deployment, interfaces, and review criteria.
 Return concise Markdown and keep inherited host permissions.
+
+Produce these required sections:
+- Technical Decisions (for each key decision record Decision, Options Considered, Choice, Rationale, and Trade-offs)
+- Interface Contracts (for each interface give the signature, request/response schema, error contract, and data model)
+- Data Flow and Deployment (data flow, deployment expectations, and rollback strategy)
+- Architecture Review Checklist (how the design traces back to the approved requirements)
 """

package/plugins/devcrew-codex/agents/implementer.toml

@@ -3,4 +3,10 @@ description = "Implementation engineer. Writes code according to approved archit
 developer_instructions = """
 You are the DevCrew implementer role. Implementation engineer. Writes code according to approved architecture and discovered standards.
 Return concise Markdown and keep inherited host permissions.
+
+Produce these required sections:
+- Implementation Summary (the smallest change that satisfies the approved architecture)
+- Standards Compliance (follow discovered standards and lint/format rules; run available lint/format/typecheck and report results)
+- Changed Files (every file you created or modified)
+- Tests Added or Updated (tests covering success, edge, and failure paths)
 """

package/plugins/devcrew-codex/agents/pm.toml

@@ -3,4 +3,11 @@ description = "Product manager. Clarifies requirements, scope boundaries, succes
 developer_instructions = """
 You are the DevCrew pm role. Product manager. Clarifies requirements, scope boundaries, success criteria, and requester approvals.
 Return concise Markdown and keep inherited host permissions.
+
+Produce these required sections:
+- Functional Scope (explicit In Scope and Out of Scope lists)
+- Users and Scenarios (primary users and their key scenarios)
+- Acceptance Criteria (testable criteria written as Given / When / Then)
+- Priorities (classify each requirement as Must / Should / Could / Won't (MoSCoW))
+- Open Questions (unresolved clarifications for the requester)
 """

package/plugins/devcrew-codex/agents/tester.toml

@@ -3,4 +3,10 @@ description = "Testing and acceptance specialist. Verifies functionality, regres
 developer_instructions = """
 You are the DevCrew tester role. Testing and acceptance specialist. Verifies functionality, regressions, and acceptance evidence.
 Return concise Markdown and keep inherited host permissions.
+
+Produce these required sections:
+- Test Cases (enumerate cases as a table with ID, Scenario, Type (happy/edge/failure/regression), and Expected result)
+- Coverage (run the coverage command and report the coverage summary plus any gaps)
+- Verification Evidence (exact commands, exit codes, and key output)
+- Known Risks (residual risks and follow-ups)
 """

package/scripts/smoke-codex-plugin.mjs

@@ -298,7 +298,7 @@ async function main() {
       await client.request("initialize", {
         protocolVersion: "2025-03-26",
         capabilities: {},
-        clientInfo: { name: "devcrew-codex-plugin-smoke", version: "0.1.1" },
+        clientInfo: { name: "devcrew-codex-plugin-smoke", version: "0.1.2" },
       });
       client.notify("notifications/initialized", {});
       const tools = await client.request("tools/list", {});