@shelf/eslint-config 5.0.0 → 5.1.0

package/README.md

@@ -22,28 +22,6 @@ export default [...tsConfig];
 
 ### Frontend
 
-#### JavaScript with React `eslint.config.js`
-
-```js
-import feConfig from '@shelf/eslint-config/frontend';
-
-export default [
-  ...feConfig,
-  {
-    settings: {
-      react: {
-        version: '16.7.0',
-      },
-    },
-    rules: {
-      "react/prop-types": "warn"
-    }
-  }
-];
-```
-
-#### TypeScript or TypeScript + Next `eslint.config.js`
-
 ```js
 import feTsConfig from '@shelf/eslint-config/frontend-typescript';
 
@@ -52,13 +30,10 @@ export default [
   {
     settings: {
       react: {
-        version: '16.7.0',
+        version: 'detect',
       },
     },
-    rules: {
-      "react/prop-types": "warn"
-    }
-  }
+  },
 ];
 ```
 

package/base.js

@@ -1,5 +1,4 @@
 import jestFormatting from 'eslint-plugin-jest-formatting';
-import jsonFormat from 'eslint-plugin-json-format';
 import prettier from 'eslint-plugin-prettier';
 import jestPlugin from 'eslint-plugin-jest';
 import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended';
@@ -26,7 +25,6 @@ export default [
   eslintPluginPrettierRecommended,
   {
     plugins: {
-      'json-format': jsonFormat,
       prettier,
       '@stylistic/js': stylisticJs,
     },

package/common/env.js

@@ -1,8 +1,6 @@
 import globals from 'globals';
-import jest from 'eslint-plugin-jest';
 
 export default {
   ...globals.jest,
-  ...jest.environments.globals.globals,
   ...globals.node,
 };

package/frontend-typescript.js

@@ -1,17 +1,25 @@
-import node from "eslint-plugin-node";
-import testingLibrary from "eslint-plugin-testing-library";
-import {fixupPluginRules} from '@eslint/compat';
-import tsParser from "@typescript-eslint/parser";
-import path from "node:path";
-import { fileURLToPath } from "node:url";
-import js from "@eslint/js";
-import { FlatCompat } from "@eslint/eslintrc";
-import tsEslint from 'typescript-eslint'
+import node from 'eslint-plugin-n';
+import testingLibrary from 'eslint-plugin-testing-library';
+import {fixupConfigRules, fixupPluginRules} from '@eslint/compat';
+import tsParser from '@typescript-eslint/parser';
+import path from 'node:path';
+import {fileURLToPath} from 'node:url';
+import js from '@eslint/js';
+import {FlatCompat} from '@eslint/eslintrc';
+import tsEslint from 'typescript-eslint';
 import overrides from './common/overrides.js';
 import youDontNeedLodash from './rules/you-dont-need-lodash.js';
-import typescriptRules from './rules/typescript.js'
-import consistentTypeImports from './rules/consistent-type-imports.js'
-import frontendConfig from './frontend.js'
+import typescriptRules from './rules/typescript.js';
+import consistentTypeImports from './rules/consistent-type-imports.js';
+import sonarjs from 'eslint-plugin-sonarjs';
+import eslintConfigPrettier from 'eslint-config-prettier';
+import baseConfig from './base.js';
+import react from 'eslint-plugin-react';
+import reactHooks from 'eslint-plugin-react-hooks';
+import _import from 'eslint-plugin-import';
+import globals from 'globals';
+import env from './common/env.js';
+import restrictedPackagesImport from './rules/restricted-packages-import.js';
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
@@ -21,25 +29,45 @@ const compat = new FlatCompat({
 });
 
 const testingLibraryReact = {
-  rules: compat.extends("plugin:testing-library/react")[0].rules,
-  files: ['**/__tests__/**/*.[jt]s?(x)', '**/?(*.)+(spec|test).[jt]s?(x)']
+  rules: compat.extends('plugin:testing-library/react')[0].rules,
+  files: ['**/__tests__/**/*.[jt]s?(x)', '**/?(*.)+(spec|test).[jt]s?(x)'],
 };
 
-export default [...compat.extends(
-  "plugin:you-dont-need-lodash-underscore/compatible",
-), ...tsEslint.configs.recommended,
-  ...frontendConfig,
+export default [
+  ...compat.extends('plugin:you-dont-need-lodash-underscore/compatible'),
+  ...tsEslint.configs.recommended,
+  ...fixupConfigRules(compat.extends('plugin:react/recommended', 'plugin:react-hooks/recommended')),
+  sonarjs.configs.recommended,
+  eslintConfigPrettier,
+  ...baseConfig,
+  {
+    rules: {
+      ...restrictedPackagesImport,
+      'no-console': 'error',
+      'react-hooks/exhaustive-deps': 'error',
+      'sonarjs/cognitive-complexity': ['error', 18],
+      '@stylistic/js/multiline-comment-style': 'off',
+      'no-unreachable': 'error',
+      'react/react-in-jsx-scope': 'off',
+    },
+  },
   testingLibraryReact,
   {
     plugins: {
+      react: fixupPluginRules(react),
+      'react-hooks': fixupPluginRules(reactHooks),
+      import: fixupPluginRules(_import),
       '@typescript-eslint': tsEslint.plugin,
       node,
-      "testing-library": fixupPluginRules(testingLibrary),
+      'testing-library': fixupPluginRules(testingLibrary),
     },
 
     languageOptions: {
+      globals: {
+        ...env,
+        ...globals.browser,
+      },
       parser: tsParser,
-
       parserOptions: {
         ecmaFeatures: {
           jsx: true,
@@ -49,45 +77,47 @@ export default [...compat.extends(
 
     rules: {
       // Often test name starts with component name which are always capitalized
-      "jest/lowercase-name": "off",
-      "react/prop-types": "off",
-      "react/display-name": "warn",
-      "testing-library/await-async-queries": "error",
-      "testing-library/no-await-sync-queries": "error",
+      'jest/lowercase-name': 'off',
+      'react/prop-types': 'off',
+      'react/display-name': 'warn',
+      'testing-library/await-async-queries': 'error',
+      'testing-library/no-await-sync-queries': 'error',
       // 'testing-library/no-wait-for-empty-callback': 'error',
       // It's enabled in overrides
-      "testing-library/no-debugging-utils": "off",
-      "testing-library/consistent-data-testid": [2, {
-        testIdPattern: "^(([a-z])+(-)*)+$",
-      }],
+      'testing-library/no-debugging-utils': 'off',
+      'testing-library/consistent-data-testid': [
+        2,
+        {
+          testIdPattern: '^(([a-z])+(-)*)+$',
+        },
+      ],
       ...consistentTypeImports,
       // it fail to compile TS on react static class properties (displayName | defaultProps | etc..)
-      "@typescript-eslint/explicit-member-accessibility": 0,
-      "@typescript-eslint/consistent-type-assertions": "warn",
+      '@typescript-eslint/explicit-member-accessibility': 0,
+      '@typescript-eslint/consistent-type-assertions': 'warn',
       // Don`t need for typescript files
-      "@typescript-eslint/no-empty-function": "off",
+      '@typescript-eslint/no-empty-function': 'off',
       ...typescriptRules,
-      "@typescript-eslint/no-unused-vars": ["error", {ignoreRestSiblings: true}],
+      '@typescript-eslint/no-unused-vars': ['error', {ignoreRestSiblings: true}],
       ...youDontNeedLodash,
     },
   },
   overrides.allowRequireInConfigs,
   overrides.noExplicitsInTests,
   overrides.noCastWithJestMock,
+  overrides.noTSRulesWithJSON,
   {
-    files: ["**/*.test.{ts,tsx,js}", "**/mocks.ts", "**/mock.js"],
-
+    files: ['**/*.test.{ts,tsx,js}', '**/mocks.ts', '**/mock.js'],
     rules: {
-      camelcase: "off",
-      "sonarjs/no-duplicate-string": "off",
-      "testing-library/no-debugging-utils": "error",
+      camelcase: 'off',
+      'sonarjs/no-duplicate-string': 'off',
+      'testing-library/no-debugging-utils': 'error',
     },
   },
   {
-    files: ["**/*.styled.{ts,tsx}"],
-
+    files: ['**/*.styled.{ts,tsx}'],
     rules: {
-      "sonarjs/no-nested-template-literals": "off",
+      'sonarjs/no-nested-template-literals': 'off',
     },
-  }
+  },
 ];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@shelf/eslint-config",
-  "version": "5.0.0",
+  "version": "5.1.0",
   "description": "ESLint Config for Shelf Projects",
   "license": "MIT",
   "repository": "shelfio/eslint-config",
@@ -13,15 +13,14 @@
     "node": ">=8.10"
   },
   "scripts": {
-    "test": "echo ok"
+    "test": "echo ok",
+    "prepare": "husky"
   },
   "files": [
     "common",
     "rules",
     "base.js",
-    "frontend.js",
     "frontend-typescript.js",
-    "meteor.js",
     "typescript.js"
   ],
   "main": "base.js",
@@ -34,39 +33,35 @@
   },
   "type": "module",
   "dependencies": {
-    "@babel/eslint-parser": "7.26.8",
-    "@babel/eslint-plugin": "7.25.9",
     "@eslint/compat": "1.2.6",
     "@eslint/eslintrc": "3.2.0",
     "@eslint/js": "9.20.0",
     "@stylistic/eslint-plugin-js": "2.13.0",
     "@types/eslint__js": "8.42.3",
-    "@typescript-eslint/eslint-plugin": "8.24.1",
-    "@typescript-eslint/parser": "8.24.1",
-    "eslint-config-next": "15.1.7",
-    "eslint-config-prettier": "10.0.1",
+    "@typescript-eslint/eslint-plugin": "8.26.0",
+    "@typescript-eslint/parser": "8.26.0",
+    "eslint-config-next": "15.2.3",
+    "eslint-config-prettier": "10.1.1",
     "eslint-plugin-babel": "5.3.1",
     "eslint-plugin-import": "2.31.0",
     "eslint-plugin-jest": "28.11.0",
     "eslint-plugin-jest-formatting": "3.1.0",
-    "eslint-plugin-json-format": "2.0.1",
     "eslint-plugin-jsx": "0.1.0",
-    "eslint-plugin-n": "17.15.1",
-    "eslint-plugin-node": "11.1.0",
+    "eslint-plugin-n": "17.16.2",
     "eslint-plugin-prettier": "5.2.3",
     "eslint-plugin-react": "7.37.4",
-    "eslint-plugin-react-hooks": "5.1.0",
+    "eslint-plugin-react-hooks": "5.2.0",
     "eslint-plugin-shelf-no-need-lodash-methods": "2.0.8",
     "eslint-plugin-sonarjs": "3.0.2",
     "eslint-plugin-testing-library": "7.1.1",
     "eslint-plugin-you-dont-need-lodash-underscore": "6.14.0",
     "globals": "15.15.0",
-    "typescript-eslint": "8.24.1"
+    "typescript-eslint": "8.26.0"
   },
   "devDependencies": {
-    "husky": "8.0.3",
-    "lint-staged": "15.4.3",
-    "prettier": "3.5.1"
+    "husky": "9.1.7",
+    "lint-staged": "15.5.0",
+    "prettier": "3.5.3"
   },
   "peerDependencies": {
     "eslint": "9.x",

package/typescript.js

@@ -1,8 +1,7 @@
 import jestFormatting from 'eslint-plugin-jest-formatting';
-import jsonFormat from 'eslint-plugin-json-format';
 import prettier from 'eslint-plugin-prettier';
 import _import from 'eslint-plugin-import';
-import node from 'eslint-plugin-node';
+import node from 'eslint-plugin-n';
 import {fixupPluginRules} from '@eslint/compat';
 import tsParser from '@typescript-eslint/parser';
 import path from 'node:path';
@@ -51,7 +50,6 @@ export default [
   {
     plugins: {
       'jest-formatting': jestFormatting,
-      'json-format': jsonFormat,
       prettier,
       import: fixupPluginRules(_import),
       node,
@@ -117,6 +115,13 @@ export default [
           requireReturnForObjectLiteral: true,
         },
       ],
+      'id-length': [
+        'warn',
+        {
+          min: 1,
+          max: 14
+        },
+      ],
       'no-unreachable': 'error',
       'require-await': 'error',
       ...youDontNeedLodash,

package/.husky/_/husky.sh

@@ -1,31 +0,0 @@
-#!/bin/sh
-if [ -z "$husky_skip_init" ]; then
-  debug () {
-    if [ "$HUSKY_DEBUG" = "1" ]; then
-      echo "husky (debug) - $1"
-    fi
-  }
-
-  readonly hook_name="$(basename "$0")"
-  debug "starting $hook_name..."
-
-  if [ "$HUSKY" = "0" ]; then
-    debug "HUSKY env variable is set to 0, skipping hook"
-    exit 0
-  fi
-
-  if [ -f ~/.huskyrc ]; then
-    debug "sourcing ~/.huskyrc"
-    . ~/.huskyrc
-  fi
-
-  export readonly husky_skip_init=1
-  sh -e "$0" "$@"
-  exitCode="$?"
-
-  if [ $exitCode != 0 ]; then
-    echo "husky - $hook_name hook exited with code $exitCode (error)"
-  fi
-
-  exit $exitCode
-fi

package/CHANGELOG.md

@@ -1,12 +0,0 @@
-## 3.0.0
-
-Override recommended no explicit type any in tests
-
-## 2.0.0
-
-Removed separate file for testing-library, added testing-library rules to `frontend-typescript.js`.
-Extended `frontend.js` in `frontend-typescript.js` and `frontend-typescript-vue.js`.
-
-## 1.0.0
-
-Breaking changes of the eslint-config-prettier 8.0.0

package/frontend.js

@@ -1,71 +0,0 @@
-import { FlatCompat } from '@eslint/eslintrc';
-import { fixupConfigRules, fixupPluginRules } from "@eslint/compat";
-import react from "eslint-plugin-react";
-import _import from "eslint-plugin-import";
-import sonarjs from "eslint-plugin-sonarjs";
-import globals from "globals";
-import babelParser from "@babel/eslint-parser";
-import path from "node:path";
-import { fileURLToPath } from "node:url";
-import js from "@eslint/js";
-import reactHooks from 'eslint-plugin-react-hooks';
-import eslintConfigPrettier from 'eslint-config-prettier';
-import env from './common/env.js';
-import restrictedPackagesImport from './rules/restricted-packages-import.js';
-import baseConfig from './base.js';
-
-
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = path.dirname(__filename);
-const compat = new FlatCompat({
-  baseDirectory: __dirname,
-  recommendedConfig: js.configs.recommended,
-});
-
-export default [...fixupConfigRules(compat.extends(
-  "plugin:react/recommended",
-  "plugin:react-hooks/recommended",
-)),
-  sonarjs.configs.recommended,
-  eslintConfigPrettier,
-  ...baseConfig,
-  {
-  plugins: {
-    react: fixupPluginRules(react),
-    'react-hooks': fixupPluginRules(reactHooks),
-    import: fixupPluginRules(_import),
-  },
-
-  languageOptions: {
-    globals: {
-      ...globals.browser,
-      ...env,
-    },
-
-    parser: babelParser,
-    ecmaVersion: 5,
-    sourceType: "commonjs",
-
-    parserOptions: {
-      ecmaFeatures: {
-        jsx: true,
-      },
-    }
-  },
-
-  rules: {
-    ...restrictedPackagesImport,
-    "no-console": "error",
-    "react-hooks/exhaustive-deps": "error",
-    "sonarjs/cognitive-complexity": ["error", 18],
-    "@stylistic/js/multiline-comment-style": "off",
-    "no-unreachable": "error",
-    "react/react-in-jsx-scope": "off",
-  },
-}, {
-  files: ["**/*.test.{ts,tsx}"],
-
-  rules: {
-    "sonarjs/no-duplicate-string": "off",
-  },
-}];

package/meteor.js

@@ -1,71 +0,0 @@
-import { fixupConfigRules, fixupPluginRules } from "@eslint/compat";
-import babel from "@babel/eslint-plugin";
-import react from "eslint-plugin-react";
-import prettier from "eslint-plugin-prettier";
-import _import from "eslint-plugin-import";
-import globals from "globals";
-import babelParser from "@babel/eslint-parser";
-import path from "node:path";
-import { fileURLToPath } from "node:url";
-import js from "@eslint/js";
-import { FlatCompat } from "@eslint/eslintrc";
-import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended';
-import importOrder from './rules/import-order.js';
-import paddingLineBetweenStatements from './rules/padding-line-between-statements.js';
-import stylisticJs from '@stylistic/eslint-plugin-js';
-
-
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = path.dirname(__filename);
-const compat = new FlatCompat({
-  baseDirectory: __dirname,
-  recommendedConfig: js.configs.recommended,
-});
-
-export default [...fixupConfigRules(compat.extends(
-  "plugin:react/recommended",
-)),
-  eslintPluginPrettierRecommended,
-  {
-    plugins: {
-      babel,
-      react: fixupPluginRules(react),
-      prettier,
-      import: fixupPluginRules(_import),
-      '@stylistic/js': stylisticJs,
-    },
-
-    languageOptions: {
-      globals: {
-        ...globals.node,
-        ...globals.browser,
-        ...globals.meteor,
-      },
-
-      parser: babelParser,
-
-      parserOptions: {
-        ecmaFeatures: {
-          jsx: true,
-        },
-
-        allowImportExportEverywhere: false,
-        codeFrame: false,
-      },
-    },
-
-    rules: {
-      "prettier/prettier": "error",
-      ...importOrder,
-      ...paddingLineBetweenStatements,
-      "comma-dangle": "off",
-      camelcase: "error",
-      eqeqeq: ["error", "smart"],
-      "new-cap": "error",
-      "no-extend-native": "error",
-      "no-use-before-define": ["error", "nofunc"],
-      "@stylistic/js/multiline-comment-style": ["error", "separate-lines"],
-      "no-unreachable": "error",
-      "require-await": "error",
-    },
-  }];