@shelf/eslint-config 2.18.0 → 2.19.2

package/README.md

@@ -20,14 +20,6 @@ $ yarn add @shelf/eslint-config --dev
 }
 ```
 
-#### TypeScript `.eslintrc`
-
-```json
-{
-  "extends": ["@shelf/eslint-config/typescript"]
-}
-```
-
 ### Frontend
 
 #### JavaScript with React `.eslintrc`

package/base.js

@@ -1,5 +1,5 @@
-const paddingLineBetweenStatements = require('./rules/padding-line-between-statements');
-const preferDestructuring = require('./rules/prefer-destructuring');
+const paddingLineBetweenStatements = require('./rules/padding-line-between-statements.json');
+const preferES6Features = require('./rules/prefer-es6.json');
 const sortImports = require('./rules/sort-imports.json');
 const importOrder = require('./rules/import-order.json');
 const jestRules = require('./rules/jest.json');
@@ -21,14 +21,12 @@ module.exports = {
   },
   rules: {
     'prettier/prettier': 'error',
-    'padding-line-between-statements': paddingLineBetweenStatements,
+    ...paddingLineBetweenStatements,
     ...jestRules,
-    ...preferDestructuring,
+    ...preferES6Features,
     'no-empty': ['error', {allowEmptyCatch: true}],
     ...importOrder,
     ...sortImports,
-    'prefer-template': 'error',
-    'prefer-object-spread': 'error',
     'comma-dangle': 'off',
     camelcase: 'error',
     eqeqeq: ['error', 'smart'],

package/frontend-typescript-vue.js

@@ -1,7 +1,8 @@
-const {allowRequireInConfigs, noExplicitReturnTypeInTests} = require('./rules/overrides');
+const {allowRequireInConfigs, noExplicitReturnTypeInTests} = require('./common/overrides');
 const consistentTypeAssertions = require('./rules/consistent-type-assertions.json');
 const consistentTypeImports = require('./rules/consistent-type-imports.json');
 const vueConfig = require('./frontend-vue');
+const typescriptRules = require('./rules/typescript');
 
 module.exports = {
   extends: [
@@ -16,13 +17,11 @@ module.exports = {
   },
   rules: {
     ...vueConfig.rules,
-    '@typescript-eslint/no-use-before-define': 0,
-    '@typescript-eslint/camelcase': 0,
-    '@typescript-eslint/explicit-member-accessibility': 0,
     'jest/lowercase-name': 'off',
     ...consistentTypeAssertions,
-    '@typescript-eslint/consistent-type-definitions': ['error', 'type'],
     ...consistentTypeImports,
+    '@typescript-eslint/explicit-member-accessibility': 0,
+    ...typescriptRules,
   },
   overrides: [allowRequireInConfigs, noExplicitReturnTypeInTests],
 };

package/frontend-typescript.js

@@ -1,13 +1,15 @@
-const commonExtends = require('./rules/extends-common.json');
+const commonExtends = require('./common/extends.json');
 const commonPlugins = require('./common/plugins');
 const tsParser = require('./common/ts-parser');
-const {allowRequireInConfigs, noExplicitReturnTypeInTests} = require('./rules/overrides');
+const {allowRequireInConfigs, noExplicitReturnTypeInTests} = require('./common/overrides');
 const consistentTypeAssertions = require('./rules/consistent-type-assertions.json');
 const consistentTypeImports = require('./rules/consistent-type-imports.json');
 const frontendConfig = require('./frontend');
+const youDontNeedLodashRules = require('./rules/you-dont-need-lodash.json');
+const typescriptRules = require('./rules/typescript');
 
 module.exports = {
-  extends: ['./frontend.js', ...commonExtends],
+  extends: ['./frontend.js', ...commonExtends, 'plugin:you-dont-need-lodash-underscore/compatible'],
   globals: {
     DD_LOGS: true,
   },
@@ -15,17 +17,10 @@ module.exports = {
   ...tsParser,
   rules: {
     ...frontendConfig.rules,
-    '@typescript-eslint/no-use-before-define': 0,
-    '@typescript-eslint/camelcase': 0,
-    // it fail to compile TS on react static class properties (displayName | defaultProps | etc..)
-    '@typescript-eslint/explicit-member-accessibility': 0,
     // Often test name starts with component name which are always capitalized
     'jest/lowercase-name': 'off',
-    // Don`t needed for typescript files
-    '@typescript-eslint/no-empty-function': 'off',
     'react/prop-types': 'off',
     'react/display-name': 'warn',
-    '@typescript-eslint/no-unused-vars': 'error',
     ...consistentTypeAssertions,
     'testing-library/await-async-query': 'error',
     'testing-library/no-await-sync-query': 'error',
@@ -36,8 +31,13 @@ module.exports = {
         testIdPattern: '^(([a-z])+(-)*)+$',
       },
     ],
-    '@typescript-eslint/consistent-type-definitions': ['error', 'type'],
     ...consistentTypeImports,
+    ...youDontNeedLodashRules,
+    // it fail to compile TS on react static class properties (displayName | defaultProps | etc..)
+    '@typescript-eslint/explicit-member-accessibility': 0,
+    // Don`t need for typescript files
+    '@typescript-eslint/no-empty-function': 'off',
+    ...typescriptRules,
   },
   overrides: [
     allowRequireInConfigs,

package/meteor.js

@@ -1,4 +1,4 @@
-const paddingLineBetweenStatements = require('./rules/padding-line-between-statements');
+const paddingLineBetweenStatements = require('./rules/padding-line-between-statements.json');
 const importOrder = require('./rules/import-order.json');
 
 module.exports = {
@@ -28,7 +28,7 @@ module.exports = {
   rules: {
     'prettier/prettier': 'error',
     ...importOrder,
-    'padding-line-between-statements': paddingLineBetweenStatements,
+    ...paddingLineBetweenStatements,
     'comma-dangle': 'off',
     camelcase: 'error',
     eqeqeq: ['error', 'smart'],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@shelf/eslint-config",
-  "version": "2.18.0",
+  "version": "2.19.2",
   "description": "ESLint Config for Shelf Projects",
   "license": "MIT",
   "repository": "shelfio/eslint-config",
@@ -32,28 +32,29 @@
     "eslintconfig"
   ],
   "dependencies": {
-    "@babel/eslint-parser": "7.17.0",
-    "@typescript-eslint/eslint-plugin": "5.26.0",
-    "@typescript-eslint/parser": "5.26.0",
+    "@babel/eslint-parser": "7.18.2",
+    "@typescript-eslint/eslint-plugin": "5.30.5",
+    "@typescript-eslint/parser": "5.30.5",
     "eslint-config-next": "11.1.2",
     "eslint-config-prettier": "8.5.0",
     "eslint-plugin-babel": "5.3.1",
     "eslint-plugin-import": "2.26.0",
-    "eslint-plugin-jest": "26.2.2",
+    "eslint-plugin-jest": "26.5.3",
     "eslint-plugin-jest-formatting": "3.1.0",
     "eslint-plugin-json-format": "2.0.1",
     "eslint-plugin-jsx": "0.1.0",
-    "eslint-plugin-prettier": "4.0.0",
-    "eslint-plugin-react": "7.30.0",
-    "eslint-plugin-react-hooks": "4.5.0",
+    "eslint-plugin-prettier": "4.2.1",
+    "eslint-plugin-react": "7.30.1",
+    "eslint-plugin-react-hooks": "4.6.0",
     "eslint-plugin-sonarjs": "0.13.0",
-    "eslint-plugin-testing-library": "5.5.0",
-    "eslint-plugin-vue": "8.5.0"
+    "eslint-plugin-testing-library": "5.5.1",
+    "eslint-plugin-vue": "9.2.0",
+    "eslint-plugin-you-dont-need-lodash-underscore": "6.12.0"
   },
   "devDependencies": {
     "husky": "8.0.1",
-    "lint-staged": "12.4.1",
-    "prettier": "2.6.2"
+    "lint-staged": "13.0.3",
+    "prettier": "2.7.1"
   },
   "peerDependencies": {
     "eslint": "7.x || 8.x",
@@ -61,8 +62,7 @@
   },
   "lint-staged": {
     "*.{js,json,css,md,yml}": [
-      "prettier --write",
-      "git add"
+      "prettier --write"
     ]
   },
   "publishConfig": {

package/rules/padding-line-between-statements.json

@@ -0,0 +1,30 @@
+{
+  "padding-line-between-statements": [
+    "error",
+    {
+      "blankLine": "always",
+      "prev": "*",
+      "next": "return"
+    },
+    {
+      "blankLine": "always",
+      "prev": ["if", "const", "let", "var"],
+      "next": "if"
+    },
+    {
+      "blankLine": "always",
+      "prev": ["if"],
+      "next": ["const", "let", "var"]
+    },
+    {
+      "blankLine": "always",
+      "prev": ["import"],
+      "next": "*"
+    },
+    {
+      "blankLine": "never",
+      "prev": "import",
+      "next": "import"
+    }
+  ]
+}

package/rules/prefer-es6.json

@@ -0,0 +1,14 @@
+{
+  "prefer-destructuring": [
+    "error",
+    {
+      "array": false,
+      "object": true
+    },
+    {
+      "enforceForRenamedProperties": false
+    }
+  ],
+  "prefer-template": "error",
+  "prefer-object-spread": "error"
+}

package/rules/typescript.js

@@ -0,0 +1,6 @@
+module.exports = {
+  '@typescript-eslint/consistent-type-definitions': ['error', 'type'],
+  '@typescript-eslint/no-use-before-define': 'off',
+  '@typescript-eslint/no-unused-vars': 'error',
+  '@typescript-eslint/camelcase': 'off',
+};

package/rules/you-dont-need-lodash.json

@@ -0,0 +1,13 @@
+{
+  "you-dont-need-lodash-underscore/uniq": "off",
+  "you-dont-need-lodash-underscore/last": "off",
+  "you-dont-need-lodash-underscore/omit": "off",
+  "you-dont-need-lodash-underscore/trim": "off",
+  "you-dont-need-lodash-underscore/is-string": "off",
+  "you-dont-need-lodash-underscore/is-function": "off",
+  "you-dont-need-lodash-underscore/get": "error",
+  "you-dont-need-lodash-underscore/every": "error",
+  "you-dont-need-lodash-underscore/map": "error",
+  "you-dont-need-lodash-underscore/filter": "error",
+  "you-dont-need-lodash-underscore/size": "error"
+}

package/typescript.js

@@ -1,18 +1,20 @@
-const commonExtends = require('./rules/extends-common.json');
+const commonExtends = require('./common/extends.json');
 const commonPlugins = require('./common/plugins');
 const env = require('./common/env');
 const importOrder = require('./rules/import-order.json');
 const jestRules = require('./rules/jest.json');
-const paddingLineBetweenStatements = require('./rules/padding-line-between-statements');
-const preferDestructuring = require('./rules/prefer-destructuring');
+const paddingLineBetweenStatements = require('./rules/padding-line-between-statements.json');
+const preferES6Features = require('./rules/prefer-es6.json');
 const sortImports = require('./rules/sort-imports.json');
 const tsParser = require('./common/ts-parser');
-const {allowRequireInConfigs, noExplicitReturnTypeInTests} = require('./rules/overrides');
+const {allowRequireInConfigs, noExplicitReturnTypeInTests} = require('./common/overrides');
 const consistentTypeAssertions = require('./rules/consistent-type-assertions.json');
 const consistentTypeImports = require('./rules/consistent-type-imports.json');
+const youDontNeedLodashRules = require('./rules/you-dont-need-lodash.json');
+const typescriptRules = require('./rules/typescript');
 
 module.exports = {
-  extends: commonExtends,
+  extends: [...commonExtends, 'plugin:you-dont-need-lodash-underscore/compatible'],
   plugins: commonPlugins,
   env,
   ...tsParser,
@@ -22,20 +24,13 @@ module.exports = {
     curly: 'error',
     'no-nested-ternary': 'error',
     'prettier/prettier': 'error',
-    '@typescript-eslint/camelcase': 0,
-    'padding-line-between-statements': paddingLineBetweenStatements,
+    ...paddingLineBetweenStatements,
     ...jestRules,
-    ...preferDestructuring,
-    'prefer-template': 'error',
-    'prefer-object-spread': 'error',
+    ...preferES6Features,
     ...importOrder,
     ...sortImports,
-    '@typescript-eslint/no-unused-vars': 'error',
     'comma-dangle': 'off',
-    '@typescript-eslint/ban-ts-comment': 'off',
     ...consistentTypeAssertions,
-    '@typescript-eslint/consistent-type-definitions': ['error', 'type'],
-    '@typescript-eslint/no-non-null-assertion': 'off', // we want to allow using the "!" operator
     camelcase: [
       'error',
       {properties: 'never', ignoreGlobals: true, allow: ['hash_key', 'range_key']},
@@ -44,12 +39,15 @@ module.exports = {
     'new-cap': 'error',
     'no-extend-native': 'error',
     'no-use-before-define': 'off',
-    '@typescript-eslint/no-use-before-define': 'off',
     ...consistentTypeImports,
     'multiline-comment-style': ['error', 'separate-lines'],
     'arrow-body-style': ['error', 'as-needed', {requireReturnForObjectLiteral: true}],
     'no-unreachable': 'error',
     'require-await': 'error',
+    ...youDontNeedLodashRules,
+    '@typescript-eslint/ban-ts-comment': 'off',
+    '@typescript-eslint/no-non-null-assertion': 'off', // we want to allow using the "!" operator
+    ...typescriptRules,
   },
   overrides: [allowRequireInConfigs, noExplicitReturnTypeInTests],
 };

package/rules/padding-line-between-statements.js

@@ -1,28 +0,0 @@
-module.exports = [
-  'error',
-  {
-    blankLine: 'always',
-    prev: '*',
-    next: 'return',
-  },
-  {
-    blankLine: 'always',
-    prev: ['if', 'const', 'let', 'var'],
-    next: 'if',
-  },
-  {
-    blankLine: 'always',
-    prev: ['if'],
-    next: ['const', 'let', 'var'],
-  },
-  {
-    blankLine: 'always',
-    prev: ['import'],
-    next: '*',
-  },
-  {
-    blankLine: 'never',
-    prev: 'import',
-    next: 'import',
-  },
-];

package/rules/prefer-destructuring.js

@@ -1,7 +0,0 @@
-module.exports = {
-  'prefer-destructuring': [
-    'error',
-    {array: false, object: true},
-    {enforceForRenamedProperties: false},
-  ],
-};