@shbernal/ts-xlsx 3.2.2-next.31.ga6df6f9 → 3.2.2-next.32.g433defc

package/dist/core/autofilter.js

@@ -1,4 +1,4 @@
-import { AuthoringError, quoted } from '../errors.js';
+import { AuthoringError, InternalError, quoted } from '../errors.js';
 import { tokenSet } from '../token-set.js';
 import { boundedRect, decodeRange, encodeRect } from './address.js';
 import { isDeletedSpan, shiftIndex, shiftRect } from './grid-shift.js';
@@ -44,8 +44,9 @@ function canonicalizeColumn(column, width) {
 }
 export function shiftAutoFilter(filter, splice) {
     const rect = boundedRect(decodeRange(filter.ref));
-    if (rect === undefined)
-        return filter;
+    if (rect === undefined) {
+        throw new InternalError(`stored autofilter range ${quoted(filter.ref)} is not a bounded rectangle`);
+    }
     const moved = shiftRect(rect, splice);
     if (moved === undefined)
         return undefined;

package/dist/customui/ribbon.js

@@ -1,6 +1,7 @@
 import { strFromU8 } from 'fflate';
 import { isRelType } from '../rel-type.js';
 import { tokenSet } from '../token-set.js';
+import { XmlParseError } from '../xml/errors.js';
 import { boolStrict, localName, xmlEvents } from '../xml/xml-scan.js';
 import { CustomUiParseError } from './errors.js';
 export const CUSTOMUI_2006_NAMESPACE = 'http://schemas.microsoft.com/office/2006/01/customui';
@@ -38,10 +39,9 @@ export function parseCustomUi(input) {
         root = buildTree(xml);
     }
     catch (error) {
-        if (error instanceof CustomUiParseError)
+        if (!(error instanceof XmlParseError))
             throw error;
-        const detail = error instanceof Error ? error.message : String(error);
-        throw new CustomUiParseError(`malformed customUI XML: ${detail}`, { cause: error });
+        throw new CustomUiParseError(`malformed customUI XML: ${error.message}`, { cause: error });
     }
     const customUi = findChild(root, 'customUI');
     if (customUi === undefined) {
@@ -104,8 +104,6 @@ function buildTree(xml) {
     for (const event of xmlEvents(xml)) {
         if (event.kind === 'open') {
             const parent = stack[stack.length - 1];
-            if (parent === undefined)
-                throw new CustomUiParseError('unbalanced customUI markup');
             const el = {
                 name: event.name,
                 local: localName(event.name),

package/dist/io/csv/read.js

@@ -90,8 +90,7 @@ function defaultCsvCoerce(field) {
     const numeric = NUMERIC.exec(field);
     if (numeric) {
         const value = Number(field);
-        const exact = Number.isFinite(value) &&
-            Math.abs(value) <= Number.MAX_SAFE_INTEGER &&
+        const exact = Math.abs(value) <= Number.MAX_SAFE_INTEGER &&
             significantDigits(numeric[1] ?? '') <= MAX_EXACT_SIGNIFICANT_DIGITS;
         return exact ? value : field;
     }

package/dist/io/style/xf-style.js

@@ -56,7 +56,7 @@ const BUILTIN_NUMFMTS = new Map([
     [58, '[$-404]m"月"d"日"'],
 ]);
 export function numFmtCodeFor(id, custom) {
-    if (!Number.isInteger(id) || id === 0)
+    if (id === 0)
         return undefined;
     return custom.get(id) ?? BUILTIN_NUMFMTS.get(id);
 }

package/dist/io/xlsb/primitives.d.ts

@@ -1,5 +1,5 @@
 import type { Color } from '../../core/style.ts';
-import { type ErrorCode } from '../../core/value.ts';
+import type { ErrorCode } from '../../core/value.ts';
 /** The `Cell` structure ([MS-XLSB] 2.5.10) every cell record opens with. */
 export interface CellHeader {
     /** Zero-based column index. */

package/dist/io/xlsb/primitives.js

@@ -1,5 +1,4 @@
 import { decodeUtf16le } from '../../bytes.js';
-import { isErrorCode } from '../../core/value.js';
 import { hex } from '../../hex.js';
 import { XlsbParseError } from './errors.js';
 const NULL_STRING_LENGTH = 0xffffffff;
@@ -104,8 +103,7 @@ export class RecordReader {
     }
 }
 export function errorCodeFor(code) {
-    const text = BERR_CODES.get(code);
-    return text !== undefined && isErrorCode(text) ? text : undefined;
+    return BERR_CODES.get(code);
 }
 const BERR_CODES = new Map([
     [0x00, '#NULL!'],

package/dist/io/xlsb/read.d.ts

@@ -17,7 +17,6 @@ export declare function readXlsb(data: Uint8Array, options?: ReadPackageOptions)
  * `.xlsx` reader can hand over a package it has already inflated and classified, rather than
  * inflating the same bytes twice.
  *
- * `documentPath` is where the package's own `_rels/.rels` says its workbook lives; it defaults to the
- * conventional path for a caller holding nothing but the parts.
+ * `documentPath` is where the package's own `_rels/.rels` says its workbook lives.
  */
-export declare function readXlsbPackage(files: Record<string, Uint8Array>, documentPath?: string): Workbook;
+export declare function readXlsbPackage(files: Record<string, Uint8Array>, documentPath: string): Workbook;

package/dist/io/xlsb/read.js

@@ -24,7 +24,7 @@ export function readXlsb(data, options = {}) {
     }
     return readXlsbPackage(files, documentPath);
 }
-export function readXlsbPackage(files, documentPath = XLSB_WORKBOOK_PART) {
+export function readXlsbPackage(files, documentPath) {
     const { partText, partBytes } = packageAccessors(files);
     const workbookPart = partBytes(documentPath);
     if (workbookPart === undefined) {

package/dist/io/xlsx/comments.js

@@ -6,9 +6,8 @@ export function collectComments(cells, threads, alreadyCollected = []) {
     const anchored = new Set(fallbacks.map((fallback) => fallback.ref));
     const comments = [...fallbacks, ...alreadyCollected];
     for (const cell of cells) {
-        if (cell.note === undefined || anchored.has(cell.address))
-            continue;
-        comments.push(noteOn(cell, cell.note));
+        if (cell.note !== undefined)
+            comments.push(noteOn(cell, cell.note));
     }
     return comments
         .filter((comment) => comment.threadId !== undefined || !anchored.has(comment.ref))

package/dist/io/xlsx/pivot.js

@@ -1,4 +1,5 @@
 import { encodeAddress } from '../../core/address.js';
+import { InternalError } from '../../errors.js';
 import { escapeAttr, numberText, XML_DECLARATION } from '../../xml/xml.js';
 import { RELATIONSHIPS_NS } from '../opc/namespaces.js';
 import { SPREADSHEETML_NS } from './namespaces.js';
@@ -46,8 +47,11 @@ export function pivotCacheRecordsXml(table) {
         `</pivotCacheRecords>`);
 }
 export function pivotTableXml(table, name, cacheId) {
-    const rowField = table.rowFields[0] ?? 0;
-    const columnField = table.columnFields[0] ?? 0;
+    const [rowField] = table.rowFields;
+    const [columnField] = table.columnFields;
+    if (rowField === undefined || columnField === undefined) {
+        throw new InternalError('a pivot table reached the writer with no row or column field');
+    }
     const rowGroups = table.cacheFields[rowField]?.sharedItems?.length ?? 1;
     const columnGroups = table.cacheFields[columnField]?.sharedItems?.length ?? 1;
     const location = `A1:${encodeAddress(2 + columnGroups, 3 + rowGroups)}`;

package/dist/vba/project-editor.js

@@ -146,7 +146,7 @@ function removeModuleDirRecord(dir, streamName, decoder) {
     }
     if (countAt < 0)
         throw new VbaParseError('dir stream is missing MODULES_COUNT');
-    if (removeStart < 0 || removeEnd < 0) {
+    if (removeStart < 0) {
         throw new VbaParseError(`module stream ${quoted(streamName)} not found in the dir stream`);
     }
     if (countAt >= removeStart) {
@@ -214,7 +214,7 @@ function removeProjectwmRecord(wm, existingModuleCount, name, decoder) {
             removeEnd = pos;
         }
     }
-    if (removeStart < 0 || removeEnd < 0) {
+    if (removeStart < 0) {
         throw new VbaParseError(`module ${quoted(name)} not found in the PROJECTwm stream`);
     }
     return spliceBytes(wm, removeStart, removeEnd);

package/dist/xml/xml-scan.js

@@ -166,15 +166,11 @@ export function* xmlEvents(source) {
     while (i < length) {
         const lt = source.indexOf('<', i);
         if (lt === -1) {
-            const chunk = source.slice(i);
-            if (chunk.length > 0)
-                yield { kind: 'text', text: admitText(normalizeLineEndings(chunk)) };
+            yield { kind: 'text', text: admitText(normalizeLineEndings(source.slice(i))) };
             return;
         }
         if (lt > i) {
-            const chunk = source.slice(i, lt);
-            if (chunk.length > 0)
-                yield { kind: 'text', text: admitText(normalizeLineEndings(chunk)) };
+            yield { kind: 'text', text: admitText(normalizeLineEndings(source.slice(i, lt))) };
         }
         const markup = markupAt(source, lt);
         if (markup !== undefined) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@shbernal/ts-xlsx",
-  "version": "3.2.2-next.31.ga6df6f9",
+  "version": "3.2.2-next.32.g433defc",
   "description": "A TypeScript-first library for reading and writing xlsx (OOXML) spreadsheets.",
   "keywords": [
     "csv",
@@ -92,7 +92,6 @@
     "corpus-blind:check": "node scripts/check-corpus-blind.ts",
     "entries:check": "node scripts/check-entries.ts",
     "public-types:check": "node scripts/check-public-types.ts",
-    "facet-register:check": "node scripts/check-facet-register.ts",
     "tsconfig-coverage:check": "node scripts/check-tsconfig-coverage.ts",
     "browser:check": "node scripts/check-browser-safe.ts",
     "source-text:check": "node scripts/check-source-text.ts",
@@ -117,7 +116,7 @@
     "verify": "node scripts/verify.ts --full",
     "verify:quick": "node scripts/verify.ts --quick",
     "test": "node scripts/verify.ts --full",
-    "prepublishOnly": "pnpm run build && pnpm run test && pnpm run smoke:dist && pnpm run size",
+    "prepublishOnly": "pnpm run test && pnpm run smoke:dist",
     "validate:ooxml": "ooxml-validate",
     "test:ooxml": "node test/ooxml-validation/run.ts"
   },