@shaykec/app-agent 1.0.5 → 1.0.7

package/templates/ios/Skeleton/SkeletonTests/DataRepositoryTests.swift

@@ -0,0 +1,95 @@
+import XCTest
+@testable import Skeleton
+
+/// Tests that MockDataProvider conforms to DataRepository and that
+/// DataSourceResolver returns the correct implementation.
+final class DataRepositoryTests: XCTestCase {
+
+    // MARK: - DataRepository Protocol Conformance
+
+    func testMockDataProviderConformsToDataRepository() {
+        let repo: any DataRepository = MockDataProvider.shared
+        XCTAssertNotNil(repo, "MockDataProvider should conform to DataRepository")
+    }
+
+    func testRepositoryLoadData() {
+        let repo: any DataRepository = MockDataProvider.shared
+        repo.loadData()
+        XCTAssertFalse(repo.items.isEmpty, "loadData() should populate items")
+        XCTAssertFalse(repo.categories.isEmpty, "loadData() should populate categories")
+    }
+
+    func testRepositoryAddItem() {
+        let repo: any DataRepository = MockDataProvider.shared
+        repo.loadData()
+        let initialCount = repo.items.count
+        let newItem = Item(title: "Protocol Test Item", subtitle: "Via DataRepository")
+        repo.addItem(newItem)
+        XCTAssertEqual(repo.items.count, initialCount + 1, "addItem should increase count by 1")
+    }
+
+    func testRepositoryDeleteItem() {
+        let repo: any DataRepository = MockDataProvider.shared
+        repo.loadData()
+        let initialCount = repo.items.count
+        guard let first = repo.items.first else {
+            XCTFail("No items to delete")
+            return
+        }
+        repo.deleteItem(first)
+        XCTAssertEqual(repo.items.count, initialCount - 1, "deleteItem should decrease count by 1")
+    }
+
+    func testRepositoryToggleFavorite() {
+        let repo: any DataRepository = MockDataProvider.shared
+        repo.loadData()
+        guard let first = repo.items.first else {
+            XCTFail("No items")
+            return
+        }
+        let wasFavorite = first.isFavorite
+        repo.toggleFavorite(first)
+        let updated = repo.items.first { $0.id == first.id }
+        XCTAssertEqual(updated?.isFavorite, !wasFavorite, "toggleFavorite should flip the state")
+    }
+
+    func testRepositorySearchItems() {
+        let repo: any DataRepository = MockDataProvider.shared
+        repo.loadData()
+        let all = repo.searchItems(query: "")
+        XCTAssertEqual(all.count, repo.items.count, "Empty query should return all items")
+        let filtered = repo.searchItems(query: "Item One")
+        XCTAssertFalse(filtered.isEmpty, "Should find items matching 'Item One'")
+    }
+
+    func testRepositoryItemsByCategory() {
+        let repo: any DataRepository = MockDataProvider.shared
+        repo.loadData()
+        guard let firstCat = repo.categories.first else {
+            XCTFail("No categories")
+            return
+        }
+        let catItems = repo.itemsByCategory(firstCat.name)
+        for item in catItems {
+            XCTAssertEqual(item.category, firstCat.name, "All items should belong to the requested category")
+        }
+    }
+
+    func testRepositoryFavoriteItems() {
+        let repo: any DataRepository = MockDataProvider.shared
+        repo.loadData()
+        let favs = repo.favoriteItems
+        for item in favs {
+            XCTAssertTrue(item.isFavorite, "All favoriteItems should have isFavorite == true")
+        }
+    }
+
+    // MARK: - DataSourceResolver
+
+    func testDataSourceResolverReturnsMock() {
+        // Default config is .mock
+        let repo = DataSourceResolver.repository
+        XCTAssertNotNil(repo, "DataSourceResolver should return a non-nil repository")
+        XCTAssertTrue(repo is MockDataProvider, "When active is .mock, should return MockDataProvider")
+    }
+}

package/templates/ios/Skeleton/SkeletonTests/MockDataProviderTests.swift

@@ -3,6 +3,7 @@ import XCTest
 
 final class MockDataProviderTests: XCTestCase {
     var provider: MockDataProvider!
+    var repository: any DataRepository { provider }
 
     override func setUp() {
         super.setUp()

package/templates/ios/Skeleton/TESTING_MANIFEST.md

@@ -16,13 +16,15 @@ This document catalogs all accessibility identifiers in the Skeleton template fo
 - `home_category_chips` — Category filter chips
 - `home_item_{index}_card` — Item card (e.g., `home_item_0_card`)
 - `home_create_button` — Create new item button
+- `home_empty_state` — Empty state view when no items exist
 
 ## ExploreView Identifiers
 
 - `explore_search_field` — Search input
 - `explore_category_{index}` — Category section
 - `explore_result_{index}_card` — Search result card
-- `explore_empty_state` — Empty search state
+- `explore_empty_state` — Empty state view when no search results or no items
+- `explore_no_results` — Empty state for no matching search results
 
 ## DetailView Identifiers
 
@@ -36,7 +38,7 @@ This document catalogs all accessibility identifiers in the Skeleton template fo
 ## FavoritesView Identifiers
 
 - `favorites_item_{index}_card` — Favorite item card
-- `favorites_empty_state` — Empty favorites state
+- `favorites_empty_state` — Empty state view when no favorites saved
 
 ## ProfileView Identifiers
 

package/templates/ios/Skeleton/tests/01_app_launch.yaml

@@ -2,8 +2,7 @@ appId: ${APP_BUNDLE_ID}
 ---
 - clearState
 - launchApp
-- assertVisible:
-    id: "tab_bar_home"
+- assertVisible: "Home"
 - assertVisible:
     id: "home_item_0_card"
 - assertVisible:

package/templates/ios/Skeleton/tests/02_tab_navigation.yaml

@@ -2,19 +2,14 @@ appId: ${APP_BUNDLE_ID}
 ---
 - clearState
 - launchApp
+- assertVisible: "Home"
+- tapOn: "Explore"
 - assertVisible:
-    id: "tab_bar_home"
-- tapOn:
-    id: "tab_bar_explore"
-- assertVisible:
-    id: "explore_category_0"
-- tapOn:
-    id: "tab_bar_favorites"
-- tapOn:
-    id: "tab_bar_profile"
+    id: "explore_search_field"
+- tapOn: "Favorites"
+- tapOn: "Profile"
 - assertVisible:
     id: "profile_avatar"
-- tapOn:
-    id: "tab_bar_home"
+- tapOn: "Home"
 - assertVisible:
     id: "home_item_0_card"

package/templates/ios/Skeleton/tests/03_detail_screen.yaml

@@ -0,0 +1,20 @@
+appId: ${APP_BUNDLE_ID}
+---
+- clearState
+- launchApp
+- assertVisible: "Home"
+- extendedWaitUntil:
+    visible:
+        id: "home_item_0_card"
+    timeout: 10000
+- tapOn:
+    id: "home_item_0_card"
+- assertVisible:
+    id: "detail_title"
+- assertVisible:
+    id: "detail_description"
+- assertVisible:
+    id: "detail_favorite_button"
+- tapOn:
+    id: "detail_favorite_button"
+- back

package/templates/ios/Skeleton/tests/04_favorites.yaml

@@ -0,0 +1,17 @@
+appId: ${APP_BUNDLE_ID}
+---
+- clearState
+- launchApp
+- assertVisible: "Home"
+- extendedWaitUntil:
+    visible:
+        id: "home_item_0_card"
+    timeout: 10000
+# Favorite an item first
+- tapOn:
+    id: "home_item_0_card"
+- tapOn:
+    id: "detail_favorite_button"
+- back
+# Check favorites tab has the item
+- tapOn: "Favorites"

package/templates/ios/Skeleton/tests/05_explore_search.yaml

@@ -0,0 +1,12 @@
+appId: ${APP_BUNDLE_ID}
+---
+- clearState
+- launchApp
+- tapOn: "Explore"
+- assertVisible:
+    id: "explore_search_field"
+- tapOn:
+    id: "explore_search_field"
+- inputText: "Test Query"
+- assertVisible:
+    id: "explore_search_field"

package/templates/ios/Skeleton/tests/06_create_item.yaml

@@ -0,0 +1,19 @@
+appId: ${APP_BUNDLE_ID}
+---
+- clearState
+- launchApp
+- tapOn:
+    id: "home_create_button"
+- assertVisible:
+    id: "create_title_field"
+- tapOn:
+    id: "create_title_field"
+- inputText: "Test Item"
+- tapOn:
+    id: "create_subtitle_field"
+- inputText: "Test Subtitle"
+- tapOn:
+    id: "create_description_field"
+- inputText: "Test Description"
+- assertVisible:
+    id: "create_save_button"

package/templates/ios/Skeleton/tests/07_profile.yaml

@@ -0,0 +1,17 @@
+appId: ${APP_BUNDLE_ID}
+---
+- clearState
+- launchApp
+- tapOn: "Profile"
+- assertVisible:
+    id: "profile_avatar"
+- assertVisible:
+    id: "profile_name"
+- assertVisible:
+    id: "profile_email"
+- assertVisible:
+    id: "profile_notifications"
+- assertVisible:
+    id: "profile_appearance"
+- assertVisible:
+    id: "profile_version"

package/templates/ios/Skeleton/tests/08_full_e2e.yaml

@@ -0,0 +1,36 @@
+appId: ${APP_BUNDLE_ID}
+---
+- clearState
+- launchApp
+# Home tab
+- assertVisible: "Home"
+- extendedWaitUntil:
+    visible:
+        id: "home_item_0_card"
+    timeout: 10000
+# Detail from home
+- tapOn:
+    id: "home_item_0_card"
+- assertVisible:
+    id: "detail_title"
+- tapOn:
+    id: "detail_favorite_button"
+- back
+# Explore tab
+- tapOn: "Explore"
+- assertVisible:
+    id: "explore_search_field"
+- tapOn:
+    id: "explore_search_field"
+- inputText: "Sample"
+- pressKey: Enter
+# Favorites tab
+- tapOn: "Favorites"
+# Profile tab
+- tapOn: "Profile"
+- assertVisible:
+    id: "profile_avatar"
+- assertVisible:
+    id: "profile_name"
+# Create flow
+- tapOn: "Home"

package/templates/ios/SocialTemplate/SocialTemplate/App/AppConfig.swift

@@ -83,6 +83,15 @@ struct AppConfig {
             ("Create", "Express yourself through posts and stories", "sparkles")
         ]
     }
+    
+    // CUSTOMIZE:DATASOURCE
+    enum DataSource {
+        enum SourceType {
+            case localStorage
+            case mock
+        }
+        static let active: SourceType = .mock
+    }
 }
 
 // MARK: - App State

package/templates/ios/SocialTemplate/SocialTemplate/Core/EmptyStateView.swift

@@ -0,0 +1,145 @@
+import SwiftUI
+
+// MARK: - Empty State View
+/// Reusable empty state view with illustration, title, subtitle, and optional CTA button.
+/// Used when a list or screen has no content to display.
+struct EmptyStateView: View {
+    let config: EmptyStateConfig
+
+    var body: some View {
+        VStack(spacing: AppConfig.Theme.Spacing.lg) {
+            // Icon/Illustration
+            if let iconName = config.iconName {
+                Image(systemName: iconName)
+                    .font(.system(size: 64))
+                    .foregroundStyle(config.iconColor ?? AppConfig.Theme.primaryColor)
+                    .accessibilityIdentifier("empty_state_icon")
+            }
+
+            // Title
+            Text(config.title)
+                .font(AppConfig.Theme.Typography.title2)
+                .multilineTextAlignment(.center)
+                .accessibilityIdentifier("empty_state_title")
+
+            // Subtitle
+            if let subtitle = config.subtitle {
+                Text(subtitle)
+                    .font(AppConfig.Theme.Typography.body)
+                    .foregroundStyle(.secondary)
+                    .multilineTextAlignment(.center)
+                    .accessibilityIdentifier("empty_state_subtitle")
+            }
+
+            // CTA Button
+            if let buttonTitle = config.buttonTitle,
+               let buttonAction = config.buttonAction {
+                Button {
+                    buttonAction()
+                } label: {
+                    Text(buttonTitle)
+                        .font(AppConfig.Theme.Typography.headline)
+                        .frame(maxWidth: .infinity)
+                        .padding(.vertical, AppConfig.Theme.Spacing.sm)
+                }
+                .buttonStyle(.borderedProminent)
+                .accessibilityIdentifier("empty_state_button")
+            }
+        }
+        .padding(AppConfig.Theme.Spacing.lg)
+        .frame(maxWidth: .infinity, maxHeight: .infinity)
+    }
+}
+
+// MARK: - Empty State Config
+struct EmptyStateConfig {
+    let title: String
+    let subtitle: String?
+    let iconName: String?
+    let iconColor: Color?
+    let buttonTitle: String?
+    let buttonAction: (() -> Void)?
+
+    init(
+        title: String,
+        subtitle: String? = nil,
+        iconName: String? = nil,
+        iconColor: Color? = nil,
+        buttonTitle: String? = nil,
+        buttonAction: (() -> Void)? = nil
+    ) {
+        self.title = title
+        self.subtitle = subtitle
+        self.iconName = iconName
+        self.iconColor = iconColor
+        self.buttonTitle = buttonTitle
+        self.buttonAction = buttonAction
+    }
+}
+
+// MARK: - Preset Empty States
+extension EmptyStateConfig {
+    /// No results found (search, filter)
+    static func noResults(searchQuery: String? = nil) -> EmptyStateConfig {
+        EmptyStateConfig(
+            title: Strings.EmptyStates.noResultsTitle,
+            subtitle: searchQuery.map { Strings.EmptyStates.noResultsSubtitle($0) },
+            iconName: "magnifyingglass",
+            iconColor: .secondary
+        )
+    }
+
+    /// No items in list
+    static func noItems(
+        message: String? = nil,
+        onAdd: (() -> Void)? = nil
+    ) -> EmptyStateConfig {
+        EmptyStateConfig(
+            title: Strings.EmptyStates.noItemsTitle,
+            subtitle: message ?? Strings.EmptyStates.noItemsSubtitle,
+            iconName: "tray",
+            iconColor: .secondary,
+            buttonTitle: onAdd != nil ? Strings.EmptyStates.addItemButton : nil,
+            buttonAction: onAdd
+        )
+    }
+
+    /// No favorites/bookmarks
+    static func noFavorites(onBrowse: (() -> Void)? = nil) -> EmptyStateConfig {
+        EmptyStateConfig(
+            title: Strings.EmptyStates.noFavoritesTitle,
+            subtitle: Strings.EmptyStates.noFavoritesSubtitle,
+            iconName: "heart",
+            iconColor: .pink,
+            buttonTitle: onBrowse != nil ? Strings.EmptyStates.browseButton : nil,
+            buttonAction: onBrowse
+        )
+    }
+
+    /// No internet connection
+    static func noConnection(onRetry: @escaping () -> Void) -> EmptyStateConfig {
+        EmptyStateConfig(
+            title: Strings.EmptyStates.noConnectionTitle,
+            subtitle: Strings.EmptyStates.noConnectionSubtitle,
+            iconName: "wifi.slash",
+            iconColor: .orange,
+            buttonTitle: Strings.EmptyStates.retryButton,
+            buttonAction: onRetry
+        )
+    }
+}
+
+// MARK: - Helper Extension
+extension EmptyStateConfig {
+    /// Add a custom button to an existing config
+    func withButton(title: String, action: @escaping () -> Void) -> EmptyStateConfig {
+        EmptyStateConfig(
+            title: self.title,
+            subtitle: self.subtitle,
+            iconName: self.iconName,
+            iconColor: self.iconColor,
+            buttonTitle: title,
+            buttonAction: action
+        )
+    }
+}

package/templates/ios/SocialTemplate/SocialTemplate/Core/Strings.swift

@@ -0,0 +1,21 @@
+import Foundation
+
+// MARK: - Strings
+/// Root enum for all string extensions.
+/// Each feature module extends this enum with its own nested enum.
+enum Strings {
+    // MARK: - Empty States
+    enum EmptyStates {
+        static let noResultsTitle = "No Results Found"
+        static func noResultsSubtitle(_ query: String) -> String { "We couldn't find anything matching \"\(query)\"" }
+        static let noItemsTitle = "Nothing Here Yet"
+        static let noItemsSubtitle = "Get started by adding your first item"
+        static let addItemButton = "Add Item"
+        static let noFavoritesTitle = "No Favorites Yet"
+        static let noFavoritesSubtitle = "Items you favorite will appear here"
+        static let browseButton = "Browse"
+        static let noConnectionTitle = "No Internet Connection"
+        static let noConnectionSubtitle = "Please check your connection and try again"
+        static let retryButton = "Retry"
+    }
+}

package/templates/ios/SocialTemplate/SocialTemplate/Data/DataSourceResolver.swift

@@ -11,8 +11,7 @@ enum DataSourceResolver {
     static var repository: any DataRepository {
         switch AppConfig.DataSource.active {
         case .localStorage:
-            // TODO: Return LocalStorageProvider.shared once implemented
-            return MockDataProvider.shared
+            return LocalStorageProvider.shared
         case .mock:
             return MockDataProvider.shared
         }

package/templates/ios/SocialTemplate/SocialTemplate/Data/LocalStorage/CommentEntity.swift

@@ -0,0 +1,74 @@
+import CoreData
+import Foundation
+
+/// Core Data managed object for Comment persistence.
+@objc(CommentEntity)
+final class CommentEntity: NSManagedObject {
+    @NSManaged var id: String
+    @NSManaged var postId: String
+    @NSManaged var authorJSON: String
+    @NSManaged var content: String
+    @NSManaged var likeCount: Int32
+    @NSManaged var isLiked: Bool
+    @NSManaged var createdAt: Date?
+    @NSManaged var repliesJSON: String
+
+    // MARK: - Conversion
+
+    func toComment() -> Comment {
+        Comment(
+            id: id,
+            author: decodeAuthor(),
+            content: content,
+            likeCount: Int(likeCount),
+            isLiked: isLiked,
+            createdAt: createdAt ?? Date(),
+            replies: decodeReplies()
+        )
+    }
+
+    func update(from comment: Comment, postId: String) {
+        id = comment.id
+        self.postId = postId
+        authorJSON = encodeAuthor(comment.author)
+        content = comment.content
+        likeCount = Int32(comment.likeCount)
+        isLiked = comment.isLiked
+        createdAt = comment.createdAt
+        repliesJSON = encodeReplies(comment.replies)
+    }
+
+    // MARK: - JSON Helpers
+
+    private func decodeAuthor() -> User {
+        guard let data = authorJSON.data(using: .utf8),
+              let user = try? JSONDecoder().decode(User.self, from: data) else {
+            return User(id: "", username: "", displayName: "", followerCount: 0, followingCount: 0, postCount: 0, isVerified: false, isFollowing: false, isPrivate: false)
+        }
+        return user
+    }
+
+    private func encodeAuthor(_ user: User) -> String {
+        guard let data = try? JSONEncoder().encode(user),
+              let json = String(data: data, encoding: .utf8) else {
+            return "{}"
+        }
+        return json
+    }
+
+    private func decodeReplies() -> [Comment]? {
+        guard let data = repliesJSON.data(using: .utf8),
+              let replies = try? JSONDecoder().decode([Comment].self, from: data) else {
+            return nil
+        }
+        return replies.isEmpty ? nil : replies
+    }
+
+    private func encodeReplies(_ replies: [Comment]?) -> String {
+        guard let replies = replies, let data = try? JSONEncoder().encode(replies),
+              let json = String(data: data, encoding: .utf8) else {
+            return "[]"
+        }
+        return json
+    }
+}

package/templates/ios/SocialTemplate/SocialTemplate/Data/LocalStorage/ConversationEntity.swift

@@ -0,0 +1,76 @@
+import CoreData
+import Foundation
+
+/// Core Data managed object for Conversation persistence.
+@objc(ConversationEntity)
+final class ConversationEntity: NSManagedObject {
+    @NSManaged var id: String
+    @NSManaged var participantsJSON: String
+    @NSManaged var lastMessageJSON: String?
+    @NSManaged var unreadCount: Int32
+    @NSManaged var updatedAt: Date
+    @NSManaged var isGroup: Bool
+    @NSManaged var groupName: String?
+    @NSManaged var groupAvatarURL: String?
+
+    func toConversation() -> Conversation {
+        let participants = decodeParticipants()
+        let lastMessage = decodeLastMessage()
+        
+        return Conversation(
+            id: id,
+            participants: participants,
+            lastMessage: lastMessage,
+            unreadCount: Int(unreadCount),
+            updatedAt: updatedAt,
+            isGroup: isGroup,
+            groupName: groupName,
+            groupAvatarURL: groupAvatarURL
+        )
+    }
+
+    func update(from conversation: Conversation) {
+        id = conversation.id
+        participantsJSON = encodeParticipants(conversation.participants)
+        lastMessageJSON = encodeLastMessage(conversation.lastMessage)
+        unreadCount = Int32(conversation.unreadCount)
+        updatedAt = conversation.updatedAt
+        isGroup = conversation.isGroup
+        groupName = conversation.groupName
+        groupAvatarURL = conversation.groupAvatarURL
+    }
+
+    private func decodeParticipants() -> [User] {
+        guard let data = participantsJSON.data(using: .utf8),
+              let participants = try? JSONDecoder().decode([User].self, from: data) else {
+            return []
+        }
+        return participants
+    }
+
+    private func encodeParticipants(_ participants: [User]) -> String {
+        guard let data = try? JSONEncoder().encode(participants),
+              let json = String(data: data, encoding: .utf8) else {
+            return "[]"
+        }
+        return json
+    }
+
+    private func decodeLastMessage() -> Message? {
+        guard let lastMessageJSON = lastMessageJSON,
+              let data = lastMessageJSON.data(using: .utf8),
+              let message = try? JSONDecoder().decode(Message.self, from: data) else {
+            return nil
+        }
+        return message
+    }
+
+    private func encodeLastMessage(_ message: Message?) -> String? {
+        guard let message = message,
+              let data = try? JSONEncoder().encode(message),
+              let json = String(data: data, encoding: .utf8) else {
+            return nil
+        }
+        return json
+    }
+}