@shayanthenerd/eslint-config 0.32.0 → 0.33.0

package/dist/rules/html.mjs

@@ -55,7 +55,7 @@ function getHtmlRules(options) {
 		"@html-eslint/require-input-label": "error",
 		"@html-eslint/require-meta-viewport": "error"
 	};
-	if (isEnabled(stylistic)) Object.assign(htmlRules, {
+	const stylisticRules = {
 		"@html-eslint/attrs-newline": ["warn", {
 			maxLen: maxLineLength,
 			ifAttrsMoreThan: maxAttributesPerLine
@@ -78,7 +78,8 @@ function getHtmlRules(options) {
 			"double",
 			{ enforceTemplatedAttrValue: true }
 		]
-	});
+	};
+	if (isEnabled(stylistic)) Object.assign(htmlRules, stylisticRules);
 	if (isEnabled(tailwind)) htmlRules["better-tailwindcss/no-duplicate-classes"] = "off";
 	if (isEnabled(unicorn)) htmlRules["unicorn/no-invalid-file-input-accept"] = "error";
 	return htmlRules;

package/dist/rules/importX.mjs

@@ -2,7 +2,7 @@ import { isEnabled } from "../utils/isEnabled.mjs";
 import path from "node:path";
 //#region src/rules/importX.ts
 function getImportXRules(options) {
-	const { packageDir, configs: { typescript } } = options;
+	const { packageDir, configs: { unicorn, typescript } } = options;
 	const isTypescriptEnabled = isEnabled(typescript);
 	return {
 		"import-x/export": isTypescriptEnabled ? "off" : "error",
@@ -15,7 +15,7 @@ function getImportXRules(options) {
 		"import-x/no-mutable-exports": "error",
 		"import-x/no-named-as-default": "error",
 		"import-x/no-amd": "error",
-		"import-x/no-commonjs": "error",
+		"import-x/no-commonjs": isEnabled(unicorn) ? "off" : "error",
 		"import-x/no-import-module-exports": "error",
 		"import-x/named": isTypescriptEnabled ? "off" : "error",
 		"import-x/default": isTypescriptEnabled ? "off" : "error",

package/dist/rules/javascript.mjs

@@ -1,7 +1,8 @@
 import { isEnabled } from "../utils/isEnabled.mjs";
 //#region src/rules/javascript.ts
 function getJavaScriptRules(options) {
-	const { unicorn, typescript, javascript: { maxDepth, maxNestedCallbacks } } = options.configs;
+	const { importX, unicorn, typescript, javascript: { maxDepth, maxNestedCallbacks } } = options.configs;
+	const isImportXEnabled = isEnabled(importX);
 	const isUnicornEnabled = isEnabled(unicorn);
 	const isTypescriptEnabled = isEnabled(typescript);
 	return {
@@ -26,7 +27,7 @@ function getJavaScriptRules(options) {
 		"no-dupe-class-members": isTypescriptEnabled ? "off" : "error",
 		"no-dupe-else-if": "error",
 		"no-dupe-keys": isTypescriptEnabled ? "off" : "error",
-		"no-duplicate-case": "error",
+		"no-duplicate-case": isImportXEnabled ? "off" : "error",
 		"no-duplicate-imports": ["error", {
 			includeExports: true,
 			allowSeparateTypeImports: true
@@ -190,7 +191,7 @@ function getJavaScriptRules(options) {
 		"no-useless-call": "error",
 		"no-useless-catch": "error",
 		"no-useless-computed-key": "error",
-		"no-useless-concat": "error",
+		"no-useless-concat": isUnicornEnabled ? "error" : "off",
 		"no-useless-constructor": "error",
 		"no-useless-escape": "error",
 		"no-useless-rename": "error",
@@ -200,7 +201,7 @@ function getJavaScriptRules(options) {
 		"no-with": "error",
 		"object-shorthand": "warn",
 		"operator-assignment": "warn",
-		"prefer-arrow-callback": ["warn", { allowUnboundThis: true }],
+		"prefer-arrow-callback": "warn",
 		"prefer-const": "error",
 		"prefer-destructuring": isTypescriptEnabled ? "off" : ["warn", {
 			object: true,
@@ -214,7 +215,7 @@ function getJavaScriptRules(options) {
 		"prefer-promise-reject-errors": isTypescriptEnabled ? "off" : ["warn", { allowEmptyReject: true }],
 		"prefer-regex-literals": ["warn", { disallowRedundantWrapping: true }],
 		"prefer-rest-params": "warn",
-		"prefer-spread": "warn",
+		"prefer-spread": isUnicornEnabled ? "warn" : "off",
 		"prefer-template": "warn",
 		"preserve-caught-error": "warn",
 		"radix": "warn",

package/dist/rules/next.mjs

@@ -4,6 +4,7 @@ const nextRules = {
 	"next/google-font-preconnect": "warn",
 	"next/inline-script-id": "error",
 	"next/next-script-for-ga": "warn",
+	"next/no-assign-module-variable": "error",
 	"next/no-async-client-component": "error",
 	"next/no-before-interactive-script-outside-document": "error",
 	"next/no-css-tags": "warn",
@@ -13,6 +14,7 @@ const nextRules = {
 	"next/no-head-import-in-document": "error",
 	"next/no-html-link-for-pages": "warn",
 	"next/no-img-element": "warn",
+	"next/no-location-assign-relative-destination": "error",
 	"next/no-page-custom-font": "warn",
 	"next/no-script-component-in-head": "error",
 	"next/no-styled-jsx-in-document": "error",

package/dist/rules/node.mjs

@@ -11,7 +11,7 @@ function getNodeRules(options) {
 		"n/no-path-concat": "error",
 		"n/no-process-env": ["error", { allowedVariables: ["NODE_ENV"] }],
 		"n/no-process-exit": "error",
-		"n/no-sync": "warn",
+		"n/no-sync": isEnabled(typescript) ? "warn" : "off",
 		"n/no-unpublished-import": "error",
 		"n/no-unsupported-features/es-builtins": "error",
 		"n/no-unsupported-features/es-syntax": "error",

package/dist/rules/packageJson.mjs

@@ -1,157 +1,170 @@
+import { defaultOptions } from "../helpers/options/defaultOptions.mjs";
+import { isEnabled } from "../utils/isEnabled.mjs";
 //#region src/rules/packageJson.ts
-const packageJsonRules = {
-	"package-json/bin-name-casing": "warn",
-	"package-json/exports-subpaths-style": ["warn", { prefer: "implicit" }],
-	"package-json/no-empty-fields": "error",
-	"package-json/no-local-dependencies": "error",
-	"package-json/no-redundant-files": "error",
-	"package-json/no-redundant-publishConfig": "error",
-	"package-json/order-properties": "warn",
-	"package-json/repository-shorthand": "warn",
-	"package-json/require-attribution": ["warn", { ignorePrivate: true }],
-	"package-json/require-bugs": "warn",
-	"package-json/require-description": ["warn", { ignorePrivate: true }],
-	"package-json/require-devEngines": "warn",
-	"package-json/require-engines": ["warn", { ignorePrivate: true }],
-	"package-json/require-exports": ["error", { ignorePrivate: true }],
-	"package-json/require-files": ["error", { ignorePrivate: true }],
-	"package-json/require-homepage": "warn",
-	"package-json/require-keywords": "warn",
-	"package-json/require-license": ["error", { ignorePrivate: true }],
-	"package-json/require-name": "error",
-	"package-json/require-repository": "warn",
-	"package-json/require-type": "warn",
-	"package-json/require-types": ["error", { ignorePrivate: true }],
-	"package-json/require-version": "error",
-	"package-json/restrict-dependency-ranges": ["warn", [{
-		forDependencyTypes: ["dependencies", "devDependencies"],
-		rangeType: "pin"
-	}, {
-		forDependencyTypes: ["peerDependencies", "optionalDependencies"],
-		rangeType: ["caret", "tilde"]
-	}]],
-	"package-json/restrict-private-properties": ["error", { blockedProperties: [
-		"files",
-		"publishConfig",
-		"keywords",
-		"funding"
-	] }],
-	"package-json/restrict-top-level-properties": ["warn", { ban: [
-		{
-			property: "bun",
-			message: "use bunfig.toml."
-		},
-		{
-			property: "pnpm",
-			message: "use pnpm-workspace.yaml."
-		},
-		{
-			property: "commitlint",
-			message: "use a dedicated config file."
-		},
-		{
-			property: "stylelint",
-			message: "use a dedicated config file."
-		},
-		{
-			property: "prettier",
-			message: "use a dedicated config file."
-		},
-		{
-			property: "renovate",
-			message: "use a dedicated config file."
-		}
-	] }],
-	"package-json/scripts-name-casing": "warn",
-	"package-json/sort-collections": ["warn", [
-		{
-			key: "author",
-			order: [
-				"name",
-				"email",
-				"url"
-			]
-		},
-		{
-			key: "bugs",
-			order: ["email", "url"]
-		},
-		"config",
-		"dependencies",
-		"devEngines",
-		"devDependencies",
-		"directories",
-		{
-			key: "dist",
-			order: ["shasum", "tarball"]
-		},
-		"engines",
-		"exports",
-		"husky",
-		"husky.hooks",
-		"lint-staged",
-		"nano-staged",
-		"optionalDependencies",
-		"overrides",
-		"peerDependencies",
-		"peerDependenciesMeta",
-		{
-			key: "repository",
-			order: [
-				"type",
-				"url",
-				"directory"
-			]
-		},
-		"release",
-		"simple-git-hooks"
-	]],
-	"package-json/specify-peers-locally": "warn",
-	"package-json/unique-dependencies": "error",
-	"package-json/valid-author": "error",
-	"package-json/valid-bin": "error",
-	"package-json/valid-browser": "error",
-	"package-json/valid-bugs": "error",
-	"package-json/valid-bundleDependencies": "error",
-	"package-json/valid-config": "error",
-	"package-json/valid-contributors": "error",
-	"package-json/valid-cpu": "error",
-	"package-json/valid-dependencies": "error",
-	"package-json/valid-description": "error",
-	"package-json/valid-devDependencies": "error",
-	"package-json/valid-devEngines": "error",
-	"package-json/valid-directories": "error",
-	"package-json/valid-engines": "error",
-	"package-json/valid-exports": "error",
-	"package-json/valid-files": "error",
-	"package-json/valid-funding": "error",
-	"package-json/valid-gypfile": "error",
-	"package-json/valid-homepage": "error",
-	"package-json/valid-keywords": "error",
-	"package-json/valid-libc": "error",
-	"package-json/valid-license": "error",
-	"package-json/valid-main": "error",
-	"package-json/valid-man": "error",
-	"package-json/valid-module": "error",
-	"package-json/valid-name": "error",
-	"package-json/valid-optionalDependencies": "error",
-	"package-json/valid-os": "error",
-	"package-json/valid-packageManager": "error",
-	"package-json/valid-peerDependencies": "error",
-	"package-json/valid-peerDependenciesMeta": "error",
-	"package-json/valid-peerDependenciesMeta-relationship": "error",
-	"package-json/valid-private": "error",
-	"package-json/valid-publishConfig": "error",
-	"package-json/valid-repository": "error",
-	"package-json/valid-repository-directory": "error",
-	"package-json/valid-scripts": "error",
-	"package-json/valid-sideEffects": "error",
-	"package-json/valid-type": "error",
-	"package-json/valid-version": "error",
-	"package-json/valid-workspaces": "error"
-};
-function getPackageJsonRules() {
-	return packageJsonRules;
+/**
+Using a wildcard to target all objects within an array isn't supported yet.
+@see https://github.com/michaelfaith/eslint-plugin-package-json/issues/1967
+*/
+const collectionSortPatterns = [
+	{
+		key: "author",
+		order: [
+			"name",
+			"email",
+			"url"
+		]
+	},
+	{
+		key: "bugs",
+		order: ["email", "url"]
+	},
+	"config",
+	"dependencies",
+	"devEngines",
+	"devDependencies",
+	"directories",
+	{
+		key: "dist",
+		order: ["shasum", "tarball"]
+	},
+	"engines",
+	"exports",
+	"husky",
+	"husky.hooks",
+	"lint-staged",
+	"nano-staged",
+	"optionalDependencies",
+	"overrides",
+	"peerDependencies",
+	"peerDependenciesMeta",
+	{
+		key: "repository",
+		order: [
+			"type",
+			"url",
+			"directory"
+		]
+	},
+	"release",
+	"simple-git-hooks"
+];
+function getPackageJsonRules(options) {
+	const { packageJson } = options.configs;
+	const { allowedDistTags: userUseAllowedDistTags, allowedDistTagsFor: userUseAllowedDistTagsFor } = isEnabled(packageJson) ? packageJson : defaultOptions.configs.packageJson;
+	return {
+		"package-json/bin-name-casing": "warn",
+		"package-json/exports-subpaths-style": ["warn", { prefer: "implicit" }],
+		"package-json/no-empty-fields": "error",
+		"package-json/no-local-dependencies": "error",
+		"package-json/no-redundant-files": "error",
+		"package-json/no-redundant-publishConfig": "error",
+		"package-json/order-properties": "warn",
+		"package-json/repository-shorthand": "warn",
+		"package-json/require-attribution": "warn",
+		"package-json/require-package-json-export": "error",
+		"package-json/require-bugs": "warn",
+		"package-json/require-description": ["warn", { ignorePrivate: true }],
+		"package-json/require-devEngines": "warn",
+		"package-json/require-engines": ["warn", { ignorePrivate: true }],
+		"package-json/require-exports": ["error", { ignorePrivate: true }],
+		"package-json/require-files": ["error", { ignorePrivate: true }],
+		"package-json/require-homepage": "warn",
+		"package-json/require-keywords": "warn",
+		"package-json/require-license": ["error", { ignorePrivate: true }],
+		"package-json/require-name": "error",
+		"package-json/require-repository": "warn",
+		"package-json/require-type": "warn",
+		"package-json/require-types": ["error", { ignorePrivate: true }],
+		"package-json/require-version": "error",
+		"package-json/restrict-dependency-ranges": ["warn", [{
+			forDependencyTypes: ["dependencies", "devDependencies"],
+			rangeType: "pin"
+		}, {
+			forDependencyTypes: ["peerDependencies", "optionalDependencies"],
+			rangeType: ["caret", "tilde"]
+		}]],
+		"package-json/restrict-dist-tags": ["warn", {
+			allowed: userUseAllowedDistTags,
+			allowedFor: userUseAllowedDistTagsFor
+		}],
+		"package-json/restrict-private-properties": ["error", { blockedProperties: [
+			"files",
+			"publishConfig",
+			"keywords",
+			"funding"
+		] }],
+		"package-json/restrict-top-level-properties": ["warn", { ban: [
+			{
+				property: "bun",
+				message: "use bunfig.toml."
+			},
+			{
+				property: "pnpm",
+				message: "use pnpm-workspace.yaml."
+			},
+			{
+				property: "commitlint",
+				message: "use a dedicated config file."
+			},
+			{
+				property: "stylelint",
+				message: "use a dedicated config file."
+			},
+			{
+				property: "prettier",
+				message: "use a dedicated config file."
+			},
+			{
+				property: "renovate",
+				message: "use a dedicated config file."
+			}
+		] }],
+		"package-json/scripts-name-casing": "warn",
+		"package-json/sort-collections": ["warn", collectionSortPatterns],
+		"package-json/specify-peers-locally": "warn",
+		"package-json/unique-dependencies": "error",
+		"package-json/valid-author": "error",
+		"package-json/valid-bin": "error",
+		"package-json/valid-browser": "error",
+		"package-json/valid-bugs": "error",
+		"package-json/valid-bundleDependencies": "error",
+		"package-json/valid-config": "error",
+		"package-json/valid-contributors": "error",
+		"package-json/valid-cpu": "error",
+		"package-json/valid-dependencies": "error",
+		"package-json/valid-description": "error",
+		"package-json/valid-devDependencies": "error",
+		"package-json/valid-devEngines": "error",
+		"package-json/valid-directories": "error",
+		"package-json/valid-engines": "error",
+		"package-json/valid-exports": "error",
+		"package-json/valid-files": "error",
+		"package-json/valid-funding": "error",
+		"package-json/valid-gypfile": "error",
+		"package-json/valid-homepage": "error",
+		"package-json/valid-keywords": "error",
+		"package-json/valid-libc": "error",
+		"package-json/valid-license": "error",
+		"package-json/valid-main": "error",
+		"package-json/valid-man": "error",
+		"package-json/valid-module": "error",
+		"package-json/valid-name": "error",
+		"package-json/valid-optionalDependencies": "error",
+		"package-json/valid-os": "error",
+		"package-json/valid-packageManager": "error",
+		"package-json/valid-peerDependencies": "error",
+		"package-json/valid-peerDependenciesMeta": "error",
+		"package-json/valid-peerDependenciesMeta-relationship": "error",
+		"package-json/valid-private": "error",
+		"package-json/valid-publishConfig": "error",
+		"package-json/valid-repository": "error",
+		"package-json/valid-repository-directory": "error",
+		"package-json/valid-scripts": "error",
+		"package-json/valid-sideEffects": "error",
+		"package-json/valid-type": "error",
+		"package-json/valid-version": "error",
+		"package-json/valid-workspaces": "error"
+	};
 }
 //#endregion
 export { getPackageJsonRules };

package/dist/rules/perfectionist.mjs

@@ -69,20 +69,47 @@ const sortArrayIncludesOptions = {
 		"unknown"
 	]
 };
-const sortImportsCustomGroups = [{
-	groupName: "component",
-	elementNamePattern: ["\\.(vue|[jt]sx)$"],
-	modifiers: ["value"]
-}, {
-	groupName: "image",
-	elementNamePattern: ["\\.(ico|svg|gif|png|jpe?g|webp|avif|heic)$"]
-}];
+const componentPattern = ["\\.([jt]sx|astro|vue)$"];
+const sortImportsCustomGroups = [
+	{
+		groupName: "component-subpath",
+		elementNamePattern: componentPattern,
+		modifiers: ["value"],
+		selector: "subpath"
+	},
+	{
+		groupName: "component-tsconfig-path",
+		elementNamePattern: componentPattern,
+		modifiers: ["value"],
+		selector: "tsconfig-path"
+	},
+	{
+		groupName: "component-internal",
+		elementNamePattern: componentPattern,
+		modifiers: ["value"],
+		selector: "internal"
+	},
+	{
+		groupName: "component",
+		elementNamePattern: componentPattern,
+		modifiers: ["value"]
+	},
+	{
+		groupName: "image",
+		elementNamePattern: ["\\.(apng|avif|bmp|gif|heic|heif|ico|jfif|jpe?g|jxl|pjpeg|png|svgz?|tiff?|webp)$"]
+	}
+];
 const sortImportsGroups = [
 	["style", "side-effect-style"],
 	{ newlinesBetween: 0 },
 	"side-effect",
 	"image",
-	"component",
+	[
+		"component-subpath",
+		"component-tsconfig-path",
+		"component-internal",
+		"component"
+	],
 	"type-external",
 	{ newlinesBetween: 0 },
 	"type-builtin",
@@ -98,10 +125,13 @@ const sortImportsGroups = [
 	"external",
 	{ newlinesBetween: 0 },
 	"builtin",
-	["tsconfig-path", "subpath"],
+	[
+		"subpath",
+		"tsconfig-path",
+		"internal"
+	],
 	{ newlinesBetween: 0 },
 	[
-		"internal",
 		"parent",
 		"index",
 		"sibling"

package/dist/rules/playwright.mjs

@@ -2,9 +2,11 @@
 function getPlaywrightRules(options) {
 	const { maxNestedDescribe } = options.configs.test;
 	return {
+		"playwright/consistent-spacing-between-blocks": "warn",
 		"playwright/expect-expect": "error",
 		"playwright/max-nested-describe": ["warn", { max: maxNestedDescribe }],
 		"playwright/missing-playwright-await": ["error", { includePageLocatorMethods: true }],
+		"playwright/no-action-timeout": "warn",
 		"playwright/no-commented-out-tests": "error",
 		"playwright/no-conditional-expect": "error",
 		"playwright/no-conditional-in-test": "error",
@@ -12,24 +14,31 @@ function getPlaywrightRules(options) {
 		"playwright/no-duplicate-slow": "error",
 		"playwright/no-element-handle": "warn",
 		"playwright/no-eval": "error",
+		"playwright/no-export": "error",
 		"playwright/no-focused-test": "error",
 		"playwright/no-force-option": "warn",
 		"playwright/no-get-by-title": "warn",
+		"playwright/no-identical-title": "error",
+		"playwright/no-magic-timeouts": "warn",
 		"playwright/no-nested-step": "warn",
 		"playwright/no-networkidle": "error",
+		"playwright/no-nth-methods": "warn",
 		"playwright/no-page-pause": "error",
 		"playwright/no-raw-locators": "warn",
 		"playwright/no-skipped-test": "error",
 		"playwright/no-slowed-test": "warn",
 		"playwright/no-standalone-expect": "error",
+		"playwright/no-test-return-statement": "error",
 		"playwright/no-unnecessary-assertions": "error",
 		"playwright/no-unsafe-references": "error",
 		"playwright/no-unused-locators": "warn",
 		"playwright/no-useless-await": "warn",
 		"playwright/no-useless-not": "warn",
+		"playwright/no-wait-for-navigation": "error",
 		"playwright/no-wait-for-selector": "warn",
 		"playwright/no-wait-for-timeout": "error",
 		"playwright/prefer-comparison-matcher": "warn",
+		"playwright/prefer-ending-with-an-expect": "warn",
 		"playwright/prefer-equality-matcher": "warn",
 		"playwright/prefer-hooks-in-order": "warn",
 		"playwright/prefer-hooks-on-top": "warn",
@@ -42,6 +51,7 @@ function getPlaywrightRules(options) {
 		"playwright/prefer-to-have-count": "warn",
 		"playwright/prefer-to-have-length": "warn",
 		"playwright/prefer-web-first-assertions": "warn",
+		"playwright/require-annotation-reason": "warn",
 		"playwright/require-hook": "error",
 		"playwright/require-to-pass-timeout": "error",
 		"playwright/require-to-throw-message": "error",