@shakesco/silent 1.1.0 → 1.1.2

package/README.md

@@ -207,8 +207,4 @@ function main() {
 
 The receiver can use `private_key` to spend the funds!
 
-Thats it! 🎊🎊🎊
-
-### Contribute
-
-If you love what we do to progress privacy, [contribute](https://donate.shakesco.com/@shakesco.sns "shakesco_donate") to further development
+Thats it! 🎊🎊🎊

package/classes/CreateOutput.js

@@ -200,7 +200,7 @@ class SilentPaymentBuilder {
     const matches = {};
     var k = 0;
 
-    do {
+    while (outputsToCheck.length > 0) {
       const t_k = taggedHash(
         Buffer.concat([
           Buffer.from(ecdhSharedSecret.encodeCompressed(), "array"),
@@ -210,9 +210,11 @@ class SilentPaymentBuilder {
       );
 
       const P_k = tweakAddPublic(B_spend, t_k);
-      const length = outputsToCheck.length;
 
-      for (var i = 0; i < length; i++) {
+      let i = 0;
+      let foundMatch = false;
+
+      while (i < outputsToCheck.length) {
         const output = outputsToCheck[i].script.slice(4);
         const outputPubkey = output.toString("hex");
         const outputAmount = Number(outputsToCheck[i].value);
@@ -235,10 +237,14 @@ class SilentPaymentBuilder {
 
           outputsToCheck.splice(i, 1);
           k++;
+          foundMatch = true;
           break;
         }
 
-        if (precomputedLabels != null && precomputedLabels.isNotEmpty) {
+        if (
+          precomputedLabels != null &&
+          Object.keys(precomputedLabels).length > 0
+        ) {
           var m_G_sub = tweakAddPublic(
             ec.keyFromPublic(Buffer.from(output, "hex")).getPublic(),
             pubNegate(P_k)
@@ -277,17 +283,19 @@ class SilentPaymentBuilder {
 
             outputsToCheck.splice(i, 1);
             k++;
+            foundMatch = true;
             break;
           }
         }
 
-        outputsToCheck.splice(i, 1);
+        i++;
+      }
 
-        if (i + 1 >= outputsToCheck.length) {
-          break;
-        }
+      // If we went through all outputs without finding a match, we're done
+      if (!foundMatch) {
+        break;
       }
-    } while (outputsToCheck.isNotEmpty);
+    }
 
     return matches;
   }

package/package.json

@@ -1,13 +1,13 @@
 {
   "name": "@shakesco/silent",
-  "version": "1.1.0",
+  "version": "1.1.2",
   "description": "Bitcoin Silent Payments",
   "main": "index.js",
   "author": "Shawn Kimtai",
   "license": "MIT",
   "keywords": [
     "shakesco",
-    "shakespay",
+    "payments",
     "private",
     "bitcoin",
     "silent payments",