@sfqa/scar 0.1.0 → 0.1.1

package/CHANGELOG.md

@@ -5,7 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project aims to follow [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.1.0] - 2026-05
+## [0.1.1] - 2026-11-15
+
+### Changed
+- ST-004 wording now says what Playwright does: the `timeout` option on `isVisible()` is ignored and the call returns instantly (it previously said the method takes no options).
+- The shipped ST-008 example identifier shape and the fixtures that use it are now a neutral `SKU-A12-0042` shape instead of an organisation-specific one; replace it with your own.
+- Page-object names in the ST-013 example pattern are generic (`OrderPage`, `ItemPage`).
+
+## [0.1.0] - 2026-11-14
 
 ### Added
 - Dependency-free CLI (`sfqa-scar`) for Node >= 20: `scan`, `new`, `prove`, and `harvest`.

package/README.md

@@ -14,7 +14,7 @@ npx sfqa-scar .                 # scan with the shipped template (or your scar-t
 ```
 
 ```text
-[HIGH] ST-004 - Never pass options to isVisible() - it takes none and returns instantly. Use waitFor({ state: 'visible', timeout }) when render timing matters.
+[HIGH] ST-004 - Never pass a timeout to isVisible() - the option is ignored and the call returns instantly. Use waitFor({ state: 'visible', timeout }) when render timing matters.
   where  : test-pages/web/LeadPage.ts:212
   matched: const visible = await label.isVisible({ timeout: 5000 });
   context: All Playwright page objects (test-pages/web/**), field readers and verification helpers reading Lightning labels.
@@ -72,7 +72,7 @@ incident, because the incident is the part you already know:
 That paragraph is the whole job. It becomes a rule like this:
 
 ```bash
-npx sfqa-scar new --rule "Never pass options to isVisible() - it takes none" --scope "test-pages/**"
+npx sfqa-scar new --rule "Never pass a timeout to isVisible() - it is ignored" --scope "test-pages/**"
 ```
 
 which writes three files: the rule entry, one fixture that must match, and one
@@ -477,7 +477,7 @@ that you replace:
 | Detector input | Shipped example | Replace with |
 |---|---|---|
 | `labelRules.canonical` | `Web`, `Event`, `Referral`, `Phone`, `Email`, `SMS` | the exact labels your org renders |
-| inventory-code shape | `Project-B2-03-04` | the identifier shape your product uses |
+| inventory-code shape | `SKU-A12-0042` | the identifier shape your product uses |
 | local-only file patterns | `local-notes-*.md`, `*.zip` | the paths your team keeps local |
 | timeout ceiling | `< 360000` ms | your measured longest journey, minus headroom |
 
@@ -668,7 +668,7 @@ your stack, delete it rather than leave it in the file.
 | ST-001 | high | Never hardcode credentials, tokens or secrets in code, config fallbacks or committed `.env` files. |
 | ST-002 | high | Each environment config reads its own environment's variables, never a sibling's. |
 | ST-003 | high | Picklist values match the Salesforce label exactly: case, spaces, hyphens. |
-| ST-004 | high | `isVisible()` takes no options; use `waitFor({ state: 'visible' })`. |
+| ST-004 | high | `isVisible()` ignores any `timeout`; use `waitFor({ state: 'visible' })`. |
 | ST-005 | med | Never treat a success toast as the only success signal. |
 | ST-006 | med | Record navigation tolerates Lightning URL variants; no single strict `waitForURL`. |
 | ST-007 | med | Server-side integration fields need periodic reload, not just a deadline poll. |
@@ -859,6 +859,6 @@ spread, the rule that could never fire, the detectors that were the problem).
 
 ## Status
 
-`0.1.0`. Dependency-free, Node >= 20, TypeScript types included. 18 of 19 rules
+`0.1.1`. Dependency-free, Node >= 20, TypeScript types included. 18 of 19 rules
 have a machine detector and are proven both ways; the 19th is a documented gap.
 The public proof runs on synthetic fixtures, not a field trial. MIT licensed.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sfqa/scar",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "Review code against a Salesforce test suite's scar tissue: past failures, encoded as declarative rules.",
   "license": "MIT",
   "author": "Vaishali Desarda",
@@ -20,7 +20,7 @@
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "bin": {
-    "sfqa-scar": "./dist/cli.js"
+    "sfqa-scar": "dist/cli.js"
   },
   "exports": {
     ".": {

package/rules/generic.json

@@ -101,7 +101,7 @@
     },
     {
       "id": "ST-004",
-      "rule": "Never pass options to isVisible() - it takes none and returns instantly. Use waitFor({ state: 'visible', timeout }) when render timing matters.",
+      "rule": "Never pass a timeout to isVisible() - the option is ignored and the call returns instantly. Use waitFor({ state: 'visible', timeout }) when render timing matters.",
       "context": "All Playwright page objects (test-pages/web/**), field readers and verification helpers reading Lightning labels.",
       "origin": {
         "commit": null,
@@ -220,7 +220,7 @@
         "summary": "Smoke scenarios pinned concrete inventory codes; each green run CONSUMED the record and the next run failed on 'not available'. The fix introduced a sentinel so the product's search picks the freshest eligible row at runtime."
       },
       "severity": "high",
-      "detection_pattern": "Concrete inventory codes in feature tables or step expectations. The shape below is an EXAMPLE (project-floor-unit); replace it with your org's identifier shape.",
+      "detection_pattern": "Concrete inventory codes in feature tables or step expectations. The shape below is an EXAMPLE (SKU-bin-number); replace it with your org's identifier shape.",
       "match": {
         "pathInclude": [
           "features/**",
@@ -230,7 +230,7 @@
           "**/node_modules/**"
         ],
         "linePatterns": [
-          "[A-Za-z][A-Za-z0-9]*-(?:B|T)\\d{1,2}-\\d{1,2}-\\d{1,2}"
+          "\\bSKU-[A-Z]\\d{1,2}-\\d{3,5}\\b"
         ]
       },
       "recommendation": "Use a sentinel (e.g. AUTO) resolved by an availability-aware search with deterministic tie-breaking, logging what was actually selected."
@@ -358,7 +358,7 @@
           "**/node_modules/**"
         ],
         "linePatterns": [
-          "new\\s+(?:LeadPage|OpportunityPage|SalesOrderPage|HomePage|UnitPage)\\(\\s*page\\s*,"
+          "new\\s+(?:LeadPage|OpportunityPage|OrderPage|HomePage|ItemPage)\\(\\s*page\\s*,"
         ],
         "fileExemptSignals": [
           "activePage"