@sfdxy/mule-lint 1.20.0 → 1.21.0

package/dist/src/rules/error-handling/CatchAllLastRule.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"CatchAllLastRule.d.ts","sourceRoot":"","sources":["../../../../src/rules/error-handling/CatchAllLastRule.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,KAAK,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAClE,OAAO,EAAE,QAAQ,EAAE,MAAM,kBAAkB,CAAC;AAE5C;;;;;;;;;GASG;AACH,qBAAa,gBAAiB,SAAQ,QAAQ;IAC5C,EAAE,SAAa;IACf,IAAI,SAA4B;IAChC,WAAW,SAC8E;IACzF,QAAQ,EAAG,OAAO,CAAU;IAC5B,QAAQ,EAAG,gBAAgB,CAAU;IACrC,SAAS,EAAE,SAAS,CAAS;IAE7B,OAAO,CAAC,QAAQ,CAAC,eAAe,CAAuB;IAEvD,QAAQ,CAAC,GAAG,EAAE,QAAQ,EAAE,QAAQ,EAAE,iBAAiB,GAAG,KAAK,EAAE;IAkD7D,OAAO,CAAC,kBAAkB;CAU3B"}

package/dist/src/rules/error-handling/CatchAllLastRule.js

@@ -0,0 +1,65 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CatchAllLastRule = void 0;
+const BaseRule_1 = require("../base/BaseRule");
+/**
+ * ERR-004: Catch-All Must Be Last
+ *
+ * When type="ANY" (or no type attribute — implicit catch-all) is used in
+ * an error handler, it must be the last on-error block. Placing a catch-all
+ * before specific error types makes those specific handlers unreachable.
+ *
+ * Real-world pattern from accelerators: type="ANY" is always the final
+ * on-error-propagate, typically mapping to HTTP 500.
+ */
+class CatchAllLastRule extends BaseRule_1.BaseRule {
+    id = 'ERR-004';
+    name = 'Catch-All Must Be Last';
+    description = 'type="ANY" or implicit catch-all must be the last on-error block in an error handler';
+    severity = 'error';
+    category = 'error-handling';
+    issueType = 'bug';
+    CATCH_ALL_TYPES = ['ANY', 'MULE:ANY'];
+    validate(doc, _context) {
+        const issues = [];
+        const errorHandlers = this.select('//mule:error-handler', doc);
+        for (const handler of errorHandlers) {
+            // Collect all on-error-* children in document order
+            const children = this.select('./*[local-name()="on-error-continue" or local-name()="on-error-propagate"]', handler);
+            if (children.length <= 1) {
+                continue; // Single handler — nothing to check
+            }
+            // Check each child except the last
+            for (let i = 0; i < children.length - 1; i++) {
+                const child = children[i];
+                const typeAttr = this.getAttribute(child, 'type');
+                const isCatchAll = typeAttr === null ||
+                    typeAttr === undefined ||
+                    typeAttr.trim() === '' ||
+                    this.CATCH_ALL_TYPES.includes(typeAttr.trim().toUpperCase());
+                if (isCatchAll) {
+                    const handlerName = this.getAttribute(handler, 'name') ?? this.findParentFlowName(handler) ?? 'unnamed';
+                    const blockType = child.nodeName.includes('continue')
+                        ? 'on-error-continue'
+                        : 'on-error-propagate';
+                    issues.push(this.createIssue(child, `Catch-all ${blockType}${typeAttr ? ` (type="${typeAttr}")` : ''} is not the last handler in "${handlerName}" — subsequent handlers are unreachable`, {
+                        suggestion: 'Move the catch-all (type="ANY") block to be the last on-error handler',
+                    }));
+                }
+            }
+        }
+        return issues;
+    }
+    findParentFlowName(node) {
+        let current = node.parentNode;
+        while (current) {
+            if (current.nodeName === 'flow' || current.nodeName === 'mule:flow') {
+                return current.getAttribute('name');
+            }
+            current = current.parentNode;
+        }
+        return null;
+    }
+}
+exports.CatchAllLastRule = CatchAllLastRule;
+//# sourceMappingURL=CatchAllLastRule.js.map

package/dist/src/rules/error-handling/CatchAllLastRule.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"CatchAllLastRule.js","sourceRoot":"","sources":["../../../../src/rules/error-handling/CatchAllLastRule.ts"],"names":[],"mappings":";;;AACA,+CAA4C;AAE5C;;;;;;;;;GASG;AACH,MAAa,gBAAiB,SAAQ,mBAAQ;IAC5C,EAAE,GAAG,SAAS,CAAC;IACf,IAAI,GAAG,wBAAwB,CAAC;IAChC,WAAW,GACT,sFAAsF,CAAC;IACzF,QAAQ,GAAG,OAAgB,CAAC;IAC5B,QAAQ,GAAG,gBAAyB,CAAC;IACrC,SAAS,GAAc,KAAK,CAAC;IAEZ,eAAe,GAAG,CAAC,KAAK,EAAE,UAAU,CAAC,CAAC;IAEvD,QAAQ,CAAC,GAAa,EAAE,QAA2B;QACjD,MAAM,MAAM,GAAY,EAAE,CAAC;QAE3B,MAAM,aAAa,GAAG,IAAI,CAAC,MAAM,CAAC,sBAAsB,EAAE,GAAG,CAAC,CAAC;QAE/D,KAAK,MAAM,OAAO,IAAI,aAAa,EAAE,CAAC;YACpC,oDAAoD;YACpD,MAAM,QAAQ,GAAG,IAAI,CAAC,MAAM,CAC1B,4EAA4E,EAC5E,OAAmB,CACpB,CAAC;YAEF,IAAI,QAAQ,CAAC,MAAM,IAAI,CAAC,EAAE,CAAC;gBACzB,SAAS,CAAC,oCAAoC;YAChD,CAAC;YAED,mCAAmC;YACnC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC;gBAC7C,MAAM,KAAK,GAAG,QAAQ,CAAC,CAAC,CAAC,CAAC;gBAC1B,MAAM,QAAQ,GAAG,IAAI,CAAC,YAAY,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC;gBAElD,MAAM,UAAU,GACd,QAAQ,KAAK,IAAI;oBACjB,QAAQ,KAAK,SAAS;oBACtB,QAAQ,CAAC,IAAI,EAAE,KAAK,EAAE;oBACtB,IAAI,CAAC,eAAe,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC,CAAC;gBAE/D,IAAI,UAAU,EAAE,CAAC;oBACf,MAAM,WAAW,GACf,IAAI,CAAC,YAAY,CAAC,OAAO,EAAE,MAAM,CAAC,IAAI,IAAI,CAAC,kBAAkB,CAAC,OAAO,CAAC,IAAI,SAAS,CAAC;oBACtF,MAAM,SAAS,GAAG,KAAK,CAAC,QAAQ,CAAC,QAAQ,CAAC,UAAU,CAAC;wBACnD,CAAC,CAAC,mBAAmB;wBACrB,CAAC,CAAC,oBAAoB,CAAC;oBAEzB,MAAM,CAAC,IAAI,CACT,IAAI,CAAC,WAAW,CACd,KAAK,EACL,aAAa,SAAS,GAAG,QAAQ,CAAC,CAAC,CAAC,WAAW,QAAQ,IAAI,CAAC,CAAC,CAAC,EAAE,gCAAgC,WAAW,yCAAyC,EACpJ;wBACE,UAAU,EAAE,uEAAuE;qBACpF,CACF,CACF,CAAC;gBACJ,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO,MAAM,CAAC;IAChB,CAAC;IAEO,kBAAkB,CAAC,IAAU;QACnC,IAAI,OAAO,GAAgB,IAAI,CAAC,UAAU,CAAC;QAC3C,OAAO,OAAO,EAAE,CAAC;YACf,IAAI,OAAO,CAAC,QAAQ,KAAK,MAAM,IAAI,OAAO,CAAC,QAAQ,KAAK,WAAW,EAAE,CAAC;gBACpE,OAAQ,OAAmB,CAAC,YAAY,CAAC,MAAM,CAAC,CAAC;YACnD,CAAC;YACD,OAAO,GAAG,OAAO,CAAC,UAAU,CAAC;QAC/B,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;CACF;AAvED,4CAuEC"}

package/dist/src/rules/error-handling/ErrorHandlerTypeCoverageRule.d.ts

@@ -0,0 +1,28 @@
+import { ValidationContext, Issue, IssueType } from '../../types';
+import { BaseRule } from '../base/BaseRule';
+/**
+ * ERR-002: Error Handler Type Coverage
+ *
+ * SAPI error handlers should cover the standard APIKit error types
+ * (BAD_REQUEST, NOT_FOUND, METHOD_NOT_ALLOWED, NOT_ACCEPTABLE,
+ * UNSUPPORTED_MEDIA_TYPE) when an APIKit router is present.
+ *
+ * Inspired by real-world accelerator patterns where both Salesforce and
+ * NetSuite SAPIs consistently cover these types for proper HTTP status
+ * code mapping.
+ */
+export declare class ErrorHandlerTypeCoverageRule extends BaseRule {
+    id: string;
+    name: string;
+    description: string;
+    severity: "warning";
+    category: "error-handling";
+    issueType: IssueType;
+    /**
+     * Minimum set of APIKit error types that a well-structured SAPI should handle.
+     * These correspond to standard HTTP status codes that APIKit can generate.
+     */
+    private readonly REQUIRED_APIKIT_TYPES;
+    validate(doc: Document, context: ValidationContext): Issue[];
+}
+//# sourceMappingURL=ErrorHandlerTypeCoverageRule.d.ts.map

package/dist/src/rules/error-handling/ErrorHandlerTypeCoverageRule.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"ErrorHandlerTypeCoverageRule.d.ts","sourceRoot":"","sources":["../../../../src/rules/error-handling/ErrorHandlerTypeCoverageRule.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,KAAK,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAClE,OAAO,EAAE,QAAQ,EAAE,MAAM,kBAAkB,CAAC;AAE5C;;;;;;;;;;GAUG;AACH,qBAAa,4BAA6B,SAAQ,QAAQ;IACxD,EAAE,SAAa;IACf,IAAI,SAAiC;IACrC,WAAW,SAAgF;IAC3F,QAAQ,EAAG,SAAS,CAAU;IAC9B,QAAQ,EAAG,gBAAgB,CAAU;IACrC,SAAS,EAAE,SAAS,CAAS;IAE7B;;;OAGG;IACH,OAAO,CAAC,QAAQ,CAAC,qBAAqB,CAMpC;IAEF,QAAQ,CAAC,GAAG,EAAE,QAAQ,EAAE,OAAO,EAAE,iBAAiB,GAAG,KAAK,EAAE;CAkD7D"}

package/dist/src/rules/error-handling/ErrorHandlerTypeCoverageRule.js

@@ -0,0 +1,70 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ErrorHandlerTypeCoverageRule = void 0;
+const BaseRule_1 = require("../base/BaseRule");
+/**
+ * ERR-002: Error Handler Type Coverage
+ *
+ * SAPI error handlers should cover the standard APIKit error types
+ * (BAD_REQUEST, NOT_FOUND, METHOD_NOT_ALLOWED, NOT_ACCEPTABLE,
+ * UNSUPPORTED_MEDIA_TYPE) when an APIKit router is present.
+ *
+ * Inspired by real-world accelerator patterns where both Salesforce and
+ * NetSuite SAPIs consistently cover these types for proper HTTP status
+ * code mapping.
+ */
+class ErrorHandlerTypeCoverageRule extends BaseRule_1.BaseRule {
+    id = 'ERR-002';
+    name = 'Error Handler Type Coverage';
+    description = 'Error handlers in APIKit projects should cover standard APIKit error types';
+    severity = 'warning';
+    category = 'error-handling';
+    issueType = 'bug';
+    /**
+     * Minimum set of APIKit error types that a well-structured SAPI should handle.
+     * These correspond to standard HTTP status codes that APIKit can generate.
+     */
+    REQUIRED_APIKIT_TYPES = [
+        'APIKIT:BAD_REQUEST',
+        'APIKIT:NOT_FOUND',
+        'APIKIT:METHOD_NOT_ALLOWED',
+        'APIKIT:NOT_ACCEPTABLE',
+        'APIKIT:UNSUPPORTED_MEDIA_TYPE',
+    ];
+    validate(doc, context) {
+        const issues = [];
+        // Only apply when project has an APIKit router
+        if (context.projectContext && !context.projectContext.hasApikitRouter) {
+            return issues;
+        }
+        // Find named (global) error handlers — these are the ones that should
+        // have comprehensive coverage
+        const errorHandlers = this.select('//mule:error-handler[@name]', doc);
+        for (const handler of errorHandlers) {
+            const handlerName = this.getAttribute(handler, 'name') ?? 'unnamed';
+            // Collect all error types handled in this error-handler
+            const handledTypes = new Set();
+            const onErrorBlocks = [
+                ...this.select('.//mule:on-error-continue[@type]', handler),
+                ...this.select('.//mule:on-error-propagate[@type]', handler),
+            ];
+            for (const block of onErrorBlocks) {
+                const typeAttr = this.getAttribute(block, 'type') ?? '';
+                // Types can be comma-separated (e.g., "SALESFORCE:CONNECTIVITY, HTTP:CONNECTIVITY")
+                for (const t of typeAttr.split(',')) {
+                    handledTypes.add(t.trim().toUpperCase());
+                }
+            }
+            // Check which required types are missing
+            const missingTypes = this.REQUIRED_APIKIT_TYPES.filter((t) => !handledTypes.has(t));
+            if (missingTypes.length > 0) {
+                issues.push(this.createIssue(handler, `Error handler "${handlerName}" is missing coverage for: ${missingTypes.join(', ')}`, {
+                    suggestion: 'Add on-error-propagate blocks for each APIKit error type to return correct HTTP status codes (400, 404, 405, 406, 415)',
+                }));
+            }
+        }
+        return issues;
+    }
+}
+exports.ErrorHandlerTypeCoverageRule = ErrorHandlerTypeCoverageRule;
+//# sourceMappingURL=ErrorHandlerTypeCoverageRule.js.map

package/dist/src/rules/error-handling/ErrorHandlerTypeCoverageRule.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"ErrorHandlerTypeCoverageRule.js","sourceRoot":"","sources":["../../../../src/rules/error-handling/ErrorHandlerTypeCoverageRule.ts"],"names":[],"mappings":";;;AACA,+CAA4C;AAE5C;;;;;;;;;;GAUG;AACH,MAAa,4BAA6B,SAAQ,mBAAQ;IACxD,EAAE,GAAG,SAAS,CAAC;IACf,IAAI,GAAG,6BAA6B,CAAC;IACrC,WAAW,GAAG,4EAA4E,CAAC;IAC3F,QAAQ,GAAG,SAAkB,CAAC;IAC9B,QAAQ,GAAG,gBAAyB,CAAC;IACrC,SAAS,GAAc,KAAK,CAAC;IAE7B;;;OAGG;IACc,qBAAqB,GAAG;QACvC,oBAAoB;QACpB,kBAAkB;QAClB,2BAA2B;QAC3B,uBAAuB;QACvB,+BAA+B;KAChC,CAAC;IAEF,QAAQ,CAAC,GAAa,EAAE,OAA0B;QAChD,MAAM,MAAM,GAAY,EAAE,CAAC;QAE3B,+CAA+C;QAC/C,IAAI,OAAO,CAAC,cAAc,IAAI,CAAC,OAAO,CAAC,cAAc,CAAC,eAAe,EAAE,CAAC;YACtE,OAAO,MAAM,CAAC;QAChB,CAAC;QAED,sEAAsE;QACtE,8BAA8B;QAC9B,MAAM,aAAa,GAAG,IAAI,CAAC,MAAM,CAAC,6BAA6B,EAAE,GAAG,CAAC,CAAC;QAEtE,KAAK,MAAM,OAAO,IAAI,aAAa,EAAE,CAAC;YACpC,MAAM,WAAW,GAAG,IAAI,CAAC,YAAY,CAAC,OAAO,EAAE,MAAM,CAAC,IAAI,SAAS,CAAC;YAEpE,wDAAwD;YACxD,MAAM,YAAY,GAAG,IAAI,GAAG,EAAU,CAAC;YAEvC,MAAM,aAAa,GAAG;gBACpB,GAAG,IAAI,CAAC,MAAM,CAAC,kCAAkC,EAAE,OAAmB,CAAC;gBACvE,GAAG,IAAI,CAAC,MAAM,CAAC,mCAAmC,EAAE,OAAmB,CAAC;aACzE,CAAC;YAEF,KAAK,MAAM,KAAK,IAAI,aAAa,EAAE,CAAC;gBAClC,MAAM,QAAQ,GAAG,IAAI,CAAC,YAAY,CAAC,KAAK,EAAE,MAAM,CAAC,IAAI,EAAE,CAAC;gBACxD,oFAAoF;gBACpF,KAAK,MAAM,CAAC,IAAI,QAAQ,CAAC,KAAK,CAAC,GAAG,CAAC,EAAE,CAAC;oBACpC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC,CAAC;gBAC3C,CAAC;YACH,CAAC;YAED,yCAAyC;YACzC,MAAM,YAAY,GAAG,IAAI,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC;YAEpF,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;gBAC5B,MAAM,CAAC,IAAI,CACT,IAAI,CAAC,WAAW,CACd,OAAO,EACP,kBAAkB,WAAW,8BAA8B,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,EACpF;oBACE,UAAU,EACR,wHAAwH;iBAC3H,CACF,CACF,CAAC;YACJ,CAAC;QACH,CAAC;QAED,OAAO,MAAM,CAAC;IAChB,CAAC;CACF;AAtED,oEAsEC"}

package/dist/src/rules/error-handling/ErrorResponseStructureRule.d.ts

@@ -0,0 +1,23 @@
+import { ValidationContext, Issue, IssueType } from '../../types';
+import { BaseRule } from '../base/BaseRule';
+/**
+ * ERR-003: Error Response Structure
+ *
+ * Error responses should include both a correlationId and a message field
+ * for effective debugging and traceability. Real-world accelerator projects
+ * consistently use a JSON envelope like:
+ *   { correlationId: "...", error: "...", message: "..." }
+ *
+ * This rule checks that ee:set-payload elements inside error handlers
+ * contain both correlationId and message in their DataWeave body.
+ */
+export declare class ErrorResponseStructureRule extends BaseRule {
+    id: string;
+    name: string;
+    description: string;
+    severity: "info";
+    category: "error-handling";
+    issueType: IssueType;
+    validate(doc: Document, _context: ValidationContext): Issue[];
+}
+//# sourceMappingURL=ErrorResponseStructureRule.d.ts.map

package/dist/src/rules/error-handling/ErrorResponseStructureRule.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"ErrorResponseStructureRule.d.ts","sourceRoot":"","sources":["../../../../src/rules/error-handling/ErrorResponseStructureRule.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,KAAK,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAClE,OAAO,EAAE,QAAQ,EAAE,MAAM,kBAAkB,CAAC;AAG5C;;;;;;;;;;GAUG;AACH,qBAAa,0BAA2B,SAAQ,QAAQ;IACtD,EAAE,SAAa;IACf,IAAI,SAA8B;IAClC,WAAW,SAAqE;IAChF,QAAQ,EAAG,MAAM,CAAU;IAC3B,QAAQ,EAAG,gBAAgB,CAAU;IACrC,SAAS,EAAE,SAAS,CAAS;IAE7B,QAAQ,CAAC,GAAG,EAAE,QAAQ,EAAE,QAAQ,EAAE,iBAAiB,GAAG,KAAK,EAAE;CAyE9D"}

package/dist/src/rules/error-handling/ErrorResponseStructureRule.js

@@ -0,0 +1,73 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ErrorResponseStructureRule = void 0;
+const BaseRule_1 = require("../base/BaseRule");
+const XPathHelper_1 = require("../../core/XPathHelper");
+/**
+ * ERR-003: Error Response Structure
+ *
+ * Error responses should include both a correlationId and a message field
+ * for effective debugging and traceability. Real-world accelerator projects
+ * consistently use a JSON envelope like:
+ *   { correlationId: "...", error: "...", message: "..." }
+ *
+ * This rule checks that ee:set-payload elements inside error handlers
+ * contain both correlationId and message in their DataWeave body.
+ */
+class ErrorResponseStructureRule extends BaseRule_1.BaseRule {
+    id = 'ERR-003';
+    name = 'Error Response Structure';
+    description = 'Error responses should include correlationId and message fields';
+    severity = 'info';
+    category = 'error-handling';
+    issueType = 'bug';
+    validate(doc, _context) {
+        const issues = [];
+        // Find on-error blocks that contain ee:set-payload (i.e., they build an error response)
+        const onErrorBlocks = [
+            ...this.select('//mule:on-error-continue', doc),
+            ...this.select('//mule:on-error-propagate', doc),
+        ];
+        for (const block of onErrorBlocks) {
+            // Find ee:set-payload within this error block
+            const setPayloads = this.select('.//*[local-name()="set-payload" and namespace-uri()="http://www.mulesoft.org/schema/mule/ee/core"]', block);
+            if (setPayloads.length === 0) {
+                continue; // No payload transformation — skip (might be logging-only)
+            }
+            for (const sp of setPayloads) {
+                const content = (0, XPathHelper_1.getTextContent)(sp).toLowerCase();
+                // Also check resource attribute — if present, we can't inspect inline
+                const resourceAttr = this.getAttribute(sp, 'resource');
+                if (resourceAttr) {
+                    continue; // External DWL — inspected by MULE-007 (CorrelationIdRule)
+                }
+                // Skip non-DataWeave content (e.g., static strings)
+                if (!content.includes('dw 2.0') && !content.includes('---')) {
+                    continue;
+                }
+                const hasCorrelationId = content.includes('correlationid');
+                const hasMessage = content.includes('message') || content.includes('detaileddescription');
+                if (!hasCorrelationId && !hasMessage) {
+                    issues.push(this.createIssue(sp, 'Error response payload is missing both correlationId and message fields', {
+                        suggestion: 'Include correlationId and message in the error response for traceability: { correlationId: vars.correlationId, message: error.detailedDescription }',
+                    }));
+                }
+                else if (!hasCorrelationId) {
+                    issues.push(this.createIssue(sp, 'Error response payload is missing correlationId field', {
+                        severity: 'info',
+                        suggestion: 'Add correlationId to the error response: correlationId: vars.correlationId default ""',
+                    }));
+                }
+                else if (!hasMessage) {
+                    issues.push(this.createIssue(sp, 'Error response payload is missing a message or description field', {
+                        severity: 'info',
+                        suggestion: 'Add a message field: message: error.detailedDescription default ""',
+                    }));
+                }
+            }
+        }
+        return issues;
+    }
+}
+exports.ErrorResponseStructureRule = ErrorResponseStructureRule;
+//# sourceMappingURL=ErrorResponseStructureRule.js.map

package/dist/src/rules/error-handling/ErrorResponseStructureRule.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"ErrorResponseStructureRule.js","sourceRoot":"","sources":["../../../../src/rules/error-handling/ErrorResponseStructureRule.ts"],"names":[],"mappings":";;;AACA,+CAA4C;AAC5C,wDAAwD;AAExD;;;;;;;;;;GAUG;AACH,MAAa,0BAA2B,SAAQ,mBAAQ;IACtD,EAAE,GAAG,SAAS,CAAC;IACf,IAAI,GAAG,0BAA0B,CAAC;IAClC,WAAW,GAAG,iEAAiE,CAAC;IAChF,QAAQ,GAAG,MAAe,CAAC;IAC3B,QAAQ,GAAG,gBAAyB,CAAC;IACrC,SAAS,GAAc,KAAK,CAAC;IAE7B,QAAQ,CAAC,GAAa,EAAE,QAA2B;QACjD,MAAM,MAAM,GAAY,EAAE,CAAC;QAE3B,wFAAwF;QACxF,MAAM,aAAa,GAAG;YACpB,GAAG,IAAI,CAAC,MAAM,CAAC,0BAA0B,EAAE,GAAG,CAAC;YAC/C,GAAG,IAAI,CAAC,MAAM,CAAC,2BAA2B,EAAE,GAAG,CAAC;SACjD,CAAC;QAEF,KAAK,MAAM,KAAK,IAAI,aAAa,EAAE,CAAC;YAClC,8CAA8C;YAC9C,MAAM,WAAW,GAAG,IAAI,CAAC,MAAM,CAC7B,oGAAoG,EACpG,KAAK,CACN,CAAC;YAEF,IAAI,WAAW,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;gBAC7B,SAAS,CAAC,2DAA2D;YACvE,CAAC;YAED,KAAK,MAAM,EAAE,IAAI,WAAW,EAAE,CAAC;gBAC7B,MAAM,OAAO,GAAG,IAAA,4BAAc,EAAC,EAAE,CAAC,CAAC,WAAW,EAAE,CAAC;gBAEjD,sEAAsE;gBACtE,MAAM,YAAY,GAAG,IAAI,CAAC,YAAY,CAAC,EAAE,EAAE,UAAU,CAAC,CAAC;gBACvD,IAAI,YAAY,EAAE,CAAC;oBACjB,SAAS,CAAC,2DAA2D;gBACvE,CAAC;gBAED,oDAAoD;gBACpD,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,CAAC;oBAC5D,SAAS;gBACX,CAAC;gBAED,MAAM,gBAAgB,GAAG,OAAO,CAAC,QAAQ,CAAC,eAAe,CAAC,CAAC;gBAC3D,MAAM,UAAU,GAAG,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,OAAO,CAAC,QAAQ,CAAC,qBAAqB,CAAC,CAAC;gBAE1F,IAAI,CAAC,gBAAgB,IAAI,CAAC,UAAU,EAAE,CAAC;oBACrC,MAAM,CAAC,IAAI,CACT,IAAI,CAAC,WAAW,CACd,EAAE,EACF,yEAAyE,EACzE;wBACE,UAAU,EACR,qJAAqJ;qBACxJ,CACF,CACF,CAAC;gBACJ,CAAC;qBAAM,IAAI,CAAC,gBAAgB,EAAE,CAAC;oBAC7B,MAAM,CAAC,IAAI,CACT,IAAI,CAAC,WAAW,CAAC,EAAE,EAAE,uDAAuD,EAAE;wBAC5E,QAAQ,EAAE,MAAM;wBAChB,UAAU,EACR,uFAAuF;qBAC1F,CAAC,CACH,CAAC;gBACJ,CAAC;qBAAM,IAAI,CAAC,UAAU,EAAE,CAAC;oBACvB,MAAM,CAAC,IAAI,CACT,IAAI,CAAC,WAAW,CACd,EAAE,EACF,kEAAkE,EAClE;wBACE,QAAQ,EAAE,MAAM;wBAChB,UAAU,EAAE,oEAAoE;qBACjF,CACF,CACF,CAAC;gBACJ,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO,MAAM,CAAC;IAChB,CAAC;CACF;AAjFD,gEAiFC"}

package/dist/src/rules/error-handling/GenericErrorRule.d.ts

@@ -3,8 +3,13 @@ import { BaseRule } from '../base/BaseRule';
 /**
  * MULE-009: Generic Error Type
  *
- * Avoid catching type="ANY" in error handlers.
- * Be specific about error types to handle them appropriately.
+ * Avoid catching type="ANY" in error handlers — unless it is the LAST
+ * on-error block in the error-handler, where it serves as a catch-all
+ * fallback (the accelerator pattern maps this to HTTP 500).
+ *
+ * Enhanced: only flag type="ANY" when it is NOT the last sibling in
+ * its parent error-handler, since a catch-all as the final block is
+ * an accepted MuleSoft best practice.
  */
 export declare class GenericErrorRule extends BaseRule {
     id: string;
@@ -16,8 +21,15 @@ export declare class GenericErrorRule extends BaseRule {
     private readonly GENERIC_TYPES;
     validate(doc: Document, _context: ValidationContext): Issue[];
     /**
-     * Check if handler uses generic error type
+     * Check if handler uses generic error type.
+     * Skip if this handler is the LAST on-error block in its parent
+     * error-handler (catch-all fallback is an accepted pattern).
      */
     private checkGenericType;
+    /**
+     * Returns true if the given on-error node is the last on-error child
+     * of its parent error-handler element.
+     */
+    private isLastOnErrorBlock;
 }
 //# sourceMappingURL=GenericErrorRule.d.ts.map

package/dist/src/rules/error-handling/GenericErrorRule.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"GenericErrorRule.d.ts","sourceRoot":"","sources":["../../../../src/rules/error-handling/GenericErrorRule.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,KAAK,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAClE,OAAO,EAAE,QAAQ,EAAE,MAAM,kBAAkB,CAAC;AAE5C;;;;;GAKG;AACH,qBAAa,gBAAiB,SAAQ,QAAQ;IAC5C,EAAE,SAAc;IAChB,IAAI,SAAwB;IAC5B,WAAW,SAA+D;IAC1E,QAAQ,EAAG,SAAS,CAAU;IAC9B,QAAQ,EAAG,gBAAgB,CAAU;IACrC,SAAS,EAAE,SAAS,CAAS;IAG7B,OAAO,CAAC,QAAQ,CAAC,aAAa,CAAuB;IAErD,QAAQ,CAAC,GAAG,EAAE,QAAQ,EAAE,QAAQ,EAAE,iBAAiB,GAAG,KAAK,EAAE;IAoB7D;;OAEG;IACH,OAAO,CAAC,gBAAgB;CAmBzB"}
+{"version":3,"file":"GenericErrorRule.d.ts","sourceRoot":"","sources":["../../../../src/rules/error-handling/GenericErrorRule.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,KAAK,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAClE,OAAO,EAAE,QAAQ,EAAE,MAAM,kBAAkB,CAAC;AAE5C;;;;;;;;;;GAUG;AACH,qBAAa,gBAAiB,SAAQ,QAAQ;IAC5C,EAAE,SAAc;IAChB,IAAI,SAAwB;IAC5B,WAAW,SAA+D;IAC1E,QAAQ,EAAG,SAAS,CAAU;IAC9B,QAAQ,EAAG,gBAAgB,CAAU;IACrC,SAAS,EAAE,SAAS,CAAS;IAG7B,OAAO,CAAC,QAAQ,CAAC,aAAa,CAAuB;IAErD,QAAQ,CAAC,GAAG,EAAE,QAAQ,EAAE,QAAQ,EAAE,iBAAiB,GAAG,KAAK,EAAE;IAsB7D;;;;OAIG;IACH,OAAO,CAAC,gBAAgB;IA2BxB;;;OAGG;IACH,OAAO,CAAC,kBAAkB;CAuB3B"}

package/dist/src/rules/error-handling/GenericErrorRule.js

@@ -5,8 +5,13 @@ const BaseRule_1 = require("../base/BaseRule");
 /**
  * MULE-009: Generic Error Type
  *
- * Avoid catching type="ANY" in error handlers.
- * Be specific about error types to handle them appropriately.
+ * Avoid catching type="ANY" in error handlers — unless it is the LAST
+ * on-error block in the error-handler, where it serves as a catch-all
+ * fallback (the accelerator pattern maps this to HTTP 500).
+ *
+ * Enhanced: only flag type="ANY" when it is NOT the last sibling in
+ * its parent error-handler, since a catch-all as the final block is
+ * an accepted MuleSoft best practice.
  */
 class GenericErrorRule extends BaseRule_1.BaseRule {
     id = 'MULE-009';
@@ -19,30 +24,65 @@ class GenericErrorRule extends BaseRule_1.BaseRule {
     GENERIC_TYPES = ['ANY', 'MULE:ANY'];
     validate(doc, _context) {
         const issues = [];
-        // Find on-error-continue with type="ANY"
-        const onErrorContinue = this.select('//mule:on-error-continue[@type]', doc);
-        for (const handler of onErrorContinue) {
-            this.checkGenericType(handler, 'on-error-continue', issues);
-        }
-        // Find on-error-propagate with type="ANY"
-        const onErrorPropagate = this.select('//mule:on-error-propagate[@type]', doc);
-        for (const handler of onErrorPropagate) {
-            this.checkGenericType(handler, 'on-error-propagate', issues);
+        // Find all on-error-continue and on-error-propagate with type attribute
+        const allHandlers = [
+            ...this.select('//mule:on-error-continue[@type]', doc).map((h) => ({
+                node: h,
+                type: 'on-error-continue',
+            })),
+            ...this.select('//mule:on-error-propagate[@type]', doc).map((h) => ({
+                node: h,
+                type: 'on-error-propagate',
+            })),
+        ];
+        for (const handler of allHandlers) {
+            this.checkGenericType(handler.node, handler.type, issues);
         }
         return issues;
     }
     /**
-     * Check if handler uses generic error type
+     * Check if handler uses generic error type.
+     * Skip if this handler is the LAST on-error block in its parent
+     * error-handler (catch-all fallback is an accepted pattern).
      */
     checkGenericType(handler, handlerType, issues) {
         const errorType = this.getAttribute(handler, 'type');
-        if (errorType && this.GENERIC_TYPES.includes(errorType.toUpperCase())) {
-            const docName = this.getDocName(handler);
-            const displayName = docName ? `"${docName}"` : '';
-            issues.push(this.createIssue(handler, `${handlerType} ${displayName} uses generic type="${errorType}"`, {
-                suggestion: 'Catch specific error types (e.g., HTTP:CONNECTIVITY, DB:CONNECTIVITY, VALIDATION:INVALID_JSON) for better error handling',
-            }));
+        if (!errorType || !this.GENERIC_TYPES.includes(errorType.toUpperCase())) {
+            return;
+        }
+        // Check if this is the last on-error sibling in its parent error-handler
+        if (this.isLastOnErrorBlock(handler)) {
+            return; // Catch-all as last block is fine
+        }
+        const docName = this.getDocName(handler);
+        const displayName = docName ? `"${docName}"` : '';
+        issues.push(this.createIssue(handler, `${handlerType} ${displayName} uses generic type="${errorType}" but is not the last error handler — move it to the end or use specific types`, {
+            suggestion: 'If this is a catch-all, place it as the last on-error block. Otherwise, catch specific error types (e.g., HTTP:CONNECTIVITY, DB:CONNECTIVITY)',
+        }));
+    }
+    /**
+     * Returns true if the given on-error node is the last on-error child
+     * of its parent error-handler element.
+     */
+    isLastOnErrorBlock(handler) {
+        const parent = handler.parentNode;
+        if (!parent) {
+            return true; // No parent, can't determine position — assume last
+        }
+        // Collect on-error siblings (continue and propagate)
+        const siblings = parent.childNodes;
+        let lastOnError = null;
+        for (let i = 0; i < siblings.length; i++) {
+            const sibling = siblings[i];
+            if (sibling.nodeType === 1 /* ELEMENT_NODE */) {
+                const el = sibling;
+                const localName = el.localName ?? el.tagName ?? '';
+                if (localName === 'on-error-continue' || localName === 'on-error-propagate') {
+                    lastOnError = sibling;
+                }
+            }
         }
+        return lastOnError === handler;
     }
 }
 exports.GenericErrorRule = GenericErrorRule;

package/dist/src/rules/error-handling/GenericErrorRule.js.map

@@ -1 +1 @@
-{"version":3,"file":"GenericErrorRule.js","sourceRoot":"","sources":["../../../../src/rules/error-handling/GenericErrorRule.ts"],"names":[],"mappings":";;;AACA,+CAA4C;AAE5C;;;;;GAKG;AACH,MAAa,gBAAiB,SAAQ,mBAAQ;IAC5C,EAAE,GAAG,UAAU,CAAC;IAChB,IAAI,GAAG,oBAAoB,CAAC;IAC5B,WAAW,GAAG,2DAA2D,CAAC;IAC1E,QAAQ,GAAG,SAAkB,CAAC;IAC9B,QAAQ,GAAG,gBAAyB,CAAC;IACrC,SAAS,GAAc,KAAK,CAAC;IAE7B,wBAAwB;IACP,aAAa,GAAG,CAAC,KAAK,EAAE,UAAU,CAAC,CAAC;IAErD,QAAQ,CAAC,GAAa,EAAE,QAA2B;QACjD,MAAM,MAAM,GAAY,EAAE,CAAC;QAE3B,yCAAyC;QACzC,MAAM,eAAe,GAAG,IAAI,CAAC,MAAM,CAAC,iCAAiC,EAAE,GAAG,CAAC,CAAC;QAE5E,KAAK,MAAM,OAAO,IAAI,eAAe,EAAE,CAAC;YACtC,IAAI,CAAC,gBAAgB,CAAC,OAAO,EAAE,mBAAmB,EAAE,MAAM,CAAC,CAAC;QAC9D,CAAC;QAED,0CAA0C;QAC1C,MAAM,gBAAgB,GAAG,IAAI,CAAC,MAAM,CAAC,kCAAkC,EAAE,GAAG,CAAC,CAAC;QAE9E,KAAK,MAAM,OAAO,IAAI,gBAAgB,EAAE,CAAC;YACvC,IAAI,CAAC,gBAAgB,CAAC,OAAO,EAAE,oBAAoB,EAAE,MAAM,CAAC,CAAC;QAC/D,CAAC;QAED,OAAO,MAAM,CAAC;IAChB,CAAC;IAED;;OAEG;IACK,gBAAgB,CAAC,OAAa,EAAE,WAAmB,EAAE,MAAe;QAC1E,MAAM,SAAS,GAAG,IAAI,CAAC,YAAY,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC;QAErD,IAAI,SAAS,IAAI,IAAI,CAAC,aAAa,CAAC,QAAQ,CAAC,SAAS,CAAC,WAAW,EAAE,CAAC,EAAE,CAAC;YACtE,MAAM,OAAO,GAAG,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC;YACzC,MAAM,WAAW,GAAG,OAAO,CAAC,CAAC,CAAC,IAAI,OAAO,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC;YAElD,MAAM,CAAC,IAAI,CACT,IAAI,CAAC,WAAW,CACd,OAAO,EACP,GAAG,WAAW,IAAI,WAAW,uBAAuB,SAAS,GAAG,EAChE;gBACE,UAAU,EACR,0HAA0H;aAC7H,CACF,CACF,CAAC;QACJ,CAAC;IACH,CAAC;CACF;AArDD,4CAqDC"}
+{"version":3,"file":"GenericErrorRule.js","sourceRoot":"","sources":["../../../../src/rules/error-handling/GenericErrorRule.ts"],"names":[],"mappings":";;;AACA,+CAA4C;AAE5C;;;;;;;;;;GAUG;AACH,MAAa,gBAAiB,SAAQ,mBAAQ;IAC5C,EAAE,GAAG,UAAU,CAAC;IAChB,IAAI,GAAG,oBAAoB,CAAC;IAC5B,WAAW,GAAG,2DAA2D,CAAC;IAC1E,QAAQ,GAAG,SAAkB,CAAC;IAC9B,QAAQ,GAAG,gBAAyB,CAAC;IACrC,SAAS,GAAc,KAAK,CAAC;IAE7B,wBAAwB;IACP,aAAa,GAAG,CAAC,KAAK,EAAE,UAAU,CAAC,CAAC;IAErD,QAAQ,CAAC,GAAa,EAAE,QAA2B;QACjD,MAAM,MAAM,GAAY,EAAE,CAAC;QAE3B,wEAAwE;QACxE,MAAM,WAAW,GAAG;YAClB,GAAG,IAAI,CAAC,MAAM,CAAC,iCAAiC,EAAE,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;gBACjE,IAAI,EAAE,CAAC;gBACP,IAAI,EAAE,mBAAmB;aAC1B,CAAC,CAAC;YACH,GAAG,IAAI,CAAC,MAAM,CAAC,kCAAkC,EAAE,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;gBAClE,IAAI,EAAE,CAAC;gBACP,IAAI,EAAE,oBAAoB;aAC3B,CAAC,CAAC;SACJ,CAAC;QAEF,KAAK,MAAM,OAAO,IAAI,WAAW,EAAE,CAAC;YAClC,IAAI,CAAC,gBAAgB,CAAC,OAAO,CAAC,IAAI,EAAE,OAAO,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;QAC5D,CAAC;QAED,OAAO,MAAM,CAAC;IAChB,CAAC;IAED;;;;OAIG;IACK,gBAAgB,CAAC,OAAa,EAAE,WAAmB,EAAE,MAAe;QAC1E,MAAM,SAAS,GAAG,IAAI,CAAC,YAAY,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC;QAErD,IAAI,CAAC,SAAS,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,QAAQ,CAAC,SAAS,CAAC,WAAW,EAAE,CAAC,EAAE,CAAC;YACxE,OAAO;QACT,CAAC;QAED,yEAAyE;QACzE,IAAI,IAAI,CAAC,kBAAkB,CAAC,OAAO,CAAC,EAAE,CAAC;YACrC,OAAO,CAAC,kCAAkC;QAC5C,CAAC;QAED,MAAM,OAAO,GAAG,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC;QACzC,MAAM,WAAW,GAAG,OAAO,CAAC,CAAC,CAAC,IAAI,OAAO,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC;QAElD,MAAM,CAAC,IAAI,CACT,IAAI,CAAC,WAAW,CACd,OAAO,EACP,GAAG,WAAW,IAAI,WAAW,uBAAuB,SAAS,gFAAgF,EAC7I;YACE,UAAU,EACR,+IAA+I;SAClJ,CACF,CACF,CAAC;IACJ,CAAC;IAED;;;OAGG;IACK,kBAAkB,CAAC,OAAa;QACtC,MAAM,MAAM,GAAG,OAAO,CAAC,UAAU,CAAC;QAClC,IAAI,CAAC,MAAM,EAAE,CAAC;YACZ,OAAO,IAAI,CAAC,CAAC,oDAAoD;QACnE,CAAC;QAED,qDAAqD;QACrD,MAAM,QAAQ,GAAG,MAAM,CAAC,UAAU,CAAC;QACnC,IAAI,WAAW,GAAgB,IAAI,CAAC;QAEpC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,QAAQ,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;YACzC,MAAM,OAAO,GAAG,QAAQ,CAAC,CAAC,CAAC,CAAC;YAC5B,IAAI,OAAO,CAAC,QAAQ,KAAK,CAAC,CAAC,kBAAkB,EAAE,CAAC;gBAC9C,MAAM,EAAE,GAAG,OAAkB,CAAC;gBAC9B,MAAM,SAAS,GAAG,EAAE,CAAC,SAAS,IAAI,EAAE,CAAC,OAAO,IAAI,EAAE,CAAC;gBACnD,IAAI,SAAS,KAAK,mBAAmB,IAAI,SAAS,KAAK,oBAAoB,EAAE,CAAC;oBAC5E,WAAW,GAAG,OAAO,CAAC;gBACxB,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO,WAAW,KAAK,OAAO,CAAC;IACjC,CAAC;CACF;AA5FD,4CA4FC"}

package/dist/src/rules/error-handling/GlobalErrorHandlerRule.d.ts

@@ -1,30 +1,29 @@
 import { ValidationContext, Issue, IssueType } from '../../types';
-import { BaseRule } from '../base/BaseRule';
+import { ProjectRule } from '../base/ProjectRule';
 /**
  * MULE-001: Global Error Handler Exists
  *
  * Every Mule project should have a global error handler: either a dedicated
- * file (default: global-error-handler.xml) OR any scanned XML file that
- * contains a named <error-handler> element.
+ * file (default: global-error-handler.xml) OR any XML file in the project
+ * that contains a named <error-handler> element.
  *
- * The rule fires on every scanned XML file that:
- *   1. Contains at least one <flow> or <sub-flow> (is a flow file), AND
- *   2. Does not itself define an <error-handler> element
- *
- * If neither the expected file exists NOR any named <error-handler> has been
- * found in the current document, an issue is raised.
- *
- * Note: the old guard `context.relativePath.includes('global')` has been
- * removed.  Restricting reports to only "global" files hid the rule for
- * projects that did not follow that naming convention.
+ * This is a ProjectRule — it runs once per scan (not per file). It scans all
+ * XML files in the Mule source directory looking for a named error-handler
+ * definition. If none is found and the expected file doesn't exist, it reports
+ * a single project-level issue.
  */
-export declare class GlobalErrorHandlerRule extends BaseRule {
+export declare class GlobalErrorHandlerRule extends ProjectRule {
     id: string;
     name: string;
     description: string;
     severity: "warning";
     category: "error-handling";
     issueType: IssueType;
-    validate(doc: Document, context: ValidationContext): Issue[];
+    protected validateProject(context: ValidationContext): Issue[];
+    /**
+     * Recursively scan a directory for XML files containing a named
+     * <error-handler> or <error-handler ref="..."> element.
+     */
+    private scanForErrorHandler;
 }
 //# sourceMappingURL=GlobalErrorHandlerRule.d.ts.map

package/dist/src/rules/error-handling/GlobalErrorHandlerRule.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"GlobalErrorHandlerRule.d.ts","sourceRoot":"","sources":["../../../../src/rules/error-handling/GlobalErrorHandlerRule.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,KAAK,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAClE,OAAO,EAAE,QAAQ,EAAE,MAAM,kBAAkB,CAAC;AAI5C;;;;;;;;;;;;;;;;;GAiBG;AACH,qBAAa,sBAAuB,SAAQ,QAAQ;IAClD,EAAE,SAAc;IAChB,IAAI,SAAiC;IACrC,WAAW,SACgF;IAC3F,QAAQ,EAAG,SAAS,CAAU;IAC9B,QAAQ,EAAG,gBAAgB,CAAU;IACrC,SAAS,EAAE,SAAS,CAAS;IAE7B,QAAQ,CAAC,GAAG,EAAE,QAAQ,EAAE,OAAO,EAAE,iBAAiB,GAAG,KAAK,EAAE;CAoD7D"}
+{"version":3,"file":"GlobalErrorHandlerRule.d.ts","sourceRoot":"","sources":["../../../../src/rules/error-handling/GlobalErrorHandlerRule.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,KAAK,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAClE,OAAO,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AAKlD;;;;;;;;;;;GAWG;AACH,qBAAa,sBAAuB,SAAQ,WAAW;IACrD,EAAE,SAAc;IAChB,IAAI,SAAiC;IACrC,WAAW,SACgF;IAC3F,QAAQ,EAAG,SAAS,CAAU;IAC9B,QAAQ,EAAG,gBAAgB,CAAU;IACrC,SAAS,EAAE,SAAS,CAAS;IAE7B,SAAS,CAAC,eAAe,CAAC,OAAO,EAAE,iBAAiB,GAAG,KAAK,EAAE;IAqC9D;;;OAGG;IACH,OAAO,CAAC,mBAAmB;CA8B5B"}

package/dist/src/rules/error-handling/GlobalErrorHandlerRule.js

@@ -34,66 +34,87 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.GlobalErrorHandlerRule = void 0;
-const BaseRule_1 = require("../base/BaseRule");
+const ProjectRule_1 = require("../base/ProjectRule");
 const FileScanner_1 = require("../../core/FileScanner");
 const path = __importStar(require("path"));
+const fs = __importStar(require("fs"));
 /**
  * MULE-001: Global Error Handler Exists
  *
  * Every Mule project should have a global error handler: either a dedicated
- * file (default: global-error-handler.xml) OR any scanned XML file that
- * contains a named <error-handler> element.
+ * file (default: global-error-handler.xml) OR any XML file in the project
+ * that contains a named <error-handler> element.
  *
- * The rule fires on every scanned XML file that:
- *   1. Contains at least one <flow> or <sub-flow> (is a flow file), AND
- *   2. Does not itself define an <error-handler> element
- *
- * If neither the expected file exists NOR any named <error-handler> has been
- * found in the current document, an issue is raised.
- *
- * Note: the old guard `context.relativePath.includes('global')` has been
- * removed.  Restricting reports to only "global" files hid the rule for
- * projects that did not follow that naming convention.
+ * This is a ProjectRule — it runs once per scan (not per file). It scans all
+ * XML files in the Mule source directory looking for a named error-handler
+ * definition. If none is found and the expected file doesn't exist, it reports
+ * a single project-level issue.
  */
-class GlobalErrorHandlerRule extends BaseRule_1.BaseRule {
+class GlobalErrorHandlerRule extends ProjectRule_1.ProjectRule {
     id = 'MULE-001';
     name = 'Global Error Handler Exists';
     description = 'Project should have a global error handler configuration for consistent error handling';
     severity = 'warning';
     category = 'error-handling';
     issueType = 'bug';
-    validate(doc, context) {
-        const issues = [];
+    validateProject(context) {
         // Get configurable expected file path
         const expectedFile = this.getOption(context, 'filePath', 'src/main/mule/global-error-handler.xml');
         const fullPath = path.join(context.projectRoot, expectedFile);
-        // If the dedicated global error handler file exists, the project satisfies
-        // the rule regardless of what is in the current file.
+        // 1. If the dedicated global error handler file exists, the project
+        //    satisfies the rule.
         if ((0, FileScanner_1.fileExists)(fullPath)) {
-            return issues;
+            return [];
         }
-        // The expected file does not exist.  Check whether the current document
-        // itself provides a global error handler via:
-        //   (a) a named <error-handler> element, OR
-        //   (b) a flow that references an error handler by ref attribute
-        const hasNamedErrorHandler = this.exists('//*[local-name()="error-handler"][@name]', doc);
-        if (hasNamedErrorHandler) {
-            return issues;
+        // 2. Scan all XML files in src/main/mule for a named <error-handler>
+        //    element or an <error-handler ref="..."> reference.
+        const muleDir = path.join(context.projectRoot, 'src/main/mule');
+        if (fs.existsSync(muleDir)) {
+            const hasErrorHandler = this.scanForErrorHandler(muleDir);
+            if (hasErrorHandler) {
+                return [];
+            }
         }
-        const hasErrorHandlerRef = this.exists('//*[local-name()="error-handler"][@ref]', doc);
-        if (hasErrorHandlerRef) {
-            return issues;
+        return [
+            this.createProjectIssue(`Global error handler configuration not found. Expected "${expectedFile}" or a named <error-handler> element in any Mule XML file.`, {
+                suggestion: 'Create a global-error-handler.xml file with a named <error-handler> element, or add an <error-handler name="..."> to an existing configuration file',
+            }),
+        ];
+    }
+    /**
+     * Recursively scan a directory for XML files containing a named
+     * <error-handler> or <error-handler ref="..."> element.
+     */
+    scanForErrorHandler(dir) {
+        try {
+            const entries = fs.readdirSync(dir, { withFileTypes: true });
+            for (const entry of entries) {
+                const fullPath = path.join(dir, entry.name);
+                if (entry.isDirectory()) {
+                    if (this.scanForErrorHandler(fullPath)) {
+                        return true;
+                    }
+                }
+                else if (entry.name.endsWith('.xml')) {
+                    try {
+                        const content = fs.readFileSync(fullPath, 'utf-8');
+                        // Quick string check before full parse — avoids parsing every file
+                        if (content.includes('error-handler') &&
+                            (/<error-handler\s[^>]*name\s*=/.test(content) ||
+                                /<error-handler\s[^>]*ref\s*=/.test(content))) {
+                            return true;
+                        }
+                    }
+                    catch {
+                        // Unreadable file, skip
+                    }
+                }
+            }
         }
-        // Only report for files that actually contain flows / sub-flows so that
-        // pure configuration files (e.g. global.xml without flows) are excluded.
-        const hasFlows = this.exists('//*[local-name()="flow" or local-name()="sub-flow"]', doc);
-        if (!hasFlows) {
-            return issues;
+        catch {
+            // Unreadable directory
         }
-        issues.push(this.createFileIssue(`Global error handler configuration not found. Expected "${expectedFile}" or a named <error-handler> element in any flow file.`, {
-            suggestion: 'Create a global-error-handler.xml file with a named <error-handler> element, or add an <error-handler name="..."> to an existing configuration file',
-        }));
-        return issues;
+        return false;
     }
 }
 exports.GlobalErrorHandlerRule = GlobalErrorHandlerRule;