@sesamehr/react-design-system 2.0.0-beta.11 → 2.0.0-beta.12
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -113,6 +113,16 @@ export interface ComboboxItemEditProps extends Omit<React.HTMLAttributes<HTMLDiv
|
|
|
113
113
|
* sides: take focus on entering the edit, hand it back to the combobox's own
|
|
114
114
|
* field on leaving.
|
|
115
115
|
*
|
|
116
|
+
* **A dialog around the combobox is free here and was not in Vue.** A dialog
|
|
117
|
+
* traps focus, the popover is portalled to `body` and is therefore outside what
|
|
118
|
+
* the trap considers the dialog, so the `.focus()` below reads as focus
|
|
119
|
+
* escaping — unless a nearer focus layer has suspended the trap.
|
|
120
|
+
* `Popover.Content` registers one in every Radix build, untrapped when the
|
|
121
|
+
* popover is non-modal, which ours is. reka gives `SelectContentImpl`,
|
|
122
|
+
* `PopoverContentImpl` and `MenuContentImpl` a `FocusScope` and
|
|
123
|
+
* `ComboboxContentImpl` none, so the Vue `ComboboxContent` has to add the layer
|
|
124
|
+
* by hand to reach the behaviour this side gets for nothing.
|
|
125
|
+
*
|
|
116
126
|
* **One thing here has no Vue counterpart.** cmdk re-sorts the option elements
|
|
117
127
|
* by moving the DOM nodes themselves whenever the search term changes, and a
|
|
118
128
|
* focused field inside a row that gets reparented loses focus. Typing in the
|