@servicetitan/startup 39.1.0 → 39.2.0

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@servicetitan/startup",
-    "version": "39.1.0",
+    "version": "39.2.0",
     "description": "CLI to create multi-package Lerna projects with TypeScript and React",
     "homepage": "https://docs.st.dev/docs/frontend/uikit/startup",
     "repository": {
@@ -103,20 +103,20 @@
         "@jest/core": "~30.4.2",
         "@jest/types": "~30.4.1",
         "@jsdevtools/coverage-istanbul-loader": "^3.0.5",
-        "@servicetitan/eslint-config": "39.1.0",
-        "@servicetitan/install": "39.1.0",
-        "@servicetitan/startup-utils": "39.1.0",
-        "@servicetitan/stylelint-config": "39.1.0",
+        "@servicetitan/eslint-config": "39.2.0",
+        "@servicetitan/install": "39.2.0",
+        "@servicetitan/startup-utils": "39.2.0",
+        "@servicetitan/stylelint-config": "39.2.0",
         "@svgr/webpack": "^8.1.0",
         "@swc/cli": "^0.8.1",
-        "@swc/core": "1.15.46",
+        "@swc/core": "1.16.1",
         "@types/debug": "^4.1.12",
         "@types/jest": "~30.0.0",
-        "@vitest/coverage-v8": "^4.1.10",
+        "@vitest/coverage-v8": "^4.1.11",
         "chalk": "~4.1.2",
         "cli-table3": "^0.6.5",
         "cpx2": "9.0.0",
-        "css-loader": "~7.1.4",
+        "css-loader": "~7.1.5",
         "css-minimizer-webpack-plugin": "^8.0.0",
         "debug": "^4.4.3",
         "deepmerge": "~4.3.1",
@@ -132,15 +132,15 @@
         "jest-circus": "~30.4.2",
         "jest-environment-jsdom": "~30.4.1",
         "jest-fetch-mock": "~4.2.0",
-        "js-yaml": "~5.3.0",
+        "js-yaml": "~5.4.1",
         "json5": "^2.2.3",
         "lerna": "~9.0.7",
-        "less": "~4.8.1",
+        "less": "~4.9.0",
         "less-loader": "~13.0.0",
         "less-plugin-npm-import": "~2.1.0",
         "lodash.kebabcase": "^4.1.1",
         "lodash.memoize": "^4.1.2",
-        "magic-string": "^1.1.0",
+        "magic-string": "^1.2.3",
         "memfs": "~4.68.1",
         "mini-css-extract-plugin": "~2.10.2",
         "minimizer-webpack-plugin": "^5.6.1",
@@ -148,7 +148,7 @@
         "multimatch": "~8.0.0",
         "patch-package": "^8.0.1",
         "portfinder": "~1.0.38",
-        "postcss": "~8.5.16",
+        "postcss": "~8.5.26",
         "prettier": "~3.9.6",
         "react-refresh": "^0.18.0",
         "sass": "~1.102.0",
@@ -164,11 +164,11 @@
         "ts-node": "~10.9.2",
         "typed-css-modules": "~0.9.1",
         "typescript": "6.0.3",
-        "vite": "^8.1.5",
+        "vite": "^8.2.2",
         "vite-bundle-analyzer": "^1.3.9",
         "vite-plugin-istanbul": "^9.0.1",
         "vite-plugin-svgr": "^5.2.0",
-        "vitest": "^4.1.10",
+        "vitest": "^4.1.11",
         "webpack": "~5.108.4",
         "webpack-assets-manifest": "~6.5.2",
         "webpack-bundle-analyzer": "^5.3.1",
@@ -202,6 +202,5 @@
     },
     "cli": {
         "webpack": false
-    },
-    "gitHead": "a2471578a506e8c40e90956a5c70cc1638bbe9c1"
+    }
 }

package/src/cli/commands/__tests__/mfe-list.test.ts

@@ -1,16 +1,20 @@
-import { npmWhoAmI } from '@servicetitan/install';
+import { isCI, npmWhoAmI } from '@servicetitan/install';
 import chalk from 'chalk';
 import Table from 'cli-table3';
 import { vol } from 'memfs';
 import path from 'path';
-import { createInterface } from 'readline/promises';
 import { formatRelativeDate, toArray } from '../../../utils';
-import { isTTY, npmView, runCommand } from '../../utils';
+import { npmView } from '../../utils';
 import { MFEList } from '../mfe-list';
 import { entry } from '../registry/mfe-list';
+import { DEV_MFE_REGISTRY, PROD_MFE_REGISTRY, login } from '../utils';
 
 jest.mock('@servicetitan/install');
 jest.mock('cli-table3');
+jest.mock('../utils', () => ({
+    ...jest.requireActual('../utils'),
+    login: jest.fn(),
+}));
 jest.mock('fs', () => require('memfs').fs);
 jest.mock('readline/promises', () => ({
     createInterface: jest.fn(),
@@ -30,6 +34,7 @@ describe(`[startup] ${MFEList.name}`, () => {
     let distTags: Record<string, string>;
     let time: Record<string, string>;
     let args: ConstructorParameters<typeof MFEList>[0];
+    let ci: boolean;
 
     function volFromJSON(overrides: Record<string, any> = {}) {
         vol.fromJSON({
@@ -58,8 +63,10 @@ describe(`[startup] ${MFEList.name}`, () => {
             latest: versions[DEFAULT_LIMIT],
         };
         args = { _: [] }; // eslint-disable-line @typescript-eslint/naming-convention
+        ci = false;
         jest.clearAllMocks();
         jest.spyOn(process.stdout, 'write').mockImplementation(jest.fn()); // suppress output
+        jest.mocked(isCI).mockImplementation(() => ci);
         jest.mocked(npmWhoAmI).mockReturnValue('Foo');
         jest.mocked(npmView).mockImplementation(({ packageName }) => ({
             'name': packageName,
@@ -357,67 +364,29 @@ describe(`[startup] ${MFEList.name}`, () => {
         });
     });
 
-    describe('when machine is not authorized', () => {
-        const readline = { question: jest.fn(), close: jest.fn() };
-        let answer: string;
-
-        beforeEach(() => {
-            answer = 'Y';
-            jest.mocked(readline.question).mockImplementation(() => Promise.resolve(answer));
-            jest.mocked(createInterface).mockReturnValue(readline as any);
-            jest.mocked(npmWhoAmI).mockReturnValue(undefined);
-            jest.mocked(isTTY).mockReturnValue(true);
-        });
-
-        test('prompts and authorizes machine', async () => {
-            await subject();
-
-            expect(readline.question).toHaveBeenCalledWith(
-                expect.stringMatching(/machine is not authorized.*Authorize\? \[Y\/n\]/)
-            );
-            expect(readline.close).toHaveBeenCalled();
-            expect(runCommand).toHaveBeenCalledWith(
-                'npx --yes verdaccio-okta-oauth@latest --registry=https://verdaccio.servicetitan.com',
-                { quiet: true }
-            );
-        });
-
-        describe('when user does not answer', () => {
-            beforeEach(() => (answer = ''));
-
-            test('authorizes machine', async () => {
-                await subject();
-
-                expect(runCommand).toHaveBeenCalled();
-            });
-        });
-
-        describe('when user declines', () => {
-            beforeEach(() => (answer = 'n'));
+    test(`authorizes the machine for ${PROD_MFE_REGISTRY}`, async () => {
+        await subject();
 
-            test('throws error', async () => {
-                await expect(subject()).rejects.toThrow(/Not authorized/);
-            });
-        });
+        expect(login).toHaveBeenCalledWith(PROD_MFE_REGISTRY);
+    });
 
-        describe('when terminal is not interactive', () => {
-            beforeEach(() => jest.mocked(isTTY).mockReturnValue(false));
+    describe('in CI environment', () => {
+        beforeEach(() => (ci = true));
 
-            test('skips prompt and throws error', async () => {
-                await expect(subject()).rejects.toThrow(/machine is not authorized/);
+        test('skips authorization', async () => {
+            await subject();
 
-                expect(readline.question).not.toHaveBeenCalled();
-            });
+            expect(login).not.toHaveBeenCalled();
         });
+    });
 
-        describe('with --registry', () => {
-            beforeEach(() => (args.registry = 'https://verdaccio.st.dev'));
+    describe('with --registry', () => {
+        beforeEach(() => (args.registry = DEV_MFE_REGISTRY));
 
-            test('skips check whether machine is authorized', async () => {
-                await subject();
+        test('authorizes the machine for the specified registry', async () => {
+            await subject();
 
-                expect(npmWhoAmI).not.toHaveBeenCalled();
-            });
+            expect(login).toHaveBeenCalledWith(args.registry);
         });
     });
 });

package/src/cli/commands/__tests__/mfe-package-clean.test.ts

@@ -2,6 +2,7 @@ import { fs, vol } from 'memfs';
 import { isWebComponent, log } from '../../../utils';
 import { gitGetBranch, npmGetPackageVersionsDetails, npmUnpublish, Version } from '../../utils';
 import { MFEPackageClean } from '../mfe-package-clean';
+import { getMfeRegistry } from '../utils';
 
 jest.mock('fs', () => fs);
 jest.mock('../../../utils', () => ({
@@ -14,6 +15,10 @@ jest.mock('../../utils', () => ({
     npmGetPackageVersionsDetails: jest.fn(),
     npmUnpublish: jest.fn(),
 }));
+jest.mock('../utils', () => ({
+    ...jest.requireActual('../utils'),
+    getMfeRegistry: jest.fn(),
+}));
 
 const DEFAULT_VERSIONS_TO_KEEP = 5;
 
@@ -37,6 +42,7 @@ describe(`[startup] ${MFEPackageClean.name}`, () => {
         versions = getBranchVersions(gitBranch, 10);
 
         jest.resetAllMocks();
+        jest.mocked(getMfeRegistry).mockImplementation(explicit => explicit ?? registry);
         jest.mocked(isWebComponent).mockReturnValue(true);
         jest.mocked(npmGetPackageVersionsDetails).mockImplementation(() => versions);
         jest.mocked(gitGetBranch).mockImplementation(() => gitBranch);

package/src/cli/commands/__tests__/mfe-package-publish.test.ts

@@ -12,7 +12,7 @@ import {
     runCommand,
 } from '../../utils';
 import { MFEPackagePublish } from '../mfe-package-publish';
-import { purgeCache, ROLLBACK_TAG_SUFFIX } from '../utils';
+import { getMfeRegistry, purgeCache, ROLLBACK_TAG_SUFFIX } from '../utils';
 
 jest.mock('fs', () => fs);
 
@@ -34,11 +34,12 @@ jest.mock('../../utils', () => ({
 }));
 jest.mock('../utils', () => ({
     ...jest.requireActual('../utils'),
+    getMfeRegistry: jest.fn(),
     purgeCache: jest.fn(),
 }));
 
 describe(`[startup] ${MFEPackagePublish.name}`, () => {
-    const defaultRegistry = 'https://verdaccio.servicetitan.com';
+    const registry = 'https://foo.com';
     const branch = 'master';
     const tag = 'prod';
     const rollbackTag = `${tag}${ROLLBACK_TAG_SUFFIX}`;
@@ -53,6 +54,7 @@ describe(`[startup] ${MFEPackagePublish.name}`, () => {
     beforeEach(() => {
         args = {};
         jest.clearAllMocks();
+        jest.mocked(getMfeRegistry).mockImplementation(explicit => explicit ?? registry);
         jest.mocked(isWebComponent).mockReturnValue(true);
         jest.mocked(gitGetBranch).mockReturnValue(branch);
         jest.mocked(gitGetCommitHash).mockReturnValue(commitHash);
@@ -103,7 +105,7 @@ describe(`[startup] ${MFEPackagePublish.name}`, () => {
     test('sets package registry', async () => {
         await subject();
 
-        expect(npmPackageSet).toHaveBeenCalledWith('publishConfig.registry', defaultRegistry);
+        expect(npmPackageSet).toHaveBeenCalledWith('publishConfig.registry', registry);
     });
 
     test('adds package version to metadata.json', async () => {
@@ -127,23 +129,53 @@ describe(`[startup] ${MFEPackagePublish.name}`, () => {
         await subject();
 
         expect(runCommand).toHaveBeenCalledWith(
-            `npx startup upload-sourcemaps --releaseVersion=${buildPackageVersion()}`
+            `npx startup upload-sourcemaps --releaseVersion=${buildPackageVersion()} --registry=${registry}`
         );
     });
 
+    function itDoesNotUploadSourcemaps() {
+        test('does not upload sourcemaps', async () => {
+            await subject();
+
+            expect(runCommand).not.toHaveBeenCalledWith(
+                expect.stringContaining('upload-sourcemaps')
+            );
+        });
+    }
+
+    describe('with "uploadSourcemaps: false"', () => {
+        beforeEach(() => (args.uploadSourcemaps = false));
+
+        itDoesNotUploadSourcemaps();
+    });
+
+    describe('when branch configuration includes "uploadSourcemaps: false"', () => {
+        beforeEach(() =>
+            vol.fromJSON({
+                'package.json': JSON.stringify({
+                    name: packageName,
+                    cli: {
+                        'web-component': {
+                            branches: { [branch]: { uploadSourcemaps: false } },
+                        },
+                    },
+                }),
+            })
+        );
+
+        itDoesNotUploadSourcemaps();
+    });
+
     test('purges cache after publishing', async () => {
         await subject();
 
-        expect(purgeCache).toHaveBeenCalledWith({ packageName, tag });
+        expect(purgeCache).toHaveBeenCalledWith({ packageName, registry, tag });
     });
 
     test('gets current tagged versions before publishing', async () => {
         await subject();
 
-        expect(npmView).toHaveBeenCalledWith({
-            packageName,
-            registry: defaultRegistry,
-        });
+        expect(npmView).toHaveBeenCalledWith({ packageName, registry });
     });
 
     test(`tags previous version with {tag}${ROLLBACK_TAG_SUFFIX}`, async () => {
@@ -151,7 +183,7 @@ describe(`[startup] ${MFEPackagePublish.name}`, () => {
         expect(npmTagVersion).toHaveBeenCalledWith({
             packageName,
             packageVersion: previousVersion,
-            registry: defaultRegistry,
+            registry,
             tag: rollbackTag,
         });
 
@@ -250,31 +282,19 @@ describe(`[startup] ${MFEPackagePublish.name}`, () => {
             expect(npmTagVersion).not.toHaveBeenCalled();
         });
 
-        test('uploads sourcemaps with "--dry" option', async () => {
-            await subject();
+        describe('with "uploadSourcemaps: true"', () => {
+            beforeEach(() => (args.uploadSourcemaps = true));
 
-            expect(runCommand).toHaveBeenCalledWith(
-                `npx startup upload-sourcemaps --dry --releaseVersion=${buildPackageVersion()}`
-            );
-        });
-
-        itDoesNotPurgeCache();
-    });
-
-    function itDoesNotUploadSourcemaps() {
-        test('does not upload sourcemaps', async () => {
-            await subject();
+            test('uploads sourcemaps with "--dry" option', async () => {
+                await subject();
 
-            expect(runCommand).not.toHaveBeenCalledWith(
-                expect.stringContaining('upload-sourcemaps')
-            );
+                expect(runCommand).toHaveBeenCalledWith(
+                    `npx startup upload-sourcemaps --dry --releaseVersion=${buildPackageVersion()} --registry=${registry}`
+                );
+            });
         });
-    }
-
-    describe('with "uploadSourcemaps: false"', () => {
-        beforeEach(() => (args.uploadSourcemaps = false));
 
-        itDoesNotUploadSourcemaps();
+        itDoesNotPurgeCache();
     });
 
     describe('with "purgeCache: false"', () => {
@@ -283,21 +303,6 @@ describe(`[startup] ${MFEPackagePublish.name}`, () => {
         itDoesNotPurgeCache();
     });
 
-    describe('when branch configuration includes "uploadSourcemaps: false"', () => {
-        beforeEach(() =>
-            vol.fromJSON({
-                'package.json': JSON.stringify({
-                    name: packageName,
-                    cli: {
-                        'web-component': { branches: { [branch]: { uploadSourcemaps: false } } },
-                    },
-                }),
-            })
-        );
-
-        itDoesNotUploadSourcemaps();
-    });
-
     describe('with "trackHistory: false"', () => {
         beforeEach(() => {
             args.trackHistory = false;
@@ -484,7 +489,7 @@ describe(`[startup] ${MFEPackagePublish.name}`, () => {
             expect(npmTagVersion).toHaveBeenCalledWith({
                 packageName,
                 packageVersion: buildPackageVersion(),
-                registry: defaultRegistry,
+                registry,
                 tag,
             });
             expect(log.info).toHaveBeenCalledWith(

package/src/cli/commands/__tests__/mfe-package-rollback.test.ts

@@ -1,7 +1,7 @@
 import { log, readJson } from '../../../utils';
 import { npmTagVersion, npmView } from '../../utils';
 import { MFEPackageRollback } from '../mfe-package-rollback';
-import { purgeCache } from '../utils';
+import { getMfeRegistry, purgeCache } from '../utils';
 
 jest.mock('../../../utils', () => ({
     ...jest.requireActual('../../../utils'),
@@ -19,6 +19,7 @@ jest.mock('../../utils', () => ({
 }));
 jest.mock('../utils', () => ({
     ...jest.requireActual('../utils'),
+    getMfeRegistry: jest.fn(),
     purgeCache: jest.fn(),
 }));
 
@@ -43,6 +44,7 @@ describe(`[startup] ${MFEPackageRollback.name}`, () => {
         };
 
         jest.resetAllMocks();
+        jest.mocked(getMfeRegistry).mockImplementation(explicit => explicit ?? registry);
         jest.mocked(readJson).mockReturnValue({ name: packageName });
         jest.mocked(npmView).mockReturnValue(packageInfo);
         jest.mocked(npmTagVersion).mockResolvedValue(undefined);
@@ -106,7 +108,7 @@ describe(`[startup] ${MFEPackageRollback.name}`, () => {
     test('purges cache after rollback', async () => {
         await subject();
 
-        expect(purgeCache).toHaveBeenCalledWith({ packageName, tag });
+        expect(purgeCache).toHaveBeenCalledWith({ packageName, registry, tag });
     });
 
     describe('when package is not found in registry', () => {

package/src/cli/commands/__tests__/mfe-publish.test.ts

@@ -1,3 +1,4 @@
+import { isCI } from '@servicetitan/install';
 import { fs, vol } from 'memfs';
 import { createPackage } from '../../../__mocks__';
 import { Package, PackageType, getPackages } from '../../../utils';
@@ -7,6 +8,7 @@ import { entry as mfePackageClean } from '../registry/mfe-package-clean';
 import { entry as mfePackagePublish } from '../registry/mfe-package-publish';
 import { entry as mfePackageRollback } from '../registry/mfe-package-rollback';
 import { entry as mfePublish } from '../registry/mfe-publish';
+import { getMfeRegistry, login } from '../utils';
 
 jest.mock('fs', () => fs);
 
@@ -15,16 +17,27 @@ jest.mock('../../../utils', () => ({
     ...jest.requireActual('../../../utils'),
     getPackages: jest.fn(),
 }));
+jest.mock('@servicetitan/install', () => ({ isCI: jest.fn() }));
+jest.mock('../utils', () => ({
+    ...jest.requireActual('../utils'),
+    getMfeRegistry: jest.fn(),
+    login: jest.fn(),
+}));
 
 describe(`[startup] ${MFEPublish.name}`, () => {
+    const registry = 'https://foo.com';
     let args: ConstructorParameters<typeof MFEPublish>[0];
+    let ci: boolean;
     let packages: Package[];
 
     beforeEach(() => {
         args = {};
+        ci = false;
         packages = [];
         jest.resetAllMocks();
         jest.mocked(getPackages).mockReturnValue(packages);
+        jest.mocked(getMfeRegistry).mockImplementation(explicit => explicit ?? registry);
+        jest.mocked(isCI).mockImplementation(() => ci);
     });
 
     afterEach(() => vol.reset());
@@ -80,7 +93,13 @@ describe(`[startup] ${MFEPublish.name}`, () => {
             mockPackageJson(packages);
         });
 
-        test('publishes the package', async () => {
+        test('authorizes the machine for the registry', async () => {
+            await subject();
+
+            expect(login).toHaveBeenCalledWith(registry);
+        });
+
+        test('publishes to registry', async () => {
             await subject();
 
             expect(lernaExec).toHaveBeenCalledWith({
@@ -88,7 +107,17 @@ describe(`[startup] ${MFEPublish.name}`, () => {
                 'scope': packages.map(({ name }) => name),
                 'stream': true,
                 'parallel': 1,
-                '--': [],
+                '--': [`--registry ${registry}`],
+            });
+        });
+
+        describe('in CI environment', () => {
+            beforeEach(() => (ci = true));
+
+            test('skips authorization', async () => {
+                await subject();
+
+                expect(login).not.toHaveBeenCalled();
             });
         });
 
@@ -105,7 +134,10 @@ describe(`[startup] ${MFEPublish.name}`, () => {
                 await subject();
 
                 expect(lernaExec).toHaveBeenCalledWith(
-                    expect.objectContaining({ cmd: 'startup mfe-package-clean' })
+                    expect.objectContaining({
+                        'cmd': 'startup mfe-package-clean',
+                        '--': [`--registry ${registry}`],
+                    })
                 );
             });
 
@@ -127,9 +159,11 @@ describe(`[startup] ${MFEPublish.name}`, () => {
 
                     expect(lernaExec).toHaveBeenCalledWith(
                         expect.objectContaining({
-                            '--': Array.isArray(expected)
-                                ? expected
-                                : [expected ?? `--${name} ${value}`],
+                            '--': expect.arrayContaining(
+                                Array.isArray(expected)
+                                    ? expected
+                                    : [expected ?? `--${name} ${value}`]
+                            ),
                         })
                     );
                 });
@@ -161,9 +195,9 @@ describe(`[startup] ${MFEPublish.name}`, () => {
 
                 expect(lernaExec).toHaveBeenCalledWith(
                     expect.objectContaining({
-                        '--': Array.isArray(expected)
-                            ? expected
-                            : [expected ?? `--${name} ${value}`],
+                        '--': expect.arrayContaining(
+                            Array.isArray(expected) ? expected : [expected ?? `--${name} ${value}`]
+                        ),
                     })
                 );
             });
@@ -190,8 +224,9 @@ describe(`[startup] ${MFEPublish.name}`, () => {
 
                 expect(lernaExec).toHaveBeenCalledWith(
                     expect.objectContaining({
-                        cmd: 'startup mfe-package-rollback',
-                        scope: [packages[0].name],
+                        'cmd': 'startup mfe-package-rollback',
+                        'scope': [packages[0].name],
+                        '--': [`--registry ${registry}`],
                     })
                 );
             });
@@ -212,9 +247,11 @@ describe(`[startup] ${MFEPublish.name}`, () => {
 
                     expect(lernaExec).toHaveBeenCalledWith(
                         expect.objectContaining({
-                            '--': Array.isArray(expected)
-                                ? expected
-                                : [expected ?? `--${name} ${value}`],
+                            '--': expect.arrayContaining(
+                                Array.isArray(expected)
+                                    ? expected
+                                    : [expected ?? `--${name} ${value}`]
+                            ),
                         })
                     );
                 });