@servicetitan/startup 36.4.0 → 37.0.1

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@servicetitan/startup",
-    "version": "36.4.0",
+    "version": "37.0.1",
     "description": "CLI to create multi-package Lerna projects with TypeScript and React",
     "homepage": "https://docs.st.dev/docs/frontend/uikit/startup",
     "repository": {
@@ -47,6 +47,7 @@
     ],
     "bin": {
         "startup": "./bin/index.js",
+        "analyze": "./bin/analyze.js",
         "cpx": "./bin/cpx.js",
         "eslint": "./bin/eslint.js",
         "jest": "./bin/jest.js",
@@ -85,7 +86,7 @@
         "prepare": "node ./src/scripts/generate-bin-wrappers.js"
     },
     "devDependencies": {
-        "@swc/types": "^0.1.26",
+        "@swc/types": "^0.1.27",
         "@types/cpx": "~1.5.5",
         "@types/debug": "^4.1.12",
         "@types/eslint": "~9.6.1",
@@ -102,16 +103,16 @@
         "@jest/core": "~30.4.2",
         "@jest/types": "~30.4.1",
         "@jsdevtools/coverage-istanbul-loader": "^3.0.5",
-        "@servicetitan/eslint-config": "36.4.0",
-        "@servicetitan/install": "36.4.0",
-        "@servicetitan/startup-utils": "36.4.0",
-        "@servicetitan/stylelint-config": "36.4.0",
+        "@servicetitan/eslint-config": "37.0.1",
+        "@servicetitan/install": "37.0.1",
+        "@servicetitan/startup-utils": "37.0.1",
+        "@servicetitan/stylelint-config": "37.0.1",
         "@svgr/webpack": "^8.1.0",
         "@swc/cli": "^0.8.1",
-        "@swc/core": "1.15.40",
+        "@swc/core": "1.15.43",
         "@types/debug": "^4.1.12",
         "@types/jest": "~30.0.0",
-        "@vitest/coverage-v8": "^4.1.8",
+        "@vitest/coverage-v8": "^4.1.9",
         "chalk": "~4.1.2",
         "cli-table3": "^0.6.5",
         "cpx2": "9.0.0",
@@ -119,6 +120,7 @@
         "css-minimizer-webpack-plugin": "^8.0.0",
         "debug": "^4.4.3",
         "deepmerge": "~4.3.1",
+        "es-module-lexer": "^2.1.0",
         "eslint": "~9.39.2",
         "eta": "^4.6.0",
         "execa": "~5.1.1",
@@ -133,39 +135,41 @@
         "js-yaml": "~4.2.0",
         "json5": "^2.2.3",
         "lerna": "~9.0.7",
-        "less": "~4.6.4",
+        "less": "~4.6.6",
         "less-loader": "~13.0.0",
         "less-plugin-npm-import": "~2.1.0",
         "lodash.kebabcase": "^4.1.1",
         "lodash.memoize": "^4.1.2",
-        "memfs": "~4.57.2",
+        "memfs": "~4.57.8",
         "mini-css-extract-plugin": "~2.10.2",
         "moment-locales-webpack-plugin": "~1.2.0",
         "multimatch": "~8.0.0",
         "patch-package": "^8.0.1",
         "portfinder": "~1.0.38",
         "postcss": "~8.5.15",
-        "prettier": "~3.8.3",
-        "sass": "~1.100.0",
+        "prettier": "~3.8.4",
+        "sass": "~1.101.0",
         "sass-loader": "~17.0.0",
-        "semver": "~7.8.1",
+        "semver": "~7.8.5",
         "source-map-loader": "~5.0.0",
         "style-loader": "~4.0.0",
-        "stylelint": "~16.26.1",
+        "stylelint": "~17.13.0",
         "swc-loader": "^0.2.7",
         "terminal-link": "^5.0.0",
         "terser-webpack-plugin": "^5.6.1",
         "ts-jest": "29.4.11",
         "ts-node": "~10.9.2",
         "typed-css-modules": "~0.9.1",
-        "typescript": "5.9.3",
+        "typescript": "6.0.3",
         "vite": "^8.0.16",
+        "vite-bundle-analyzer": "^1.3.8",
+        "vite-plugin-istanbul": "^9.0.1",
         "vite-plugin-svgr": "^5.2.0",
-        "vitest": "^4.1.8",
+        "vitest": "^4.1.9",
         "webpack": "~5.107.2",
         "webpack-assets-manifest": "~6.5.2",
         "webpack-bundle-analyzer": "^5.3.0",
-        "webpack-dev-server": "^5.2.4",
+        "webpack-dev-server": "^5.2.5",
         "webpack-filter-warnings-plugin": "~1.2.1",
         "webpack-merge": "~6.0.1",
         "webpack-remove-empty-scripts": "^1.1.1",
@@ -193,5 +197,5 @@
     "cli": {
         "webpack": false
     },
-    "gitHead": "8beab9ae3a70ce381e8cd53f2de8691640e96c6e"
+    "gitHead": "9a2e5579f88cf9895fd2948ce5d5810e976d20b0"
 }

package/src/cli/commands/__tests__/build.test.ts

@@ -11,6 +11,7 @@ import { entry } from '../registry/build';
 jest.mock('../../../utils', () => ({
     ...jest.requireActual('../../../utils'),
     getPackages: jest.fn(),
+    getConfiguration: jest.fn(() => ({})),
 }));
 jest.mock('../../utils', () => ({
     ...jest.requireActual('../../utils'),
@@ -121,7 +122,7 @@ describe(`[startup] ${Build.name}`, () => {
             await subject();
 
             expect(lernaExec).toHaveBeenCalledWith({
-                'cmd': 'startup bundle-package',
+                'cmd': 'startup bundle-webpack',
                 'scope': packages.map(({ name }) => name),
                 'parallel': true,
                 'stream': true,
@@ -133,13 +134,25 @@ describe(`[startup] ${Build.name}`, () => {
             await subject();
 
             expect(lernaExec).toHaveBeenCalledWith({
-                'cmd': 'startup bundle-package',
+                'cmd': 'startup bundle-webpack',
                 'scope': packages.map(({ name }) => name),
                 'stream': true,
                 '--': [],
             });
         });
 
+        describe('with --bundler=vite', () => {
+            beforeEach(() => (args.bundler = 'vite'));
+
+            test('bundles with Vite', async () => {
+                await subject();
+
+                expect(lernaExec).toHaveBeenCalledWith(
+                    expect.objectContaining({ cmd: 'startup bundle-vite' })
+                );
+            });
+        });
+
         describe('with "code-coverage"', () => {
             beforeEach(() => (args.codeCoverage = true));
 
@@ -148,7 +161,7 @@ describe(`[startup] ${Build.name}`, () => {
 
                 expect(lernaExec).toHaveBeenCalledWith(
                     expect.objectContaining({
-                        'cmd': 'startup bundle-package',
+                        'cmd': 'startup bundle-webpack',
                         '--': ['--code-coverage'],
                     })
                 );
@@ -163,13 +176,28 @@ describe(`[startup] ${Build.name}`, () => {
 
                 expect(lernaExec).toHaveBeenCalledWith(
                     expect.objectContaining({
-                        'cmd': 'startup bundle-package',
+                        'cmd': 'startup bundle-webpack',
                         '--': ['--stat'],
                     })
                 );
             });
         });
 
+        describe('with "preview"', () => {
+            beforeEach(() => (args.preview = true));
+
+            test('passes --preview to the bundler', async () => {
+                await subject();
+
+                expect(lernaExec).toHaveBeenCalledWith(
+                    expect.objectContaining({
+                        'cmd': 'startup bundle-webpack',
+                        '--': ['--preview'],
+                    })
+                );
+            });
+        });
+
         describe('with "config"', () => {
             beforeEach(() => (args.config = 'foo.config.js'));
 
@@ -178,7 +206,7 @@ describe(`[startup] ${Build.name}`, () => {
 
                 expect(lernaExec).toHaveBeenCalledWith(
                     expect.objectContaining({
-                        'cmd': 'startup bundle-package',
+                        'cmd': 'startup bundle-webpack',
                         '--': [`--config "${args.config}"`],
                     })
                 );

package/src/cli/commands/__tests__/bundle-vite.test.ts

@@ -1,6 +1,12 @@
 import { build, createServer, preview as previewServer } from 'vite';
 import { getBuildName, stringifyConfig } from '../../../core';
-import { hasHeadlessBundle, isExposeSharedDependencies, isWebComponent, log } from '../../../utils';
+import {
+    hasHeadlessBundle,
+    isExposeSharedDependencies,
+    isViteDevServerDisabled,
+    isWebComponent,
+    log,
+} from '../../../utils';
 import { buildSharedDependencies } from '../../../vite/build-shared-dependencies';
 import { createViteConfig } from '../../../vite/config';
 import { validateViteSharedDependencies } from '../../../vite/validate-shared-dependencies';
@@ -20,6 +26,7 @@ jest.mock('../../../utils', () => ({
     ...jest.requireActual('../../../utils'),
     hasHeadlessBundle: jest.fn(() => false),
     isExposeSharedDependencies: jest.fn(() => true),
+    isViteDevServerDisabled: jest.fn(() => false),
     isWebComponent: jest.fn(() => false),
     log: { text: jest.fn() },
 }));
@@ -79,6 +86,18 @@ describe(BundleVite.name, () => {
         expect(build).toHaveBeenCalledWith(viteConfig);
     });
 
+    describe('with "stat"', () => {
+        beforeEach(() => (args.stat = true));
+
+        test('requests a bundle report', async () => {
+            await subject();
+
+            expect(createViteConfig).toHaveBeenCalledWith(
+                expect.objectContaining({ buildStat: true })
+            );
+        });
+    });
+
     describe('with "printConfig"', () => {
         beforeEach(() => (args.printConfig = true));
 
@@ -157,6 +176,36 @@ describe(BundleVite.name, () => {
                 expect(mockServer.listen).not.toHaveBeenCalled();
             });
         });
+
+        describe('when dev server disabled', () => {
+            const originalNodeEnv = process.env.NODE_ENV;
+
+            beforeEach(() => jest.mocked(isViteDevServerDisabled).mockReturnValue(true));
+
+            afterEach(() => {
+                process.env.NODE_ENV = originalNodeEnv;
+            });
+
+            test('builds to disk in watch mode', async () => {
+                await subject();
+
+                expect(build).toHaveBeenCalledWith(
+                    expect.objectContaining({ build: { watch: {} } })
+                );
+            });
+
+            test('produces a development build', async () => {
+                await subject();
+
+                expect(process.env.NODE_ENV).toBe('development');
+            });
+
+            test('does not start a dev server', async () => {
+                await subject();
+
+                expect(createServer).not.toHaveBeenCalled();
+            });
+        });
     });
 
     describe('with "useWatchConfig"', () => {

package/src/cli/commands/__tests__/start.test.ts

@@ -7,6 +7,7 @@ import { Start } from '../start';
 jest.mock('../../../utils', () => ({
     ...jest.requireActual('../../../utils'),
     getPackages: jest.fn(),
+    getConfiguration: jest.fn(() => ({})),
 }));
 jest.mock('../../utils', () => ({
     ...jest.requireActual('../../utils'),
@@ -131,7 +132,7 @@ describe(`[startup] ${Start.name}`, () => {
             await subject();
 
             expect(lernaExec).toHaveBeenCalledWith({
-                'cmd': 'startup bundle-package',
+                'cmd': 'startup bundle-webpack',
                 'scope': packages.map(({ name }) => name),
                 'parallel': true,
                 'stream': true,
@@ -143,7 +144,7 @@ describe(`[startup] ${Start.name}`, () => {
             await subject();
 
             expect(lernaExec).toHaveBeenCalledWith({
-                'cmd': 'startup bundle-package',
+                'cmd': 'startup bundle-webpack',
                 'scope': packages.map(({ name }) => name),
                 'parallel': true,
                 'stream': true,
@@ -151,6 +152,18 @@ describe(`[startup] ${Start.name}`, () => {
             });
         });
 
+        describe('with --bundler=vite', () => {
+            beforeEach(() => (args.bundler = 'vite'));
+
+            test('bundles with Vite in watch mode', async () => {
+                await subject();
+
+                expect(lernaExec).toHaveBeenCalledWith(
+                    expect.objectContaining({ cmd: 'startup bundle-vite' })
+                );
+            });
+        });
+
         describe('with "code-coverage"', () => {
             beforeEach(() => (args.codeCoverage = true));
 
@@ -159,7 +172,7 @@ describe(`[startup] ${Start.name}`, () => {
 
                 expect(lernaExec).toHaveBeenCalledWith(
                     expect.objectContaining({
-                        'cmd': 'startup bundle-package',
+                        'cmd': 'startup bundle-webpack',
                         '--': ['--watch', '--code-coverage'],
                     })
                 );
@@ -174,7 +187,7 @@ describe(`[startup] ${Start.name}`, () => {
 
                 expect(lernaExec).toHaveBeenCalledWith(
                     expect.objectContaining({
-                        'cmd': 'startup bundle-package',
+                        'cmd': 'startup bundle-webpack',
                         '--': ['--watch', `--config "${args.config}"`],
                     })
                 );

package/src/cli/commands/build.ts

@@ -1,5 +1,5 @@
 import { getPackages, logErrors, PackageType } from '../../utils';
-import { checkArgs, compile, lernaExec, ProcessTree, typeCheck } from '../utils';
+import { checkArgs, compile, getBundleCommand, lernaExec, ProcessTree, typeCheck } from '../utils';
 import { kendoUILicense } from './kendo-ui-license';
 import type { entry } from './registry/build';
 import { Command } from './types';
@@ -20,8 +20,6 @@ export class Build extends Command<typeof entry> {
         checkArgs(this.args, { obsolete: ['--esbuild', '--experimental-bundlers'] });
 
         const useTsc = this.args.useTsc;
-        const useVite = this.args.useVite;
-        const cmd = useVite ? 'startup bundle-vite' : 'startup bundle-package';
 
         const packages = getPackages({
             scope: this.args.scope,
@@ -40,6 +38,7 @@ export class Build extends Command<typeof entry> {
         const bundleScope = packages
             .filter(({ type }) => type === PackageType.Bundle)
             .map(({ name }) => name);
+        const bundleCmd = getBundleCommand(this.args);
         const precompileScope = packages
             .filter(({ scripts }) => !!scripts?.precompile)
             .map(({ name }) => name);
@@ -78,7 +77,7 @@ export class Build extends Command<typeof entry> {
                     return Promise.resolve();
                 }
                 return lernaExec({
-                    cmd,
+                    'cmd': bundleCmd,
                     'scope': bundleScope,
                     'parallel': true,
                     'stream': true,
@@ -101,14 +100,14 @@ export class Build extends Command<typeof entry> {
                 }
 
                 return lernaExec({
-                    cmd,
+                    'cmd': bundleCmd,
                     'scope': bundleScope,
                     'stream': true,
                     '--': [
                         ...[this.args.config ? `--config "${this.args.config}"` : undefined],
                         ...[this.args.codeCoverage ? '--code-coverage' : undefined],
                         ...[this.args.stat ? '--stat' : undefined],
-                        ...[useVite && this.args.preview ? '--preview' : undefined],
+                        ...[this.args.preview ? '--preview' : undefined],
                     ].filter(item => !!item) as string[],
                 });
             },

package/src/cli/commands/bundle-vite.ts

@@ -3,6 +3,7 @@ import { BuildContextOptions, getBuildName, stringifyConfig } from '../../core';
 import {
     hasHeadlessBundle,
     isExposeSharedDependencies,
+    isViteDevServerDisabled,
     isWebComponent,
     log,
     logErrors,
@@ -24,6 +25,7 @@ export class BundleVite extends Command<typeof entry> {
         const options: BuildContextOptions = {
             name: getBuildName(),
             isProduction,
+            buildStat: this.args.stat,
         };
 
         if (this.args.printConfig) {
@@ -61,6 +63,17 @@ async function buildAndServe(
 ): Promise<void> {
     const config = await createViteConfig(options);
     if (watch) {
+        if (isViteDevServerDisabled()) {
+            /*
+             * Create a development build with no HTTP server, using Vite's watcher to rebuild
+             * on change. `vite build` forces NODE_ENV to production regardless of `mode`, because
+             * Vite treats the two as independent. Set NODE_ENV directly to get a development
+             * build; `mode` alone does not change it.
+             */
+            process.env.NODE_ENV = 'development';
+            await build({ ...config, build: { ...config.build, watch: {} } });
+            return;
+        }
         await serve(config);
         return;
     }

package/src/cli/commands/registry/build.ts

@@ -5,6 +5,11 @@ export const entry = defineEntry({
     description: 'Build project for production',
     greedy: true,
     options: {
+        bundler: {
+            choices: ['vite', 'webpack'] as const,
+            description: 'Bundler',
+            defaultDescription: 'webpack',
+        },
         cdnPath: { string: true, description: 'Base url for application assets' },
         codeCoverage: { boolean: true, description: 'Instrument code for coverage analysis?' },
         config: { string: true, hidden: true, description: 'Use specified configuration' },
@@ -13,6 +18,6 @@ export const entry = defineEntry({
         scope: { array: true, string: true, description: 'Packages to build' },
         stat: { boolean: true, description: 'Generate bundle report?' },
         useTsc: { boolean: true, description: 'Use tsc to compile packages?' },
-        useVite: { boolean: true, description: 'Use Vite to bundle packages?' },
+        useVite: { boolean: true, hidden: true, description: 'Deprecated: use --bundler=vite' },
     },
 } satisfies CommandEntry);

package/src/cli/commands/registry/command-registry.ts

@@ -64,7 +64,6 @@ function makeEntry<K extends CommandName, T extends CommandEntry>(
  */
 export const commandRegistry = {
     ...makeEntry(CommandName.build, build),
-    ...makeEntry(CommandName['bundle-package'], bundleWebpack, { path: 'bundle-webpack' }),
     ...makeEntry(CommandName['bundle-vite'], bundleVite),
     ...makeEntry(CommandName['bundle-webpack'], bundleWebpack),
     ...makeEntry(CommandName.clean, clean),

package/src/cli/commands/registry/start.ts

@@ -5,11 +5,16 @@ export const entry = defineEntry({
     description: 'Run project in development mode',
     greedy: true,
     options: {
+        bundler: {
+            choices: ['vite', 'webpack'] as const,
+            description: 'Bundler',
+            defaultDescription: 'webpack',
+        },
         codeCoverage: { boolean: true, description: 'Instrument code for coverage analysis?' },
         config: { string: true, hidden: true, description: 'Use specified configuration' },
         ignore: { array: true, string: true, description: 'Packages to skip' },
         scope: { array: true, string: true, description: 'Packages to run and watch' },
         useTsc: { boolean: true, description: 'Use tsc to compile packages?' },
-        useVite: { boolean: true, description: 'Use Vite to bundle packages?' },
+        useVite: { boolean: true, hidden: true, description: 'Deprecated: use --bundler=vite' },
     },
 } satisfies CommandEntry);

package/src/cli/commands/review/rules/__tests__/require-compatible-typescript.test.ts

@@ -0,0 +1,127 @@
+import chalk from 'chalk';
+import { execSync } from 'node:child_process';
+import { expectCalls, MockPackageManager } from '../../__mocks__';
+import { FixCategory, PackageError } from '../../types';
+import { mockProject } from '../__mocks__';
+import { RequireCompatibleTypescript } from '../require-compatible-typescript';
+
+jest.mock('child_process', () => ({ execSync: jest.fn() }));
+
+const STARTUP = '@servicetitan/startup';
+const TYPESCRIPT = 'typescript';
+const REQUIRED_VERSION = '6.0.3';
+const OLDER_VERSION = '5.9.3';
+
+describe(`[startup] Review ${RequireCompatibleTypescript.name}`, () => {
+    const id = 'require-compatible-typescript';
+    const rule = new RequireCompatibleTypescript();
+    const mockPackageManager = new MockPackageManager();
+
+    let requiredVersion: string | undefined;
+    let actualVersion: string | undefined;
+
+    beforeAll(() => {
+        jest.spyOn(mockPackageManager, 'getDeclaredVersion').mockImplementation(
+            ({ declaredBy, dependency }) =>
+                declaredBy === STARTUP && dependency === TYPESCRIPT ? requiredVersion : undefined
+        );
+        jest.spyOn(mockPackageManager, 'getResolvedVersion').mockImplementation(({ dependency }) =>
+            dependency === TYPESCRIPT ? actualVersion : undefined
+        );
+    });
+
+    beforeEach(() => {
+        requiredVersion = REQUIRED_VERSION;
+        actualVersion = undefined;
+        mockPackageManager.command = 'npm';
+        jest.clearAllMocks();
+    });
+
+    const project = () => mockProject({ packageManager: mockPackageManager as any });
+
+    const subject = () => rule.run(project());
+
+    const fixSubject = () => rule.fix!(subject()!);
+
+    function itReturnsNothing() {
+        test('returns nothing', () => {
+            expect(subject()).toBeUndefined();
+        });
+    }
+
+    function itReturnsError() {
+        test('returns error', () => {
+            expect(subject()).toEqual({
+                id,
+                message: `project's top-level "${TYPESCRIPT}" is older than the version required by ${STARTUP}`,
+                details: `${chalk.yellow(actualVersion)} is older than ${requiredVersion}`,
+                fixable: FixCategory.lockFile,
+                location: mockPackageManager.lockFileName,
+                data: { actualVersion, requiredVersion },
+            } satisfies PackageError);
+        });
+    }
+
+    itReturnsNothing();
+
+    describe('when startup is not a dependency', () => {
+        beforeEach(() => {
+            requiredVersion = undefined;
+            actualVersion = REQUIRED_VERSION;
+        });
+
+        itReturnsNothing();
+    });
+
+    describe('when top-level typescript is older than startup requires', () => {
+        beforeEach(() => (actualVersion = OLDER_VERSION));
+
+        itReturnsError();
+
+        test('fixes error', () => {
+            fixSubject();
+
+            expectCalls(
+                ...[
+                    `npm pkg set dependencies["${TYPESCRIPT}"]="${REQUIRED_VERSION}"`,
+                    'npx @servicetitan/install --fix --quiet',
+                    `npm pkg delete dependencies["${TYPESCRIPT}"]`,
+                ].map(command => [execSync, command, { stdio: 'inherit' }])
+            );
+        });
+
+        describe('when package manager is pnpm', () => {
+            beforeEach(() => (mockPackageManager.command = 'pnpm'));
+
+            itReturnsNothing();
+        });
+    });
+
+    describe('when top-level typescript equals the version startup requires', () => {
+        beforeEach(() => (actualVersion = REQUIRED_VERSION));
+
+        itReturnsNothing();
+    });
+
+    describe('when top-level typescript is newer than startup requires', () => {
+        beforeEach(() => (actualVersion = '6.1.0'));
+
+        itReturnsNothing();
+    });
+
+    describe('when startup declares typescript as a range', () => {
+        beforeEach(() => (requiredVersion = '^6.0.0'));
+
+        describe('when top-level typescript is below the range floor', () => {
+            beforeEach(() => (actualVersion = OLDER_VERSION));
+
+            itReturnsError();
+        });
+
+        describe('when top-level typescript is at the range floor', () => {
+            beforeEach(() => (actualVersion = '6.0.0'));
+
+            itReturnsNothing();
+        });
+    });
+});

package/src/cli/commands/review/rules/index.ts

@@ -6,6 +6,7 @@ import { NoTypescriptEntryPoint } from './no-typescript-entry-point';
 import { PreferOpenEndedPeerDependencies } from './prefer-open-ended-peer-dependencies';
 import { RequireAllReactDependencies } from './require-all-react-dependencies';
 import { RequireCompatibleLaunchDarklySdk } from './require-compatible-launch-darkly-sdk';
+import { RequireCompatibleTypescript } from './require-compatible-typescript';
 import { RequireExplicitSideEffects } from './require-explicit-side-effects';
 import { RequireNpmrc } from './require-npmrc';
 import { RequireOneAnvilUikitContribVersion } from './require-one-anvil-uikit-contrib-version';
@@ -24,6 +25,7 @@ export const rules: PackageRule[] = [
     new RequireOneUikitVersion(),
     new RequireProjectVersionInRootNodeModules(),
     new RequireCompatibleLaunchDarklySdk(),
+    new RequireCompatibleTypescript(),
     new NoDeprecatedContentBase(),
     new NoDirectPeerDependencies(),
     new NoDeprecatedStartupInstall(),