@servicetitan/startup 36.0.0 → 36.1.1-beta.1

package/src/{webpack/configs/utils → core/metadata}/__tests__/build-metadata.test.ts

@@ -1,13 +1,17 @@
 import { fs, vol } from 'memfs';
-import { getStartupVersion } from '../../../../utils/get-startup-version';
+import {
+    getLaunchDarklySdkVersion,
+    getStartupVersion,
+    getWebComponentsVersion,
+} from '../../get-version';
 import { buildMetadata, BuildMetadataParams } from '../build-metadata';
-import { getLaunchDarklySdkVersion } from '../get-launchdarkly-sdk-version';
-import { getWebComponentsVersion } from '../get-web-components-version';
 
 jest.mock('fs', () => fs);
-jest.mock('../../../../utils/get-startup-version');
-jest.mock('../get-launchdarkly-sdk-version');
-jest.mock('../get-web-components-version');
+jest.mock('../../get-version', () => ({
+    getLaunchDarklySdkVersion: jest.fn(),
+    getStartupVersion: jest.fn(),
+    getWebComponentsVersion: jest.fn(),
+}));
 
 describe(`[startup] ${buildMetadata.name}`, () => {
     const destination = 'dist';

package/src/{webpack/configs/utils → core/metadata}/__tests__/generate-metadata.test.ts

@@ -1,8 +1,8 @@
 import { fs, vol } from 'memfs';
 
 import * as mockedFs from 'fs';
-import { createPackage } from '../../../../__mocks__';
-import { Context } from '../../types';
+import { createPackage } from '../../../__mocks__';
+import { BuildContext } from '../../types';
 import { buildMetadata } from '../build-metadata';
 import { generateMetadata } from '../generate-metadata';
 
@@ -16,7 +16,7 @@ function generatedMetadata(dest: string) {
 describe(`[startup] ${generateMetadata.name}`, () => {
     const pkg = createPackage({});
     const destination = 'dist';
-    let context: Partial<Context>;
+    let context: BuildContext;
 
     const mockMetadata = {
         name: pkg.name,
@@ -36,16 +36,30 @@ describe(`[startup] ${generateMetadata.name}`, () => {
         jest.mocked(buildMetadata).mockReturnValue(mockMetadata);
 
         context = {
-            destination,
-            name: pkg.name,
-            packageData: { name: pkg.name, version: pkg.version, dependencies: { foo: '1.0.1' } },
-            sharedDependencies: { react: 'SharedDependencies.React' },
+            build: {
+                name: pkg.name,
+                isProduction: false,
+            },
+            package: {
+                name: pkg.name,
+                version: pkg.version,
+                destination,
+                source: 'src',
+                dependencies: { foo: '1.0.1' },
+                sharedDependencies: { react: 'SharedDependencies.React' },
+                isWebComponent: false,
+                isLegacyRoot: false,
+                isExposeSharedDependencies: false,
+            },
+            options: {
+                bundlerConfig: {},
+            },
         };
     });
 
     afterEach(() => vol.reset());
 
-    const subject = () => generateMetadata(context as any);
+    const subject = () => generateMetadata(context);
 
     function itWritesMetadataToDestination(destination: string) {
         test('writes metadata to output file', () => {
@@ -60,10 +74,10 @@ describe(`[startup] ${generateMetadata.name}`, () => {
 
         expect(buildMetadata).toHaveBeenCalledWith({
             destination,
-            name: context.name,
-            version: context.packageData!.version,
-            dependencies: context.packageData!.dependencies,
-            sharedDependencies: context.sharedDependencies,
+            name: context.build.name,
+            version: context.package.version,
+            dependencies: context.package.dependencies,
+            sharedDependencies: context.package.sharedDependencies,
         });
     });
 
@@ -72,7 +86,7 @@ describe(`[startup] ${generateMetadata.name}`, () => {
     describe('when destination directory does not exist', () => {
         const nestedDestination = 'nested/path/dist';
 
-        beforeEach(() => (context.destination = nestedDestination));
+        beforeEach(() => (context.package.destination = nestedDestination));
 
         test('creates destination directory', () => {
             subject();

package/src/{webpack/configs/utils → core/metadata}/build-metadata.ts

@@ -1,8 +1,11 @@
 import path from 'path';
-import { getStartupVersion, readJsonSafe } from '../../../utils';
+import { readJsonSafe } from '../../utils';
+import {
+    getLaunchDarklySdkVersion,
+    getStartupVersion,
+    getWebComponentsVersion,
+} from '../get-version';
 import { EntryPoints, Metadata } from '../types';
-import { getLaunchDarklySdkVersion } from './get-launchdarkly-sdk-version';
-import { getWebComponentsVersion } from './get-web-components-version';
 
 export interface BuildMetadataParams {
     destination: string;

package/src/core/metadata/generate-exposed-dependencies-metadata.ts

@@ -0,0 +1,20 @@
+import fs from 'fs';
+import path from 'path';
+import { ExposedDepsMetadata } from '../get-shared-entry-points';
+
+export function getExposedDependenciesMetadataPath(destination: string) {
+    return path.join(destination, 'exposed-dependencies-metadata.json');
+}
+
+export function generateExposedDependenciesMetadata(
+    destination: string,
+    getOutputPath: () => string
+) {
+    if (!fs.existsSync(destination)) {
+        fs.mkdirSync(destination, { recursive: true });
+    }
+
+    const metadataPath = getExposedDependenciesMetadataPath(destination);
+    const metadata: ExposedDepsMetadata = { entryPointsPath: getOutputPath() };
+    fs.writeFileSync(metadataPath, JSON.stringify(metadata, null, 2), 'utf-8');
+}

package/src/{webpack/configs/utils → core/metadata}/generate-metadata.ts

@@ -1,11 +1,12 @@
 import fs from 'fs';
 import path from 'path';
-import { log } from '../../../utils';
-import { Context } from '../types';
+import { log } from '../../utils';
+import { BuildContext } from '../types';
 import { buildMetadata } from './build-metadata';
 
-export function generateMetadata(context: Context) {
-    const { destination, name, packageData, sharedDependencies } = context;
+export function generateMetadata(context: BuildContext) {
+    const { destination, sharedDependencies, version, dependencies } = context.package;
+    const { name } = context.build;
 
     if (!fs.existsSync(destination)) {
         fs.mkdirSync(destination, { recursive: true });
@@ -14,8 +15,8 @@ export function generateMetadata(context: Context) {
     const metadata = buildMetadata({
         destination,
         name,
-        version: packageData.version,
-        dependencies: packageData.dependencies,
+        version,
+        dependencies,
         sharedDependencies,
     });
 

package/src/core/metadata/index.ts

@@ -0,0 +1,3 @@
+export * from './build-metadata';
+export * from './generate-exposed-dependencies-metadata';
+export * from './generate-metadata';

package/src/core/types.ts

@@ -0,0 +1,50 @@
+export type BuildContext<T = unknown> = {
+    package: PackageContext;
+    build: BuildIdentity;
+    options: BuildOptions;
+} & (unknown extends T ? {} : { bundlerConfig: T });
+
+export interface PackageContext {
+    name: string;
+    version: string;
+    destination: string;
+    source: string;
+    dependencies: Record<string, string>;
+    sharedDependencies: Record<string, string>;
+    isWebComponent: boolean;
+    isLegacyRoot: boolean;
+    isExposeSharedDependencies: boolean;
+}
+
+export interface BuildIdentity {
+    name: string;
+    isProduction: boolean;
+    light?: boolean;
+    headless?: boolean;
+    emitExposedDependencies?: boolean | { output?: { path?: string } };
+}
+
+export interface BuildOptions {
+    codeCoverage?: boolean;
+    buildStat?: boolean;
+}
+
+export interface EntryPoint {
+    css?: string[];
+    js?: string[];
+}
+
+export interface EntryPoints {
+    full?: EntryPoint;
+    light?: EntryPoint;
+    headless?: EntryPoint;
+}
+
+export interface Metadata {
+    name: string;
+    version: string;
+    bundledWith: Record<string, string | undefined>;
+    sharedDependencies: Record<string, string>;
+    dependencies: Record<string, string>;
+    entrypoints: EntryPoints;
+}

package/src/core/virtual-modules.ts

@@ -0,0 +1,74 @@
+import fs from 'fs';
+import path from 'path';
+import { BuildContext } from './types';
+
+export function virtualModules(context: BuildContext) {
+    const modules: { index?: string; designSystem?: string } = {};
+
+    if (context.package.isWebComponent) {
+        modules.index = indexCode(context);
+    }
+
+    if (needsToIncludeDesignSystem(context)) {
+        const designSystemPath = getDesignSystemPath(context);
+        if (!fs.existsSync(designSystemPath)) {
+            modules.designSystem = designSystemCode();
+        }
+    }
+
+    return modules;
+}
+
+export function getDesignSystemPath(context: BuildContext) {
+    return path.join(process.cwd(), context.package.destination, 'design-system.css');
+}
+
+function designSystemCode() {
+    return [
+        `@import '@servicetitan/tokens/core/tokens.css';`,
+        `@import '@servicetitan/anvil-fonts/dist/css/anvil-fonts.css';`,
+        `@import '@servicetitan/design-system/dist/system.min.css';`,
+    ].join('\n');
+}
+
+function indexCode(context: BuildContext) {
+    const { light = false, headless } = context.build;
+    const { isLegacyRoot, sharedDependencies } = context.package;
+    if (headless) {
+        return headlessIndex();
+    }
+
+    const options = `{ legacyRoot: ${isLegacyRoot}, sharedDependenciesNames: ${JSON.stringify(
+        Object.keys(sharedDependencies)
+    )} }`;
+
+    return [
+        ...(needsToIncludeDesignSystem(context) ? [`import './design-system.css';`] : []),
+        `import { register } from '@servicetitan/web-components';`,
+        `import { App } from './app';`,
+        `register(App, ${light}, ${options});`,
+    ].join('\n');
+}
+
+export function needsToIncludeDesignSystem(context: BuildContext) {
+    const { light, headless, emitExposedDependencies } = context.build;
+    const { isWebComponent, dependencies, sharedDependencies } = context.package;
+
+    return (
+        (!!emitExposedDependencies && !!sharedDependencies['@servicetitan/design-system']) ||
+        (isWebComponent &&
+            !headless &&
+            // Depends on design system
+            !!dependencies['@servicetitan/design-system'] &&
+            // ... and is not light bundle with private copy of design system
+            !(light && !!sharedDependencies['@servicetitan/design-system']))
+    );
+}
+
+function headlessIndex() {
+    return [
+        "import { registerHeadless } from '@servicetitan/web-components/register-headless';",
+        "import { connectedCallback, disconnectedCallback } from './headless';",
+        'registerHeadless(connectedCallback, disconnectedCallback);',
+    ].join('\n');
+}

package/src/cypress/config/__tests__/webpack-config.test.ts

@@ -2,7 +2,8 @@ import { fs, vol } from 'memfs';
 import { getSwcOptions } from '../../../cli/tasks';
 import { TSConfig } from '../../../cli/utils';
 import { getBaseTsConfig } from '../../../utils';
-import { Overrides, rulesConfig } from '../../../webpack/configs';
+import { rulesConfig } from '../../../webpack/configs';
+import { Overrides } from '../../../webpack/types';
 import { webpackConfig } from '../webpack-config';
 
 jest.mock('fs', () => fs);
@@ -40,7 +41,16 @@ describe(`[startup/cypress-config] ${webpackConfig.name}`, () => {
         subject();
 
         expect(rulesConfig).toHaveBeenCalledWith(
-            expect.objectContaining({ isProduction: false }),
+            expect.objectContaining({ build: expect.objectContaining({ isProduction: false }) }),
+            expect.anything()
+        );
+    });
+
+    test('enables code coverage', () => {
+        subject();
+
+        expect(rulesConfig).toHaveBeenCalledWith(
+            expect.objectContaining({ options: { codeCoverage: true } }),
             expect.anything()
         );
     });

package/src/cypress/config/webpack-config.ts

@@ -4,7 +4,8 @@ import merge from 'webpack-merge';
 import { getSwcOptions } from '../../cli/tasks';
 import { TSConfig } from '../../cli/utils';
 import { getTsConfigWithFallback, log } from '../../utils';
-import { Context, Overrides, rulesConfig } from '../../webpack/configs';
+import { rulesConfig } from '../../webpack/configs';
+import { Overrides, WebpackBuildContext } from '../../webpack/types';
 
 export function webpackConfig(overrides?: Overrides): Configuration {
     const context = getContext();
@@ -25,18 +26,31 @@ export function webpackConfig(overrides?: Overrides): Configuration {
     return merge(config, overrides?.configuration ?? {});
 }
 
-function getContext(): Context {
+function getContext(): WebpackBuildContext {
     return {
-        destination: '',
-        isProduction: false,
-        name: '',
-        packageData: {} as any,
-        sharedDependencies: {},
-        source: '',
+        package: {
+            name: '',
+            version: '',
+            destination: '',
+            source: '',
+            dependencies: {},
+            sharedDependencies: {},
+            isWebComponent: false,
+            isLegacyRoot: false,
+            isExposeSharedDependencies: false,
+        },
+        build: {
+            name: '',
+            isProduction: false,
+        },
+        options: {
+            codeCoverage: true,
+        },
+        bundlerConfig: {},
     };
 }
 
-function getRules(context: Context, overrides: Overrides) {
+function getRules(context: WebpackBuildContext, overrides: Overrides) {
     const { rules } = rulesConfig(context, overrides);
 
     return [getSwcLoaderRule(), ...rules];

package/src/index.ts

@@ -1,2 +1,3 @@
 export * from './utils/get-packages';
+
 export * from './webpack';

package/src/storybook-config/__tests__/webpack-final.test.ts

@@ -1,6 +1,7 @@
 import type { Configuration } from 'webpack';
-import { Overrides, rulesConfig } from '../../webpack/configs';
+import { rulesConfig } from '../../webpack/configs';
 import { miniCssExtractPlugin } from '../../webpack/configs/plugins';
+import { Overrides } from '../../webpack/types';
 import { webpackFinal } from '../webpack-final';
 
 jest.mock('../../webpack/configs');
@@ -91,7 +92,9 @@ describe(`[startup/storybook-config] ${webpackFinal.name}`, () => {
             subject();
 
             expect(rulesConfig).toHaveBeenCalledWith(
-                expect.objectContaining({ isProduction: true }),
+                expect.objectContaining({
+                    build: expect.objectContaining({ isProduction: true }),
+                }),
                 expect.anything()
             );
         });

package/src/storybook-config/webpack-final.ts

@@ -1,8 +1,9 @@
 import { inspect } from 'node:util';
 import type { Configuration } from 'webpack';
 import { log } from '../utils';
-import { Context, Overrides, rulesConfig } from '../webpack/configs';
+import { rulesConfig } from '../webpack/configs';
 import { miniCssExtractPlugin } from '../webpack/configs/plugins';
+import { Overrides, WebpackBuildContext } from '../webpack/types';
 
 export function webpackFinal(config: Configuration, overrides: Overrides = {}): Configuration {
     const context = getContext(config);
@@ -22,22 +23,33 @@ export function webpackFinal(config: Configuration, overrides: Overrides = {}):
     };
 }
 
-function getContext(config: Configuration): Context {
+function getContext(config: Configuration): WebpackBuildContext {
     return {
-        destination: '',
-        isProduction: config.mode === 'production',
-        name: '',
-        packageData: {} as any,
-        sharedDependencies: {},
-        source: '',
+        package: {
+            name: '',
+            version: '',
+            destination: '',
+            source: '',
+            dependencies: {},
+            sharedDependencies: {},
+            isWebComponent: false,
+            isLegacyRoot: false,
+            isExposeSharedDependencies: false,
+        },
+        build: {
+            name: '',
+            isProduction: config.mode === 'production',
+        },
+        options: {},
+        bundlerConfig: {},
     };
 }
 
-function getPlugins(context: Context, overrides: Overrides) {
+function getPlugins(context: WebpackBuildContext, overrides: Overrides) {
     return [miniCssExtractPlugin(context, overrides)].filter(plugin => !!plugin);
 }
 
-function getRules(context: Context, overrides: Overrides) {
+function getRules(context: WebpackBuildContext, overrides: Overrides) {
     const include = ['.module.css', '.module.less', '.less', '.module.scss', '.scss', '.svg'];
     const exclude = ['.css'];
 

package/src/utils/__tests__/get-configuration.test.ts

@@ -7,12 +7,12 @@ import {
     getJestConfiguration,
     getReviewConfiguration,
     getStylelintConfiguration,
+    getViteConfiguration,
     getVitestConfiguration,
     getWebComponentBranchConfigs,
     getWebComponentConfiguration,
     hasHeadlessBundle,
     isBundle,
-    isCustomStyleRules,
     isDevServerDisabled,
     isExposeSharedDependencies,
     isLegacy,
@@ -225,6 +225,29 @@ describe('[startup] Utils', () => {
         });
     });
 
+    describe(getViteConfiguration.name, () => {
+        const subject = () => getViteConfiguration();
+
+        itReturns(subject, {});
+
+        describe('with "cli.vite"', () => {
+            const content = {
+                cli: {
+                    vite: {
+                        omitDefault: ['plugins.svgr'],
+                        config: { server: { port: 9000 }, build: { minify: false } },
+                    },
+                },
+            };
+
+            beforeEach(() => mockPackageJson(content));
+
+            test('returns "cli.vite"', () => {
+                expect(subject()).toEqual(content.cli.vite);
+            });
+        });
+    });
+
     describe(getVitestConfiguration.name, () => {
         const subject = () => getVitestConfiguration();
 
@@ -394,11 +417,6 @@ describe('[startup] Utils', () => {
             defaultValue: true,
             trigger: { cli: { webpack: false } },
         },
-        {
-            fn: isCustomStyleRules,
-            defaultValue: false,
-            trigger: { cli: { webpack: { 'custom-style-rules': true } } },
-        },
         {
             fn: isDevServerDisabled,
             defaultValue: false,
@@ -407,7 +425,10 @@ describe('[startup] Utils', () => {
         {
             fn: isExposeSharedDependencies,
             defaultValue: false,
-            trigger: { cli: { webpack: { 'expose-shared-dependencies': true } } },
+            trigger: [
+                { cli: { 'expose-shared-dependencies': true } },
+                { cli: { webpack: { 'expose-shared-dependencies': true } } },
+            ],
         },
         {
             fn: isLegacy,

package/src/utils/__tests__/get-package-data.test.ts

@@ -32,7 +32,7 @@ describe(`[startup] Utils`, () => {
             });
         });
 
-        describe(`when ${packageJson} contains sharedDependencies`, () => {
+        describe(`when ${packageJson} contains cli.webpack.sharedDependencies`, () => {
             const sharedDependencies = { react: 'SharedDependencies.React' };
 
             beforeEach(() => {
@@ -45,6 +45,40 @@ describe(`[startup] Utils`, () => {
                 expect(subject()).toEqual(expect.objectContaining({ sharedDependencies }));
             });
         });
+
+        describe(`when ${packageJson} contains cli.sharedDependencies`, () => {
+            const sharedDependencies = { mobx: 'SharedDependencies.MobX' };
+
+            beforeEach(() => {
+                Object.assign(packages[packageJson], {
+                    cli: { 'shared-dependencies': sharedDependencies },
+                });
+            });
+
+            test('returns sharedDependencies', () => {
+                expect(subject()).toEqual(expect.objectContaining({ sharedDependencies }));
+            });
+        });
+
+        describe(`when ${packageJson} contains cli.sharedDependencies and cli.webpack.sharedDependencies`, () => {
+            const topLevel = { react: 'SharedDependencies.React' };
+            const webpack = { mobx: 'SharedDependencies.MobX' };
+
+            beforeEach(() => {
+                Object.assign(packages[packageJson], {
+                    cli: {
+                        'shared-dependencies': topLevel,
+                        'webpack': { 'shared-dependencies': webpack },
+                    },
+                });
+            });
+
+            test('returns cli.sharedDependencies', () => {
+                expect(subject()).toEqual(
+                    expect.objectContaining({ sharedDependencies: topLevel })
+                );
+            });
+        });
     });
 
     describe(`${getPackageDependencyVersion.name}`, () => {

package/src/utils/__tests__/get-packages.test.ts

@@ -65,7 +65,7 @@ describe('[startup] Utils', () => {
                     version: '1.0.0',
                     private: true,
                     location: path.resolve('./packages/foo'),
-                    type: PackageType.Webpack,
+                    type: PackageType.Bundle,
                 },
                 {
                     name: 'bar',
@@ -167,14 +167,14 @@ describe('[startup] Utils', () => {
         });
 
         describe('with "type"', () => {
-            beforeEach(() => (options = { type: PackageType.Webpack }));
+            beforeEach(() => (options = { type: PackageType.Bundle }));
 
             test('returns only the specified packages', () => {
                 expect(subject()).toEqual([expect.objectContaining({ name: 'foo' })]);
             });
 
             describe('when "type" is an array', () => {
-                beforeEach(() => (options = { type: [PackageType.TSC, PackageType.Webpack] }));
+                beforeEach(() => (options = { type: [PackageType.TSC, PackageType.Bundle] }));
 
                 test('returns only the specified packages', () => {
                     expect(subject()).toEqual(

package/src/utils/__tests__/validate-shared-dependencies.test.ts

@@ -0,0 +1,55 @@
+import { fs, vol } from 'memfs';
+import { validateSharedDependencies } from '../validate-shared-dependencies';
+
+jest.mock('fs', () => fs);
+
+describe('validateSharedDependencies', () => {
+    function mockPackageJson(content: Record<string, any> = {}) {
+        vol.fromJSON({ 'package.json': JSON.stringify(content) });
+    }
+
+    afterEach(() => vol.reset());
+
+    test('passes when neither is set', () => {
+        mockPackageJson();
+        expect(() => validateSharedDependencies()).not.toThrow();
+    });
+
+    test('passes when only cli top level is set', () => {
+        mockPackageJson({ cli: { 'shared-dependencies': { defaults: '' } } });
+        expect(() => validateSharedDependencies()).not.toThrow();
+    });
+
+    test('passes when only cli.webpack is set', () => {
+        mockPackageJson({ cli: { webpack: { 'shared-dependencies': { defaults: '' } } } });
+        expect(() => validateSharedDependencies()).not.toThrow();
+    });
+
+    test('passes when both are set and identical', () => {
+        const deps = { defaults: '', lodash: 'SharedDependencies.Lodash' };
+        mockPackageJson({
+            cli: { 'shared-dependencies': deps, 'webpack': { 'shared-dependencies': deps } },
+        });
+        expect(() => validateSharedDependencies()).not.toThrow();
+    });
+
+    test('throws when shared-dependencies both exist and differ', () => {
+        mockPackageJson({
+            cli: {
+                'shared-dependencies': { defaults: '' },
+                'webpack': { 'shared-dependencies': { defaults: '', extra: 'foo' } },
+            },
+        });
+        expect(() => validateSharedDependencies()).toThrow(/both set but differ/);
+    });
+
+    test('throws when expose-shared-dependencies both exist and differ', () => {
+        mockPackageJson({
+            cli: {
+                'expose-shared-dependencies': true,
+                'webpack': { 'expose-shared-dependencies': false },
+            },
+        });
+        expect(() => validateSharedDependencies()).toThrow(/both set but differ/);
+    });
+});