@servicetitan/startup 34.0.0 → 34.0.1

package/dist/cli/commands/review/rules/require-tsconfig-references.d.ts

@@ -19,6 +19,8 @@ export declare class RequireTsconfigReferences implements PackageRule {
     private collectTsConfigFiles;
     private findMissingDependencyReferences;
     private readonly checkTsConfigReferences;
+    private isDefaultTsConfig;
+    private isDirectory;
 }
 export {};
 //# sourceMappingURL=require-tsconfig-references.d.ts.map

package/dist/cli/commands/review/rules/require-tsconfig-references.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"require-tsconfig-references.d.ts","sourceRoot":"","sources":["../../../../../src/cli/commands/review/rules/require-tsconfig-references.ts"],"names":[],"mappings":"AAIA,OAAO,EAAwB,YAAY,EAAE,WAAW,EAAE,OAAO,EAAE,MAAM,UAAU,CAAC;AAOpF,UAAU,SAAS;IACf,YAAY,EAAE,MAAM,CAAC;IACrB,gBAAgB,EAAE,MAAM,CAAC;IACzB,YAAY,EAAE,MAAM,CAAC;CACxB;AAED,MAAM,MAAM,SAAS,GAAG,YAAY,CAAC,SAAS,CAAC,CAAC;AAEhD,qBAAa,yBAA0B,YAAW,WAAW;IACzD,OAAO,CAAC,qBAAqB,CAAuB;IACpD,OAAO,CAAC,qBAAqB,CAAuB;IACpD,OAAO,CAAC,qBAAqB,CAAe;IAE5C,IAAI,EAAE,WAEL;IAED,GAAG,CAAC,OAAO,EAAE,OAAO,GAAG,SAAS,EAAE;IAYlC,GAAG,CAAC,EAAE,IAAI,EAAE,EAAE,SAAS;IAmBvB,OAAO,CAAC,oBAAoB;IAY5B,OAAO,CAAC,qBAAqB;IAI7B,OAAO,CAAC,6BAA6B;IAuBrC,OAAO,CAAC,wBAAwB;IAQhC,OAAO,CAAC,oBAAoB;IAS5B,OAAO,CAAC,+BAA+B;IA6BvC,OAAO,CAAC,QAAQ,CAAC,uBAAuB,CAWtC;CACL"}
+{"version":3,"file":"require-tsconfig-references.d.ts","sourceRoot":"","sources":["../../../../../src/cli/commands/review/rules/require-tsconfig-references.ts"],"names":[],"mappings":"AAIA,OAAO,EAAwB,YAAY,EAAE,WAAW,EAAE,OAAO,EAAE,MAAM,UAAU,CAAC;AAOpF,UAAU,SAAS;IACf,YAAY,EAAE,MAAM,CAAC;IACrB,gBAAgB,EAAE,MAAM,CAAC;IACzB,YAAY,EAAE,MAAM,CAAC;CACxB;AAED,MAAM,MAAM,SAAS,GAAG,YAAY,CAAC,SAAS,CAAC,CAAC;AAEhD,qBAAa,yBAA0B,YAAW,WAAW;IACzD,OAAO,CAAC,qBAAqB,CAAuB;IACpD,OAAO,CAAC,qBAAqB,CAAuB;IACpD,OAAO,CAAC,qBAAqB,CAAe;IAE5C,IAAI,EAAE,WAEL;IAED,GAAG,CAAC,OAAO,EAAE,OAAO,GAAG,SAAS,EAAE;IAYlC,GAAG,CAAC,EAAE,IAAI,EAAE,EAAE,SAAS;IAgBvB,OAAO,CAAC,oBAAoB;IAY5B,OAAO,CAAC,qBAAqB;IAO7B,OAAO,CAAC,6BAA6B;IAwBrC,OAAO,CAAC,wBAAwB;IAWhC,OAAO,CAAC,oBAAoB;IAS5B,OAAO,CAAC,+BAA+B;IA6BvC,OAAO,CAAC,QAAQ,CAAC,uBAAuB,CAWtC;IAEF,OAAO,CAAC,iBAAiB;IAIzB,OAAO,CAAC,WAAW;CAOtB"}

package/dist/cli/commands/review/rules/require-tsconfig-references.js

@@ -54,10 +54,7 @@ class RequireTsconfigReferences {
             return;
         }
         const { tsconfigPath, expectedPath } = data;
-        const tsconfig = (0, _utils.readJsonSafe)(tsconfigPath);
-        if (!tsconfig) {
-            return;
-        }
+        const tsconfig = (0, _utils.readJson)(tsconfigPath);
         const references = (_tsconfig_references = tsconfig.references) !== null && _tsconfig_references !== void 0 ? _tsconfig_references : [];
         references.push({
             path: expectedPath
@@ -75,6 +72,9 @@ class RequireTsconfigReferences {
         return Object.keys(dependencies).filter((dependency)=>this.workspacePackageNames.has(dependency));
     }
     normalizeTsConfigPath(filePath) {
+        if (this.isDirectory(filePath)) {
+            return _nodepath.default.join(filePath, 'tsconfig.json');
+        }
         return filePath.endsWith('.json') ? filePath : `${filePath}.json`;
     }
     getTsConfigReferencedPackages(tsconfigPath) {
@@ -85,8 +85,7 @@ class RequireTsconfigReferences {
         const tsconfigDir = _nodepath.default.dirname(tsconfigPath);
         const referencedPackages = new Set();
         for (const reference of config.references){
-            const normalizedPath = this.normalizeTsConfigPath(reference.path);
-            const resolvedRefPath = _nodepath.default.resolve(tsconfigDir, normalizedPath);
+            const resolvedRefPath = this.normalizeTsConfigPath(_nodepath.default.resolve(tsconfigDir, reference.path));
             const refDir = _nodepath.default.dirname(resolvedRefPath);
             const packageName = this.locationToPackageName.get(refDir);
             if (packageName) {
@@ -99,7 +98,8 @@ class RequireTsconfigReferences {
         const relativePath = _nodepath.default.relative(fromLocation, toLocation);
         const tsconfigFile = (0, _utils.getTsConfig)(toLocation);
         const tsconfigName = _nodepath.default.basename(tsconfigFile);
-        return _nodepath.default.join(relativePath, tsconfigName).replaceAll('\\', '/');
+        const referencePath = this.isDefaultTsConfig(tsconfigName) ? relativePath : _nodepath.default.join(relativePath, tsconfigName);
+        return referencePath.replaceAll('\\', '/');
     }
     collectTsConfigFiles(location) {
         const tsconfigFiles = (0, _glob.globSync)([
@@ -128,6 +128,16 @@ class RequireTsconfigReferences {
             };
         });
     }
+    isDefaultTsConfig(name) {
+        return name === 'tsconfig.json';
+    }
+    isDirectory(file) {
+        try {
+            return _nodefs.default.statSync(file).isDirectory();
+        } catch (unused) {
+            return false;
+        }
+    }
     constructor(){
         _define_property(this, "packageNameToLocation", void 0);
         _define_property(this, "locationToPackageName", void 0);

package/dist/cli/commands/review/rules/require-tsconfig-references.js.map

@@ -1 +1 @@
-{"version":3,"sources":["../../../../../src/cli/commands/review/rules/require-tsconfig-references.ts"],"sourcesContent":["import { globSync } from 'glob';\nimport fs from 'node:fs';\nimport path from 'node:path';\nimport { getTsConfig, prettifySync, readJsonSafe } from '../../../../utils';\nimport { FixCategory, Package, PackageError, PackageRule, Project } from '../types';\nimport { checkPackages } from '../utils';\n\ninterface TsConfig {\n    references?: { path: string }[];\n}\n\ninterface ErrorData {\n    tsconfigPath: string;\n    missingReference: string;\n    expectedPath: string;\n}\n\nexport type RuleError = PackageError<ErrorData>;\n\nexport class RequireTsconfigReferences implements PackageRule {\n    private packageNameToLocation!: Map<string, string>;\n    private locationToPackageName!: Map<string, string>;\n    private workspacePackageNames!: Set<string>;\n\n    get id() {\n        return 'require-tsconfig-references';\n    }\n\n    run(project: Project): RuleError[] {\n        this.packageNameToLocation = new Map(\n            project.packages.map(({ name, location }) => [name, location])\n        );\n        this.locationToPackageName = new Map(\n            project.packages.map(({ name, location }) => [path.resolve(location), name])\n        );\n        this.workspacePackageNames = new Set(project.packages.map(({ name }) => name));\n\n        return checkPackages(this, project, this.checkTsConfigReferences);\n    }\n\n    fix({ data }: RuleError) {\n        if (!data) {\n            return;\n        }\n\n        const { tsconfigPath, expectedPath } = data;\n        const tsconfig = readJsonSafe<TsConfig>(tsconfigPath);\n        if (!tsconfig) {\n            return;\n        }\n\n        const references = tsconfig.references ?? [];\n        references.push({ path: expectedPath });\n        tsconfig.references = references;\n\n        fs.writeFileSync(tsconfigPath, JSON.stringify(tsconfig) + '\\n', 'utf-8');\n        prettifySync(tsconfigPath);\n    }\n\n    private getLocalDependencies(pkg: Package) {\n        const dependencies = {\n            ...pkg.dependencies,\n            ...pkg.devDependencies,\n            ...pkg.peerDependencies,\n        };\n\n        return Object.keys(dependencies).filter(dependency =>\n            this.workspacePackageNames.has(dependency)\n        );\n    }\n\n    private normalizeTsConfigPath(filePath: string): string {\n        return filePath.endsWith('.json') ? filePath : `${filePath}.json`;\n    }\n\n    private getTsConfigReferencedPackages(tsconfigPath: string) {\n        const config = readJsonSafe<TsConfig>(tsconfigPath);\n        if (!config?.references) {\n            return new Set<string>();\n        }\n\n        const tsconfigDir = path.dirname(tsconfigPath);\n        const referencedPackages = new Set<string>();\n\n        for (const reference of config.references) {\n            const normalizedPath = this.normalizeTsConfigPath(reference.path);\n            const resolvedRefPath = path.resolve(tsconfigDir, normalizedPath);\n            const refDir = path.dirname(resolvedRefPath);\n            const packageName = this.locationToPackageName.get(refDir);\n\n            if (packageName) {\n                referencedPackages.add(packageName);\n            }\n        }\n\n        return referencedPackages;\n    }\n\n    private getExpectedReferencePath(fromLocation: string, toLocation: string) {\n        const relativePath = path.relative(fromLocation, toLocation);\n        const tsconfigFile = getTsConfig(toLocation);\n        const tsconfigName = path.basename(tsconfigFile);\n\n        return path.join(relativePath, tsconfigName).replaceAll('\\\\', '/');\n    }\n\n    private collectTsConfigFiles(location: string): string[] {\n        const tsconfigFiles = globSync(['tsconfig.json', 'tsconfig.*.json'], {\n            absolute: false,\n            cwd: location,\n        });\n\n        return tsconfigFiles.map(tsconfigFile => path.join(location, tsconfigFile));\n    }\n\n    private findMissingDependencyReferences(\n        pkg: Package,\n        tsconfigPath: string,\n        localDependencies: string[]\n    ): RuleError[] {\n        const referencedPackages = this.getTsConfigReferencedPackages(tsconfigPath);\n\n        return localDependencies\n            .filter(dependency => !referencedPackages.has(dependency))\n            .map(dependency => {\n                const dependencyLocation = this.packageNameToLocation.get(dependency)!;\n\n                return {\n                    id: this.id,\n                    message: `missing reference for dependency: ${dependency}`,\n                    location: tsconfigPath,\n                    fixable: FixCategory.normal,\n                    data: {\n                        tsconfigPath,\n                        missingReference: dependency,\n                        expectedPath: this.getExpectedReferencePath(\n                            pkg.location,\n                            dependencyLocation\n                        ),\n                    },\n                };\n            });\n    }\n\n    private readonly checkTsConfigReferences = (pkg: Package) => {\n        if (pkg.location === '.') {\n            return [];\n        }\n\n        const tsconfigFiles = this.collectTsConfigFiles(pkg.location);\n        const localDependencies = this.getLocalDependencies(pkg);\n\n        return tsconfigFiles.flatMap(tsconfigPath =>\n            this.findMissingDependencyReferences(pkg, tsconfigPath, localDependencies)\n        );\n    };\n}\n"],"names":["RequireTsconfigReferences","id","run","project","packageNameToLocation","Map","packages","map","name","location","locationToPackageName","path","resolve","workspacePackageNames","Set","checkPackages","checkTsConfigReferences","fix","data","tsconfig","tsconfigPath","expectedPath","readJsonSafe","references","push","fs","writeFileSync","JSON","stringify","prettifySync","getLocalDependencies","pkg","dependencies","devDependencies","peerDependencies","Object","keys","filter","dependency","has","normalizeTsConfigPath","filePath","endsWith","getTsConfigReferencedPackages","config","tsconfigDir","dirname","referencedPackages","reference","normalizedPath","resolvedRefPath","refDir","packageName","get","add","getExpectedReferencePath","fromLocation","toLocation","relativePath","relative","tsconfigFile","getTsConfig","tsconfigName","basename","join","replaceAll","collectTsConfigFiles","tsconfigFiles","globSync","absolute","cwd","findMissingDependencyReferences","localDependencies","dependencyLocation","message","fixable","FixCategory","normal","missingReference","flatMap"],"mappings":";;;;+BAmBaA;;;eAAAA;;;sBAnBY;+DACV;iEACE;uBACuC;uBACiB;wBAC3C;;;;;;;;;;;;;;;;;;;AAcvB,MAAMA;IAKT,IAAIC,KAAK;QACL,OAAO;IACX;IAEAC,IAAIC,OAAgB,EAAe;QAC/B,IAAI,CAACC,qBAAqB,GAAG,IAAIC,IAC7BF,QAAQG,QAAQ,CAACC,GAAG,CAAC,CAAC,EAAEC,IAAI,EAAEC,QAAQ,EAAE,GAAK;gBAACD;gBAAMC;aAAS;QAEjE,IAAI,CAACC,qBAAqB,GAAG,IAAIL,IAC7BF,QAAQG,QAAQ,CAACC,GAAG,CAAC,CAAC,EAAEC,IAAI,EAAEC,QAAQ,EAAE,GAAK;gBAACE,iBAAI,CAACC,OAAO,CAACH;gBAAWD;aAAK;QAE/E,IAAI,CAACK,qBAAqB,GAAG,IAAIC,IAAIX,QAAQG,QAAQ,CAACC,GAAG,CAAC,CAAC,EAAEC,IAAI,EAAE,GAAKA;QAExE,OAAOO,IAAAA,qBAAa,EAAC,IAAI,EAAEZ,SAAS,IAAI,CAACa,uBAAuB;IACpE;IAEAC,IAAI,EAAEC,IAAI,EAAa,EAAE;YAWFC;QAVnB,IAAI,CAACD,MAAM;YACP;QACJ;QAEA,MAAM,EAAEE,YAAY,EAAEC,YAAY,EAAE,GAAGH;QACvC,MAAMC,WAAWG,IAAAA,mBAAY,EAAWF;QACxC,IAAI,CAACD,UAAU;YACX;QACJ;QAEA,MAAMI,cAAaJ,uBAAAA,SAASI,UAAU,cAAnBJ,kCAAAA,uBAAuB,EAAE;QAC5CI,WAAWC,IAAI,CAAC;YAAEb,MAAMU;QAAa;QACrCF,SAASI,UAAU,GAAGA;QAEtBE,eAAE,CAACC,aAAa,CAACN,cAAcO,KAAKC,SAAS,CAACT,YAAY,MAAM;QAChEU,IAAAA,mBAAY,EAACT;IACjB;IAEQU,qBAAqBC,GAAY,EAAE;QACvC,MAAMC,eAAe;YACjB,GAAGD,IAAIC,YAAY;YACnB,GAAGD,IAAIE,eAAe;YACtB,GAAGF,IAAIG,gBAAgB;QAC3B;QAEA,OAAOC,OAAOC,IAAI,CAACJ,cAAcK,MAAM,CAACC,CAAAA,aACpC,IAAI,CAACzB,qBAAqB,CAAC0B,GAAG,CAACD;IAEvC;IAEQE,sBAAsBC,QAAgB,EAAU;QACpD,OAAOA,SAASC,QAAQ,CAAC,WAAWD,WAAW,GAAGA,SAAS,KAAK,CAAC;IACrE;IAEQE,8BAA8BvB,YAAoB,EAAE;QACxD,MAAMwB,SAAStB,IAAAA,mBAAY,EAAWF;QACtC,IAAI,EAACwB,mBAAAA,6BAAAA,OAAQrB,UAAU,GAAE;YACrB,OAAO,IAAIT;QACf;QAEA,MAAM+B,cAAclC,iBAAI,CAACmC,OAAO,CAAC1B;QACjC,MAAM2B,qBAAqB,IAAIjC;QAE/B,KAAK,MAAMkC,aAAaJ,OAAOrB,UAAU,CAAE;YACvC,MAAM0B,iBAAiB,IAAI,CAACT,qBAAqB,CAACQ,UAAUrC,IAAI;YAChE,MAAMuC,kBAAkBvC,iBAAI,CAACC,OAAO,CAACiC,aAAaI;YAClD,MAAME,SAASxC,iBAAI,CAACmC,OAAO,CAACI;YAC5B,MAAME,cAAc,IAAI,CAAC1C,qBAAqB,CAAC2C,GAAG,CAACF;YAEnD,IAAIC,aAAa;gBACbL,mBAAmBO,GAAG,CAACF;YAC3B;QACJ;QAEA,OAAOL;IACX;IAEQQ,yBAAyBC,YAAoB,EAAEC,UAAkB,EAAE;QACvE,MAAMC,eAAe/C,iBAAI,CAACgD,QAAQ,CAACH,cAAcC;QACjD,MAAMG,eAAeC,IAAAA,kBAAW,EAACJ;QACjC,MAAMK,eAAenD,iBAAI,CAACoD,QAAQ,CAACH;QAEnC,OAAOjD,iBAAI,CAACqD,IAAI,CAACN,cAAcI,cAAcG,UAAU,CAAC,MAAM;IAClE;IAEQC,qBAAqBzD,QAAgB,EAAY;QACrD,MAAM0D,gBAAgBC,IAAAA,cAAQ,EAAC;YAAC;YAAiB;SAAkB,EAAE;YACjEC,UAAU;YACVC,KAAK7D;QACT;QAEA,OAAO0D,cAAc5D,GAAG,CAACqD,CAAAA,eAAgBjD,iBAAI,CAACqD,IAAI,CAACvD,UAAUmD;IACjE;IAEQW,gCACJxC,GAAY,EACZX,YAAoB,EACpBoD,iBAA2B,EAChB;QACX,MAAMzB,qBAAqB,IAAI,CAACJ,6BAA6B,CAACvB;QAE9D,OAAOoD,kBACFnC,MAAM,CAACC,CAAAA,aAAc,CAACS,mBAAmBR,GAAG,CAACD,aAC7C/B,GAAG,CAAC+B,CAAAA;YACD,MAAMmC,qBAAqB,IAAI,CAACrE,qBAAqB,CAACiD,GAAG,CAACf;YAE1D,OAAO;gBACHrC,IAAI,IAAI,CAACA,EAAE;gBACXyE,SAAS,CAAC,kCAAkC,EAAEpC,YAAY;gBAC1D7B,UAAUW;gBACVuD,SAASC,kBAAW,CAACC,MAAM;gBAC3B3D,MAAM;oBACFE;oBACA0D,kBAAkBxC;oBAClBjB,cAAc,IAAI,CAACkC,wBAAwB,CACvCxB,IAAItB,QAAQ,EACZgE;gBAER;YACJ;QACJ;IACR;;QA1HA,uBAAQrE,yBAAR,KAAA;QACA,uBAAQM,yBAAR,KAAA;QACA,uBAAQG,yBAAR,KAAA;QA0HA,uBAAiBG,2BAA0B,CAACe;YACxC,IAAIA,IAAItB,QAAQ,KAAK,KAAK;gBACtB,OAAO,EAAE;YACb;YAEA,MAAM0D,gBAAgB,IAAI,CAACD,oBAAoB,CAACnC,IAAItB,QAAQ;YAC5D,MAAM+D,oBAAoB,IAAI,CAAC1C,oBAAoB,CAACC;YAEpD,OAAOoC,cAAcY,OAAO,CAAC3D,CAAAA,eACzB,IAAI,CAACmD,+BAA+B,CAACxC,KAAKX,cAAcoD;QAEhE;;AACJ"}
+{"version":3,"sources":["../../../../../src/cli/commands/review/rules/require-tsconfig-references.ts"],"sourcesContent":["import { globSync } from 'glob';\nimport fs from 'node:fs';\nimport path from 'node:path';\nimport { getTsConfig, prettifySync, readJson, readJsonSafe } from '../../../../utils';\nimport { FixCategory, Package, PackageError, PackageRule, Project } from '../types';\nimport { checkPackages } from '../utils';\n\ninterface TsConfig {\n    references?: { path: string }[];\n}\n\ninterface ErrorData {\n    tsconfigPath: string;\n    missingReference: string;\n    expectedPath: string;\n}\n\nexport type RuleError = PackageError<ErrorData>;\n\nexport class RequireTsconfigReferences implements PackageRule {\n    private packageNameToLocation!: Map<string, string>;\n    private locationToPackageName!: Map<string, string>;\n    private workspacePackageNames!: Set<string>;\n\n    get id() {\n        return 'require-tsconfig-references';\n    }\n\n    run(project: Project): RuleError[] {\n        this.packageNameToLocation = new Map(\n            project.packages.map(({ name, location }) => [name, location])\n        );\n        this.locationToPackageName = new Map(\n            project.packages.map(({ name, location }) => [path.resolve(location), name])\n        );\n        this.workspacePackageNames = new Set(project.packages.map(({ name }) => name));\n\n        return checkPackages(this, project, this.checkTsConfigReferences);\n    }\n\n    fix({ data }: RuleError) {\n        if (!data) {\n            return;\n        }\n\n        const { tsconfigPath, expectedPath } = data;\n        const tsconfig = readJson<TsConfig>(tsconfigPath);\n\n        const references = tsconfig.references ?? [];\n        references.push({ path: expectedPath });\n        tsconfig.references = references;\n\n        fs.writeFileSync(tsconfigPath, JSON.stringify(tsconfig) + '\\n', 'utf-8');\n        prettifySync(tsconfigPath);\n    }\n\n    private getLocalDependencies(pkg: Package) {\n        const dependencies = {\n            ...pkg.dependencies,\n            ...pkg.devDependencies,\n            ...pkg.peerDependencies,\n        };\n\n        return Object.keys(dependencies).filter(dependency =>\n            this.workspacePackageNames.has(dependency)\n        );\n    }\n\n    private normalizeTsConfigPath(filePath: string): string {\n        if (this.isDirectory(filePath)) {\n            return path.join(filePath, 'tsconfig.json');\n        }\n        return filePath.endsWith('.json') ? filePath : `${filePath}.json`;\n    }\n\n    private getTsConfigReferencedPackages(tsconfigPath: string) {\n        const config = readJsonSafe<TsConfig>(tsconfigPath);\n        if (!config?.references) {\n            return new Set<string>();\n        }\n\n        const tsconfigDir = path.dirname(tsconfigPath);\n        const referencedPackages = new Set<string>();\n\n        for (const reference of config.references) {\n            const resolvedRefPath = this.normalizeTsConfigPath(\n                path.resolve(tsconfigDir, reference.path)\n            );\n            const refDir = path.dirname(resolvedRefPath);\n            const packageName = this.locationToPackageName.get(refDir);\n\n            if (packageName) {\n                referencedPackages.add(packageName);\n            }\n        }\n\n        return referencedPackages;\n    }\n\n    private getExpectedReferencePath(fromLocation: string, toLocation: string) {\n        const relativePath = path.relative(fromLocation, toLocation);\n        const tsconfigFile = getTsConfig(toLocation);\n        const tsconfigName = path.basename(tsconfigFile);\n        const referencePath = this.isDefaultTsConfig(tsconfigName)\n            ? relativePath\n            : path.join(relativePath, tsconfigName);\n\n        return referencePath.replaceAll('\\\\', '/');\n    }\n\n    private collectTsConfigFiles(location: string): string[] {\n        const tsconfigFiles = globSync(['tsconfig.json', 'tsconfig.*.json'], {\n            absolute: false,\n            cwd: location,\n        });\n\n        return tsconfigFiles.map(tsconfigFile => path.join(location, tsconfigFile));\n    }\n\n    private findMissingDependencyReferences(\n        pkg: Package,\n        tsconfigPath: string,\n        localDependencies: string[]\n    ): RuleError[] {\n        const referencedPackages = this.getTsConfigReferencedPackages(tsconfigPath);\n\n        return localDependencies\n            .filter(dependency => !referencedPackages.has(dependency))\n            .map(dependency => {\n                const dependencyLocation = this.packageNameToLocation.get(dependency)!;\n\n                return {\n                    id: this.id,\n                    message: `missing reference for dependency: ${dependency}`,\n                    location: tsconfigPath,\n                    fixable: FixCategory.normal,\n                    data: {\n                        tsconfigPath,\n                        missingReference: dependency,\n                        expectedPath: this.getExpectedReferencePath(\n                            pkg.location,\n                            dependencyLocation\n                        ),\n                    },\n                };\n            });\n    }\n\n    private readonly checkTsConfigReferences = (pkg: Package) => {\n        if (pkg.location === '.') {\n            return [];\n        }\n\n        const tsconfigFiles = this.collectTsConfigFiles(pkg.location);\n        const localDependencies = this.getLocalDependencies(pkg);\n\n        return tsconfigFiles.flatMap(tsconfigPath =>\n            this.findMissingDependencyReferences(pkg, tsconfigPath, localDependencies)\n        );\n    };\n\n    private isDefaultTsConfig(name: string) {\n        return name === 'tsconfig.json';\n    }\n\n    private isDirectory(file: string) {\n        try {\n            return fs.statSync(file).isDirectory();\n        } catch {\n            return false;\n        }\n    }\n}\n"],"names":["RequireTsconfigReferences","id","run","project","packageNameToLocation","Map","packages","map","name","location","locationToPackageName","path","resolve","workspacePackageNames","Set","checkPackages","checkTsConfigReferences","fix","data","tsconfig","tsconfigPath","expectedPath","readJson","references","push","fs","writeFileSync","JSON","stringify","prettifySync","getLocalDependencies","pkg","dependencies","devDependencies","peerDependencies","Object","keys","filter","dependency","has","normalizeTsConfigPath","filePath","isDirectory","join","endsWith","getTsConfigReferencedPackages","config","readJsonSafe","tsconfigDir","dirname","referencedPackages","reference","resolvedRefPath","refDir","packageName","get","add","getExpectedReferencePath","fromLocation","toLocation","relativePath","relative","tsconfigFile","getTsConfig","tsconfigName","basename","referencePath","isDefaultTsConfig","replaceAll","collectTsConfigFiles","tsconfigFiles","globSync","absolute","cwd","findMissingDependencyReferences","localDependencies","dependencyLocation","message","fixable","FixCategory","normal","missingReference","file","statSync","flatMap"],"mappings":";;;;+BAmBaA;;;eAAAA;;;sBAnBY;+DACV;iEACE;uBACiD;uBACO;wBAC3C;;;;;;;;;;;;;;;;;;;AAcvB,MAAMA;IAKT,IAAIC,KAAK;QACL,OAAO;IACX;IAEAC,IAAIC,OAAgB,EAAe;QAC/B,IAAI,CAACC,qBAAqB,GAAG,IAAIC,IAC7BF,QAAQG,QAAQ,CAACC,GAAG,CAAC,CAAC,EAAEC,IAAI,EAAEC,QAAQ,EAAE,GAAK;gBAACD;gBAAMC;aAAS;QAEjE,IAAI,CAACC,qBAAqB,GAAG,IAAIL,IAC7BF,QAAQG,QAAQ,CAACC,GAAG,CAAC,CAAC,EAAEC,IAAI,EAAEC,QAAQ,EAAE,GAAK;gBAACE,iBAAI,CAACC,OAAO,CAACH;gBAAWD;aAAK;QAE/E,IAAI,CAACK,qBAAqB,GAAG,IAAIC,IAAIX,QAAQG,QAAQ,CAACC,GAAG,CAAC,CAAC,EAAEC,IAAI,EAAE,GAAKA;QAExE,OAAOO,IAAAA,qBAAa,EAAC,IAAI,EAAEZ,SAAS,IAAI,CAACa,uBAAuB;IACpE;IAEAC,IAAI,EAAEC,IAAI,EAAa,EAAE;YAQFC;QAPnB,IAAI,CAACD,MAAM;YACP;QACJ;QAEA,MAAM,EAAEE,YAAY,EAAEC,YAAY,EAAE,GAAGH;QACvC,MAAMC,WAAWG,IAAAA,eAAQ,EAAWF;QAEpC,MAAMG,cAAaJ,uBAAAA,SAASI,UAAU,cAAnBJ,kCAAAA,uBAAuB,EAAE;QAC5CI,WAAWC,IAAI,CAAC;YAAEb,MAAMU;QAAa;QACrCF,SAASI,UAAU,GAAGA;QAEtBE,eAAE,CAACC,aAAa,CAACN,cAAcO,KAAKC,SAAS,CAACT,YAAY,MAAM;QAChEU,IAAAA,mBAAY,EAACT;IACjB;IAEQU,qBAAqBC,GAAY,EAAE;QACvC,MAAMC,eAAe;YACjB,GAAGD,IAAIC,YAAY;YACnB,GAAGD,IAAIE,eAAe;YACtB,GAAGF,IAAIG,gBAAgB;QAC3B;QAEA,OAAOC,OAAOC,IAAI,CAACJ,cAAcK,MAAM,CAACC,CAAAA,aACpC,IAAI,CAACzB,qBAAqB,CAAC0B,GAAG,CAACD;IAEvC;IAEQE,sBAAsBC,QAAgB,EAAU;QACpD,IAAI,IAAI,CAACC,WAAW,CAACD,WAAW;YAC5B,OAAO9B,iBAAI,CAACgC,IAAI,CAACF,UAAU;QAC/B;QACA,OAAOA,SAASG,QAAQ,CAAC,WAAWH,WAAW,GAAGA,SAAS,KAAK,CAAC;IACrE;IAEQI,8BAA8BzB,YAAoB,EAAE;QACxD,MAAM0B,SAASC,IAAAA,mBAAY,EAAW3B;QACtC,IAAI,EAAC0B,mBAAAA,6BAAAA,OAAQvB,UAAU,GAAE;YACrB,OAAO,IAAIT;QACf;QAEA,MAAMkC,cAAcrC,iBAAI,CAACsC,OAAO,CAAC7B;QACjC,MAAM8B,qBAAqB,IAAIpC;QAE/B,KAAK,MAAMqC,aAAaL,OAAOvB,UAAU,CAAE;YACvC,MAAM6B,kBAAkB,IAAI,CAACZ,qBAAqB,CAC9C7B,iBAAI,CAACC,OAAO,CAACoC,aAAaG,UAAUxC,IAAI;YAE5C,MAAM0C,SAAS1C,iBAAI,CAACsC,OAAO,CAACG;YAC5B,MAAME,cAAc,IAAI,CAAC5C,qBAAqB,CAAC6C,GAAG,CAACF;YAEnD,IAAIC,aAAa;gBACbJ,mBAAmBM,GAAG,CAACF;YAC3B;QACJ;QAEA,OAAOJ;IACX;IAEQO,yBAAyBC,YAAoB,EAAEC,UAAkB,EAAE;QACvE,MAAMC,eAAejD,iBAAI,CAACkD,QAAQ,CAACH,cAAcC;QACjD,MAAMG,eAAeC,IAAAA,kBAAW,EAACJ;QACjC,MAAMK,eAAerD,iBAAI,CAACsD,QAAQ,CAACH;QACnC,MAAMI,gBAAgB,IAAI,CAACC,iBAAiB,CAACH,gBACvCJ,eACAjD,iBAAI,CAACgC,IAAI,CAACiB,cAAcI;QAE9B,OAAOE,cAAcE,UAAU,CAAC,MAAM;IAC1C;IAEQC,qBAAqB5D,QAAgB,EAAY;QACrD,MAAM6D,gBAAgBC,IAAAA,cAAQ,EAAC;YAAC;YAAiB;SAAkB,EAAE;YACjEC,UAAU;YACVC,KAAKhE;QACT;QAEA,OAAO6D,cAAc/D,GAAG,CAACuD,CAAAA,eAAgBnD,iBAAI,CAACgC,IAAI,CAAClC,UAAUqD;IACjE;IAEQY,gCACJ3C,GAAY,EACZX,YAAoB,EACpBuD,iBAA2B,EAChB;QACX,MAAMzB,qBAAqB,IAAI,CAACL,6BAA6B,CAACzB;QAE9D,OAAOuD,kBACFtC,MAAM,CAACC,CAAAA,aAAc,CAACY,mBAAmBX,GAAG,CAACD,aAC7C/B,GAAG,CAAC+B,CAAAA;YACD,MAAMsC,qBAAqB,IAAI,CAACxE,qBAAqB,CAACmD,GAAG,CAACjB;YAE1D,OAAO;gBACHrC,IAAI,IAAI,CAACA,EAAE;gBACX4E,SAAS,CAAC,kCAAkC,EAAEvC,YAAY;gBAC1D7B,UAAUW;gBACV0D,SAASC,kBAAW,CAACC,MAAM;gBAC3B9D,MAAM;oBACFE;oBACA6D,kBAAkB3C;oBAClBjB,cAAc,IAAI,CAACoC,wBAAwB,CACvC1B,IAAItB,QAAQ,EACZmE;gBAER;YACJ;QACJ;IACR;IAeQT,kBAAkB3D,IAAY,EAAE;QACpC,OAAOA,SAAS;IACpB;IAEQkC,YAAYwC,IAAY,EAAE;QAC9B,IAAI;YACA,OAAOzD,eAAE,CAAC0D,QAAQ,CAACD,MAAMxC,WAAW;QACxC,EAAE,eAAM;YACJ,OAAO;QACX;IACJ;;QAvJA,uBAAQtC,yBAAR,KAAA;QACA,uBAAQM,yBAAR,KAAA;QACA,uBAAQG,yBAAR,KAAA;QA8HA,uBAAiBG,2BAA0B,CAACe;YACxC,IAAIA,IAAItB,QAAQ,KAAK,KAAK;gBACtB,OAAO,EAAE;YACb;YAEA,MAAM6D,gBAAgB,IAAI,CAACD,oBAAoB,CAACtC,IAAItB,QAAQ;YAC5D,MAAMkE,oBAAoB,IAAI,CAAC7C,oBAAoB,CAACC;YAEpD,OAAOuC,cAAcc,OAAO,CAAChE,CAAAA,eACzB,IAAI,CAACsD,+BAA+B,CAAC3C,KAAKX,cAAcuD;QAEhE;;AAaJ"}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@servicetitan/startup",
-    "version": "34.0.0",
+    "version": "34.0.1",
     "description": "CLI to create multi-package Lerna projects with TypeScript and React",
     "homepage": "https://docs.st.dev/docs/frontend/uikit/startup",
     "repository": {
@@ -54,10 +54,10 @@
         "@jest/core": "~30.2.0",
         "@jest/types": "~30.2.0",
         "@jsdevtools/coverage-istanbul-loader": "^3.0.5",
-        "@servicetitan/eslint-config": "34.0.0",
-        "@servicetitan/install": "34.0.0",
-        "@servicetitan/startup-utils": "34.0.0",
-        "@servicetitan/stylelint-config": "34.0.0",
+        "@servicetitan/eslint-config": "34.0.1",
+        "@servicetitan/install": "34.0.1",
+        "@servicetitan/startup-utils": "34.0.1",
+        "@servicetitan/stylelint-config": "34.0.1",
         "@svgr/webpack": "^8.1.0",
         "@swc/cli": "^0.5.0",
         "@swc/core": "1.15.10",
@@ -142,5 +142,5 @@
     "cli": {
         "webpack": false
     },
-    "gitHead": "e193dc22703963f67099874a24de535d0696b6e2"
+    "gitHead": "e42375d199bbc11b2f0b8881c26a8f0229446256"
 }

package/src/cli/commands/review/rules/__tests__/require-tsconfig-references.test.ts

@@ -1,9 +1,9 @@
 import { fs, vol } from 'memfs';
 import path from 'node:path';
-import { Package, ReviewConfiguration } from '../../types';
-import { mockProject } from '../__mocks__';
-
+import { createPackage } from '../../../../../__mocks__';
 import { prettifySync } from '../../../../../utils';
+import { Package } from '../../types';
+import { mockProject } from '../__mocks__';
 import { RequireTsconfigReferences } from '../require-tsconfig-references';
 
 jest.mock('node:fs', () => fs);
@@ -17,299 +17,177 @@ jest.mock('../../../../../utils', () => ({
 
 describe(`[startup] Review ${RequireTsconfigReferences.name}`, () => {
     let rule: RequireTsconfigReferences;
-    let config: ReviewConfiguration;
     let packages: Package[];
 
     beforeEach(() => {
         rule = new RequireTsconfigReferences();
-        config = {};
-        packages = [];
+        packages = [
+            // Note, tests assume the "app" that depends on local package(s) is first
+            createPackage({ name: 'app', dependencies: { utils: '1.0.0' } }),
+            createPackage({ name: 'utils' }),
+        ];
     });
 
     afterEach(() => vol.reset());
 
-    const subject = () => rule.run(mockProject({ config, packages }));
-    const fixSubject = () => {
-        const ruleErrors = subject();
+    const subject = () => rule.run(mockProject({ packages }));
 
-        ruleErrors.forEach(rule.fix);
-    };
+    function appTsConfig() {
+        return path.join(packages[0].location, 'tsconfig.json');
+    }
 
-    function setupPackages(pkgs: Package[], tsconfigFiles: Record<string, object>) {
-        packages = pkgs;
+    function volFromJSON(json: Record<string, any>) {
         vol.fromJSON(
             Object.fromEntries(
-                Object.entries(tsconfigFiles).map(([filePath, content]) => [
+                Object.entries(json).map(([filePath, content]) => [
                     filePath,
-                    JSON.stringify(content, null, 4),
+                    JSON.stringify(content),
                 ])
             )
         );
     }
 
-    describe('when package has local dependency with correct tsconfig reference', () => {
-        beforeEach(() => {
-            setupPackages(
-                [
-                    {
-                        name: '@servicetitan/runtime',
-                        location: path.normalize('packages/runtime'),
-                        dependencies: {
-                            '@servicetitan/log-service': '1.0.0',
-                        },
-                    },
-                    {
-                        name: '@servicetitan/log-service',
-                        location: path.normalize('packages/log-service'),
-                    },
-                ],
-                {
-                    [path.normalize('packages/runtime/tsconfig.json')]: {
-                        references: [{ path: '../log-service/tsconfig.json' }],
-                    },
-                    [path.normalize('packages/log-service/tsconfig.json')]: {},
-                }
-            );
-        });
-
+    function itReportsNoErrors() {
         test('reports no errors', () => {
             expect(subject()).toEqual([]);
         });
-    });
+    }
 
-    describe('when tsconfig files are missing references', () => {
+    describe('when package has correct tsconfig reference', () => {
         beforeEach(() => {
-            setupPackages(
-                [
-                    {
-                        name: '@servicetitan/runtime',
-                        location: path.normalize('packages/runtime'),
-                        dependencies: {
-                            '@servicetitan/log-service': '1.0.0',
-                        },
-                    },
-                    {
-                        name: '@servicetitan/log-service',
-                        location: path.normalize('packages/log-service'),
-                    },
-                ],
-                {
-                    [path.normalize('packages/runtime/tsconfig.json')]: {},
-                    [path.normalize('packages/runtime/tsconfig.build.json')]: {},
-                    [path.normalize('packages/log-service/tsconfig.json')]: {},
-                }
-            );
+            volFromJSON({
+                [appTsConfig()]: { references: [{ path: '../utils/tsconfig.json' }] },
+            });
         });
 
-        test('reports errors for tsconfig files', () => {
-            expect(subject()).toEqual(
-                expect.arrayContaining([
-                    {
-                        id: 'require-tsconfig-references',
-                        message: 'missing reference for dependency: @servicetitan/log-service',
-                        location: path.normalize('packages/runtime/tsconfig.json'),
-                        fixable: 'normal',
-                        data: {
-                            tsconfigPath: path.normalize('packages/runtime/tsconfig.json'),
-                            missingReference: '@servicetitan/log-service',
-                            expectedPath: '../log-service/tsconfig.json',
-                        },
-                    },
-                    {
-                        id: 'require-tsconfig-references',
-                        message: 'missing reference for dependency: @servicetitan/log-service',
-                        location: path.normalize('packages/runtime/tsconfig.build.json'),
-                        fixable: 'normal',
-                        data: {
-                            tsconfigPath: path.normalize('packages/runtime/tsconfig.build.json'),
-                            missingReference: '@servicetitan/log-service',
-                            expectedPath: '../log-service/tsconfig.json',
-                        },
-                    },
-                ])
-            );
-        });
+        itReportsNoErrors();
     });
 
-    describe('when package dependencies are in devDependencies and peerDependencies', () => {
+    describe('when reference is build config', () => {
         beforeEach(() => {
-            setupPackages(
-                [
-                    {
-                        name: '@servicetitan/runtime',
-                        location: path.normalize('packages/runtime'),
-                        devDependencies: { '@servicetitan/log-service': '1.0.0' },
-                    },
-                    {
-                        name: '@servicetitan/examples',
-                        location: path.normalize('packages/examples'),
-                        peerDependencies: { '@servicetitan/log-service': '1.0.0' },
-                    },
-                    {
-                        name: '@servicetitan/log-service',
-                        location: path.normalize('packages/log-service'),
-                    },
-                ],
-                {
-                    [path.normalize('packages/runtime/tsconfig.json')]: {},
-                    [path.normalize('packages/examples/tsconfig.json')]: {},
-                    [path.normalize('packages/log-service/tsconfig.json')]: {},
-                }
-            );
+            volFromJSON({
+                [appTsConfig()]: { references: [{ path: '../utils/tsconfig.build.json ' }] },
+            });
         });
 
-        test('reports missing reference errors', () => {
-            expect(subject()).toEqual([
-                {
-                    id: 'require-tsconfig-references',
-                    message: 'missing reference for dependency: @servicetitan/log-service',
-                    location: path.normalize('packages/runtime/tsconfig.json'),
-                    fixable: 'normal',
-                    data: {
-                        tsconfigPath: path.normalize('packages/runtime/tsconfig.json'),
-                        missingReference: '@servicetitan/log-service',
-                        expectedPath: '../log-service/tsconfig.json',
-                    },
-                },
-                {
-                    id: 'require-tsconfig-references',
-                    message: 'missing reference for dependency: @servicetitan/log-service',
-                    location: path.normalize('packages/examples/tsconfig.json'),
-                    fixable: 'normal',
-                    data: {
-                        tsconfigPath: path.normalize('packages/examples/tsconfig.json'),
-                        missingReference: '@servicetitan/log-service',
-                        expectedPath: '../log-service/tsconfig.json',
-                    },
-                },
-            ]);
-        });
+        itReportsNoErrors();
     });
 
-    describe('when fix is called with non-existent tsconfig file', () => {
-        const tsconfigPath = path.normalize('packages/nonexistent/tsconfig.json');
-
+    describe('when reference omits .json extension', () => {
         beforeEach(() => {
-            setupPackages(
-                [
-                    {
-                        name: '@servicetitan/runtime',
-                        location: path.normalize('packages/runtime'),
-                        devDependencies: { '@servicetitan/log-service': '1.0.0' },
-                    },
-                    {
-                        name: '@servicetitan/log-service',
-                        location: path.normalize('packages/log-service'),
-                    },
-                ],
-                {}
-            );
+            volFromJSON({
+                [appTsConfig()]: { references: [{ path: '../utils/tsconfig' }] },
+            });
         });
 
-        test('file remains non-existent', () => {
-            fixSubject();
+        itReportsNoErrors();
+    });
 
-            expect(fs.existsSync(tsconfigPath)).toBe(false);
+    describe('when reference is directory', () => {
+        beforeEach(() => {
+            volFromJSON({
+                [appTsConfig()]: { references: [{ path: '../utils' }] },
+                'packages/utils/tsconfig.json': {}, // ensures directory exists
+            });
         });
-    });
 
-    describe('when fix is called on tsconfig that already has references', () => {
-        const tsconfigFilePath = path.normalize('packages/runtime/tsconfig.json');
+        itReportsNoErrors();
+    });
 
+    describe('when package is missing reference', () => {
         beforeEach(() => {
-            setupPackages(
-                [
-                    {
-                        name: '@servicetitan/runtime',
-                        location: path.normalize('packages/runtime'),
-                        dependencies: {
-                            '@servicetitan/log-service': '1.0.0',
-                        },
-                    },
-                    {
-                        name: '@servicetitan/log-service',
-                        location: path.normalize('packages/log-service'),
-                    },
-                ],
-                {
-                    [tsconfigFilePath]: {
-                        references: [{ path: '../existing/tsconfig.json' }],
-                    },
-                }
-            );
+            volFromJSON({ [appTsConfig()]: {} });
         });
 
-        test('appends to existing references', () => {
-            fixSubject();
+        function itReportsError() {
+            test('reports error', () => {
+                expect(subject()).toEqual([
+                    expect.objectContaining({
+                        id: 'require-tsconfig-references',
+                        message: 'missing reference for dependency: utils',
+                        location: appTsConfig(),
+                        fixable: 'normal',
+                    }),
+                ]);
+            });
+        }
+
+        itReportsError();
+
+        describe.each(['devDependencies', 'peerDependencies'])(
+            'when dependency is in %s',
+            (key: keyof Package) => {
+                beforeEach(() => {
+                    const appPackage = packages[0];
+                    appPackage[key] = appPackage.dependencies;
+                    delete appPackage.dependencies;
+                });
+
+                itReportsError();
+            }
+        );
+
+        describe('when package is workspace root', () => {
+            beforeEach(() => (packages[0].location = '.'));
 
-            const content = JSON.parse(fs.readFileSync(tsconfigFilePath, 'utf8') as string);
-            expect(content.references).toContainEqual({ path: '../existing/tsconfig.json' });
-            expect(content.references).toContainEqual({ path: '../log-service/tsconfig.json' });
+            itReportsNoErrors();
         });
 
-        test('runs prettier on the modified file', () => {
-            fixSubject();
+        describe('fix', () => {
+            const fixSubject = () => {
+                const ruleErrors = subject();
+                ruleErrors.forEach(rule.fix);
+            };
 
-            expect(prettifySync).toHaveBeenCalled();
-        });
-    });
+            function expectReferences(references: Record<string, string>[]) {
+                const json = fs.readFileSync(appTsConfig(), { encoding: 'utf-8' }).toString();
+                expect(JSON.parse(json)).toEqual({ references });
+            }
 
-    describe('when tsconfig reference omits .json extension', () => {
-        beforeEach(() => {
-            setupPackages(
-                [
-                    {
-                        name: '@servicetitan/runtime',
-                        location: path.normalize('packages/runtime'),
-                        dependencies: {
-                            '@servicetitan/log-service': '1.0.0',
-                        },
-                    },
-                    {
-                        name: '@servicetitan/log-service',
-                        location: path.normalize('packages/log-service'),
-                    },
-                ],
-                {
-                    [path.normalize('packages/runtime/tsconfig.json')]: {
-                        references: [{ path: '../log-service/tsconfig' }],
-                    },
-                    [path.normalize('packages/log-service/tsconfig.json')]: {},
-                }
-            );
-        });
+            test('fixes error', () => {
+                fixSubject();
 
-        test('reports no errors', () => {
-            expect(subject()).toEqual([]);
-        });
-    });
+                expectReferences([{ path: '../utils' }]);
+            });
 
-    describe('when package is a workspace root', () => {
-        beforeEach(() => {
-            setupPackages(
-                [
-                    {
-                        name: 'my-monorepo',
-                        location: '.',
-                        workspaces: ['packages/*'],
-                        dependencies: {
-                            '@servicetitan/log-service': '1.0.0',
-                        },
-                    },
-                    {
-                        name: '@servicetitan/log-service',
-                        location: path.normalize('packages/log-service'),
-                    },
-                ],
-                {
-                    'tsconfig.json': {},
-                    [path.normalize('packages/log-service/tsconfig.json')]: {},
-                }
-            );
-        });
+            test('prettifies output', () => {
+                fixSubject();
 
-        test('skips the workspace root package', () => {
-            expect(subject()).toEqual([]);
+                expect(prettifySync).toHaveBeenCalledWith(appTsConfig());
+            });
+
+            describe('when reference is build config', () => {
+                beforeEach(() => {
+                    volFromJSON({
+                        [appTsConfig()]: {},
+                        'packages/utils/tsconfig.build.json': {},
+                    });
+                });
+
+                test('references build config', () => {
+                    fixSubject();
+
+                    expectReferences([{ path: '../utils/tsconfig.build.json' }]);
+                });
+            });
+
+            describe('when package has other references', () => {
+                const references = [{ path: '../foo' }];
+
+                beforeEach(() => {
+                    volFromJSON({ [appTsConfig()]: { references } });
+                });
+
+                test('preserves other references', () => {
+                    fixSubject();
+
+                    expectReferences([...references, { path: '../utils' }]);
+                });
+            });
+
+            test('ignores invalid data', () => {
+                expect(() => rule.fix({} as any)).not.toThrow();
+            });
         });
     });
 });

package/src/cli/commands/review/rules/require-tsconfig-references.ts

@@ -1,7 +1,7 @@
 import { globSync } from 'glob';
 import fs from 'node:fs';
 import path from 'node:path';
-import { getTsConfig, prettifySync, readJsonSafe } from '../../../../utils';
+import { getTsConfig, prettifySync, readJson, readJsonSafe } from '../../../../utils';
 import { FixCategory, Package, PackageError, PackageRule, Project } from '../types';
 import { checkPackages } from '../utils';
 
@@ -44,10 +44,7 @@ export class RequireTsconfigReferences implements PackageRule {
         }
 
         const { tsconfigPath, expectedPath } = data;
-        const tsconfig = readJsonSafe<TsConfig>(tsconfigPath);
-        if (!tsconfig) {
-            return;
-        }
+        const tsconfig = readJson<TsConfig>(tsconfigPath);
 
         const references = tsconfig.references ?? [];
         references.push({ path: expectedPath });
@@ -70,6 +67,9 @@ export class RequireTsconfigReferences implements PackageRule {
     }
 
     private normalizeTsConfigPath(filePath: string): string {
+        if (this.isDirectory(filePath)) {
+            return path.join(filePath, 'tsconfig.json');
+        }
         return filePath.endsWith('.json') ? filePath : `${filePath}.json`;
     }
 
@@ -83,8 +83,9 @@ export class RequireTsconfigReferences implements PackageRule {
         const referencedPackages = new Set<string>();
 
         for (const reference of config.references) {
-            const normalizedPath = this.normalizeTsConfigPath(reference.path);
-            const resolvedRefPath = path.resolve(tsconfigDir, normalizedPath);
+            const resolvedRefPath = this.normalizeTsConfigPath(
+                path.resolve(tsconfigDir, reference.path)
+            );
             const refDir = path.dirname(resolvedRefPath);
             const packageName = this.locationToPackageName.get(refDir);
 
@@ -100,8 +101,11 @@ export class RequireTsconfigReferences implements PackageRule {
         const relativePath = path.relative(fromLocation, toLocation);
         const tsconfigFile = getTsConfig(toLocation);
         const tsconfigName = path.basename(tsconfigFile);
+        const referencePath = this.isDefaultTsConfig(tsconfigName)
+            ? relativePath
+            : path.join(relativePath, tsconfigName);
 
-        return path.join(relativePath, tsconfigName).replaceAll('\\', '/');
+        return referencePath.replaceAll('\\', '/');
     }
 
     private collectTsConfigFiles(location: string): string[] {
@@ -154,4 +158,16 @@ export class RequireTsconfigReferences implements PackageRule {
             this.findMissingDependencyReferences(pkg, tsconfigPath, localDependencies)
         );
     };
+
+    private isDefaultTsConfig(name: string) {
+        return name === 'tsconfig.json';
+    }
+
+    private isDirectory(file: string) {
+        try {
+            return fs.statSync(file).isDirectory();
+        } catch {
+            return false;
+        }
+    }
 }