@servicetitan/startup 32.0.1 → 32.1.0

package/dist/cli/commands/review/utils/check-packages.js

@@ -0,0 +1,30 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", {
+    value: true
+});
+Object.defineProperty(exports, "checkPackages", {
+    enumerable: true,
+    get: function() {
+        return checkPackages;
+    }
+});
+const _applyfilter = require("./apply-filter");
+function checkPackages({ id }, { config, packages }, fn) {
+    var _config_rules;
+    const ruleConfig = id ? (_config_rules = config.rules) === null || _config_rules === void 0 ? void 0 : _config_rules[id] : undefined;
+    return (0, _applyfilter.applyFilter)(ruleConfig, packages, ({ name })=>name).reduce((result, pkg)=>{
+        const error = fn(pkg);
+        if (Array.isArray(error)) {
+            return [
+                ...result,
+                ...error
+            ];
+        }
+        return error ? [
+            ...result,
+            error
+        ] : result;
+    }, []);
+}
+
+//# sourceMappingURL=check-packages.js.map

package/dist/cli/commands/review/utils/check-packages.js.map

@@ -0,0 +1 @@
+{"version":3,"sources":["../../../../../src/cli/commands/review/utils/check-packages.ts"],"sourcesContent":["import { Package, PackageError, Project } from '../types';\nimport { applyFilter } from './apply-filter';\n\ntype CheckFn<T> = (pkg: Package) => PackageError<T>[] | PackageError<T> | undefined;\n\nexport function checkPackages<T>(\n    { id }: { id?: string },\n    { config, packages }: Project,\n    fn: CheckFn<T>\n) {\n    const ruleConfig = id ? config.rules?.[id] : undefined;\n    return applyFilter(ruleConfig, packages, ({ name }) => name).reduce((result, pkg) => {\n        const error = fn(pkg);\n        if (Array.isArray(error)) {\n            return [...result, ...error];\n        }\n        return error ? [...result, error] : result;\n    }, []);\n}\n"],"names":["checkPackages","id","config","packages","fn","ruleConfig","rules","undefined","applyFilter","name","reduce","result","pkg","error","Array","isArray"],"mappings":";;;;+BAKgBA;;;eAAAA;;;6BAJY;AAIrB,SAASA,cACZ,EAAEC,EAAE,EAAmB,EACvB,EAAEC,MAAM,EAAEC,QAAQ,EAAW,EAC7BC,EAAc;QAEUF;IAAxB,MAAMG,aAAaJ,MAAKC,gBAAAA,OAAOI,KAAK,cAAZJ,oCAAAA,aAAc,CAACD,GAAG,GAAGM;IAC7C,OAAOC,IAAAA,wBAAW,EAACH,YAAYF,UAAU,CAAC,EAAEM,IAAI,EAAE,GAAKA,MAAMC,MAAM,CAAC,CAACC,QAAQC;QACzE,MAAMC,QAAQT,GAAGQ;QACjB,IAAIE,MAAMC,OAAO,CAACF,QAAQ;YACtB,OAAO;mBAAIF;mBAAWE;aAAM;QAChC;QACA,OAAOA,QAAQ;eAAIF;YAAQE;SAAM,GAAGF;IACxC,GAAG,EAAE;AACT"}

package/dist/cli/commands/review/utils/index.d.ts

@@ -1,4 +1,5 @@
 export * from './apply-filter';
+export * from './check-packages';
 export * from './collate-dependencies';
 export * from './compare-version';
 export * from './format-depends-on';

package/dist/cli/commands/review/utils/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../../../src/cli/commands/review/utils/index.ts"],"names":[],"mappings":"AAAA,cAAc,gBAAgB,CAAC;AAC/B,cAAc,wBAAwB,CAAC;AACvC,cAAc,mBAAmB,CAAC;AAClC,cAAc,qBAAqB,CAAC;AACpC,cAAc,mBAAmB,CAAC;AAClC,cAAc,WAAW,CAAC;AAC1B,cAAc,mBAAmB,CAAC;AAClC,cAAc,UAAU,CAAC;AACzB,cAAc,cAAc,CAAC;AAC7B,cAAc,oBAAoB,CAAC;AACnC,cAAc,aAAa,CAAC;AAC5B,cAAc,eAAe,CAAC;AAC9B,cAAc,aAAa,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../../../src/cli/commands/review/utils/index.ts"],"names":[],"mappings":"AAAA,cAAc,gBAAgB,CAAC;AAC/B,cAAc,kBAAkB,CAAC;AACjC,cAAc,wBAAwB,CAAC;AACvC,cAAc,mBAAmB,CAAC;AAClC,cAAc,qBAAqB,CAAC;AACpC,cAAc,mBAAmB,CAAC;AAClC,cAAc,WAAW,CAAC;AAC1B,cAAc,mBAAmB,CAAC;AAClC,cAAc,UAAU,CAAC;AACzB,cAAc,cAAc,CAAC;AAC7B,cAAc,oBAAoB,CAAC;AACnC,cAAc,aAAa,CAAC;AAC5B,cAAc,eAAe,CAAC;AAC9B,cAAc,aAAa,CAAC"}

package/dist/cli/commands/review/utils/index.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", {
     value: true
 });
 _export_star(require("./apply-filter"), exports);
+_export_star(require("./check-packages"), exports);
 _export_star(require("./collate-dependencies"), exports);
 _export_star(require("./compare-version"), exports);
 _export_star(require("./format-depends-on"), exports);

package/dist/cli/commands/review/utils/index.js.map

@@ -1 +1 @@
-{"version":3,"sources":["../../../../../src/cli/commands/review/utils/index.ts"],"sourcesContent":["export * from './apply-filter';\nexport * from './collate-dependencies';\nexport * from './compare-version';\nexport * from './format-depends-on';\nexport * from './format-location';\nexport * from './get-key';\nexport * from './get-max-version';\nexport * from './indent';\nexport * from './is-library';\nexport * from './name-to-location';\nexport * from './pluralize';\nexport * from './set-version';\nexport * from './summarize';\n"],"names":[],"mappings":";;;;qBAAc;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA"}
+{"version":3,"sources":["../../../../../src/cli/commands/review/utils/index.ts"],"sourcesContent":["export * from './apply-filter';\nexport * from './check-packages';\nexport * from './collate-dependencies';\nexport * from './compare-version';\nexport * from './format-depends-on';\nexport * from './format-location';\nexport * from './get-key';\nexport * from './get-max-version';\nexport * from './indent';\nexport * from './is-library';\nexport * from './name-to-location';\nexport * from './pluralize';\nexport * from './set-version';\nexport * from './summarize';\n"],"names":[],"mappings":";;;;qBAAc;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA;qBACA"}

package/dist/cli/utils/cli-git.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"cli-git.d.ts","sourceRoot":"","sources":["../../../src/cli/utils/cli-git.ts"],"names":[],"mappings":"AAIA,wBAAgB,YAAY,IAAI,MAAM,CAErC;AAED,wBAAgB,gBAAgB,IAAI,MAAM,CAEzC;AAED,UAAU,IAAI;IACV,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,IAAI,EAAE,MAAM,CAAC;CAChB;AAED,wBAAsB,YAAY,CAAC,MAAM,EAAE,IAAI,GAAG;IAAE,WAAW,EAAE,MAAM,CAAA;CAAE,oBAkBxE;AAED,wBAAgB,cAAc,CAAC,EAAE,KAAsB,EAAE,IAAI,EAAE,EAAE,IAAI,WASpE"}
+{"version":3,"file":"cli-git.d.ts","sourceRoot":"","sources":["../../../src/cli/utils/cli-git.ts"],"names":[],"mappings":"AAIA,wBAAgB,YAAY,IAAI,MAAM,CAErC;AAED,wBAAgB,gBAAgB,IAAI,MAAM,CAEzC;AAED,UAAU,IAAI;IACV,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,IAAI,EAAE,MAAM,CAAC;CAChB;AAED,wBAAsB,YAAY,CAAC,MAAM,EAAE,IAAI,GAAG;IAAE,WAAW,EAAE,MAAM,CAAA;CAAE,oBAsBxE;AAED,wBAAgB,cAAc,CAAC,EAAE,KAAsB,EAAE,IAAI,EAAE,EAAE,IAAI,WASpE"}

package/dist/cli/utils/cli-git.js

@@ -43,7 +43,12 @@ async function gitCloneRepo(params) {
             _utils.log.debug('git:clone-repo', `running ${command}`);
             // eslint-disable-next-line no-await-in-loop
             await (0, _clios.runCommand)(command, {
-                quiet: true
+                quiet: true,
+                // eslint-disable-next-line @typescript-eslint/naming-convention
+                env: {
+                    ...process.env,
+                    GIT_TERMINAL_PROMPT: '0'
+                }
             });
             return true;
         } catch (e) {
@@ -70,14 +75,12 @@ function gitIsReachable({ owner = 'servicetitan', name }) {
 function getGitUrls({ owner, name }) {
     const webUrl = `https://github.com/${owner}/${name}.git`;
     const sshUrl = `git@github.com:${owner}/${name}.git`;
-    const urls = [
-        webUrl,
-        sshUrl
+    return (0, _isci.isCI)() && !!process.env.GITHUB_TOKEN ? [
+        webUrl.replace('github.com', `oauth2:${process.env.GITHUB_TOKEN}@github.com`)
+    ] : [
+        sshUrl,
+        webUrl
     ];
-    if ((0, _isci.isCI)() && !!process.env.GITHUB_TOKEN) {
-        urls.unshift(webUrl.replace('github.com', `oauth2:${process.env.GITHUB_TOKEN}@github.com`));
-    }
-    return urls;
 }
 
 //# sourceMappingURL=cli-git.js.map

package/dist/cli/utils/cli-git.js.map

@@ -1 +1 @@
-{"version":3,"sources":["../../../src/cli/utils/cli-git.ts"],"sourcesContent":["import { log } from '../../utils';\nimport { runCommand, runCommandOutput } from './cli-os';\nimport { isCI } from './is-ci';\n\nexport function gitGetBranch(): string {\n    return runCommandOutput('git rev-parse --abbrev-ref HEAD').trim();\n}\n\nexport function gitGetCommitHash(): string {\n    return runCommandOutput('git rev-parse --short HEAD').trim();\n}\n\ninterface Repo {\n    owner?: string;\n    name: string;\n}\n\nexport async function gitCloneRepo(params: Repo & { destination: string }) {\n    const { destination, name, owner = 'servicetitan' } = params;\n    const gitUrls = getGitUrls({ owner, name });\n\n    for (const url of gitUrls) {\n        try {\n            const command = `git clone -q ${url} ${destination}`;\n            log.debug('git:clone-repo', `running ${command}`);\n\n            // eslint-disable-next-line no-await-in-loop\n            await runCommand(command, { quiet: true });\n            return true;\n        } catch {\n            // ignore error\n        }\n    }\n\n    return false;\n}\n\nexport function gitIsReachable({ owner = 'servicetitan', name }: Repo) {\n    return getGitUrls({ owner, name }).some(url => {\n        try {\n            runCommandOutput(`git ls-remote -qt ${url}`, { quiet: true });\n            return true;\n        } catch {\n            return false;\n        }\n    });\n}\n\nfunction getGitUrls({ owner, name }: Repo) {\n    const webUrl = `https://github.com/${owner}/${name}.git`;\n    const sshUrl = `git@github.com:${owner}/${name}.git`;\n\n    const urls = [webUrl, sshUrl];\n    if (isCI() && !!process.env.GITHUB_TOKEN) {\n        urls.unshift(webUrl.replace('github.com', `oauth2:${process.env.GITHUB_TOKEN}@github.com`));\n    }\n\n    return urls;\n}\n"],"names":["gitCloneRepo","gitGetBranch","gitGetCommitHash","gitIsReachable","runCommandOutput","trim","params","destination","name","owner","gitUrls","getGitUrls","url","command","log","debug","runCommand","quiet","some","webUrl","sshUrl","urls","isCI","process","env","GITHUB_TOKEN","unshift","replace"],"mappings":";;;;;;;;;;;QAiBsBA;eAAAA;;QAbNC;eAAAA;;QAIAC;eAAAA;;QA6BAC;eAAAA;;;uBArCI;uBACyB;sBACxB;AAEd,SAASF;IACZ,OAAOG,IAAAA,uBAAgB,EAAC,mCAAmCC,IAAI;AACnE;AAEO,SAASH;IACZ,OAAOE,IAAAA,uBAAgB,EAAC,8BAA8BC,IAAI;AAC9D;AAOO,eAAeL,aAAaM,MAAsC;IACrE,MAAM,EAAEC,WAAW,EAAEC,IAAI,EAAEC,QAAQ,cAAc,EAAE,GAAGH;IACtD,MAAMI,UAAUC,WAAW;QAAEF;QAAOD;IAAK;IAEzC,KAAK,MAAMI,OAAOF,QAAS;QACvB,IAAI;YACA,MAAMG,UAAU,CAAC,aAAa,EAAED,IAAI,CAAC,EAAEL,aAAa;YACpDO,UAAG,CAACC,KAAK,CAAC,kBAAkB,CAAC,QAAQ,EAAEF,SAAS;YAEhD,4CAA4C;YAC5C,MAAMG,IAAAA,iBAAU,EAACH,SAAS;gBAAEI,OAAO;YAAK;YACxC,OAAO;QACX,EAAE,UAAM;QACJ,eAAe;QACnB;IACJ;IAEA,OAAO;AACX;AAEO,SAASd,eAAe,EAAEM,QAAQ,cAAc,EAAED,IAAI,EAAQ;IACjE,OAAOG,WAAW;QAAEF;QAAOD;IAAK,GAAGU,IAAI,CAACN,CAAAA;QACpC,IAAI;YACAR,IAAAA,uBAAgB,EAAC,CAAC,kBAAkB,EAAEQ,KAAK,EAAE;gBAAEK,OAAO;YAAK;YAC3D,OAAO;QACX,EAAE,UAAM;YACJ,OAAO;QACX;IACJ;AACJ;AAEA,SAASN,WAAW,EAAEF,KAAK,EAAED,IAAI,EAAQ;IACrC,MAAMW,SAAS,CAAC,mBAAmB,EAAEV,MAAM,CAAC,EAAED,KAAK,IAAI,CAAC;IACxD,MAAMY,SAAS,CAAC,eAAe,EAAEX,MAAM,CAAC,EAAED,KAAK,IAAI,CAAC;IAEpD,MAAMa,OAAO;QAACF;QAAQC;KAAO;IAC7B,IAAIE,IAAAA,UAAI,OAAM,CAAC,CAACC,QAAQC,GAAG,CAACC,YAAY,EAAE;QACtCJ,KAAKK,OAAO,CAACP,OAAOQ,OAAO,CAAC,cAAc,CAAC,OAAO,EAAEJ,QAAQC,GAAG,CAACC,YAAY,CAAC,WAAW,CAAC;IAC7F;IAEA,OAAOJ;AACX"}
+{"version":3,"sources":["../../../src/cli/utils/cli-git.ts"],"sourcesContent":["import { log } from '../../utils';\nimport { runCommand, runCommandOutput } from './cli-os';\nimport { isCI } from './is-ci';\n\nexport function gitGetBranch(): string {\n    return runCommandOutput('git rev-parse --abbrev-ref HEAD').trim();\n}\n\nexport function gitGetCommitHash(): string {\n    return runCommandOutput('git rev-parse --short HEAD').trim();\n}\n\ninterface Repo {\n    owner?: string;\n    name: string;\n}\n\nexport async function gitCloneRepo(params: Repo & { destination: string }) {\n    const { destination, name, owner = 'servicetitan' } = params;\n    const gitUrls = getGitUrls({ owner, name });\n\n    for (const url of gitUrls) {\n        try {\n            const command = `git clone -q ${url} ${destination}`;\n            log.debug('git:clone-repo', `running ${command}`);\n\n            // eslint-disable-next-line no-await-in-loop\n            await runCommand(command, {\n                quiet: true,\n                // eslint-disable-next-line @typescript-eslint/naming-convention\n                env: { ...process.env, GIT_TERMINAL_PROMPT: '0' },\n            });\n            return true;\n        } catch {\n            // ignore error\n        }\n    }\n\n    return false;\n}\n\nexport function gitIsReachable({ owner = 'servicetitan', name }: Repo) {\n    return getGitUrls({ owner, name }).some(url => {\n        try {\n            runCommandOutput(`git ls-remote -qt ${url}`, { quiet: true });\n            return true;\n        } catch {\n            return false;\n        }\n    });\n}\n\nfunction getGitUrls({ owner, name }: Repo) {\n    const webUrl = `https://github.com/${owner}/${name}.git`;\n    const sshUrl = `git@github.com:${owner}/${name}.git`;\n\n    return isCI() && !!process.env.GITHUB_TOKEN\n        ? [webUrl.replace('github.com', `oauth2:${process.env.GITHUB_TOKEN}@github.com`)]\n        : [sshUrl, webUrl];\n}\n"],"names":["gitCloneRepo","gitGetBranch","gitGetCommitHash","gitIsReachable","runCommandOutput","trim","params","destination","name","owner","gitUrls","getGitUrls","url","command","log","debug","runCommand","quiet","env","process","GIT_TERMINAL_PROMPT","some","webUrl","sshUrl","isCI","GITHUB_TOKEN","replace"],"mappings":";;;;;;;;;;;QAiBsBA;eAAAA;;QAbNC;eAAAA;;QAIAC;eAAAA;;QAiCAC;eAAAA;;;uBAzCI;uBACyB;sBACxB;AAEd,SAASF;IACZ,OAAOG,IAAAA,uBAAgB,EAAC,mCAAmCC,IAAI;AACnE;AAEO,SAASH;IACZ,OAAOE,IAAAA,uBAAgB,EAAC,8BAA8BC,IAAI;AAC9D;AAOO,eAAeL,aAAaM,MAAsC;IACrE,MAAM,EAAEC,WAAW,EAAEC,IAAI,EAAEC,QAAQ,cAAc,EAAE,GAAGH;IACtD,MAAMI,UAAUC,WAAW;QAAEF;QAAOD;IAAK;IAEzC,KAAK,MAAMI,OAAOF,QAAS;QACvB,IAAI;YACA,MAAMG,UAAU,CAAC,aAAa,EAAED,IAAI,CAAC,EAAEL,aAAa;YACpDO,UAAG,CAACC,KAAK,CAAC,kBAAkB,CAAC,QAAQ,EAAEF,SAAS;YAEhD,4CAA4C;YAC5C,MAAMG,IAAAA,iBAAU,EAACH,SAAS;gBACtBI,OAAO;gBACP,gEAAgE;gBAChEC,KAAK;oBAAE,GAAGC,QAAQD,GAAG;oBAAEE,qBAAqB;gBAAI;YACpD;YACA,OAAO;QACX,EAAE,UAAM;QACJ,eAAe;QACnB;IACJ;IAEA,OAAO;AACX;AAEO,SAASjB,eAAe,EAAEM,QAAQ,cAAc,EAAED,IAAI,EAAQ;IACjE,OAAOG,WAAW;QAAEF;QAAOD;IAAK,GAAGa,IAAI,CAACT,CAAAA;QACpC,IAAI;YACAR,IAAAA,uBAAgB,EAAC,CAAC,kBAAkB,EAAEQ,KAAK,EAAE;gBAAEK,OAAO;YAAK;YAC3D,OAAO;QACX,EAAE,UAAM;YACJ,OAAO;QACX;IACJ;AACJ;AAEA,SAASN,WAAW,EAAEF,KAAK,EAAED,IAAI,EAAQ;IACrC,MAAMc,SAAS,CAAC,mBAAmB,EAAEb,MAAM,CAAC,EAAED,KAAK,IAAI,CAAC;IACxD,MAAMe,SAAS,CAAC,eAAe,EAAEd,MAAM,CAAC,EAAED,KAAK,IAAI,CAAC;IAEpD,OAAOgB,IAAAA,UAAI,OAAM,CAAC,CAACL,QAAQD,GAAG,CAACO,YAAY,GACrC;QAACH,OAAOI,OAAO,CAAC,cAAc,CAAC,OAAO,EAAEP,QAAQD,GAAG,CAACO,YAAY,CAAC,WAAW,CAAC;KAAE,GAC/E;QAACF;QAAQD;KAAO;AAC1B"}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@servicetitan/startup",
-    "version": "32.0.1",
+    "version": "32.1.0",
     "description": "",
     "homepage": "https://docs.st.dev/docs/frontend/startup",
     "repository": {
@@ -37,8 +37,8 @@
         "@jest/core": "~29.7.0",
         "@jest/types": "~29.6.3",
         "@jsdevtools/coverage-istanbul-loader": "^3.0.5",
-        "@servicetitan/eslint-config": "32.0.1",
-        "@servicetitan/stylelint-config": "32.0.1",
+        "@servicetitan/eslint-config": "32.1.0",
+        "@servicetitan/stylelint-config": "32.1.0",
         "@svgr/webpack": "^8.1.0",
         "@swc/cli": "^0.5.0",
         "@swc/core": "1.13.5",
@@ -120,5 +120,5 @@
     "cli": {
         "webpack": false
     },
-    "gitHead": "2b74dd72d39c2023151699d1cf7a6e6130d64279"
+    "gitHead": "5686f75473bd25104356c3fc6e7c8ffe478ca125"
 }

package/src/cli/commands/review/rules/__mocks__/mock-config.ts

@@ -8,7 +8,13 @@ export function mockConfig({
 }: {
     id: string;
     level?: 'error' | 'warn';
-    exclude: string | string[];
+    exclude: string | string[] | Record<string, string[]>;
 }): ReviewConfiguration {
-    return { rules: { [id]: exclude ? [level, { exclude: toArray(exclude) }] : [level] } };
+    return {
+        rules: {
+            [id]: exclude
+                ? [level, { exclude: typeof exclude === 'object' ? exclude : toArray(exclude) }]
+                : [level],
+        },
+    };
 }

package/src/cli/commands/review/rules/__tests__/no-deprecated-content-base.test.ts

@@ -0,0 +1,123 @@
+import { execSync } from 'child_process';
+import path from 'path';
+import {
+    ErrorSeverity,
+    FixCategory,
+    Package,
+    PackageError,
+    ReviewConfiguration,
+} from '../../types';
+import { expectCalls } from '../../__mocks__';
+import { mockConfig, mockProject } from '../__mocks__';
+import { NoDeprecatedContentBase } from '../no-deprecated-content-base';
+
+jest.mock('child_process', () => ({ execSync: jest.fn() }));
+
+describe(`[startup] Review ${NoDeprecatedContentBase.name}`, () => {
+    const id = 'no-deprecated-content-base';
+    const rule = new NoDeprecatedContentBase();
+    let config: ReviewConfiguration;
+    let pkg: Package;
+    let packages: Package[];
+
+    beforeEach(() => {
+        config = {};
+        pkg = { name: 'lib1', location: path.normalize('packages/lib') };
+        packages = [pkg];
+        jest.clearAllMocks();
+    });
+
+    const subject = () => rule.run(mockProject({ config, packages }));
+
+    const fixSubject = () => rule.fix(subject()![0]);
+
+    function itReturnsError() {
+        test('returns error', () => {
+            expect(subject()).toEqual([
+                expect.objectContaining({
+                    id,
+                    message: `package "${pkg.name}" uses deprecated cli.webpack.contentBase configuration`,
+                    location: pkg.location,
+                    fixable: FixCategory.isolated,
+                    severity: ErrorSeverity.warning,
+                } satisfies PackageError),
+            ]);
+        });
+    }
+
+    function itReturnsNothing() {
+        test('returns nothing', () => {
+            expect(subject()).toEqual([]);
+        });
+    }
+
+    itReturnsNothing();
+
+    describe('when package uses cli.webpack.contentBase', () => {
+        const contentBase = 'foo';
+
+        beforeEach(() => {
+            pkg.cli = { webpack: { contentBase } };
+        });
+
+        itReturnsError();
+
+        test('fixes error', () => {
+            fixSubject();
+
+            expectCalls(
+                ...[
+                    `npm pkg set cli.webpack.static.directory="${contentBase}" -w ${pkg.location}`,
+                    `npm pkg delete cli.webpack.contentBase -w ${pkg.location}`,
+                ].map(command => [execSync, command, { stdio: 'inherit' }])
+            );
+        });
+
+        test('fix ignores invalid error', () => {
+            rule.fix({} as any);
+
+            expect(execSync).not.toHaveBeenCalled();
+        });
+
+        describe('when config excludes package', () => {
+            beforeEach(() => (config = mockConfig({ id, exclude: pkg.name })));
+
+            itReturnsNothing();
+        });
+
+        describe('when multiple packages use cli.webpack.contentBase', () => {
+            beforeEach(() => {
+                packages.push({
+                    name: 'lib2',
+                    location: path.normalize('packages/lib2'),
+                    cli: { webpack: { contentBase: 'bar' } },
+                });
+            });
+
+            test('returns multiple errors', () => {
+                expect(subject()).toEqual([
+                    expect.objectContaining({ location: packages[0].location }),
+                    expect.objectContaining({ location: packages[1].location }),
+                ]);
+            });
+        });
+
+        describe('when cli.webpack.contentBase is an array', () => {
+            const contentBaseArray = ['foo', 'bar'];
+
+            beforeEach(() => (pkg.cli = { webpack: { contentBase: contentBaseArray } }));
+
+            test('fixes error', () => {
+                fixSubject();
+
+                expectCalls(
+                    ...[
+                        `npm pkg set cli.webpack.static[0].directory="${contentBaseArray[0]}" -w ${pkg.location}`,
+                        `npm pkg set cli.webpack.static[1].directory="${contentBaseArray[1]}" -w ${pkg.location}`,
+                        `npm pkg delete cli.webpack.contentBase -w ${pkg.location}`,
+                    ].map(command => [execSync, command, { stdio: 'inherit' }])
+                );
+            });
+        });
+    });
+});

package/src/cli/commands/review/rules/__tests__/no-direct-peer-dependencies.test.ts

@@ -0,0 +1,130 @@
+import { execSync } from 'child_process';
+import path from 'path';
+import { FixCategory, Package, PackageError, ReviewConfiguration } from '../../types';
+import { expectCalls } from '../../__mocks__';
+import { mockConfig, mockProject } from '../__mocks__';
+import { NoDirectPeerDependencies } from '../no-direct-peer-dependencies';
+
+jest.mock('child_process', () => ({ execSync: jest.fn() }));
+
+describe(`[startup] Review ${NoDirectPeerDependencies.name}`, () => {
+    const id = 'no-direct-peer-dependencies';
+    const rule = new NoDirectPeerDependencies();
+    let config: ReviewConfiguration;
+    let pkg: Package;
+    let packages: Package[];
+
+    beforeEach(() => {
+        config = {};
+        pkg = { name: 'lib1', location: path.normalize('packages/lib') };
+        packages = [pkg];
+        jest.clearAllMocks();
+    });
+
+    const subject = () => rule.run(mockProject({ config, packages }));
+
+    const fixSubject = () => rule.fix(subject()![0]);
+
+    function itReturnsError(message: () => string) {
+        test('returns error', () => {
+            expect(subject()).toEqual([
+                expect.objectContaining({
+                    id,
+                    message: message(),
+                    location: pkg.location,
+                    fixable: FixCategory.isolated,
+                } satisfies PackageError),
+            ]);
+        });
+    }
+
+    function itReturnsNothing() {
+        test('returns nothing', () => {
+            expect(subject()).toEqual([]);
+        });
+    }
+
+    itReturnsNothing();
+
+    describe('when package is both peer and direct dependency', () => {
+        beforeEach(() => {
+            Object.assign(pkg, {
+                dependencies: { foo: '^1.0.0', baz: '1.0.0' },
+                peerDependencies: { foo: '>=1.0.0', qux: '^1.0.0' },
+            });
+        });
+
+        itReturnsError(() => {
+            return `package "${pkg.name}" lists "foo" as both a direct and a peer dependency`;
+        });
+
+        test('fixes error', () => {
+            fixSubject();
+
+            expectCalls(
+                ...[
+                    `npm pkg set devDependencies["foo"]="${pkg.dependencies!.foo}" -w ${pkg.location}`,
+                    `npm pkg delete dependencies["foo"] -w ${pkg.location}`,
+                ].map(command => [execSync, command, { stdio: 'inherit' }])
+            );
+        });
+
+        test('fix ignores invalid error', () => {
+            rule.fix({} as any);
+
+            expect(execSync).not.toHaveBeenCalled();
+        });
+
+        describe('when config excludes package', () => {
+            beforeEach(() => (config = mockConfig({ id, exclude: pkg.name })));
+
+            itReturnsNothing();
+        });
+
+        describe('when multiple packages violate the rule', () => {
+            beforeEach(() => {
+                packages = [
+                    pkg,
+                    {
+                        ...pkg,
+                        name: 'lib2',
+                        location: path.normalize('packages/lib2'),
+                    },
+                ];
+            });
+
+            test('returns multiple errors', () => {
+                expect(subject()).toEqual([
+                    expect.objectContaining({ location: packages[0].location }),
+                    expect.objectContaining({ location: packages[1].location }),
+                ]);
+            });
+        });
+    });
+
+    describe('when multiple packages are peer and direct dependencies', () => {
+        beforeEach(() => {
+            Object.assign(pkg, {
+                dependencies: { foo: '^1.0.0', bar: '~1.0.0', baz: '1.0.0' },
+                peerDependencies: { foo: '>= 1.0.0', bar: '^1.0.0', quz: '^1.0.0' },
+            });
+        });
+
+        itReturnsError(() => {
+            return `package "${pkg.name}" lists "foo" and "bar" as both direct and peer dependencies`;
+        });
+
+        test('fixes multiple errors', () => {
+            fixSubject();
+
+            expectCalls(
+                ...[
+                    `npm pkg set devDependencies["foo"]="${pkg.dependencies!.foo}" -w ${pkg.location}`,
+                    `npm pkg delete dependencies["foo"] -w ${pkg.location}`,
+                    `npm pkg set devDependencies["bar"]="${pkg.dependencies!.bar}" -w ${pkg.location}`,
+                    `npm pkg delete dependencies["bar"] -w ${pkg.location}`,
+                ].map(command => [execSync, command, { stdio: 'inherit' }])
+            );
+        });
+    });
+});

package/src/cli/commands/review/rules/__tests__/prefer-open-ended-peer-dependencies.test.ts

@@ -0,0 +1,121 @@
+import { execSync } from 'child_process';
+import { ErrorSeverity, FixCategory, Package, PackageError } from '../../types';
+import { mockConfig, mockProject } from '../__mocks__';
+import { PreferOpenEndedPeerDependencies } from '../prefer-open-ended-peer-dependencies';
+
+jest.mock('child_process', () => ({ execSync: jest.fn() }));
+
+describe(`[startup] Review ${PreferOpenEndedPeerDependencies.name}`, () => {
+    const id = 'prefer-open-ended-peer-dependencies';
+    const rule = new PreferOpenEndedPeerDependencies();
+    let config: any;
+    let pkg: Package;
+    let packages: Package[];
+
+    beforeEach(() => {
+        config = {};
+        pkg = { name: 'lib1', location: 'packages/lib1' };
+        packages = [pkg];
+        jest.clearAllMocks();
+    });
+
+    const subject = () => rule.run(mockProject({ config, packages }));
+
+    const fixSubject = () => rule.fix(subject()![0]);
+
+    function itReturnsError(message: () => string) {
+        test('returns error', () => {
+            expect(subject()).toEqual([
+                expect.objectContaining({
+                    id,
+                    message: message(),
+                    location: pkg.location,
+                    severity: ErrorSeverity.warning,
+                    fixable: FixCategory.isolated,
+                } satisfies PackageError),
+            ]);
+        });
+    }
+
+    function itReturnsNothing() {
+        test('returns nothing', () => {
+            expect(subject()).toEqual([]);
+        });
+    }
+
+    itReturnsNothing();
+
+    describe('when a package has a closed-ended peer dependency', () => {
+        beforeEach(() => (pkg.peerDependencies = { foo: '^12.3.0' }));
+
+        itReturnsError(
+            () => `package "${pkg.name}" has closed-ended peer dependency on "foo@^12.3.0"`
+        );
+
+        test('fixes error', () => {
+            fixSubject();
+
+            expect(execSync).toHaveBeenCalledWith(
+                `npm pkg set peerDependencies["foo"]=">=12.3.0" -w ${pkg.location}`,
+                { stdio: 'inherit' }
+            );
+        });
+
+        test('fix ignores invalid error', () => {
+            rule.fix({} as any);
+
+            expect(execSync).not.toHaveBeenCalled();
+        });
+
+        describe('when config excludes package', () => {
+            beforeEach(() => (config = mockConfig({ id, exclude: pkg.name })));
+
+            itReturnsNothing();
+        });
+
+        describe('when peer is open-ended', () => {
+            beforeEach(() => (pkg.peerDependencies!.foo = '>=12.3.0'));
+
+            itReturnsNothing();
+        });
+
+        describe('when peer dependency is an exact version', () => {
+            beforeEach(() => (pkg.peerDependencies!.foo = '12.3.0'));
+
+            itReturnsNothing();
+        });
+
+        describe('with multiple closed-ended dependencies', () => {
+            beforeEach(() => (pkg.peerDependencies!.bar = '~12.3.4'));
+
+            test('returns multiple errors', () => {
+                expect(subject()).toEqual([
+                    expect.objectContaining({ message: expect.stringContaining('foo@^12.3.0') }),
+                    expect.objectContaining({ message: expect.stringContaining('bar@~12.3.4') }),
+                ]);
+            });
+
+            describe('when dependency is excluded', () => {
+                beforeEach(() => (config = mockConfig({ id, exclude: { [pkg.name]: ['foo'] } })));
+
+                test('omits excluded dependency', () => {
+                    expect(subject()).toEqual([
+                        expect.objectContaining({
+                            message: expect.stringContaining('bar@~12.3.4'),
+                        }),
+                    ]);
+                });
+            });
+        });
+
+        describe.each(['<1', '^1 || ^2', '>1 <2', '1.0 - 2.0'])('when version is "%s"', version => {
+            beforeEach(() => (pkg.peerDependencies!.foo = version));
+
+            test('error is not fixable', () => {
+                expect(subject()).not.toEqual([
+                    expect.objectContaining({ fixable: expect.anything() }),
+                ]);
+            });
+        });
+    });
+});