@servicetitan/startup 29.0.0 → 30.1.0

package/src/utils/__tests__/get-folders.test.ts

@@ -15,15 +15,9 @@ describe('[Startup] utils:get-folders', () => {
             'tsconfig.json': JSON.stringify({ compilerOptions: { ourDir: 'dist' } }),
         });
 
-        let error;
-
-        try {
-            getFolders();
-        } catch (e) {
-            error = e;
-        }
-
-        expect(error).toBe('"compilerOptions.rootDir" must be defined in the "tsconfig.json"!');
+        expect(() => getFolders()).toThrow(
+            '"compilerOptions.rootDir" must be defined in the "tsconfig.json"!'
+        );
     });
 
     test('getFolders throws an exception if "compilerOptions.outDir" isn\'t defined', () => {
@@ -32,15 +26,9 @@ describe('[Startup] utils:get-folders', () => {
             'tsconfig.json': JSON.stringify({ compilerOptions: { rootDir: 'src' } }),
         });
 
-        let error;
-
-        try {
-            getFolders();
-        } catch (e) {
-            error = e;
-        }
-
-        expect(error).toBe('"compilerOptions.outDir" must be defined in the "tsconfig.json"!');
+        expect(() => getFolders()).toThrow(
+            '"compilerOptions.outDir" must be defined in the "tsconfig.json"!'
+        );
     });
 
     test('"compilerOptions.outDir" used as the destination', () => {

package/src/utils/__tests__/log.test.ts

@@ -14,6 +14,12 @@ describe(`[startup] Utils`, () => {
             stdoutSpy = jest.spyOn(process.stdout, 'write').mockImplementation(jest.fn());
         });
 
+        test('text() writes default text', () => {
+            log.text(message);
+
+            expect(stdoutSpy).toHaveBeenCalledWith(`${chalk(message)}\n`);
+        });
+
         test('info() writes cyan text', () => {
             log.info(message);
 

package/src/utils/get-configuration.ts

@@ -58,6 +58,7 @@ export interface NodeConfiguration {
 export enum CommandName {
     'build' = 'build',
     'bundle-package' = 'bundle-package',
+    'convert-eslint-config' = 'convert-eslint-config',
     'eslint' = 'eslint',
     'init' = 'init',
     'install' = 'install',
@@ -70,6 +71,7 @@ export enum CommandName {
     'start' = 'start',
     'styles-check' = 'styles-check',
     'test' = 'test',
+    'task' = 'task',
 }
 /* eslint-enable @typescript-eslint/naming-convention */
 

package/src/utils/get-destination-folders.ts

@@ -8,24 +8,18 @@ import { getPackages, readJson } from '.';
  */
 export function getDestinationFolders() {
     const packages = getPackages();
+    const cwd = process.cwd();
 
-    return packages
-        .map(({ location }) => {
-            const tsConfigPath = path.join(location, 'tsconfig.json');
-
-            if (!fs.existsSync(tsConfigPath)) {
-                return '';
-            }
-
+    return packages.reduce<string[]>((result, { location }) => {
+        const tsConfigPath = path.join(location, 'tsconfig.json');
+        if (fs.existsSync(tsConfigPath)) {
             const { outDir } = readJson(tsConfigPath).compilerOptions ?? {};
-
-            if (!outDir) {
-                return '';
+            if (outDir) {
+                result.push(
+                    path.join(path.relative(cwd, location), outDir, '/').replace(/\\/g, '/')
+                );
             }
-
-            return path
-                .join('/', path.relative(process.cwd(), location), outDir, '/')
-                .replace(/\\/g, '/');
-        })
-        .filter(path => !!path);
+        }
+        return result;
+    }, []);
 }

package/src/utils/get-folders.ts

@@ -10,11 +10,11 @@ export function getFolders(location = './') {
         readJson(path.join(location, 'tsconfig.json')).compilerOptions ?? {};
 
     if (!rootDir) {
-        throw '"compilerOptions.rootDir" must be defined in the "tsconfig.json"!';
+        throw new Error('"compilerOptions.rootDir" must be defined in the "tsconfig.json"!');
     }
 
     if (!outDir) {
-        throw '"compilerOptions.outDir" must be defined in the "tsconfig.json"!';
+        throw new Error('"compilerOptions.outDir" must be defined in the "tsconfig.json"!');
     }
 
     return {

package/src/utils/log.ts

@@ -10,6 +10,10 @@ class Log {
         this.debugMap = new Map<string, Debugger>();
     }
 
+    text(...text: string[]) {
+        process.stdout.write(chalk(...text) + '\n');
+    }
+
     info(...text: string[]) {
         process.stdout.write(chalk.bold.cyan(...text) + '\n');
     }

package/src/webpack/__tests__/create-webpack-config-web-component.test.ts

@@ -3,7 +3,7 @@ import MiniCssExtractPlugin from 'mini-css-extract-plugin';
 import { fs, vol } from 'memfs';
 import path from 'path';
 import { DefinePlugin } from 'webpack';
-import WebpackAssetsManifest from 'webpack-assets-manifest';
+import { WebpackAssetsManifest } from 'webpack-assets-manifest';
 import VirtualModulesPlugin from 'webpack-virtual-modules';
 
 import { webpackDevConfigFileName, webpackProdConfigFileName } from '../../cli/utils';
@@ -32,7 +32,7 @@ jest.mock('webpack', () => ({
     ...jest.requireActual('webpack'),
     DefinePlugin: jest.fn(),
 }));
-jest.mock('webpack-assets-manifest', () => jest.fn());
+jest.mock('webpack-assets-manifest', () => ({ WebpackAssetsManifest: jest.fn() }));
 jest.mock('webpack-virtual-modules', () => jest.fn());
 jest.mock('../../utils', () => ({
     ...jest.requireActual('../../utils'),

package/src/webpack/__tests__/create-webpack-config.test.ts

@@ -50,7 +50,7 @@ jest.mock('webpack', () => ({
     IgnorePlugin: jest.fn(),
     ProvidePlugin: jest.fn(),
 }));
-jest.mock('webpack-assets-manifest', () => jest.fn());
+jest.mock('webpack-assets-manifest', () => ({ WebpackAssetsManifest: jest.fn() }));
 jest.mock('webpack-bundle-analyzer', () => ({ BundleAnalyzerPlugin: jest.fn() }));
 jest.mock('webpack-filter-warnings-plugin', () => jest.fn());
 jest.mock('webpack-virtual-modules', () => jest.fn());

package/src/webpack/configs/plugins/assets-manifest-plugin.ts

@@ -1,4 +1,4 @@
-import WebpackAssetsManifest from 'webpack-assets-manifest';
+import { WebpackAssetsManifest } from 'webpack-assets-manifest';
 import { Context, Overrides } from '../types';
 import { generateMetadata } from '../utils';
 
@@ -27,7 +27,8 @@ export function assetsManifestPlugin(context: Context, _: Overrides) {
                 js: getAssetsByType('js'),
             };
         },
-        done(_manifest) {
+        // eslint-disable-next-line @typescript-eslint/require-await
+        done: async (_manifest: WebpackAssetsManifest) => {
             generateMetadata(context);
         },
     });

package/src/webpack/configs/plugins/ignore-plugin/check-resource.ts

@@ -20,7 +20,7 @@ export function checkResource(packageContext: Context) {
         if (isOptionalReactDomPeerDependency({ resource, context })) {
             try {
                 require.resolve(resource);
-            } catch (e) {
+            } catch {
                 return true;
             }
         }

package/src/webpack/configs/plugins/moment-locales-plugin.ts

@@ -1,8 +1,21 @@
-import MomentLocalesPlugin from 'moment-locales-webpack-plugin';
 import { Context, Overrides } from '../types';
 
+const MomentLocalesPlugin: typeof import('moment-locales-webpack-plugin') | undefined =
+    isMomentInstalled() ? require('moment-locales-webpack-plugin') : undefined;
+
 export function momentLocalesPlugin(_: Context, _overrides: Overrides) {
-    return new MomentLocalesPlugin({
-        localesToKeep: ['en-au', 'en-ca', 'en-gb'],
-    });
+    return (
+        MomentLocalesPlugin &&
+        new MomentLocalesPlugin({
+            localesToKeep: ['en-au', 'en-ca', 'en-gb'],
+        })
+    );
+}
+
+function isMomentInstalled() {
+    try {
+        return !!require.resolve('moment');
+    } catch {
+        return false;
+    }
 }

package/src/webpack/utils/testing/normalize-errors.ts

@@ -1,5 +1,3 @@
-import { WebpackError } from 'webpack';
-
 function removeCWD(str: string) {
     const isWin = process.platform === 'win32';
     let cwd = process.cwd();
@@ -13,6 +11,6 @@ function removeCWD(str: string) {
     return str.replace(new RegExp(cwd, 'g'), '');
 }
 
-export function normalizeErrors(errors: WebpackError[]) {
+export function normalizeErrors(errors: Error[]) {
     return errors.map(error => removeCWD(error.message.split('\n').slice(0, 2).join('\n')));
 }