@servicetitan/launchdarkly-service 33.0.0 → 33.1.0

package/dist/feature-flag-provider.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"feature-flag-provider.d.ts","sourceRoot":"","sources":["../src/feature-flag-provider.tsx"],"names":[],"mappings":"AAEA,OAAO,EAAE,iBAAiB,EAAuB,MAAM,OAAO,CAAC;AAI/D,wBAAgB,mBAAmB,CAAC,EAAE,QAAQ,EAAE,EAAE,iBAAiB,6BAWlE"}
+{"version":3,"file":"feature-flag-provider.d.ts","sourceRoot":"","sources":["../src/feature-flag-provider.tsx"],"names":[],"mappings":"AAEA,OAAO,EAAE,iBAAiB,EAAuB,MAAM,OAAO,CAAC;AAI/D,wBAAgB,mBAAmB,CAAC,EAAE,QAAQ,EAAE,EAAE,iBAAiB,6BAclE"}

package/dist/feature-flag-provider.js

@@ -1,15 +1,19 @@
 import { useDependencies } from '@servicetitan/react-ioc';
-import { useFlags } from 'launchdarkly-react-client-sdk';
+import { useFlags, useLDClient } from 'launchdarkly-react-client-sdk';
 import { useEffect, useState } from 'react';
 import { FeatureFlagStore } from './feature-flag-store';
 export function FeatureFlagProvider({ children }) {
     const [initialized, setInitialized] = useState(false);
     const [{ setFlags }] = useDependencies(FeatureFlagStore);
+    const client = useLDClient();
     const flags = useFlags();
     useEffect(()=>{
-        setFlags(flags);
-        setInitialized(true);
+        if (client) {
+            setFlags(flags);
+            setInitialized(true);
+        }
     }, [
+        client,
         flags,
         setFlags
     ]);

package/dist/feature-flag-provider.js.map

@@ -1 +1 @@
-{"version":3,"sources":["../src/feature-flag-provider.tsx"],"sourcesContent":["import { useDependencies } from '@servicetitan/react-ioc';\nimport { useFlags } from 'launchdarkly-react-client-sdk';\nimport { PropsWithChildren, useEffect, useState } from 'react';\n\nimport { FeatureFlagStore } from './feature-flag-store';\n\nexport function FeatureFlagProvider({ children }: PropsWithChildren) {\n    const [initialized, setInitialized] = useState(false);\n    const [{ setFlags }] = useDependencies(FeatureFlagStore);\n    const flags = useFlags();\n\n    useEffect(() => {\n        setFlags(flags);\n        setInitialized(true);\n    }, [flags, setFlags]);\n\n    return initialized ? children : null;\n}\n"],"names":["useDependencies","useFlags","useEffect","useState","FeatureFlagStore","FeatureFlagProvider","children","initialized","setInitialized","setFlags","flags"],"mappings":"AAAA,SAASA,eAAe,QAAQ,0BAA0B;AAC1D,SAASC,QAAQ,QAAQ,gCAAgC;AACzD,SAA4BC,SAAS,EAAEC,QAAQ,QAAQ,QAAQ;AAE/D,SAASC,gBAAgB,QAAQ,uBAAuB;AAExD,OAAO,SAASC,oBAAoB,EAAEC,QAAQ,EAAqB;IAC/D,MAAM,CAACC,aAAaC,eAAe,GAAGL,SAAS;IAC/C,MAAM,CAAC,EAAEM,QAAQ,EAAE,CAAC,GAAGT,gBAAgBI;IACvC,MAAMM,QAAQT;IAEdC,UAAU;QACNO,SAASC;QACTF,eAAe;IACnB,GAAG;QAACE;QAAOD;KAAS;IAEpB,OAAOF,cAAcD,WAAW;AACpC"}
+{"version":3,"sources":["../src/feature-flag-provider.tsx"],"sourcesContent":["import { useDependencies } from '@servicetitan/react-ioc';\nimport { useFlags, useLDClient } from 'launchdarkly-react-client-sdk';\nimport { PropsWithChildren, useEffect, useState } from 'react';\n\nimport { FeatureFlagStore } from './feature-flag-store';\n\nexport function FeatureFlagProvider({ children }: PropsWithChildren) {\n    const [initialized, setInitialized] = useState(false);\n    const [{ setFlags }] = useDependencies(FeatureFlagStore);\n    const client = useLDClient();\n    const flags = useFlags();\n\n    useEffect(() => {\n        if (client) {\n            setFlags(flags);\n            setInitialized(true);\n        }\n    }, [client, flags, setFlags]);\n\n    return initialized ? children : null;\n}\n"],"names":["useDependencies","useFlags","useLDClient","useEffect","useState","FeatureFlagStore","FeatureFlagProvider","children","initialized","setInitialized","setFlags","client","flags"],"mappings":"AAAA,SAASA,eAAe,QAAQ,0BAA0B;AAC1D,SAASC,QAAQ,EAAEC,WAAW,QAAQ,gCAAgC;AACtE,SAA4BC,SAAS,EAAEC,QAAQ,QAAQ,QAAQ;AAE/D,SAASC,gBAAgB,QAAQ,uBAAuB;AAExD,OAAO,SAASC,oBAAoB,EAAEC,QAAQ,EAAqB;IAC/D,MAAM,CAACC,aAAaC,eAAe,GAAGL,SAAS;IAC/C,MAAM,CAAC,EAAEM,QAAQ,EAAE,CAAC,GAAGV,gBAAgBK;IACvC,MAAMM,SAAST;IACf,MAAMU,QAAQX;IAEdE,UAAU;QACN,IAAIQ,QAAQ;YACRD,SAASE;YACTH,eAAe;QACnB;IACJ,GAAG;QAACE;QAAQC;QAAOF;KAAS;IAE5B,OAAOF,cAAcD,WAAW;AACpC"}

package/dist/tests/feature-flag-provider.test.js

@@ -4,8 +4,9 @@ import { Provider } from '@servicetitan/react-ioc';
 import { render, screen } from '@testing-library/react';
 import { FeatureFlagProvider } from '../feature-flag-provider';
 import { FeatureFlagStore } from '../feature-flag-store';
-import { useFlags } from 'launchdarkly-react-client-sdk';
+import { useFlags, useLDClient } from 'launchdarkly-react-client-sdk';
 jest.mock('launchdarkly-react-client-sdk', ()=>({
+        useLDClient: jest.fn(),
         useFlags: jest.fn()
     }));
 describe(`[launchdarkly-service] ${FeatureFlagProvider.name}`, ()=>{
@@ -13,13 +14,16 @@ describe(`[launchdarkly-service] ${FeatureFlagProvider.name}`, ()=>{
         foo: 'bar',
         baz: 'qux'
     };
+    const componentText = '<Component />';
     const mockFeatureFlagStore = {
         setFlags: jest.fn()
     };
     const Component = ()=>{
-        return `<Component />`;
+        return componentText;
     };
     beforeEach(()=>{
+        jest.clearAllMocks();
+        jest.mocked(useLDClient).mockImplementation(()=>({}));
         jest.mocked(useFlags).mockImplementation(()=>flags);
     });
     const subject = ()=>render(/*#__PURE__*/ _jsx(Provider, {
@@ -35,12 +39,20 @@ describe(`[launchdarkly-service] ${FeatureFlagProvider.name}`, ()=>{
         }));
     test('renders children', ()=>{
         subject();
-        expect(screen.getByText(`<Component />`)).toBeInTheDocument();
+        expect(screen.getByText(componentText)).toBeInTheDocument();
     });
     test('sets feature flags in store', ()=>{
         subject();
         expect(mockFeatureFlagStore.setFlags).toHaveBeenCalledWith(flags);
     });
+    describe('when client is not ready', ()=>{
+        beforeEach(()=>jest.mocked(useLDClient).mockReturnValue(undefined));
+        test('does nothing', ()=>{
+            subject();
+            expect(screen.queryByText(componentText)).not.toBeInTheDocument();
+            expect(mockFeatureFlagStore.setFlags).not.toHaveBeenCalledWith(flags);
+        });
+    });
 });
 
 //# sourceMappingURL=feature-flag-provider.test.js.map

package/dist/tests/feature-flag-provider.test.js.map

@@ -1 +1 @@
-{"version":3,"sources":["../../src/tests/feature-flag-provider.test.tsx"],"sourcesContent":["import '@testing-library/jest-dom';\nimport { Provider } from '@servicetitan/react-ioc';\nimport { FC } from 'react';\nimport { render, screen } from '@testing-library/react';\n\nimport { FeatureFlagProvider } from '../feature-flag-provider';\nimport { FeatureFlagStore } from '../feature-flag-store';\nimport { useFlags } from 'launchdarkly-react-client-sdk';\n\njest.mock('launchdarkly-react-client-sdk', () => ({\n    useFlags: jest.fn(),\n}));\n\ndescribe(`[launchdarkly-service] ${FeatureFlagProvider.name}`, () => {\n    const flags = { foo: 'bar', baz: 'qux' };\n    const mockFeatureFlagStore = {\n        setFlags: jest.fn(),\n    };\n\n    const Component: FC = () => {\n        return `<Component />`;\n    };\n\n    beforeEach(() => {\n        jest.mocked(useFlags).mockImplementation(() => flags);\n    });\n\n    const subject = () =>\n        render(\n            <Provider singletons={[{ provide: FeatureFlagStore, useValue: mockFeatureFlagStore }]}>\n                <FeatureFlagProvider>\n                    <Component />\n                </FeatureFlagProvider>\n            </Provider>\n        );\n\n    test('renders children', () => {\n        subject();\n\n        expect(screen.getByText(`<Component />`)).toBeInTheDocument();\n    });\n\n    test('sets feature flags in store', () => {\n        subject();\n\n        expect(mockFeatureFlagStore.setFlags).toHaveBeenCalledWith(flags);\n    });\n});\n"],"names":["Provider","render","screen","FeatureFlagProvider","FeatureFlagStore","useFlags","jest","mock","fn","describe","name","flags","foo","baz","mockFeatureFlagStore","setFlags","Component","beforeEach","mocked","mockImplementation","subject","singletons","provide","useValue","test","expect","getByText","toBeInTheDocument","toHaveBeenCalledWith"],"mappings":";AAAA,OAAO,4BAA4B;AACnC,SAASA,QAAQ,QAAQ,0BAA0B;AAEnD,SAASC,MAAM,EAAEC,MAAM,QAAQ,yBAAyB;AAExD,SAASC,mBAAmB,QAAQ,2BAA2B;AAC/D,SAASC,gBAAgB,QAAQ,wBAAwB;AACzD,SAASC,QAAQ,QAAQ,gCAAgC;AAEzDC,KAAKC,IAAI,CAAC,iCAAiC,IAAO,CAAA;QAC9CF,UAAUC,KAAKE,EAAE;IACrB,CAAA;AAEAC,SAAS,CAAC,uBAAuB,EAAEN,oBAAoBO,IAAI,EAAE,EAAE;IAC3D,MAAMC,QAAQ;QAAEC,KAAK;QAAOC,KAAK;IAAM;IACvC,MAAMC,uBAAuB;QACzBC,UAAUT,KAAKE,EAAE;IACrB;IAEA,MAAMQ,YAAgB;QAClB,OAAO,CAAC,aAAa,CAAC;IAC1B;IAEAC,WAAW;QACPX,KAAKY,MAAM,CAACb,UAAUc,kBAAkB,CAAC,IAAMR;IACnD;IAEA,MAAMS,UAAU,IACZnB,qBACI,KAACD;YAASqB,YAAY;gBAAC;oBAAEC,SAASlB;oBAAkBmB,UAAUT;gBAAqB;aAAE;sBACjF,cAAA,KAACX;0BACG,cAAA,KAACa;;;IAKjBQ,KAAK,oBAAoB;QACrBJ;QAEAK,OAAOvB,OAAOwB,SAAS,CAAC,CAAC,aAAa,CAAC,GAAGC,iBAAiB;IAC/D;IAEAH,KAAK,+BAA+B;QAChCJ;QAEAK,OAAOX,qBAAqBC,QAAQ,EAAEa,oBAAoB,CAACjB;IAC/D;AACJ"}
+{"version":3,"sources":["../../src/tests/feature-flag-provider.test.tsx"],"sourcesContent":["import '@testing-library/jest-dom';\nimport { Provider } from '@servicetitan/react-ioc';\nimport { FC } from 'react';\nimport { render, screen } from '@testing-library/react';\n\nimport { FeatureFlagProvider } from '../feature-flag-provider';\nimport { FeatureFlagStore } from '../feature-flag-store';\nimport { useFlags, useLDClient } from 'launchdarkly-react-client-sdk';\n\njest.mock('launchdarkly-react-client-sdk', () => ({\n    useLDClient: jest.fn(),\n    useFlags: jest.fn(),\n}));\n\ndescribe(`[launchdarkly-service] ${FeatureFlagProvider.name}`, () => {\n    const flags = { foo: 'bar', baz: 'qux' };\n    const componentText = '<Component />';\n    const mockFeatureFlagStore = {\n        setFlags: jest.fn(),\n    };\n\n    const Component: FC = () => {\n        return componentText;\n    };\n\n    beforeEach(() => {\n        jest.clearAllMocks();\n        jest.mocked(useLDClient).mockImplementation(() => ({}) as any);\n        jest.mocked(useFlags).mockImplementation(() => flags);\n    });\n\n    const subject = () =>\n        render(\n            <Provider singletons={[{ provide: FeatureFlagStore, useValue: mockFeatureFlagStore }]}>\n                <FeatureFlagProvider>\n                    <Component />\n                </FeatureFlagProvider>\n            </Provider>\n        );\n\n    test('renders children', () => {\n        subject();\n\n        expect(screen.getByText(componentText)).toBeInTheDocument();\n    });\n\n    test('sets feature flags in store', () => {\n        subject();\n\n        expect(mockFeatureFlagStore.setFlags).toHaveBeenCalledWith(flags);\n    });\n\n    describe('when client is not ready', () => {\n        beforeEach(() => jest.mocked(useLDClient).mockReturnValue(undefined));\n\n        test('does nothing', () => {\n            subject();\n\n            expect(screen.queryByText(componentText)).not.toBeInTheDocument();\n            expect(mockFeatureFlagStore.setFlags).not.toHaveBeenCalledWith(flags);\n        });\n    });\n});\n"],"names":["Provider","render","screen","FeatureFlagProvider","FeatureFlagStore","useFlags","useLDClient","jest","mock","fn","describe","name","flags","foo","baz","componentText","mockFeatureFlagStore","setFlags","Component","beforeEach","clearAllMocks","mocked","mockImplementation","subject","singletons","provide","useValue","test","expect","getByText","toBeInTheDocument","toHaveBeenCalledWith","mockReturnValue","undefined","queryByText","not"],"mappings":";AAAA,OAAO,4BAA4B;AACnC,SAASA,QAAQ,QAAQ,0BAA0B;AAEnD,SAASC,MAAM,EAAEC,MAAM,QAAQ,yBAAyB;AAExD,SAASC,mBAAmB,QAAQ,2BAA2B;AAC/D,SAASC,gBAAgB,QAAQ,wBAAwB;AACzD,SAASC,QAAQ,EAAEC,WAAW,QAAQ,gCAAgC;AAEtEC,KAAKC,IAAI,CAAC,iCAAiC,IAAO,CAAA;QAC9CF,aAAaC,KAAKE,EAAE;QACpBJ,UAAUE,KAAKE,EAAE;IACrB,CAAA;AAEAC,SAAS,CAAC,uBAAuB,EAAEP,oBAAoBQ,IAAI,EAAE,EAAE;IAC3D,MAAMC,QAAQ;QAAEC,KAAK;QAAOC,KAAK;IAAM;IACvC,MAAMC,gBAAgB;IACtB,MAAMC,uBAAuB;QACzBC,UAAUV,KAAKE,EAAE;IACrB;IAEA,MAAMS,YAAgB;QAClB,OAAOH;IACX;IAEAI,WAAW;QACPZ,KAAKa,aAAa;QAClBb,KAAKc,MAAM,CAACf,aAAagB,kBAAkB,CAAC,IAAO,CAAA,CAAC,CAAA;QACpDf,KAAKc,MAAM,CAAChB,UAAUiB,kBAAkB,CAAC,IAAMV;IACnD;IAEA,MAAMW,UAAU,IACZtB,qBACI,KAACD;YAASwB,YAAY;gBAAC;oBAAEC,SAASrB;oBAAkBsB,UAAUV;gBAAqB;aAAE;sBACjF,cAAA,KAACb;0BACG,cAAA,KAACe;;;IAKjBS,KAAK,oBAAoB;QACrBJ;QAEAK,OAAO1B,OAAO2B,SAAS,CAACd,gBAAgBe,iBAAiB;IAC7D;IAEAH,KAAK,+BAA+B;QAChCJ;QAEAK,OAAOZ,qBAAqBC,QAAQ,EAAEc,oBAAoB,CAACnB;IAC/D;IAEAF,SAAS,4BAA4B;QACjCS,WAAW,IAAMZ,KAAKc,MAAM,CAACf,aAAa0B,eAAe,CAACC;QAE1DN,KAAK,gBAAgB;YACjBJ;YAEAK,OAAO1B,OAAOgC,WAAW,CAACnB,gBAAgBoB,GAAG,CAACL,iBAAiB;YAC/DF,OAAOZ,qBAAqBC,QAAQ,EAAEkB,GAAG,CAACJ,oBAAoB,CAACnB;QACnE;IACJ;AACJ"}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@servicetitan/launchdarkly-service",
-    "version": "33.0.0",
+    "version": "33.1.0",
     "description": "",
     "homepage": "https://docs.st.dev/docs/frontend/launchdarkly-service",
     "repository": {
@@ -16,8 +16,8 @@
         "src"
     ],
     "devDependencies": {
-        "@servicetitan/log-service": "33.0.0",
-        "@servicetitan/react-ioc": "33.0.0",
+        "@servicetitan/log-service": "33.1.0",
+        "@servicetitan/react-ioc": "33.1.0",
         "@testing-library/dom": "^10.4.1",
         "@testing-library/jest-dom": "^6.9.1",
         "@testing-library/react": "^16.3.0",
@@ -27,8 +27,8 @@
         "react": "~18.3.1"
     },
     "peerDependencies": {
-        "@servicetitan/log-service": "33.0.0",
-        "@servicetitan/react-ioc": "33.0.0",
+        "@servicetitan/log-service": "33.1.0",
+        "@servicetitan/react-ioc": "33.1.0",
         "launchdarkly-js-client-sdk": "3.5.0",
         "launchdarkly-react-client-sdk": "3.6.1",
         "mobx": ">= 6.13.7",
@@ -40,5 +40,5 @@
     "cli": {
         "webpack": false
     },
-    "gitHead": "31ea85a4348eec3402ac60008c9c2944d34bdbb2"
+    "gitHead": "126948560bcb684f276373beb7ce45faac94205c"
 }

package/src/feature-flag-provider.tsx

@@ -1,5 +1,5 @@
 import { useDependencies } from '@servicetitan/react-ioc';
-import { useFlags } from 'launchdarkly-react-client-sdk';
+import { useFlags, useLDClient } from 'launchdarkly-react-client-sdk';
 import { PropsWithChildren, useEffect, useState } from 'react';
 
 import { FeatureFlagStore } from './feature-flag-store';
@@ -7,12 +7,15 @@ import { FeatureFlagStore } from './feature-flag-store';
 export function FeatureFlagProvider({ children }: PropsWithChildren) {
     const [initialized, setInitialized] = useState(false);
     const [{ setFlags }] = useDependencies(FeatureFlagStore);
+    const client = useLDClient();
     const flags = useFlags();
 
     useEffect(() => {
-        setFlags(flags);
-        setInitialized(true);
-    }, [flags, setFlags]);
+        if (client) {
+            setFlags(flags);
+            setInitialized(true);
+        }
+    }, [client, flags, setFlags]);
 
     return initialized ? children : null;
 }

package/src/tests/feature-flag-provider.test.tsx

@@ -5,23 +5,27 @@ import { render, screen } from '@testing-library/react';
 
 import { FeatureFlagProvider } from '../feature-flag-provider';
 import { FeatureFlagStore } from '../feature-flag-store';
-import { useFlags } from 'launchdarkly-react-client-sdk';
+import { useFlags, useLDClient } from 'launchdarkly-react-client-sdk';
 
 jest.mock('launchdarkly-react-client-sdk', () => ({
+    useLDClient: jest.fn(),
     useFlags: jest.fn(),
 }));
 
 describe(`[launchdarkly-service] ${FeatureFlagProvider.name}`, () => {
     const flags = { foo: 'bar', baz: 'qux' };
+    const componentText = '<Component />';
     const mockFeatureFlagStore = {
         setFlags: jest.fn(),
     };
 
     const Component: FC = () => {
-        return `<Component />`;
+        return componentText;
     };
 
     beforeEach(() => {
+        jest.clearAllMocks();
+        jest.mocked(useLDClient).mockImplementation(() => ({}) as any);
         jest.mocked(useFlags).mockImplementation(() => flags);
     });
 
@@ -37,7 +41,7 @@ describe(`[launchdarkly-service] ${FeatureFlagProvider.name}`, () => {
     test('renders children', () => {
         subject();
 
-        expect(screen.getByText(`<Component />`)).toBeInTheDocument();
+        expect(screen.getByText(componentText)).toBeInTheDocument();
     });
 
     test('sets feature flags in store', () => {
@@ -45,4 +49,15 @@ describe(`[launchdarkly-service] ${FeatureFlagProvider.name}`, () => {
 
         expect(mockFeatureFlagStore.setFlags).toHaveBeenCalledWith(flags);
     });
+
+    describe('when client is not ready', () => {
+        beforeEach(() => jest.mocked(useLDClient).mockReturnValue(undefined));
+
+        test('does nothing', () => {
+            subject();
+
+            expect(screen.queryByText(componentText)).not.toBeInTheDocument();
+            expect(mockFeatureFlagStore.setFlags).not.toHaveBeenCalledWith(flags);
+        });
+    });
 });