@servicetitan/eslint-plugin 22.21.0 → 23.1.0

package/dist/index.d.ts

@@ -1,10 +1,6 @@
-export declare const rules: {
-    'use-declare-with-decorators': import("eslint").Rule.RuleModule;
-    'mobx/use-makeObservable-with-decorators': import("eslint").Rule.RuleModule;
-    'mobx/no-abstract-decorators': import("eslint").Rule.RuleModule;
-    'react/destructure-default-import': import("eslint").Rule.RuleModule;
-    'react/no-qualified-type': import("eslint").Rule.RuleModule;
-};
+import { AnyRuleModule } from '@typescript-eslint/utils/ts-eslint';
+import { Rule } from 'eslint';
+export declare const rules: Record<string, Rule.RuleModule | AnyRuleModule>;
 export declare const processors: {
     stub: import("eslint").Linter.LintOptions;
 };

package/dist/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAOA,eAAO,MAAM,KAAK;;;;;;CAMjB,CAAC;AAEF,eAAO,MAAM,UAAU;;CAAW,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,aAAa,EAAE,MAAM,oCAAoC,CAAC;AACnE,OAAO,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAS9B,eAAO,MAAM,KAAK,EAAE,MAAM,CAAC,MAAM,EAAE,IAAI,CAAC,UAAU,GAAG,aAAa,CAOjE,CAAC;AAEF,eAAO,MAAM,UAAU;;CAAW,CAAC"}

package/dist/index.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.processors = exports.rules = void 0;
+const no_async_in_foreach_1 = require("./rules/no-async-in-foreach");
 const decorators_declare_1 = require("./rules/decorators-declare");
 const use_makeObservable_with_decorators_1 = require("./rules/mobx/use-makeObservable-with-decorators");
 const no_abstract_decorators_1 = require("./rules/mobx/no-abstract-decorators");
@@ -8,11 +9,12 @@ const destructure_default_import_1 = require("./rules/react/destructure-default-
 const no_qualified_type_1 = require("./rules/react/no-qualified-type");
 const stub_1 = require("./processors/stub");
 exports.rules = {
-    'use-declare-with-decorators': decorators_declare_1.useDeclareWithDecorators,
     'mobx/use-makeObservable-with-decorators': use_makeObservable_with_decorators_1.mobxUseMakeObservableWithDecorators,
     'mobx/no-abstract-decorators': no_abstract_decorators_1.mobxNoAbstractDecorators,
     'react/destructure-default-import': destructure_default_import_1.reactDestructureDefaultImport,
     'react/no-qualified-type': no_qualified_type_1.reactNoQualifiedType,
+    'no-async-in-foreach': no_async_in_foreach_1.noAsyncInForEach,
+    'use-declare-with-decorators': decorators_declare_1.useDeclareWithDecorators,
 };
 exports.processors = { stub: stub_1.stub };
 //# sourceMappingURL=index.js.map

package/dist/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;;AAAA,mEAAsE;AACtE,wGAAsG;AACtG,gFAA+E;AAC/E,yFAAyF;AACzF,uEAAuE;AACvE,4CAAyC;AAE5B,QAAA,KAAK,GAAG;IACjB,6BAA6B,EAAE,6CAAwB;IACvD,yCAAyC,EAAE,wEAAmC;IAC9E,6BAA6B,EAAE,iDAAwB;IACvD,kCAAkC,EAAE,0DAA6B;IACjE,yBAAyB,EAAE,wCAAoB;CAClD,CAAC;AAEW,QAAA,UAAU,GAAG,EAAE,IAAI,EAAJ,WAAI,EAAE,CAAC"}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;;AAEA,qEAA+D;AAC/D,mEAAsE;AACtE,wGAAsG;AACtG,gFAA+E;AAC/E,yFAAyF;AACzF,uEAAuE;AACvE,4CAAyC;AAE5B,QAAA,KAAK,GAAoD;IAClE,yCAAyC,EAAE,wEAAmC;IAC9E,6BAA6B,EAAE,iDAAwB;IACvD,kCAAkC,EAAE,0DAA6B;IACjE,yBAAyB,EAAE,wCAAoB;IAC/C,qBAAqB,EAAE,sCAAgB;IACvC,6BAA6B,EAAE,6CAAwB;CAC1D,CAAC;AAEW,QAAA,UAAU,GAAG,EAAE,IAAI,EAAJ,WAAI,EAAE,CAAC"}

package/dist/rules/__mocks__/fixture/file.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=file.d.ts.map

package/dist/rules/__mocks__/fixture/file.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"file.d.ts","sourceRoot":"","sources":["../../../../src/rules/__mocks__/fixture/file.ts"],"names":[],"mappings":""}

package/dist/rules/__mocks__/fixture/file.js

@@ -0,0 +1,7 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+/*
+ * This file is required to test type-aware rules.
+ * See https://typescript-eslint.io/packages/rule-tester/#type-aware-testing
+ */
+//# sourceMappingURL=file.js.map

package/dist/rules/__mocks__/fixture/file.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"file.js","sourceRoot":"","sources":["../../../../src/rules/__mocks__/fixture/file.ts"],"names":[],"mappings":";;AAAA;;;GAGG"}

package/dist/rules/__mocks__/fixture/react.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=react.d.ts.map

package/dist/rules/__mocks__/fixture/react.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"react.d.ts","sourceRoot":"","sources":["../../../../src/rules/__mocks__/fixture/react.tsx"],"names":[],"mappings":""}

package/dist/rules/__mocks__/fixture/react.js

@@ -0,0 +1,7 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+/*
+ * This file is required to test type-aware rules.
+ * See https://typescript-eslint.io/packages/rule-tester/#type-aware-testing
+ */
+//# sourceMappingURL=react.js.map

package/dist/rules/__mocks__/fixture/react.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"react.js","sourceRoot":"","sources":["../../../../src/rules/__mocks__/fixture/react.tsx"],"names":[],"mappings":";;AAAA;;;GAGG"}

package/dist/rules/no-async-in-foreach.d.ts

@@ -0,0 +1,3 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+export declare const noAsyncInForEach: ESLintUtils.RuleModule<"noAsyncInForEach", never[], ESLintUtils.RuleListener>;
+//# sourceMappingURL=no-async-in-foreach.d.ts.map

package/dist/rules/no-async-in-foreach.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-async-in-foreach.d.ts","sourceRoot":"","sources":["../../src/rules/no-async-in-foreach.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAY,MAAM,0BAA0B,CAAC;AASjE,eAAO,MAAM,gBAAgB,+EAkF3B,CAAC"}

package/dist/rules/no-async-in-foreach.js

@@ -0,0 +1,78 @@
+"use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.noAsyncInForEach = void 0;
+const utils_1 = require("@typescript-eslint/utils");
+const eslint_utils_1 = require("@typescript-eslint/utils/eslint-utils");
+const type_utils_1 = require("@typescript-eslint/type-utils");
+const typescript_1 = __importDefault(require("typescript"));
+const createRule = utils_1.ESLintUtils.RuleCreator(_name => 'https://gist.github.com/joeytwiddle/37d2085425c049629b80956d3c618971');
+exports.noAsyncInForEach = createRule({
+    create(context) {
+        const services = (0, eslint_utils_1.getParserServices)(context);
+        const checker = services.program.getTypeChecker();
+        function checkForEachExpression(node) {
+            const callExpression = node.parent;
+            if (!isAsync(callExpression.arguments[0])) {
+                return;
+            }
+            const callee = callExpression.callee;
+            if (!isArrayLike(callee.object)) {
+                return;
+            }
+            context.report({ messageId: 'noAsyncInForEach', node });
+        }
+        function getSymbolAtLocation(node) {
+            const symbol = services.getSymbolAtLocation(node);
+            if (symbol && symbol.flags & typescript_1.default.SymbolFlags.Alias) {
+                return checker.getAliasedSymbol(symbol);
+            }
+            return symbol;
+        }
+        function isArrayLike(node) {
+            const nodeType = services.getTypeAtLocation(node);
+            const types = isUnionType(nodeType) ? nodeType.types : [nodeType];
+            return types.some(type => checker.isArrayType(type) || checker.isTupleType(type));
+        }
+        function isAsync(node) {
+            return ((node.type === utils_1.TSESTree.AST_NODE_TYPES.ArrowFunctionExpression && node.async) ||
+                hasAsyncModifier(getSymbolAtLocation(node)) ||
+                returnsPromise(node));
+        }
+        function isUnionType(type) {
+            return (type.flags & typescript_1.default.TypeFlags.Union) !== 0;
+        }
+        function hasAsyncModifier(symbol) {
+            var _a;
+            return !!((_a = symbol === null || symbol === void 0 ? void 0 : symbol.declarations) === null || _a === void 0 ? void 0 : _a.find(declaration => {
+                var _a;
+                return (_a = declaration.modifiers) === null || _a === void 0 ? void 0 : _a.find(modifier => modifier.kind === typescript_1.default.SyntaxKind.AsyncKeyword);
+            }));
+        }
+        function returnsPromise(node) {
+            const signatures = services.getTypeAtLocation(node).getCallSignatures();
+            if (signatures.length) {
+                const returnType = checker.getReturnTypeOfSignature(signatures[0]);
+                return (0, type_utils_1.containsAllTypesByName)(returnType, true, new Set(['Promise']));
+            }
+        }
+        return {
+            "CallExpression[arguments.length=1] > MemberExpression[property.name='forEach']": checkForEachExpression,
+        };
+    },
+    name: 'no-async-in-foreach',
+    meta: {
+        docs: {
+            description: 'Disallow passing asynchronous callback to Array.forEach',
+        },
+        messages: {
+            noAsyncInForEach: 'Async callback passed to Array.forEach',
+        },
+        type: 'problem',
+        schema: [],
+    },
+    defaultOptions: [],
+});
+//# sourceMappingURL=no-async-in-foreach.js.map

package/dist/rules/no-async-in-foreach.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-async-in-foreach.js","sourceRoot":"","sources":["../../src/rules/no-async-in-foreach.ts"],"names":[],"mappings":";;;;;;AAAA,oDAAiE;AACjE,wEAA0E;AAC1E,8DAAuE;AACvE,4DAA6C;AAE7C,MAAM,UAAU,GAAG,mBAAW,CAAC,WAAW,CACtC,KAAK,CAAC,EAAE,CAAC,sEAAsE,CAClF,CAAC;AAEW,QAAA,gBAAgB,GAAG,UAAU,CAAC;IACvC,MAAM,CAAC,OAAO;QACV,MAAM,QAAQ,GAAG,IAAA,gCAAiB,EAAC,OAAO,CAAC,CAAC;QAC5C,MAAM,OAAO,GAAG,QAAQ,CAAC,OAAO,CAAC,cAAc,EAI9C,CAAC;QAEF,SAAS,sBAAsB,CAAC,IAA+B;YAC3D,MAAM,cAAc,GAAG,IAAI,CAAC,MAAiC,CAAC;YAC9D,IAAI,CAAC,OAAO,CAAC,cAAc,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,EAAE;gBACvC,OAAO;aACV;YAED,MAAM,MAAM,GAAG,cAAc,CAAC,MAAmC,CAAC;YAClE,IAAI,CAAC,WAAW,CAAC,MAAM,CAAC,MAAM,CAAC,EAAE;gBAC7B,OAAO;aACV;YAED,OAAO,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,kBAAkB,EAAE,IAAI,EAAE,CAAC,CAAC;QAC5D,CAAC;QAED,SAAS,mBAAmB,CAAC,IAAmB;YAC5C,MAAM,MAAM,GAAG,QAAQ,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;YAClD,IAAI,MAAM,IAAI,MAAM,CAAC,KAAK,GAAG,oBAAE,CAAC,WAAW,CAAC,KAAK,EAAE;gBAC/C,OAAO,OAAO,CAAC,gBAAgB,CAAC,MAAM,CAAC,CAAC;aAC3C;YACD,OAAO,MAAM,CAAC;QAClB,CAAC;QAED,SAAS,WAAW,CAAC,IAAmB;YACpC,MAAM,QAAQ,GAAG,QAAQ,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;YAClD,MAAM,KAAK,GAAG,WAAW,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC;YAClE,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,OAAO,CAAC,WAAW,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC,CAAC;QACtF,CAAC;QAED,SAAS,OAAO,CAAC,IAAmB;YAChC,OAAO,CACH,CAAC,IAAI,CAAC,IAAI,KAAK,gBAAQ,CAAC,cAAc,CAAC,uBAAuB,IAAI,IAAI,CAAC,KAAK,CAAC;gBAC7E,gBAAgB,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;gBAC3C,cAAc,CAAC,IAAI,CAAC,CACvB,CAAC;QACN,CAAC;QAED,SAAS,WAAW,CAAC,IAAa;YAC9B,OAAO,CAAC,IAAI,CAAC,KAAK,GAAG,oBAAE,CAAC,SAAS,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QACnD,CAAC;QAED,SAAS,gBAAgB,CAAC,MAAkB;;YACxC,OAAO,CAAC,CAAC,CAAA,MAAA,MAAM,aAAN,MAAM,uBAAN,MAAM,CAAE,YAAY,0CAAE,IAAI,CAAC,WAAW,CAAC,EAAE;;gBAC9C,OAAA,MAAA,WAAW,CAAC,SAAS,0CAAE,IAAI,CACvB,QAAQ,CAAC,EAAE,CAAC,QAAQ,CAAC,IAAI,KAAK,oBAAE,CAAC,UAAU,CAAC,YAAY,CAC3D,CAAA;aAAA,CACJ,CAAA,CAAC;QACN,CAAC;QAED,SAAS,cAAc,CAAC,IAAmB;YACvC,MAAM,UAAU,GAAG,QAAQ,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC,iBAAiB,EAAE,CAAC;YACxE,IAAI,UAAU,CAAC,MAAM,EAAE;gBACnB,MAAM,UAAU,GAAG,OAAO,CAAC,wBAAwB,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,CAAC;gBACnE,OAAO,IAAA,mCAAsB,EAAC,UAAU,EAAE,IAAI,EAAE,IAAI,GAAG,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;aACzE;QACL,CAAC;QAED,OAAO;YACH,gFAAgF,EAC5E,sBAAsB;SAC7B,CAAC;IACN,CAAC;IACD,IAAI,EAAE,qBAAqB;IAC3B,IAAI,EAAE;QACF,IAAI,EAAE;YACF,WAAW,EAAE,yDAAyD;SACzE;QACD,QAAQ,EAAE;YACN,gBAAgB,EAAE,wCAAwC;SAC7D;QACD,IAAI,EAAE,SAAS;QACf,MAAM,EAAE,EAAE;KACb;IACD,cAAc,EAAE,EAAE;CACrB,CAAC,CAAC"}

package/dist/rules/react/destructure-default-import.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"destructure-default-import.d.ts","sourceRoot":"","sources":["../../../src/rules/react/destructure-default-import.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAE9B,eAAO,MAAM,6BAA6B,EAAE,IAAI,CAAC,UAsChD,CAAC"}
+{"version":3,"file":"destructure-default-import.d.ts","sourceRoot":"","sources":["../../../src/rules/react/destructure-default-import.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAE9B,eAAO,MAAM,6BAA6B,EAAE,IAAI,CAAC,UAkChD,CAAC"}

package/dist/rules/react/destructure-default-import.js

@@ -17,7 +17,6 @@ exports.reactDestructureDefaultImport = {
     create(context) {
         return {
             ImportDeclaration(node) {
-                const reactImportSpecifiers = new Set();
                 if (node.source.value !== 'react') {
                     return;
                 }
@@ -29,9 +28,6 @@ exports.reactDestructureDefaultImport = {
                             messageId: 'importDefault',
                         });
                     }
-                    else {
-                        reactImportSpecifiers.add(specifier.imported);
-                    }
                 });
             },
         };

package/dist/rules/react/destructure-default-import.js.map

@@ -1 +1 @@
-{"version":3,"file":"destructure-default-import.js","sourceRoot":"","sources":["../../../src/rules/react/destructure-default-import.ts"],"names":[],"mappings":";;;AAEa,QAAA,6BAA6B,GAAoB;IAC1D,IAAI,EAAE;QACF,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACF,WAAW,EAAE,2CAA2C;YACxD,QAAQ,EAAE,gBAAgB;YAC1B,WAAW,EAAE,KAAK;YAClB,GAAG,EAAE,2CAA2C;SACnD;QACD,QAAQ,EAAE;YACN,aAAa,EAAE,sCAAsC;SACxD;KACJ;IACD,MAAM,CAAC,OAAO;QACV,OAAO;YACH,iBAAiB,CAAC,IAAI;gBAClB,MAAM,qBAAqB,GAAG,IAAI,GAAG,EAAE,CAAC;gBAExC,IAAI,IAAI,CAAC,MAAM,CAAC,KAAK,KAAK,OAAO,EAAE;oBAC/B,OAAO;iBACV;gBAED,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC,SAAS,CAAC,EAAE;oBAChC,IACI,SAAS,CAAC,IAAI,KAAK,wBAAwB;wBAC3C,SAAS,CAAC,IAAI,KAAK,0BAA0B,EAC/C;wBACE,OAAO,CAAC,MAAM,CAAC;4BACX,IAAI;4BACJ,SAAS,EAAE,eAAe;yBAC7B,CAAC,CAAC;qBACN;yBAAM;wBACH,qBAAqB,CAAC,GAAG,CAAC,SAAS,CAAC,QAAQ,CAAC,CAAC;qBACjD;gBACL,CAAC,CAAC,CAAC;YACP,CAAC;SACJ,CAAC;IACN,CAAC;CACJ,CAAC"}
+{"version":3,"file":"destructure-default-import.js","sourceRoot":"","sources":["../../../src/rules/react/destructure-default-import.ts"],"names":[],"mappings":";;;AAEa,QAAA,6BAA6B,GAAoB;IAC1D,IAAI,EAAE;QACF,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACF,WAAW,EAAE,2CAA2C;YACxD,QAAQ,EAAE,gBAAgB;YAC1B,WAAW,EAAE,KAAK;YAClB,GAAG,EAAE,2CAA2C;SACnD;QACD,QAAQ,EAAE;YACN,aAAa,EAAE,sCAAsC;SACxD;KACJ;IACD,MAAM,CAAC,OAAO;QACV,OAAO;YACH,iBAAiB,CAAC,IAAI;gBAClB,IAAI,IAAI,CAAC,MAAM,CAAC,KAAK,KAAK,OAAO,EAAE;oBAC/B,OAAO;iBACV;gBAED,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC,SAAS,CAAC,EAAE;oBAChC,IACI,SAAS,CAAC,IAAI,KAAK,wBAAwB;wBAC3C,SAAS,CAAC,IAAI,KAAK,0BAA0B,EAC/C;wBACE,OAAO,CAAC,MAAM,CAAC;4BACX,IAAI;4BACJ,SAAS,EAAE,eAAe;yBAC7B,CAAC,CAAC;qBACN;gBACL,CAAC,CAAC,CAAC;YACP,CAAC;SACJ,CAAC;IACN,CAAC;CACJ,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@servicetitan/eslint-plugin",
-    "version": "22.21.0",
+    "version": "23.1.0",
     "description": "",
     "repository": {
         "type": "git",
@@ -13,12 +13,19 @@
         "dist",
         "src"
     ],
+    "dependencies": {
+        "@typescript-eslint/parser": "~6.21.0",
+        "@typescript-eslint/type-utils": "^6.21.0",
+        "@typescript-eslint/utils": "~6.21.0"
+    },
     "devDependencies": {
-        "@types/eslint": "~8.44.2",
-        "eslint": "~8.48.0"
+        "@types/eslint": "~8.56.3",
+        "@typescript-eslint/rule-tester": "~6.21.0",
+        "eslint": "~8.57.0"
     },
     "peerDependencies": {
-        "eslint": "~8.48.0"
+        "eslint": "~8.57.0",
+        "typescript": ">=4"
     },
     "publishConfig": {
         "access": "public"
@@ -26,5 +33,5 @@
     "cli": {
         "webpack": false
     },
-    "gitHead": "729b7ca4eb38c323ac538a73573cadd54a4ff839"
+    "gitHead": "7267270e54cdb3a2926f61feb4939d057e82adb3"
 }

package/src/index.ts

@@ -1,3 +1,6 @@
+import { AnyRuleModule } from '@typescript-eslint/utils/ts-eslint';
+import { Rule } from 'eslint';
+import { noAsyncInForEach } from './rules/no-async-in-foreach';
 import { useDeclareWithDecorators } from './rules/decorators-declare';
 import { mobxUseMakeObservableWithDecorators } from './rules/mobx/use-makeObservable-with-decorators';
 import { mobxNoAbstractDecorators } from './rules/mobx/no-abstract-decorators';
@@ -5,12 +8,13 @@ import { reactDestructureDefaultImport } from './rules/react/destructure-default
 import { reactNoQualifiedType } from './rules/react/no-qualified-type';
 import { stub } from './processors/stub';
 
-export const rules = {
-    'use-declare-with-decorators': useDeclareWithDecorators,
+export const rules: Record<string, Rule.RuleModule | AnyRuleModule> = {
     'mobx/use-makeObservable-with-decorators': mobxUseMakeObservableWithDecorators,
     'mobx/no-abstract-decorators': mobxNoAbstractDecorators,
     'react/destructure-default-import': reactDestructureDefaultImport,
     'react/no-qualified-type': reactNoQualifiedType,
+    'no-async-in-foreach': noAsyncInForEach,
+    'use-declare-with-decorators': useDeclareWithDecorators,
 };
 
 export const processors = { stub };

package/src/rules/__mocks__/fixture/file.ts

@@ -0,0 +1,4 @@
+/*
+ * This file is required to test type-aware rules.
+ * See https://typescript-eslint.io/packages/rule-tester/#type-aware-testing
+ */

package/src/rules/__mocks__/fixture/react.tsx

@@ -0,0 +1,4 @@
+/*
+ * This file is required to test type-aware rules.
+ * See https://typescript-eslint.io/packages/rule-tester/#type-aware-testing
+ */

package/src/rules/__mocks__/fixture/tsconfig.json

@@ -0,0 +1,6 @@
+{
+    "compilerOptions": {
+        "strict": true
+    },
+    "include": ["file.ts", "react.tsx"]
+}

package/src/rules/__tests__/no-async-in-foreach.test.ts

@@ -0,0 +1,163 @@
+import path from 'path';
+import { RuleTester } from '@typescript-eslint/rule-tester';
+import { noAsyncInForEach } from '../no-async-in-foreach';
+
+const ruleTester = new RuleTester({
+    parser: '@typescript-eslint/parser',
+    parserOptions: {
+        project: './tsconfig.json',
+        tsconfigRootDir: path.resolve(__dirname, '../__mocks__/fixture'),
+    },
+});
+
+ruleTester.run('no-async-in-foreach', noAsyncInForEach, {
+    valid: [
+        // Synchronous function
+        {
+            name: 'array literal with synchronous function',
+            code: `
+            [].forEach(() => {})
+            `,
+        },
+        {
+            name: 'array variable with synchronous function',
+            code: `
+            const arr = [];
+            arr.forEach(() => {});
+            `,
+        },
+        // Synchronous variable
+        {
+            name: 'array literal with synchronous variable',
+            code: `
+            function fn() {}
+            [].forEach(fn);
+            `,
+        },
+        {
+            name: 'array variable with synchronous variable',
+            code: `
+            const arr = [];
+            function fn() {}
+            arr.forEach(fn);
+            `,
+        },
+        // Any type
+        {
+            name: 'array literal with variable that returns any',
+            code: `
+            function fn(): any { return ''; }
+            [].forEach(fn);
+            `,
+        },
+        // Objects
+        {
+            name: 'object with synchronous function',
+            code: `
+            const obj = { forEach: (callback: Function) => callback() };
+            obj.forEach(() => {});
+            `,
+        },
+        {
+            name: 'object with synchronous variable',
+            code: `
+            const obj = { forEach: (callback: Function) => callback() };
+            function fn() {}
+            obj.forEach(fn);
+            `,
+        },
+        {
+            name: 'object with async function',
+            code: `
+            const obj = { forEach: (callback: Function) => callback() };
+            obj.forEach(async () => Promise.resolve());
+            `,
+        },
+        {
+            name: 'object with async variable',
+            code: `
+            const obj = { forEach: (callback: Function) => callback() };
+            async function fn() {}
+            obj.forEach(fn);
+            `,
+        },
+    ],
+    invalid: [
+        // Async function
+        {
+            name: 'array literal with async function',
+            code: `
+            [].forEach(async () => Promise.resolve());
+            `,
+        },
+        {
+            name: 'array literal with async variable',
+            code: `
+            async function fn() {}
+            [].forEach(fn);
+            `,
+        },
+        {
+            name: 'array variable with async function',
+            code: `
+            const arr = [];
+            arr.forEach(async () => Promise.resolve());
+            `,
+        },
+        {
+            name: 'array variable with async variable',
+            code: `
+            const arr = [];
+            async function fn() {}
+            arr.forEach(fn);
+            `,
+        },
+        // Function that returns Promise
+        {
+            name: 'array literal with function that returns Promise',
+            code: `
+            [].forEach(() => Promise.resolve())
+            `,
+        },
+        {
+            name: 'array literal with type that returns Promise',
+            code: `
+            type AsyncFunction = () => Promise<any>;
+            let fn: AsyncFunction;
+            [].forEach(fn)
+            `,
+        },
+        {
+            name: 'array variable with function that returns Promise',
+            code: `
+            let arr: Array<any>;
+            arr.forEach(() => Promise.resolve());
+            `,
+        },
+        {
+            name: 'array variable with type that returns Promise',
+            code: `
+            let arr: Array<any>;
+            type AsyncFunction = () => Promise<any>;
+            let fn: AsyncFunction;
+            arr.forEach(fn)
+            `,
+        },
+        // Tuple
+        {
+            name: 'tuple with async function',
+            code: `
+            const tuple: [number, string] = [1, 'a'];
+            tuple.forEach(async () => Promise.resolve());
+            `,
+        },
+        // Conditional callee
+        {
+            name: 'conditional callee with async function',
+            code: `
+            let arr: Array<any> | undefined;
+            arr?.forEach(async () => Promise.resolve());
+            `,
+        },
+    ].map(testCase => ({ ...testCase, errors: [{ messageId: 'noAsyncInForEach' }] })),
+});

package/src/rules/no-async-in-foreach.ts

@@ -0,0 +1,92 @@
+import { ESLintUtils, TSESTree } from '@typescript-eslint/utils';
+import { getParserServices } from '@typescript-eslint/utils/eslint-utils';
+import { containsAllTypesByName } from '@typescript-eslint/type-utils';
+import ts, { TypeChecker } from 'typescript';
+
+const createRule = ESLintUtils.RuleCreator(
+    _name => 'https://gist.github.com/joeytwiddle/37d2085425c049629b80956d3c618971'
+);
+
+export const noAsyncInForEach = createRule({
+    create(context) {
+        const services = getParserServices(context);
+        const checker = services.program.getTypeChecker() as TypeChecker & {
+            // Type declarations aren't in 4.x. See https://github.com/microsoft/TypeScript/pull/52467
+            isArrayType: (type: ts.Type) => boolean;
+            isTupleType: (type: ts.Type) => boolean;
+        };
+
+        function checkForEachExpression(node: TSESTree.MemberExpression) {
+            const callExpression = node.parent as TSESTree.CallExpression;
+            if (!isAsync(callExpression.arguments[0])) {
+                return;
+            }
+
+            const callee = callExpression.callee as TSESTree.MemberExpression;
+            if (!isArrayLike(callee.object)) {
+                return;
+            }
+
+            context.report({ messageId: 'noAsyncInForEach', node });
+        }
+
+        function getSymbolAtLocation(node: TSESTree.Node) {
+            const symbol = services.getSymbolAtLocation(node);
+            if (symbol && symbol.flags & ts.SymbolFlags.Alias) {
+                return checker.getAliasedSymbol(symbol);
+            }
+            return symbol;
+        }
+
+        function isArrayLike(node: TSESTree.Node) {
+            const nodeType = services.getTypeAtLocation(node);
+            const types = isUnionType(nodeType) ? nodeType.types : [nodeType];
+            return types.some(type => checker.isArrayType(type) || checker.isTupleType(type));
+        }
+
+        function isAsync(node: TSESTree.Node) {
+            return (
+                (node.type === TSESTree.AST_NODE_TYPES.ArrowFunctionExpression && node.async) ||
+                hasAsyncModifier(getSymbolAtLocation(node)) ||
+                returnsPromise(node)
+            );
+        }
+
+        function isUnionType(type: ts.Type): type is ts.UnionType {
+            return (type.flags & ts.TypeFlags.Union) !== 0;
+        }
+
+        function hasAsyncModifier(symbol?: ts.Symbol) {
+            return !!symbol?.declarations?.find(declaration =>
+                declaration.modifiers?.find(
+                    modifier => modifier.kind === ts.SyntaxKind.AsyncKeyword
+                )
+            );
+        }
+
+        function returnsPromise(node: TSESTree.Node) {
+            const signatures = services.getTypeAtLocation(node).getCallSignatures();
+            if (signatures.length) {
+                const returnType = checker.getReturnTypeOfSignature(signatures[0]);
+                return containsAllTypesByName(returnType, true, new Set(['Promise']));
+            }
+        }
+
+        return {
+            "CallExpression[arguments.length=1] > MemberExpression[property.name='forEach']":
+                checkForEachExpression,
+        };
+    },
+    name: 'no-async-in-foreach',
+    meta: {
+        docs: {
+            description: 'Disallow passing asynchronous callback to Array.forEach',
+        },
+        messages: {
+            noAsyncInForEach: 'Async callback passed to Array.forEach',
+        },
+        type: 'problem',
+        schema: [],
+    },
+    defaultOptions: [],
+});

package/src/rules/react/destructure-default-import.ts

@@ -16,8 +16,6 @@ export const reactDestructureDefaultImport: Rule.RuleModule = {
     create(context) {
         return {
             ImportDeclaration(node) {
-                const reactImportSpecifiers = new Set();
-
                 if (node.source.value !== 'react') {
                     return;
                 }
@@ -31,8 +29,6 @@ export const reactDestructureDefaultImport: Rule.RuleModule = {
                             node,
                             messageId: 'importDefault',
                         });
-                    } else {
-                        reactImportSpecifiers.add(specifier.imported);
                     }
                 });
             },