@servicetitan/dte-pdf-editor 1.96.2 → 1.97.0

package/src/components/field-config-panel/formula-modal.tsx

@@ -3,11 +3,7 @@ import IconRedo from '@servicetitan/anvil2/assets/icons/material/round/redo.svg'
 import IconUndo from '@servicetitan/anvil2/assets/icons/material/round/undo.svg';
 import { type ScheduleEditorContext } from '@servicetitan/dte-shared';
 import { FC, useCallback, useEffect, useMemo, useState } from 'react';
-import {
-    DEFAULT_DATE_CALCULATED_FORMAT,
-    DEFAULT_NUMBER_FORMAT,
-    MODAL_CONTENT_MAX_HEIGHT,
-} from '../../constants';
+import { DEFAULT_DATE_CALCULATED_FORMAT, DEFAULT_NUMBER_FORMAT } from '../../constants';
 import { useFormulaEditor } from '../../hooks';
 import {
     type CalculatedFieldFormat,
@@ -305,16 +301,17 @@ export const FormulaModal: FC<FormulaModalProps> = ({
         parsedTokens.length > 0;
 
     return (
-        <Dialog open onClose={handleClose} size="xlarge">
+        <Dialog open onClose={handleClose} size="xlarge" fullScreen>
             <Dialog.Header>Formula Builder</Dialog.Header>
             <Divider />
-            <Dialog.Content>
+            <Dialog.Content style={{ overflowY: 'auto', paddingBlock: 0 }}>
                 <Flex
                     flex={1}
                     alignItems="stretch"
                     gap={2}
                     style={{
-                        height: MODAL_CONTENT_MAX_HEIGHT,
+                        flexGrow: 1,
+                        minHeight: 0,
                         overflowY: 'auto',
                     }}
                 >

package/src/components/pdf-editor/pdf-editor.tsx

@@ -75,10 +75,10 @@ export interface PdfEditorProps {
      */
     onScheduleBindingsChange?(bindings: FieldScheduleBinding[]): void;
     /**
-     * Creates a tenant schedule from the "Create New Schedule" drawer. Always creates a new
-     * schedule — it never overwrites a selected one. On success the created schedule is
-     * auto-selected in the picker. A rejected promise's `message` is shown as the drawer's error
-     * (for example a duplicate-name conflict).
+     * Creates a tenant schedule from the "Create New Schedule" form (a drawer, or inside the Field
+     * Configuration panel for an e-sign `dateSignedOffset` field). Always creates a new schedule — it never overwrites a
+     * selected one. On success the created schedule is auto-selected in the picker. A rejected
+     * promise's `message` is shown as the form's error (for example a duplicate-name conflict).
      */
     onCreateSchedule?(request: SaveScheduleRequest): Promise<BusinessDaySchedule>;
     /**
@@ -89,10 +89,8 @@ export interface PdfEditorProps {
     onUpdateSchedule?(id: number, request: SaveScheduleRequest): Promise<BusinessDaySchedule>;
     /**
      * Permanently deletes a tenant schedule, from the picker's "Delete" action (DTE's
-     * `DELETE api/holidays/schedules/{id}`). Fields still bound to it fall back to the default
-     * schedule — `PdfEditor` selects the default schedule for the current field on success, but
-     * does not itself update other fields' `scheduleBindings`; the host should drop bindings to
-     * a deleted schedule when it next saves them.
+     * `DELETE api/holidays/schedules/{id}`). On success every field bound to it, the current one
+     * included, moves to the default schedule (toggle still on) through `onScheduleBindingsChange`.
      */
     onDeleteSchedule?(id: number): Promise<void>;
     onLoadSuccess?(numPages: number): void;

package/src/constants/field.constants.ts

@@ -95,7 +95,7 @@ export const E_SIGN_FIELD_TYPES: FieldTypeOption[] = [
         icon: EventAvailableIcon,
     },
     {
-        label: 'Calculated Singing Date',
+        label: 'Calculated Signing Date',
         type: FieldTypeEnum.eSign,
         subType: ESignFieldType.dateSignedOffset,
         icon: IconAppointmentsIcon,

package/src/interface/types.ts

@@ -283,15 +283,11 @@ export type {
 
 /**
  * A date calculated field whose custom business-day exclusion toggle is on, and the schedule it
- * uses (DTE's bindings, full-replace via `PUT api/holidays/templates/{id}/bindings`). A field with
- * no entry here uses the default calendar with the toggle off (plain calendar-day arithmetic).
+ * uses (DTE's bindings, full-replace via `PUT api/holidays/templates/{id}/bindings`), shared with
+ * `@servicetitan/dte-unlayer`. Here `fieldKey` is `PdfField.id`, and a field with no entry uses
+ * plain calendar-day arithmetic.
  */
-export interface FieldScheduleBinding {
-    /** `PdfField.id`. */
-    fieldKey: string;
-    /** One of the tenant's schedules, or undefined for the default schedule. */
-    scheduleId?: number;
-}
+export type { FieldScheduleBinding } from '@servicetitan/dte-shared';
 
 /** Format options for a calculated field with a numeric result (number, currency, percent) */
 export interface CalculatedFormatForNumber {

package/src/styles/field-config-panel-overlay.css

@@ -33,3 +33,27 @@
     padding: var(--spacing-2);
     flex: 1;
 }
+
+/*
+ * The schedule form of an e-sign date offset is portaled into this slot. While it has content it
+ * takes the place of the panel (the `:empty` and `~` selectors need the slot to come first and to
+ * hold nothing, not even whitespace, when it is closed).
+ */
+.dte-field-config-panel-editor-slot {
+    flex: 1;
+    padding: var(--spacing-2);
+    height: 100%;
+    overflow: auto;
+}
+
+.dte-field-config-panel-editor-slot:empty {
+    display: none;
+}
+
+.dte-field-config-panel-overlay-inner {
+    flex: 1;
+}
+
+.dte-field-config-panel-editor-slot:not(:empty) ~ .dte-field-config-panel-overlay-inner {
+    display: none;
+}

package/src/utils/formula/index.ts

@@ -5,6 +5,5 @@ export * from './expression.utils';
 export * from './format-calculated-result.utils';
 export * from './formula-types';
 export * from './render-formula.utils';
-export * from './schedule-bindings.utils';
 export * from './validate-formula.utils';
 export * from './form-fields.utils';

package/dist/utils/formula/schedule-bindings.utils.d.ts

@@ -1,12 +0,0 @@
-import { type FieldScheduleBinding } from '../../interface/types';
-/**
- * Replaces `fieldKey`'s binding: enabling adds it (default schedule, `scheduleId` undefined);
- * disabling removes it. Every other field's binding is returned unchanged.
- */
-export declare function setFieldScheduleEnabled(bindings: FieldScheduleBinding[], fieldKey: string, enabled: boolean): FieldScheduleBinding[];
-/**
- * Sets `fieldKey`'s selected schedule (`scheduleId` undefined for the default schedule),
- * enabling its toggle if it wasn't already on. Every other field's binding is returned unchanged.
- */
-export declare function setFieldSchedule(bindings: FieldScheduleBinding[], fieldKey: string, scheduleId: number | undefined): FieldScheduleBinding[];
-//# sourceMappingURL=schedule-bindings.utils.d.ts.map

package/dist/utils/formula/schedule-bindings.utils.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"schedule-bindings.utils.d.ts","sourceRoot":"","sources":["../../../src/utils/formula/schedule-bindings.utils.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,oBAAoB,EAAE,MAAM,uBAAuB,CAAC;AAElE;;;GAGG;AACH,wBAAgB,uBAAuB,CACnC,QAAQ,EAAE,oBAAoB,EAAE,EAChC,QAAQ,EAAE,MAAM,EAChB,OAAO,EAAE,OAAO,GACjB,oBAAoB,EAAE,CAGxB;AAED;;;GAGG;AACH,wBAAgB,gBAAgB,CAC5B,QAAQ,EAAE,oBAAoB,EAAE,EAChC,QAAQ,EAAE,MAAM,EAChB,UAAU,EAAE,MAAM,GAAG,SAAS,GAC/B,oBAAoB,EAAE,CAGxB"}

package/dist/utils/formula/schedule-bindings.utils.js

@@ -1,17 +0,0 @@
-/**
- * Replaces `fieldKey`'s binding: enabling adds it (default schedule, `scheduleId` undefined);
- * disabling removes it. Every other field's binding is returned unchanged.
- */
-export function setFieldScheduleEnabled(bindings, fieldKey, enabled) {
-    const withoutField = bindings.filter(b => b.fieldKey !== fieldKey);
-    return enabled ? [...withoutField, { fieldKey }] : withoutField;
-}
-/**
- * Sets `fieldKey`'s selected schedule (`scheduleId` undefined for the default schedule),
- * enabling its toggle if it wasn't already on. Every other field's binding is returned unchanged.
- */
-export function setFieldSchedule(bindings, fieldKey, scheduleId) {
-    const withoutField = bindings.filter(b => b.fieldKey !== fieldKey);
-    return [...withoutField, { fieldKey, scheduleId }];
-}
-//# sourceMappingURL=schedule-bindings.utils.js.map

package/dist/utils/formula/schedule-bindings.utils.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"schedule-bindings.utils.js","sourceRoot":"","sources":["../../../src/utils/formula/schedule-bindings.utils.ts"],"names":[],"mappings":"AAEA;;;GAGG;AACH,MAAM,UAAU,uBAAuB,CACnC,QAAgC,EAChC,QAAgB,EAChB,OAAgB;IAEhB,MAAM,YAAY,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,QAAQ,CAAC,CAAC;IACnE,OAAO,OAAO,CAAC,CAAC,CAAC,CAAC,GAAG,YAAY,EAAE,EAAE,QAAQ,EAAE,CAAC,CAAC,CAAC,CAAC,YAAY,CAAC;AACpE,CAAC;AAED;;;GAGG;AACH,MAAM,UAAU,gBAAgB,CAC5B,QAAgC,EAChC,QAAgB,EAChB,UAA8B;IAE9B,MAAM,YAAY,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,QAAQ,CAAC,CAAC;IACnE,OAAO,CAAC,GAAG,YAAY,EAAE,EAAE,QAAQ,EAAE,UAAU,EAAE,CAAC,CAAC;AACvD,CAAC"}

package/src/utils/formula/__tests__/schedule-bindings.utils.test.ts

@@ -1,73 +0,0 @@
-import { type FieldScheduleBinding } from '../../../interface/types';
-import { setFieldSchedule, setFieldScheduleEnabled } from '../schedule-bindings.utils';
-
-describe('setFieldScheduleEnabled', () => {
-    test('adds a default-schedule binding when enabling a field with no existing binding', () => {
-        expect(setFieldScheduleEnabled([], 'field-a', true)).toEqual([{ fieldKey: 'field-a' }]);
-    });
-
-    test('removing a field with no binding is a no-op', () => {
-        const bindings: FieldScheduleBinding[] = [{ fieldKey: 'field-b', scheduleId: 7 }];
-        expect(setFieldScheduleEnabled(bindings, 'field-a', false)).toEqual(bindings);
-    });
-
-    test('disabling removes the field from the bindings', () => {
-        const bindings: FieldScheduleBinding[] = [
-            { fieldKey: 'field-a', scheduleId: 3 },
-            { fieldKey: 'field-b' },
-        ];
-        expect(setFieldScheduleEnabled(bindings, 'field-a', false)).toEqual([
-            { fieldKey: 'field-b' },
-        ]);
-    });
-
-    test('re-enabling after disabling resets to the default schedule, not the previous one', () => {
-        const bindings: FieldScheduleBinding[] = [{ fieldKey: 'field-a', scheduleId: 3 }];
-        const disabled = setFieldScheduleEnabled(bindings, 'field-a', false);
-        expect(setFieldScheduleEnabled(disabled, 'field-a', true)).toEqual([
-            { fieldKey: 'field-a' },
-        ]);
-    });
-
-    test('leaves other fields untouched (field identity isolation)', () => {
-        const bindings: FieldScheduleBinding[] = [
-            { fieldKey: 'field-a', scheduleId: 1 },
-            { fieldKey: 'field-b', scheduleId: 2 },
-        ];
-        const result = setFieldScheduleEnabled(bindings, 'field-a', false);
-        expect(result).toEqual([{ fieldKey: 'field-b', scheduleId: 2 }]);
-    });
-});
-
-describe('setFieldSchedule', () => {
-    test('sets the default schedule (scheduleId undefined) for a new field', () => {
-        expect(setFieldSchedule([], 'field-a', undefined)).toEqual([
-            { fieldKey: 'field-a', scheduleId: undefined },
-        ]);
-    });
-
-    test('sets a named schedule id for a new field', () => {
-        expect(setFieldSchedule([], 'field-a', 42)).toEqual([
-            { fieldKey: 'field-a', scheduleId: 42 },
-        ]);
-    });
-
-    test('replaces an existing binding for the same field', () => {
-        const bindings: FieldScheduleBinding[] = [{ fieldKey: 'field-a', scheduleId: 1 }];
-        expect(setFieldSchedule(bindings, 'field-a', 2)).toEqual([
-            { fieldKey: 'field-a', scheduleId: 2 },
-        ]);
-    });
-
-    test('leaves other fields untouched (field identity isolation)', () => {
-        const bindings: FieldScheduleBinding[] = [
-            { fieldKey: 'field-a', scheduleId: 1 },
-            { fieldKey: 'field-b', scheduleId: 2 },
-        ];
-        const result = setFieldSchedule(bindings, 'field-a', 9);
-        expect(result).toEqual([
-            { fieldKey: 'field-b', scheduleId: 2 },
-            { fieldKey: 'field-a', scheduleId: 9 },
-        ]);
-    });
-});

package/src/utils/formula/schedule-bindings.utils.ts

@@ -1,27 +0,0 @@
-import { type FieldScheduleBinding } from '../../interface/types';
-
-/**
- * Replaces `fieldKey`'s binding: enabling adds it (default schedule, `scheduleId` undefined);
- * disabling removes it. Every other field's binding is returned unchanged.
- */
-export function setFieldScheduleEnabled(
-    bindings: FieldScheduleBinding[],
-    fieldKey: string,
-    enabled: boolean,
-): FieldScheduleBinding[] {
-    const withoutField = bindings.filter(b => b.fieldKey !== fieldKey);
-    return enabled ? [...withoutField, { fieldKey }] : withoutField;
-}
-
-/**
- * Sets `fieldKey`'s selected schedule (`scheduleId` undefined for the default schedule),
- * enabling its toggle if it wasn't already on. Every other field's binding is returned unchanged.
- */
-export function setFieldSchedule(
-    bindings: FieldScheduleBinding[],
-    fieldKey: string,
-    scheduleId: number | undefined,
-): FieldScheduleBinding[] {
-    const withoutField = bindings.filter(b => b.fieldKey !== fieldKey);
-    return [...withoutField, { fieldKey, scheduleId }];
-}