@servicetitan/acquisition-functions 0.2.0 → 0.4.0

package/README.md

@@ -14,6 +14,7 @@ const { configureProcessor } = require('@servicetitan/acquisition-functions');
 const { filterFetcher } = configureProcessor({
     workers: 10,
     mongoDb: mongoDbConnectionToDb,
+    fetchProperties: (zip) => mongoDbConnectionToDb.collection('properties').find({zipcode: zip}, {_id: 0}),
 });
 
 exports = async () => {

package/dist/__tests__/filter-fetcher.test.js

@@ -4,19 +4,23 @@ const globals_1 = require("@jest/globals");
 const index_1 = require("../index");
 const setup_1 = require("./setup");
 describe('property-assessorlastsaledate-converter', () => {
-    let processor;
     let base;
     let metadata;
     (0, globals_1.beforeAll)(async () => {
         const client = await (0, setup_1.openConnection)();
         base = client.db('test');
         await (0, setup_1.setupProperties)(base);
-        processor = (0, index_1.configureProcessor)({
+        const { filterFetcher } = (0, index_1.configureProcessor)({
             workers: 10,
             mongoDb: base,
+            fetchProperties: (0, setup_1.getFetchPropertiesForFilters)(base),
         });
-        const { filterFetcher, propertyUseGroupProcessor } = processor;
-        await propertyUseGroupProcessor.start('90001');
+        const { propertyUseGroupProcessor } = (0, index_1.configureProcessor)({
+            workers: 10,
+            mongoDb: base,
+            fetchProperties: (0, setup_1.getFetchPropertiesForFix)(base),
+        });
+        await propertyUseGroupProcessor.start(['90001', '90002']);
         metadata = await filterFetcher.start(['90001', '90002']);
     });
     (0, globals_1.test)('should have empty filter for missing zip', async () => {

package/dist/__tests__/property-fix-use-group.test.js

@@ -17,6 +17,7 @@ describe('property-use-group-converter', () => {
             processor = (0, index_1.configureProcessor)({
                 workers: 1,
                 mongoDb: base,
+                fetchProperties: (0, setup_1.getFetchPropertiesForFix)(base),
             });
             const { propertyUseGroupProcessor } = processor;
             metadata = await propertyUseGroupProcessor.start('90001');

package/dist/__tests__/setup.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.closeConnection = exports.openConnection = exports.setupProperties = void 0;
+exports.getFetchPropertiesForFix = exports.getFetchPropertiesForFilters = exports.closeConnection = exports.openConnection = exports.setupProperties = void 0;
 const mongodb_1 = require("mongodb");
 const mock_1 = require("./mock");
 async function setupProperties(base) {
@@ -39,3 +39,32 @@ const openConnection = async () => {
 exports.openConnection = openConnection;
 const closeConnection = () => connectedMongoClient?.close();
 exports.closeConnection = closeConnection;
+const getFetchPropertiesForFilters = (base) => async (zip) => {
+    return base
+        .collection('properties')
+        .find({ zipcode: zip }, {
+        projection: {
+            zipcode: 1,
+            propertyusegroup: 1,
+            propertyusestandardized: 1,
+            hvaccoolingdetail: 1,
+            hvacheatingdetail: 1,
+            utilitieswatersource: 1,
+            flooringmaterialprimary: 1,
+            _id: 0, // eslint-disable-line
+        },
+    })
+        .toArray();
+};
+exports.getFetchPropertiesForFilters = getFetchPropertiesForFilters;
+const getFetchPropertiesForFix = (base) => async (zip) => {
+    return base
+        .collection('properties')
+        .find({ zipcode: zip }, {
+        projection: {
+            propertyusegroup: 1,
+        },
+    })
+        .toArray();
+};
+exports.getFetchPropertiesForFix = getFetchPropertiesForFix;

package/dist/filter-fetcher/index.js

@@ -2,30 +2,10 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getFilterFetcherProcessor = void 0;
 const calc_filter_count_1 = require("./calc-filter-count");
-function getFilterFetcherProcessor(db) {
-    const getPropertiesCollection = async () => {
-        return db.collection('properties');
-    };
+function getFilterFetcherProcessor({ mongoDb: db, fetchProperties }) {
     const getFiltersCollection = async () => {
         return db.collection('filters');
     };
-    const getProperties = async (zip) => {
-        const collection = await getPropertiesCollection();
-        return collection
-            .find({ zipcode: zip }, {
-            projection: {
-                zipcode: 1,
-                propertyusegroup: 1,
-                propertyusestandardized: 1,
-                hvaccoolingdetail: 1,
-                hvacheatingdetail: 1,
-                utilitieswatersource: 1,
-                flooringmaterialprimary: 1,
-                _id: 0, // eslint-disable-line
-            },
-        })
-            .toArray();
-    };
     const deleteZipFilter = async (zip) => {
         const collection = await getFiltersCollection();
         return collection.deleteOne({ zipcode: zip });
@@ -53,7 +33,7 @@ function getFilterFetcherProcessor(db) {
             return meta;
         }
         try {
-            const properties = await getProperties(zip);
+            const properties = await fetchProperties(zip);
             meta.requests += 1;
             meta.properties += properties.length;
             const filters = (0, calc_filter_count_1.calculateFilterCount)(properties);

package/dist/fix-property-use/index.js

@@ -8,17 +8,7 @@ const getPropertiesCollection = async (db) => {
 function fixPropertyName(propertyName) {
     return propertyName ? propertyName.toUpperCase() : '';
 }
-function getPropertyUseGroupProcessor(db) {
-    const getProperties = async (zip) => {
-        const collection = await getPropertiesCollection(db);
-        return collection
-            .find({ zipcode: zip }, {
-            projection: {
-                propertyusegroup: 1,
-            },
-        })
-            .toArray();
-    };
+function getPropertyUseGroupProcessor({ mongoDb: db, fetchProperties }) {
     function fixPropertyNames(properties) {
         return properties
             .filter(p => p.propertyusegroup &&
@@ -52,9 +42,9 @@ function getPropertyUseGroupProcessor(db) {
             return meta;
         }
         try {
-            const properties = await getProperties(zip);
+            const properties = await fetchProperties(zip);
             meta.requests += 1;
-            if (!properties || !properties.length) {
+            if (!properties?.length) {
                 return meta;
             }
             const convertedProperties = fixPropertyNames(properties);

package/dist/index.js

@@ -6,9 +6,9 @@ const fix_property_use_1 = require("./fix-property-use");
 const property_assessorlastsaledate_converter_1 = require("./property-assessorlastsaledate-converter");
 const zip_processor_1 = require("./zip-processor");
 function configureProcessor(config) {
-    const filterFetcher = (0, zip_processor_1.zipProcessor)(config, (0, filter_fetcher_1.getFilterFetcherProcessor)(config.mongoDb));
+    const filterFetcher = (0, zip_processor_1.zipProcessor)(config, (0, filter_fetcher_1.getFilterFetcherProcessor)(config));
     const assessorLastSaleDateProcessor = (0, zip_processor_1.zipProcessor)(config, (0, property_assessorlastsaledate_converter_1.getAssessorLastSaleDateProcessor)(config.mongoDb));
-    const propertyUseGroupProcessor = (0, zip_processor_1.zipProcessor)(config, (0, fix_property_use_1.getPropertyUseGroupProcessor)(config.mongoDb));
+    const propertyUseGroupProcessor = (0, zip_processor_1.zipProcessor)(config, (0, fix_property_use_1.getPropertyUseGroupProcessor)(config));
     return { filterFetcher, assessorLastSaleDateProcessor, propertyUseGroupProcessor };
 }
 exports.configureProcessor = configureProcessor;

package/dist/property-assessorlastsaledate-converter/index.js

@@ -45,7 +45,7 @@ function getAssessorLastSaleDateProcessor(db) {
         try {
             const properties = await getPropertiesAssessorLastSaleDate(zip);
             meta.requests += 1;
-            if (!properties || !properties.length) {
+            if (!properties?.length) {
                 return meta;
             }
             const convertedProperties = (0, utils_1.convertStringToDate)(properties, 'assessorlastsaledate');

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@servicetitan/acquisition-functions",
-    "version": "0.2.0",
+    "version": "0.4.0",
     "description": "",
     "main": "./dist/index.js",
     "typings": "./dist/index.d.ts",
@@ -28,5 +28,5 @@
     "cli": {
         "webpack": false
     },
-    "gitHead": "7c93d00316dcd4bd83e1a42720579ed22c6ce208"
+    "gitHead": "b6eb3ea4bcc2edd37b3337067048605589f8972d"
 }