@servicenow/sdk-build-plugins 2.1.4 → 2.2.2

package/src/db/RecordPlugin.ts

@@ -6,7 +6,6 @@ import {
     isGUID,
     removeNode,
     transformFunctionArguments,
-    fixFunctionArgumentTypes,
     unloadBuilder,
     linkDocument,
     generateCallExpressionExportForDocument,
@@ -20,10 +19,10 @@ import {
     ObjectData,
 } from '@servicenow/sdk-build-core'
 import { z } from 'zod'
-import { CallExpression, SyntaxKind } from 'ts-morph'
+import { ts } from '@servicenow/sdk-project'
 
 // TODO: This schema should live with the Record entity function itself
-export const RecordEntitySchema = z.object({
+const RecordEntitySchema = z.object({
     $id: z.string().or(z.number()),
     data: z.record(z.any()),
     table: z.string(),
@@ -43,17 +42,15 @@ export const TextStringSchema = z.object({ '#text': z.string() }).transform((val
 export const TextBooleanSchema = z.object({ '#text': z.boolean() }).transform((val) => val['#text'])
 export const TextNumberSchema = z.object({ '#text': z.number().or(z.literal('')) }).transform((val) => val['#text'])
 
-const SysJournalFieldSchema = z.object({
-    element: TextStringSchema,
-    element_id: TextStringSchema,
-    name: TextStringSchema,
-    sys_id: TextStringSchema,
-    value: TextStringSchema,
-})
-
-export type SysJournalField = z.infer<typeof SysJournalFieldSchema>
-
-const ignoreTables = ['sys_metadata_link', 'sys_module', 'sys_ux_lib_asset', 'sys_app', 'sys_store_app']
+const ignoreTables = [
+    'sys_metadata_link',
+    'sys_module',
+    'sys_ux_lib_asset',
+    'sys_app',
+    'sys_store_app',
+    'ua_table_licensing_config',
+    'sys_index',
+]
 const ignoreFields = [
     'sys_created_by',
     'sys_created_on',
@@ -89,7 +86,7 @@ export const RecordXmlSchema = z
         )
     )
 
-export const RecordDocumentSchema = z.object({
+const RecordDocumentSchema = z.object({
     data: z.record(z.union([z.string(), z.number(), z.boolean(), z.undefined(), z.null()])),
     table: z.string(),
 })
@@ -123,11 +120,11 @@ export const RecordPlugin = Plugin({
                         (record): record is Record => RecordEntitySchema.safeParse(record).success
                     )
 
-                    if (!result.handled || !(0 in result.data)) {
+                    if (!result.handled || !result.data) {
                         return result
                     }
 
-                    const record = result.data[0]
+                    const record = result.data
                     const diagnostics = result.diagnostics
                     const tableName = record.getProperty('table').getValue()
                     const pluginInfo = context.getPluginForTable(tableName)
@@ -135,7 +132,7 @@ export const RecordPlugin = Plugin({
                     if (pluginInfo) {
                         const { logLevel, api } = pluginInfo
                         const tableNode = node
-                            .getFirstChildByKindOrThrow(SyntaxKind.ObjectLiteralExpression)
+                            .getFirstChildByKindOrThrow(ts.SyntaxKind.ObjectLiteralExpression)
                             .getPropertyOrThrow('table')
 
                         diagnostics.push(
@@ -152,10 +149,10 @@ export const RecordPlugin = Plugin({
                     if (tableName === 'sys_ui_view') {
                         const viewName = record.getProperty('data').getProperty('name')?.getValue()
                         const viewDataNode = node
-                            .getFirstChildByKindOrThrow(SyntaxKind.ObjectLiteralExpression)
+                            .getFirstChildByKindOrThrow(ts.SyntaxKind.ObjectLiteralExpression)
                             .getPropertyOrThrow('data')
-                            .asKindOrThrow(SyntaxKind.PropertyAssignment)
-                            .getInitializerIfKind(SyntaxKind.ObjectLiteralExpression)
+                            .asKindOrThrow(ts.SyntaxKind.PropertyAssignment)
+                            .getInitializerIfKind(ts.SyntaxKind.ObjectLiteralExpression)
 
                         const viewNameNode = viewDataNode?.getPropertyOrThrow('name')
                         const nameRegex = new RegExp(`^[a-zA-Z0-9_]+$`)
@@ -173,7 +170,7 @@ export const RecordPlugin = Plugin({
                     return {
                         handled: true,
                         diagnostics,
-                        data: [record],
+                        data: record,
                     }
                 },
             },
@@ -318,7 +315,7 @@ export const RecordPlugin = Plugin({
                     },
                     Record,
                     { $id: document.guid }
-                ).getExpressionIfKindOrThrow(SyntaxKind.CallExpression)
+                ).getExpressionIfKindOrThrow(ts.SyntaxKind.CallExpression)
             )
         },
     },
@@ -358,7 +355,7 @@ export const RecordPlugin = Plugin({
                     data: properties,
                 })
 
-                fixFunctionArgumentTypes(context, document.node)
+                context.argTypesToFix.push(document.node)
                 return true
             },
         },
@@ -373,7 +370,7 @@ export function extractCallExpressionAsRecord<
     fn: (...args: A) => E,
     asRecord: (entity: EntityData<E>) => ObjectData<Record<T>>,
     guid: (entity: E) => string,
-    node: CallExpression,
+    node: ts.CallExpression,
     context: Context
 ): ExtractionResult<EntityData<Record<T>>> {
     const result = extractCallExpression(fn, 'record', node, context, guid)
@@ -384,6 +381,6 @@ export function extractCallExpressionAsRecord<
     return {
         handled: true,
         diagnostics: result.diagnostics,
-        data: result.data.map((d) => new EntityData('record', d.getGuid(), asRecord(d), node), node),
+        data: result.data ? new EntityData('record', result.data.getGuid(), asRecord(result.data), node) : undefined,
     }
 }