@servicenow/eslint-plugin-sdk-app-plugin 2.2.7 → 3.0.0

package/lib/configs/recommended.js

@@ -9,7 +9,6 @@ module.exports = {
         '@servicenow/sdk-app-plugin/no-dynamic-import': 'error',
         '@servicenow/sdk-app-plugin/no-regexp-lookbehind-assertions': 'error',
         '@servicenow/sdk-app-plugin/no-regexp-unicode-property-escapes': 'error',
-        'no-console': 'error',
         '@servicenow/sdk-app-plugin/no-unsupported-node-builtins': 'error'
     }
 }

package/lib/util/utility.js

@@ -1,7 +1,7 @@
 const globals = require('globals')
 const { READ } = require('@eslint-community/eslint-utils')
 
-const globalsAllowList = []
+const globalsAllowList = ['console', 'fetch']
 const BROWSER_API_WARNING = 'Web APIs are not supported by the now platform'
 const NO_GLOBAL_THIS = 'ES2020 `globalThis` variable is not supported by the now platform'
 
@@ -18,12 +18,12 @@ const getRestrictedGlobals = () => {
     return globalRules.concat(browserRules)
 }
 
-const getCoreNodeModules = () =>  ["assert","buffer","child_process","cluster","crypto","dgram","dns","domain","events","freelist","fs","http","https","module","net","os","path","punycode","querystring","readline","repl","smalloc","stream","string_decoder","sys","timers","tls","tracing","tty","url","util","vm","zlib"]
+const coreNodeModules = ["assert","buffer","child_process","cluster","crypto","dgram","dns","domain","events","freelist","fs","http","https","module","net","os","path","punycode","querystring","readline","repl","smalloc","stream","string_decoder","sys","timers","tls","tracing","tty","url","util","vm","zlib"]
 
-const getNodeGlobals = () => Object.keys(globals.nodeBuiltin)
+const getNodeGlobals = () => Object.keys(globals.nodeBuiltin).filter((key) => !globalsAllowList.includes(key))
 
 const createTrackMap = (isNodeGlobals) => {
-    const trackMapItems = isNodeGlobals ? getNodeGlobals() : getCoreNodeModules()
+    const trackMapItems = isNodeGlobals ? getNodeGlobals() : coreNodeModules
     const trackMap = {}
     
     for(const item of trackMapItems) {
@@ -40,6 +40,6 @@ const createTrackMap = (isNodeGlobals) => {
 module.exports = {
     getRestrictedGlobals,
     createTrackMap,
-    getCoreNodeModules,
+    coreNodeModules,
     getNodeGlobals
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@servicenow/eslint-plugin-sdk-app-plugin",
-  "version": "2.2.7",
+  "version": "3.0.0",
   "description": "Plugin to disallow Browser and Node.js APIs not supported in rhino engine",
   "keywords": [
     "eslint",

package/tests/rules/no-unsupported-node-builtins.test.js

@@ -1,6 +1,6 @@
 const { RuleTester } = require('eslint');
 const noUnsupportedNodeBuiltins = require('../../lib/rules/no-unsupported-node-builtins');
-const { getCoreNodeModules, getNodeGlobals } = require('../../lib/util/utility');
+const { coreNodeModules, getNodeGlobals } = require('../../lib/util/utility');
 
 const ruleTester = new RuleTester({
     parserOptions: { sourceType: 'module' },
@@ -9,17 +9,16 @@ const ruleTester = new RuleTester({
 
 const getInvalidsForNoUnsupportedNodeBuiltsRule = () => {
     const invalids = []
-    const nodeModules = getCoreNodeModules()
     const nodeGlobals = getNodeGlobals()
 
-    for(const module of nodeModules) {
+    for(const module of coreNodeModules) {
         invalids.push({
             code: `const ${module} = require('${module}')`,
             errors: [{ message: `The ${module} Node.js API is not supported in now platform.` }]
         })
     }
 
-    for(const module of nodeModules) {
+    for(const module of coreNodeModules) {
         invalids.push({
             code: `import ${module} from '${module}'`,
             errors: [{ message: `The ${module} Node.js API is not supported in now platform.` }]
@@ -46,6 +45,14 @@ ruleTester.run(
             code: "const fs = {readFileSync: function(){}}; fs.readFileSync()"
         },{
             code: "const Buffer = {from: function(){}}; Buffer.from()"
+        },{
+            code: `const validFunction = () => {
+                    fetch("https://api.example.com/data")
+                        .then(response => response.json())
+                        .then(data => console.log(data))
+                        .catch(error => console.error('Error:', error));
+                }; 
+                validFunction();`
         }],
         invalid: getInvalidsForNoUnsupportedNodeBuiltsRule()
     }