@servicemind.tis/tis-smart-table-viewer 2.3.6 → 2.3.7

package/fesm2022/servicemind.tis-tis-smart-table-viewer.mjs

@@ -89,14 +89,12 @@ class ApiDataSource {
         this.loadingSubject.next(true);
         this.apiSubs = this.apiService.getList(url, (pageIndex + 1), pageSize, search, { filter }, { sortFilter }).pipe(catchError(() => of([])), finalize(() => this.loadingSubject.next(false))).subscribe(r => {
             console.log(`DataSource: Url: ${url}, Reply:`, r);
-            if (r?.data?.length > 0) {
-                this.totalDataLength.next(r?.total);
-            }
-            else {
-                this.totalDataLength.next(0);
-            }
-            this.apiSubject.next(r?.data);
-            this.extraDataSubject.next(r?.extraData);
+            // ✅ FIX: Ensure we always emit an array (even if empty) to prevent undefined issues
+            const data = r?.data || [];
+            const total = (Array.isArray(data) && data.length > 0) ? (r?.total || data.length) : 0;
+            this.totalDataLength.next(total);
+            this.apiSubject.next(data);
+            this.extraDataSubject.next(r?.extraData || null);
         });
     }
     loadWithCancellation(url, pageIndex, pageSize, search, filter, sortFilter, cancelSubject) {
@@ -111,14 +109,12 @@ class ApiDataSource {
         }
         this.apiSubs = apiCall$.subscribe(r => {
             console.log(`DataSource: Url: ${url}, Reply:`, r);
-            if (r?.data?.length > 0) {
-                this.totalDataLength.next(r?.total);
-            }
-            else {
-                this.totalDataLength.next(0);
-            }
-            this.apiSubject.next(r?.data);
-            this.extraDataSubject.next(r?.extraData);
+            // ✅ FIX: Ensure we always emit an array (even if empty) to prevent undefined issues
+            const data = r?.data || [];
+            const total = (Array.isArray(data) && data.length > 0) ? (r?.total || data.length) : 0;
+            this.totalDataLength.next(total);
+            this.apiSubject.next(data);
+            this.extraDataSubject.next(r?.extraData || null);
         });
     }
 }
@@ -2115,11 +2111,14 @@ class TisSmartTableViewerComponent {
                             this._paginator.pageIndex = this.pageIndex;
                             this._paginator.pageSize = this.pageSize;
                         }
+                        // ✅ FIX: Always clear caches when new data arrives (even if empty)
                         // Clear background cache when new data arrives
                         this.clearRowBackgroundCache();
                         // Pre-compute all row backgrounds for optimal performance
                         this.computeAllRowBackgrounds();
+                        // ✅ FIX: Ensure selection state is updated even when data changes from empty to populated
                         this.checkAllRowsSelected();
+                        // ✅ FIX: Force change detection by emitting events
                         this.onDataLoaded.emit(true);
                         this.onSetExtraData.emit(this.dataSource.extraDataSubject.value);
                         // if (this.selectedRowIds && this.selectedRowIds.length) {
@@ -2142,8 +2141,12 @@ class TisSmartTableViewerComponent {
             if (this.filterFormGroupSubscription) {
                 this.filterFormGroupSubscription.unsubscribe();
             }
+            // ✅ FIX: Use custom comparator for distinctUntilChanged to properly detect form value changes
             this.filterFormGroupSubscription = this.filterFormGroup.valueChanges
-                .pipe(takeUntil(this._onDestroy), distinctUntilChanged()).subscribe(val => {
+                .pipe(takeUntil(this._onDestroy), distinctUntilChanged((prev, curr) => {
+                // Custom comparator: deep compare form values
+                return JSON.stringify(prev) === JSON.stringify(curr);
+            })).subscribe(val => {
                 this.filterHasNonEmptyValue = ValidationHelper.hasNonEmptyValue(val);
             });
         }
@@ -2289,11 +2292,21 @@ class TisSmartTableViewerComponent {
     }
     // Compute all row backgrounds when data changes (runs once per data load)
     computeAllRowBackgrounds() {
-        if (!this.dataSource?.apiSubject.value || !this.rowsConfig.backgroundApplyFunction) {
+        // ✅ FIX: Always clear the cache first to ensure fresh computation
+        this.computedRowBackgrounds.clear();
+        // ✅ FIX: Safely check if we have data and a background function
+        if (!this.dataSource?.apiSubject?.value ||
+            !Array.isArray(this.dataSource.apiSubject.value) ||
+            !this.rowsConfig.backgroundApplyFunction) {
+            return;
+        }
+        // ✅ FIX: Only compute backgrounds if we have actual data
+        if (this.dataSource.apiSubject.value.length === 0) {
             return;
         }
-        this.computedRowBackgrounds.clear();
         this.dataSource.apiSubject.value.forEach((row) => {
+            if (!row)
+                return; // Skip null/undefined rows
             const rowId = row?.id || row?.[this.selectedRowKey] || JSON.stringify(row);
             try {
                 const background = this.rowsConfig.backgroundApplyFunction(row);
@@ -2382,6 +2395,8 @@ class TisSmartTableViewerComponent {
         this.isAllExpanded = false;
         // Clear expansion state when loading new data to avoid stale expansion state
         CollectionHelper.clearSet(this.expandedRowIds);
+        // ✅ FIX: Clear row background cache before loading new data to prevent stale computed backgrounds
+        this.clearRowBackgroundCache();
         const filterFormData = this.filterFormGroup?.value;
         this.filterHasNonEmptyValue = ValidationHelper.hasFormData(filterFormData);
         // Build query string using helper