@servicemind.tis/tis-smart-table-viewer 2.3.4 → 2.3.6

package/fesm2022/servicemind.tis-tis-smart-table-viewer.mjs

@@ -2096,12 +2096,18 @@ class TisSmartTableViewerComponent {
         }
         if (changes['loadDataApiBaseUrl']) {
             if (changes['loadDataApiBaseUrl'].currentValue) {
+                // Clean up existing subscriptions
                 if (this.loadingSubscription) {
                     this.loadingSubscription.unsubscribe();
                 }
                 if (this.dataLengthSubscription) {
                     this.dataLengthSubscription.unsubscribe();
                 }
+                // ✅ FIX: Disconnect previous dataSource to prevent memory leaks
+                if (this.dataSource) {
+                    this.dataSource.disconnect({});
+                }
+                // Create new ApiDataSource
                 this.dataSource = new ApiDataSource(this.apiService);
                 this.loadingSubscription = this.dataSource.loading$.subscribe(loading => {
                     if (!loading) {
@@ -2436,6 +2442,10 @@ class TisSmartTableViewerComponent {
         UrlHelper.safeNavigate(this.router, url);
     }
     toggleSelection(status, row) {
+        // ✅ Add null guards to prevent crashes
+        if (!row || !ValidationHelper.hasRowKey(row, this.selectedRowKey)) {
+            return;
+        }
         if (this.onlySingleSelection && status.checked) {
             this.selection.clear();
         }
@@ -2445,16 +2455,29 @@ class TisSmartTableViewerComponent {
         this.checkAllRowsSelected();
     }
     checkAllRowsSelected() {
+        // ✅ Add comprehensive null guards to prevent crashes
+        if (!this.dataSource?.apiSubject?.value || !Array.isArray(this.dataSource.apiSubject.value)) {
+            this.isAllRowsSelected = false;
+            this.allRowsSelectedChange.emit(this.isAllRowsSelected);
+            return;
+        }
         this.isAllRowsSelected = this.selection.selected.length === this.dataSource.apiSubject.value.length;
         this.allRowsSelectedChange.emit(this.isAllRowsSelected);
     }
     toggleAllRows() {
+        // ✅ Add comprehensive null guards
+        if (!this.dataSource?.apiSubject?.value || !Array.isArray(this.dataSource.apiSubject.value)) {
+            return;
+        }
         if (this.isAllRowsSelected) {
             this.selection.clear();
         }
         else {
             this.dataSource.apiSubject.value.forEach(row => {
-                this.selection.select(row);
+                // ✅ Validate each row before selecting
+                if (row && ValidationHelper.hasRowKey(row, this.selectedRowKey)) {
+                    this.selection.select(row);
+                }
             });
         }
         this.selectedRows = this.selection.selected;
@@ -2465,8 +2488,13 @@ class TisSmartTableViewerComponent {
         $event.stopPropagation();
     }
     isChecked(row) {
-        return ValidationHelper.hasRowKey(row, this.selectedRowKey) &&
-            this.selectedIds.has(row[this.selectedRowKey]);
+        // ✅ Add comprehensive null guards
+        if (!row ||
+            !ValidationHelper.hasRowKey(row, this.selectedRowKey) ||
+            !this.selectedIds) {
+            return false;
+        }
+        return this.selectedIds.has(row[this.selectedRowKey]);
     }
     getQueryParams(url) {
         return QueryParamsHelper.parseQueryParams(url);
@@ -2525,6 +2553,10 @@ class TisSmartTableViewerComponent {
         return this.computedRowBackgrounds.get(rowId) || null;
     }
     drop(event) {
+        // ✅ Add null guards to prevent crashes
+        if (!this.dataSource?.apiSubject?.value || !Array.isArray(this.dataSource.apiSubject.value)) {
+            return;
+        }
         // Ignore if the item was dropped at the same index
         if (event.previousIndex === event.currentIndex) {
             return;
@@ -2548,14 +2580,28 @@ class TisSmartTableViewerComponent {
         UrlHelper.handleSecondaryButtonClick(this.router, config);
     }
     setSelectedRows() {
+        // ✅ Add null guards to prevent crashes
+        if (!this.dataSource?.apiSubject?.value ||
+            !Array.isArray(this.dataSource.apiSubject.value) ||
+            !this.selectedRowIds) {
+            this.selection.clear();
+            this.selectedRows = [];
+            this.selectedRowsChange.emit(this.selectedRows);
+            return;
+        }
         this.selection.clear();
+        // ✅ FIX: Convert array to Set for O(1) lookup instead of O(n) indexOf
+        const selectedIdsSet = new Set(this.selectedRowIds);
         this.dataSource.apiSubject.value.forEach(row => {
-            if (this.selectedRowIds.indexOf(row[this.selectedRowKey]) != -1) {
+            if (row &&
+                ValidationHelper.hasRowKey(row, this.selectedRowKey) &&
+                selectedIdsSet.has(row[this.selectedRowKey])) {
                 this.selection.select(row);
             }
         });
         this.selectedRows = this.selection.selected;
         this.selectedRowsChange.emit(this.selectedRows);
+        this.checkAllRowsSelected();
     }
     resetSelectedRows() {
         this.isAllRowsSelected = false;
@@ -2571,11 +2617,9 @@ class TisSmartTableViewerComponent {
         const rowId = this.getRowIdentifier(element);
         if (this.expandedRowIds.has(rowId)) {
             this.expandedRowIds.delete(rowId);
-            element.expanded = false;
         }
         else {
             this.expandedRowIds.add(rowId);
-            element.expanded = true;
         }
     }
     expandAllRow() {
@@ -2584,18 +2628,14 @@ class TisSmartTableViewerComponent {
         }
         this.isAllExpanded = !this.isAllExpanded;
         if (this.isAllExpanded) {
-            // Add all row IDs to expanded set and set expanded property
+            // Add all row IDs to expanded set
             this.dataSource.apiSubject.value.forEach(row => {
                 const rowId = this.getRowIdentifier(row);
                 this.expandedRowIds.add(rowId);
-                row.expanded = true;
             });
         }
         else {
-            // Clear all expanded rows and remove expanded property
-            this.dataSource.apiSubject.value.forEach(row => {
-                row.expanded = false;
-            });
+            // Clear all expanded rows
             this.expandedRowIds.clear();
         }
     }