@serverkgg/bridge 0.1.2 → 0.1.4

package/src/runtime/bridgeRegistry.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, test } from "bun:test";
+import { describe, expect, it } from "bun:test";
 import { tmpdir } from "node:os";
 import {
 	BridgeAction,
@@ -116,7 +116,7 @@ const registryFor = (driver: BridgeDriver, variables: Record<string, string> = {
 };
 
 describe("actions modules", () => {
-	test("lists its action ids in the manifest", () => {
+	it("lists its action ids in the manifest", () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {
@@ -151,7 +151,7 @@ describe("actions modules", () => {
 		]);
 	});
 
-	test("hands the whole argument bag to the handler", async () => {
+	it("hands the whole argument bag to the handler", async () => {
 		const received: BridgeValues[] = [];
 
 		const registry = registryFor({
@@ -179,7 +179,7 @@ describe("actions modules", () => {
 		]);
 	});
 
-	test("refuses to run while the game is stopped", async () => {
+	it("refuses to run while the game is stopped", async () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {
@@ -202,7 +202,7 @@ describe("actions modules", () => {
 		).rejects.toThrow('module "broadcast" needs the game to be running');
 	});
 
-	test("rejects a driver that reuses a read action id", () => {
+	it("rejects a driver that reuses a read action id", () => {
 		expect(() =>
 			registryFor({
 				...baseDriver(),
@@ -222,7 +222,7 @@ describe("actions modules", () => {
 });
 
 describe("manifest events", () => {
-	test("lists the log patterns and the names the driver raises itself", () => {
+	it("lists the log patterns and the names the driver raises itself", () => {
 		const registry = registryFor({
 			...baseDriver(),
 			events: {
@@ -252,7 +252,7 @@ describe("manifest events", () => {
 		]);
 	});
 
-	test("stays on the log patterns when the driver raises nothing itself", () => {
+	it("stays on the log patterns when the driver raises nothing itself", () => {
 		const registry = registryFor({
 			...baseDriver(),
 			events: {
@@ -273,7 +273,7 @@ describe("manifest events", () => {
 });
 
 describe("collection row actions", () => {
-	test("passes the row and the arguments without the row id", async () => {
+	it("passes the row and the arguments without the row id", async () => {
 		const seen: {
 			row: BridgeRow;
 			args: BridgeValues;
@@ -318,7 +318,7 @@ describe("collection row actions", () => {
 		]);
 	});
 
-	test("keeps listing the built-in actions beside the row actions", () => {
+	it("keeps listing the built-in actions beside the row actions", () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {
@@ -398,7 +398,7 @@ describe("offline row actions", () => {
 		},
 	});
 
-	test("hands an offline action the id alone when the row is not listed", async () => {
+	it("hands an offline action the id alone when the row is not listed", async () => {
 		const seen: BridgeRow[] = [];
 		const registry = registryFor(
 			rosterDriver(
@@ -419,7 +419,7 @@ describe("offline row actions", () => {
 		]);
 	});
 
-	test("still refuses an unlisted row for an action that is not offline", async () => {
+	it("still refuses an unlisted row for an action that is not offline", async () => {
 		const registry = registryFor(
 			rosterDriver(
 				false,
@@ -437,7 +437,7 @@ describe("offline row actions", () => {
 });
 
 describe("preview modules", () => {
-	test("lists the preview action in the manifest", () => {
+	it("lists the preview action in the manifest", () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {
@@ -466,7 +466,7 @@ describe("preview modules", () => {
 		]);
 	});
 
-	test("shows the module the pending values as variables and leaves the rest as they are stored", async () => {
+	it("shows the module the pending values as variables and leaves the rest as they are stored", async () => {
 		const seen: {
 			version: string | null;
 			count: string | null;
@@ -520,7 +520,7 @@ describe("preview modules", () => {
 		]);
 	});
 
-	test("returns what the module answers", async () => {
+	it("returns what the module answers", async () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {
@@ -550,7 +550,39 @@ describe("preview modules", () => {
 		});
 	});
 
-	test("refuses an action a preview module does not answer", async () => {
+	it("passes a blocked preview through untouched", async () => {
+		const registry = registryFor({
+			...baseDriver(),
+			modules: {
+				transition: {
+					kind: BridgeKind.Preview,
+					preview: async () => ({
+						confirm: BridgeConfirm.Strong,
+						blocked: true,
+						lines: [
+							{
+								ar: "لا يوجد بيلد مستقر لهذا الإصدار بعد",
+								en: "There is no stable build for this version yet",
+							},
+						],
+					}),
+				},
+			},
+		});
+
+		expect((await registry.invoke("transition", BridgeAction.Preview)).result).toEqual({
+			confirm: BridgeConfirm.Strong,
+			blocked: true,
+			lines: [
+				{
+					ar: "لا يوجد بيلد مستقر لهذا الإصدار بعد",
+					en: "There is no stable build for this version yet",
+				},
+			],
+		});
+	});
+
+	it("refuses an action a preview module does not answer", async () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {
@@ -571,7 +603,7 @@ describe("preview modules", () => {
 });
 
 describe("detail modules", () => {
-	test("lists read and its own action ids in the manifest", () => {
+	it("lists read and its own action ids in the manifest", () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {
@@ -602,7 +634,7 @@ describe("detail modules", () => {
 		]);
 	});
 
-	test("returns what read answers", async () => {
+	it("returns what read answers", async () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {
@@ -630,7 +662,7 @@ describe("detail modules", () => {
 		});
 	});
 
-	test("hands the argument bag to an action and returns its outcome", async () => {
+	it("hands the argument bag to an action and returns its outcome", async () => {
 		const received: BridgeValues[] = [];
 
 		const registry = registryFor({
@@ -673,7 +705,7 @@ describe("detail modules", () => {
 		]);
 	});
 
-	test("refuses an action named after a read", () => {
+	it("refuses an action named after a read", () => {
 		expect(() =>
 			registryFor({
 				...baseDriver(),
@@ -690,7 +722,7 @@ describe("detail modules", () => {
 		).toThrow('module "modpackStatus" declares action "read", which is reserved for reads');
 	});
 
-	test("refuses an action the module does not answer", async () => {
+	it("refuses an action the module does not answer", async () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {
@@ -708,7 +740,7 @@ describe("detail modules", () => {
 });
 
 describe("the setup singleton", () => {
-	test("rides the manifest as its own block and never joins the panel modules", () => {
+	it("rides the manifest as its own block and never joins the panel modules", () => {
 		const steps = [
 			{
 				kind: BridgeSetupStepKind.Driver as const,
@@ -736,13 +768,13 @@ describe("the setup singleton", () => {
 		expect(manifest.modules.some((module) => module.kind === BridgeKind.Setup)).toBe(false);
 	});
 
-	test("leaves the manifest block empty for a driver that declares no setup", () => {
+	it("leaves the manifest block empty for a driver that declares no setup", () => {
 		expect(registryFor(baseDriver()).manifest().setup).toBeNull();
 	});
 });
 
 describe("protected action dispatch", () => {
-	test("advertises protection and refuses old callers before touching files", async () => {
+	it("advertises protection and refuses old callers before touching files", async () => {
 		let calls = 0;
 		const registry = registryFor({
 			...baseDriver(),
@@ -768,7 +800,7 @@ describe("protected action dispatch", () => {
 		await registry.invoke("world", "replace", {}, "01993720-0000-7000-8000-000000000001");
 		expect(calls).toBe(1);
 	});
-	test("rejects protection metadata for unknown actions or running-only modules", () => {
+	it("rejects protection metadata for unknown actions or running-only modules", () => {
 		for (const module of [
 			{
 				kind: BridgeKind.Actions as const,
@@ -830,7 +862,7 @@ describe("activity", () => {
 		},
 	});
 
-	test("answers an invoke with its result and the entries the handler reported", async () => {
+	it("answers an invoke with its result and the entries the handler reported", async () => {
 		const { registry, ring } = harnessFor(whitelistDriver());
 
 		expect(await registry.invoke("whitelist", "add")).toEqual({
@@ -842,7 +874,7 @@ describe("activity", () => {
 		expect(ring.drain(0).events).toEqual([]);
 	});
 
-	test("answers an empty list when the handler reported nothing", async () => {
+	it("answers an empty list when the handler reported nothing", async () => {
 		const { registry } = harnessFor({
 			...baseDriver(),
 			modules: {
@@ -863,7 +895,7 @@ describe("activity", () => {
 		});
 	});
 
-	test("sends what a failing handler reported to the events ring", async () => {
+	it("sends what a failing handler reported to the events ring", async () => {
 		const { registry, ring } = harnessFor(whitelistDriver(true));
 
 		await expect(registry.invoke("whitelist", "add")).rejects.toThrow("read-only");
@@ -946,7 +978,7 @@ describe("activity", () => {
 			},
 		});
 
-		test("reports the keys whose value changed when the handler reported nothing", async () => {
+		it("reports the keys whose value changed when the handler reported nothing", async () => {
 			const { registry } = harnessFor(
 				settingsDriver({
 					stored: {
@@ -980,7 +1012,7 @@ describe("activity", () => {
 			]);
 		});
 
-		test("finishes the write even when a stored value cannot be compared", async () => {
+		it("finishes the write even when a stored value cannot be compared", async () => {
 			const { registry } = harnessFor(
 				settingsDriver({
 					stored: {},
@@ -1005,7 +1037,7 @@ describe("activity", () => {
 			});
 		});
 
-		test("reports nothing when no value changed", async () => {
+		it("reports nothing when no value changed", async () => {
 			const { registry } = harnessFor(
 				settingsDriver({
 					stored: {
@@ -1023,7 +1055,7 @@ describe("activity", () => {
 			).toEqual([]);
 		});
 
-		test("keeps the handler's own entry instead of the default", async () => {
+		it("keeps the handler's own entry instead of the default", async () => {
 			const { registry } = harnessFor(
 				settingsDriver({
 					stored: {
@@ -1042,7 +1074,7 @@ describe("activity", () => {
 			]);
 		});
 
-		test("reports every written key when the settings could not be read first", async () => {
+		it("reports every written key when the settings could not be read first", async () => {
 			const { registry } = harnessFor(
 				settingsDriver({
 					stored: {},
@@ -1063,7 +1095,7 @@ describe("activity", () => {
 			});
 		});
 
-		test("never carries the value of a secret field", async () => {
+		it("never carries the value of a secret field", async () => {
 			const secret = "hunter22hunter22";
 
 			const { registry } = harnessFor(
@@ -1085,7 +1117,7 @@ describe("activity", () => {
 			expect(JSON.stringify(activity)).not.toContain(secret);
 		});
 
-		test("drops a detail a handler keyed by a secret field", async () => {
+		it("drops a detail a handler keyed by a secret field", async () => {
 			const { registry } = harnessFor({
 				...settingsDriver({
 					stored: {},
@@ -1126,7 +1158,7 @@ describe("activity", () => {
 		});
 	});
 
-	test("reports no default for a catalog install", async () => {
+	it("reports no default for a catalog install", async () => {
 		const { registry } = harnessFor({
 			...baseDriver(),
 			modules: {
@@ -1234,7 +1266,7 @@ describe("availability", () => {
 		throw new Error("the invoke did not refuse");
 	};
 
-	test("advertises availability only for a collection that declares the hook", () => {
+	it("advertises availability only for a collection that declares the hook", () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {
@@ -1273,7 +1305,7 @@ describe("availability", () => {
 		]);
 	});
 
-	test("answers the reasons per row and leaves available rows out", async () => {
+	it("answers the reasons per row and leaves available rows out", async () => {
 		const registry = registryFor(
 			worldsDriver({
 				listed: 0,
@@ -1292,7 +1324,7 @@ describe("availability", () => {
 		});
 	});
 
-	test("narrows the answer to one row when asked for its id", async () => {
+	it("narrows the answer to one row when asked for its id", async () => {
 		const registry = registryFor(
 			worldsDriver({
 				listed: 0,
@@ -1312,7 +1344,7 @@ describe("availability", () => {
 		});
 	});
 
-	test("refuses an unavailable row action before the driver is entered", async () => {
+	it("refuses an unavailable row action before the driver is entered", async () => {
 		const spies = {
 			listed: 0,
 			deleted: [] as string[],
@@ -1338,7 +1370,7 @@ describe("availability", () => {
 		]);
 	});
 
-	test("lets the action run when the hook itself fails", async () => {
+	it("lets the action run when the hook itself fails", async () => {
 		const spies = {
 			listed: 0,
 			deleted: [] as string[],
@@ -1355,7 +1387,7 @@ describe("availability", () => {
 		]);
 	});
 
-	test("lets an availability read join a list already in flight and never reuses a settled one", async () => {
+	it("lets an availability read join a list already in flight and never reuses a settled one", async () => {
 		const spies = {
 			listed: 0,
 			deleted: [] as string[],
@@ -1375,7 +1407,7 @@ describe("availability", () => {
 		expect(spies.listed).toBe(3);
 	});
 
-	test("lists fresh for every list read and every action", async () => {
+	it("lists fresh for every list read and every action", async () => {
 		const spies = {
 			listed: 0,
 			deleted: [] as string[],
@@ -1393,7 +1425,7 @@ describe("availability", () => {
 		expect(spies.listed).toBe(3);
 	});
 
-	test("forgets a list in flight when any module mutates", async () => {
+	it("forgets a list in flight when any module mutates", async () => {
 		let listed = 0;
 		let release = () => {};
 		const gate = new Promise<void>((resolve) => {
@@ -1444,7 +1476,7 @@ describe("availability", () => {
 		await first;
 	});
 
-	test("drops reasons for actions the module cannot refuse and clamps long ones", async () => {
+	it("drops reasons for actions the module cannot refuse and clamps long ones", async () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {
@@ -1485,7 +1517,7 @@ describe("availability", () => {
 		});
 	});
 
-	test("drops entries the wire would refuse so the answer always validates", async () => {
+	it("drops entries the wire would refuse so the answer always validates", async () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {
@@ -1528,7 +1560,7 @@ describe("availability", () => {
 		expect(bridgeAvailabilitySchema.safeParse(result).success).toBe(true);
 	});
 
-	test("enforces the allow-list of a detail and answers its reasons", async () => {
+	it("enforces the allow-list of a detail and answers its reasons", async () => {
 		const updates: BridgeValues[] = [];
 		let pressable: string[] = [];
 		const stale: LocalizedText = {
@@ -1572,8 +1604,8 @@ describe("availability", () => {
 			module: {
 				update: stale,
 				repair: {
-					ar: "هذا الإجراء مو متاح الحين",
-					en: "This action is not available right now",
+					ar: "هذا الإجراء غير متاح حاليًا",
+					en: "This action isn't available right now",
 				},
 			},
 			subjects: {},
@@ -1594,7 +1626,7 @@ describe("availability", () => {
 		expect(updates).toHaveLength(1);
 	});
 
-	test("refuses an actions module, a settings write and a catalog removal through their hooks", async () => {
+	it("refuses an actions module, a settings write and a catalog removal through their hooks", async () => {
 		const closed: LocalizedText = {
 			ar: "مقفل الحين",
 			en: "Closed right now",
@@ -1713,7 +1745,7 @@ describe("availability", () => {
 		});
 	});
 
-	test("does not answer availability for a module that declares no hook", async () => {
+	it("does not answer availability for a module that declares no hook", async () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {
@@ -1729,7 +1761,7 @@ describe("availability", () => {
 		);
 	});
 
-	test("refuses a driver that names a row action availability", () => {
+	it("refuses a driver that names a row action availability", () => {
 		expect(() =>
 			registryFor({
 				...baseDriver(),
@@ -1748,7 +1780,7 @@ describe("availability", () => {
 		).toThrow('module "worlds" declares action "availability", which is reserved for reads');
 	});
 
-	test("turns the gates that never enter the driver into refusals without text", async () => {
+	it("turns the gates that never enter the driver into refusals without text", async () => {
 		const registry = registryFor({
 			...baseDriver(),
 			modules: {

package/src/runtime/bridgeRegistry.ts

@@ -53,8 +53,8 @@ interface CacheEntry {
 }
 
 const UNAVAILABLE_TEXT: LocalizedText = {
-	ar: "هذا الإجراء مو متاح الحين",
-	en: "This action is not available right now",
+	ar: "هذا الإجراء غير متاح حاليًا",
+	en: "This action isn't available right now",
 };
 
 const requiresRunning = (module: BridgePanelModule) => {