@serfab/cadre-host 0.11.0 → 0.12.0

package/src/server/__tests__/settings-route.test.ts

@@ -1,4 +1,4 @@
-import { mkdtempSync, rmSync, writeFileSync } from 'node:fs';
+import { mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
 import { tmpdir } from 'node:os';
 import { join } from 'node:path';
 
@@ -180,15 +180,16 @@ describe('/api/settings routes', () => {
     expect(res.statusCode).toBe(400);
   });
 
-  it('reads v1 host.config.json and migrates to v2 on first read', async () => {
-    writeV1Config(dataDir);
+  it('rejects a v1 host.config.json without rewriting it', async () => {
+    const path = writeV1Config(dataDir);
+    const raw = readFileSync(path, 'utf8');
     app = Fastify();
     registerErrorHandler(app);
     registerSettingsRoutes(app, { settingsStore: new HostSettingsStore({ dataDir }), nat: fakeNat().svc });
     const res = await app.inject({ method: 'GET', url: '/api/settings' });
-    expect(res.statusCode).toBe(200);
-    const body = res.json() as { data: { version: number; updates: { autoApply: boolean } } };
-    expect(body.data.version).toBe(2);
-    expect(body.data.updates.autoApply).toBe(false);
+    expect(res.statusCode).toBe(500);
+    const body = res.json() as { error: { message: string } };
+    expect(body.error.message).toMatch(/unsupported version=1/);
+    expect(readFileSync(path, 'utf8')).toBe(raw);
   });
 });

package/src/server/settings-store.ts

@@ -1,37 +1,41 @@
-/**
- * Settings store — read-write facade around `host.config.json` for the
- * /api/settings route.
- *
- * The installer (`6.4.1`) owns the schema (`HostConfigFile` v2). This module
- * just delegates load/persist to that file's helpers; it exists so route
- * handlers can read/write without each one re-resolving `configPath(dataDir)`.
- *
- * PUT semantics live in routes/settings.ts; this class is purely an I/O
- * boundary so tests can swap it for an in-memory fake.
- */
-
-import { configPath } from '../installer/paths.js';
-import { readHostConfig, updateHostConfig, type HostConfigFile } from '../installer/config.js';
-
-export interface HostSettingsStoreOptions {
-  /** Resolved cadre-host data dir. */
-  dataDir: string;
-}
-
-export class HostSettingsStore {
-  private readonly configPath: string;
-
-  constructor(opts: HostSettingsStoreOptions) {
-    this.configPath = configPath(opts.dataDir);
-  }
-
-  /** Read the current host.config.json (runs v1→v2 migration on first read). */
-  read(): HostConfigFile {
-    return readHostConfig(this.configPath);
-  }
-
-  /** Patch and persist. */
-  update(patch: Partial<Omit<HostConfigFile, 'version'>>): HostConfigFile {
-    return updateHostConfig(this.configPath, patch);
-  }
-}
+/**
+ * Settings store — read-write facade around `host.config.json` for the
+ * /api/settings route.
+ *
+ * The installer (`6.4.1`) owns the schema (`HostConfigFile` v2). This module
+ * just delegates load/persist to that file's helpers; it exists so route
+ * handlers can read/write without each one re-resolving `configPath(dataDir)`.
+ *
+ * PUT semantics live in routes/settings.ts; this class is purely an I/O
+ * boundary so tests can swap it for an in-memory fake.
+ */
+
+import { configPath } from '../installer/paths.js';
+import { readHostConfig, updateHostConfig, type HostConfigFile } from '../installer/config.js';
+
+export interface HostSettingsStoreOptions {
+  /** Resolved cadre-host data dir. */
+  dataDir: string;
+}
+
+export class HostSettingsStore {
+  private readonly configPath: string;
+
+  constructor(opts: HostSettingsStoreOptions) {
+    this.configPath = configPath(opts.dataDir);
+  }
+
+  // NOTE: a bad config (absent, malformed, wrong version) throws a plain Error, so
+  // /api/settings answers 500 code "internal" with the read message passed through.
+  // Fine while the UI just surfaces the text; if it ever needs to tell "your config
+  // file is unreadable" apart from a genuine server bug, give this a typed error.
+  /** Read the current host.config.json. Throws if absent, malformed, or not version 2. */
+  read(): HostConfigFile {
+    return readHostConfig(this.configPath);
+  }
+
+  /** Patch and persist. */
+  update(patch: Partial<Omit<HostConfigFile, 'version'>>): HostConfigFile {
+    return updateHostConfig(this.configPath, patch);
+  }
+}