@serfab/cadre-host 0.10.0 → 0.11.0

package/src/donation/types.ts

@@ -1,243 +1,243 @@
-/**
- * Donation grant-token types for cadre-host.
- *
- * A **grant token** is a high-entropy base64url secret the host admin issues,
- * out-of-band (QR / copy-paste), to one *grantee* — a friend or family member
- * whose cadre authority (their phone) may then ask this host to spawn donated
- * nodes. The grantee presents the token as `Authorization: Bearer <grant-token>`
- * on every donation request (the grantee-facing surface lands in the
- * `2-donation-service` ticket).
- *
- * This module owns the grant's identity, expiry, and per-grantee quota. The
- * *live-node tally* it checks the quota against is owned by the donation
- * service, not by the grant layer — see `GrantValidator.validateForProvision`.
- *
- * **Grant ≠ trust-circle membership.** A trust-circle invite (`auth/`)
- * authorises a device to join *the host's own* cadre. A donation grant
- * authorises an external cadre authority to ask the host to spawn a node that
- * joins *the grantee's* cadre. The two token flows are deliberately separate
- * modules; this one reuses the *shape* of the trust-circle store (atomic
- * write-then-rename JSON, token-keyed rows) but with grant — not invite —
- * semantics: a grant is long-lived and reusable up to a quota, never
- * one-time-redeemed.
- */
-
-/** A grant the host admin issued to one grantee (friend/family). */
-export interface Grant {
-  /** base64url secret; also the bearer credential. The store key. */
-  token: string;
-  /** Human label chosen by the admin, e.g. "Alice's cadre". Display-only. */
-  label: string;
-  /** Max concurrently-live donated nodes this grant may hold. */
-  maxNodes: number;
-  /** ISO timestamp when the grant was issued. */
-  createdAt: string;
-  /** ISO expiry; absent = no expiry. */
-  expiresAt?: string;
-  /** Set when the admin revokes; a revoked grant validates as denied. */
-  revokedAt?: string;
-}
-
-/** Why a presented grant token was denied. */
-export type GrantDenyReason =
-  | 'unknown_token'     // no such grant
-  | 'expired'
-  | 'revoked'
-  | 'quota_exceeded';   // live node count already at maxNodes
-
-/** Result of validating a presented bearer token. */
-export interface GrantValidation {
-  ok: boolean;
-  /** The matched grant, when the token names one (present even on some denials). */
-  grant?: Grant;
-  /** Set when `ok` is false. */
-  reason?: GrantDenyReason;
-}
-
-/**
- * The slice `2-donation-service` depends on. Keeps that ticket decoupled from
- * the store implementation: it holds a `GrantValidator`, not a `GrantStore`.
- *
- * Both methods are pure functions of the store state (and, for provision, the
- * caller-supplied count) — they never throw for a bad token, they return a
- * denial. Issuance/revocation (which mutate) live on `GrantService`.
- */
-export interface GrantValidator {
-  /**
-   * Validate a presented bearer token for a *new* provision request.
-   *
-   * `liveNodeCount(token)` is supplied by the donation service — the grant
-   * layer owns identity/expiry/revocation; the donation service owns the
-   * authoritative live-node tally (it holds the grant→node records). The count
-   * is only consulted once identity/expiry/revocation have passed, so an
-   * unknown or dead token never invokes it.
-   */
-  validateForProvision(
-    token: string,
-    liveNodeCount: (token: string) => number,
-  ): GrantValidation;
-  /**
-   * Validate for a non-provisioning op (peer/seed/terminate): identity + not
-   * expired/revoked. No quota check.
-   */
-  validate(token: string): GrantValidation;
-}
-
-/** On-disk shape of `grants.json`. */
-export interface GrantFile {
-  version: 1;
-  /** keyed by token. */
-  grants: Record<string, Omit<Grant, 'token'>>;
-}
-
-/**
- * Typed handlers exposed to the loopback management server for the **admin**
- * grant surface (`/grants-admin`). Distinct from the grantee-facing `/grants`
- * provisioning surface (`2-donation-service`): the admin surface is loopback,
- * no bearer — same-machine admin, matching cadre-host's local-UI "no login"
- * posture.
- *
- * Handlers throw a `GrantError` whose `.code` the server maps to an HTTP
- * status (see `server/error-handler.ts`).
- */
-export interface GrantAdminHandlers {
-  postGrant(body: { label: string; maxNodes?: number; ttlMs?: number }): Promise<{ grant: Grant }>;
-  listGrants(): Promise<{ grants: Grant[] }>;
-  deleteGrant(token: string): Promise<void>;
-}
-
-/* ──────────────── donation lifecycle (2-donation-service) ──────────────── */
-
-/**
- * Lifecycle of one donated node:
- *   provisioning  → the child process is being spawned.
- *   awaiting_seed → spawned + reachable; waiting for the requester to present
- *                   its phone-signed seed (`PUT /grants/:id/seed`).
- *   seeded        → the seed was applied; the node has joined the requester's cadre.
- *   error         → provisioning failed (orchestrator resources reclaimed).
- *   terminated    → stopped + removed (kept in the store for audit).
- *
- * A donation is "live" (counts against a grant's `maxNodes` quota) while it is
- * `provisioning`, `awaiting_seed`, or `seeded` — see `DonationStore.liveNodeCount`.
- */
-export type DonationStatus =
-  | 'provisioning'
-  | 'awaiting_seed'
-  | 'seeded'
-  | 'error'
-  | 'terminated';
-
-/**
- * One donated node, tracked host-side and persisted to `donations.json`.
- *
- * The host contributes capacity only: `partyId` is the REQUESTER's cadre (a
- * foreign party), and `seedToken` gates the node's own `POST /seed` — it is
- * minted host-side, persisted here (so a host restart in the request→seed gap
- * can still present the seed), and NEVER returned to the grantee.
- *
- * The record also carries every input the original spawn consumed
- * (`partyId` + `profile` + `bootstrapNodes` + `ownerKeys`), so a crashed node can
- * be re-spawned from the record alone — see `DonationService.respawn`. Records
- * written before those two fields existed have neither; such a record is NOT
- * respawnable and is skipped (never crashes a sweep).
- */
-export interface Donation {
-  /** "grn_<nanoid>" — also the donated node's orchestrator containerId. */
-  id: string;
-  /** The grant token that authorized this donation (the quota key). */
-  grantToken: string;
-  /** The REQUESTER's cadre (a foreign party this host merely hosts a node for). */
-  partyId: string;
-  /**
-   * Requester control-network bootstrap multiaddrs — replayed on respawn.
-   * Absent on records written before respawn support; those are not respawnable.
-   */
-  bootstrapNodes?: string[];
-  /**
-   * Requester owner public key(s), base64url — replayed as the node's pinned
-   * seed-trust anchors (`CADRE_OWNER_KEYS`) on respawn. Absent on records written
-   * before respawn support; those are not respawnable.
-   */
-  ownerKeys?: string[];
-  /**
-   * Respawn bookkeeping, owned by the supervisor's backoff. Absent until the
-   * first respawn attempt. Not secret — it rides along in `DonationView` so the
-   * borrower's `GET /grants/:id` shows the counters for free.
-   */
-  respawn?: { attempts: number; lastAttemptAt: string };
-  /** Node profile. Defaults to `storage` so the node participates and is dialable. */
-  profile: 'storage' | 'transaction';
-  status: DonationStatus;
-  /** Orchestrator handle (opaque `pid:token`), set once the child is spawned. */
-  dockerId?: string;
-  /**
-   * Reserved: a donation's live peer identity is read fresh from the node's
-   * `/status` on each `getPeer` call and is NOT persisted here — this field is
-   * currently never written. Kept for a future cache if `/status` fan-out ever
-   * shows up as hot.
-   */
-  peerId?: string;
-  /** The node's loopback `POST /seed` URL. Host-internal — stripped from the wire view. */
-  seedEndpoint?: string;
-  /** Host↔node bearer gating `POST /seed`. Persisted; NEVER leaves the host. */
-  seedToken?: string;
-  createdAt: string;
-  updatedAt: string;
-  /** Failure detail when `status === 'error'`. */
-  error?: string;
-}
-
-/**
- * Redacted wire shape returned to the grantee: the host-only secrets
- * (`seedToken`) and host-internal loopback URL (`seedEndpoint`) are stripped.
- */
-export type DonationView = Omit<Donation, 'seedToken' | 'seedEndpoint'>;
-
-/** On-disk shape of `donations.json`. Keyed by donation id. */
-export interface DonationFile {
-  version: 1;
-  donations: Record<string, Omit<Donation, 'id'>>;
-}
-
-/** Error codes thrown by the donation service / grantee-facing routes. */
-export type DonationErrorCode =
-  | 'unauthorized'        // 401 — missing / unknown grant bearer
-  | 'forbidden'           // 403 — revoked or expired grant
-  | 'quota_exceeded'      // 429 — grant already at its maxNodes cap
-  | 'invalid_request'     // 400 — malformed body
-  | 'not_found'           // 404 — no such donation (or not owned by this grant)
-  | 'invalid_state'       // 409 — op invalid for the donation's current status
-  | 'seed_failed'         // 502 — the node rejected the presented seed
-  | 'peer_unavailable'    // 503 — the node has no peer identity yet
-  | 'orchestrator_error'  // 500 — spawn / stop failure
-  | 'storage_error';      // 500 — donations.json read/write failure
-
-/** Typed donation error carrying a stable `code` for HTTP mapping. */
-export class DonationError extends Error {
-  readonly code: DonationErrorCode;
-
-  constructor(code: DonationErrorCode, message: string) {
-    super(message);
-    this.name = 'DonationError';
-    this.code = code;
-  }
-}
-
-/** Error codes thrown by GrantStore / GrantService. */
-export type GrantErrorCode =
-  | 'not_found'          // unknown token on revoke
-  | 'invalid_label'
-  | 'invalid_max_nodes'
-  | 'invalid_ttl'
-  | 'storage_error';
-
-/** Typed error carrying a stable `code` for HTTP mapping. */
-export class GrantError extends Error {
-  readonly code: GrantErrorCode;
-
-  constructor(code: GrantErrorCode, message: string) {
-    super(message);
-    this.name = 'GrantError';
-    this.code = code;
-  }
-}
+/**
+ * Donation grant-token types for cadre-host.
+ *
+ * A **grant token** is a high-entropy base64url secret the host admin issues,
+ * out-of-band (QR / copy-paste), to one *grantee* — a friend or family member
+ * whose cadre authority (their phone) may then ask this host to spawn donated
+ * nodes. The grantee presents the token as `Authorization: Bearer <grant-token>`
+ * on every donation request (the grantee-facing surface lands in the
+ * `2-donation-service` ticket).
+ *
+ * This module owns the grant's identity, expiry, and per-grantee quota. The
+ * *live-node tally* it checks the quota against is owned by the donation
+ * service, not by the grant layer — see `GrantValidator.validateForProvision`.
+ *
+ * **Grant ≠ trust-circle membership.** A trust-circle invite (`auth/`)
+ * authorises a device to join *the host's own* cadre. A donation grant
+ * authorises an external cadre authority to ask the host to spawn a node that
+ * joins *the grantee's* cadre. The two token flows are deliberately separate
+ * modules; this one reuses the *shape* of the trust-circle store (atomic
+ * write-then-rename JSON, token-keyed rows) but with grant — not invite —
+ * semantics: a grant is long-lived and reusable up to a quota, never
+ * one-time-redeemed.
+ */
+
+/** A grant the host admin issued to one grantee (friend/family). */
+export interface Grant {
+  /** base64url secret; also the bearer credential. The store key. */
+  token: string;
+  /** Human label chosen by the admin, e.g. "Alice's cadre". Display-only. */
+  label: string;
+  /** Max concurrently-live donated nodes this grant may hold. */
+  maxNodes: number;
+  /** ISO timestamp when the grant was issued. */
+  createdAt: string;
+  /** ISO expiry; absent = no expiry. */
+  expiresAt?: string;
+  /** Set when the admin revokes; a revoked grant validates as denied. */
+  revokedAt?: string;
+}
+
+/** Why a presented grant token was denied. */
+export type GrantDenyReason =
+  | 'unknown_token'     // no such grant
+  | 'expired'
+  | 'revoked'
+  | 'quota_exceeded';   // live node count already at maxNodes
+
+/** Result of validating a presented bearer token. */
+export interface GrantValidation {
+  ok: boolean;
+  /** The matched grant, when the token names one (present even on some denials). */
+  grant?: Grant;
+  /** Set when `ok` is false. */
+  reason?: GrantDenyReason;
+}
+
+/**
+ * The slice `2-donation-service` depends on. Keeps that ticket decoupled from
+ * the store implementation: it holds a `GrantValidator`, not a `GrantStore`.
+ *
+ * Both methods are pure functions of the store state (and, for provision, the
+ * caller-supplied count) — they never throw for a bad token, they return a
+ * denial. Issuance/revocation (which mutate) live on `GrantService`.
+ */
+export interface GrantValidator {
+  /**
+   * Validate a presented bearer token for a *new* provision request.
+   *
+   * `liveNodeCount(token)` is supplied by the donation service — the grant
+   * layer owns identity/expiry/revocation; the donation service owns the
+   * authoritative live-node tally (it holds the grant→node records). The count
+   * is only consulted once identity/expiry/revocation have passed, so an
+   * unknown or dead token never invokes it.
+   */
+  validateForProvision(
+    token: string,
+    liveNodeCount: (token: string) => number,
+  ): GrantValidation;
+  /**
+   * Validate for a non-provisioning op (peer/seed/terminate): identity + not
+   * expired/revoked. No quota check.
+   */
+  validate(token: string): GrantValidation;
+}
+
+/** On-disk shape of `grants.json`. */
+export interface GrantFile {
+  version: 1;
+  /** keyed by token. */
+  grants: Record<string, Omit<Grant, 'token'>>;
+}
+
+/**
+ * Typed handlers exposed to the loopback management server for the **admin**
+ * grant surface (`/grants-admin`). Distinct from the grantee-facing `/grants`
+ * provisioning surface (`2-donation-service`): the admin surface is loopback,
+ * no bearer — same-machine admin, matching cadre-host's local-UI "no login"
+ * posture.
+ *
+ * Handlers throw a `GrantError` whose `.code` the server maps to an HTTP
+ * status (see `server/error-handler.ts`).
+ */
+export interface GrantAdminHandlers {
+  postGrant(body: { label: string; maxNodes?: number; ttlMs?: number }): Promise<{ grant: Grant }>;
+  listGrants(): Promise<{ grants: Grant[] }>;
+  deleteGrant(token: string): Promise<void>;
+}
+
+/* ──────────────── donation lifecycle (2-donation-service) ──────────────── */
+
+/**
+ * Lifecycle of one donated node:
+ *   provisioning  → the child process is being spawned.
+ *   awaiting_seed → spawned + reachable; waiting for the requester to present
+ *                   its phone-signed seed (`PUT /grants/:id/seed`).
+ *   seeded        → the seed was applied; the node has joined the requester's cadre.
+ *   error         → provisioning failed (orchestrator resources reclaimed).
+ *   terminated    → stopped + removed (kept in the store for audit).
+ *
+ * A donation is "live" (counts against a grant's `maxNodes` quota) while it is
+ * `provisioning`, `awaiting_seed`, or `seeded` — see `DonationStore.liveNodeCount`.
+ */
+export type DonationStatus =
+  | 'provisioning'
+  | 'awaiting_seed'
+  | 'seeded'
+  | 'error'
+  | 'terminated';
+
+/**
+ * One donated node, tracked host-side and persisted to `donations.json`.
+ *
+ * The host contributes capacity only: `partyId` is the REQUESTER's cadre (a
+ * foreign party), and `seedToken` gates the node's own `POST /seed` — it is
+ * minted host-side, persisted here (so a host restart in the request→seed gap
+ * can still present the seed), and NEVER returned to the grantee.
+ *
+ * The record also carries every input the original spawn consumed
+ * (`partyId` + `profile` + `bootstrapNodes` + `ownerKeys`), so a crashed node can
+ * be re-spawned from the record alone — see `DonationService.respawn`. Records
+ * written before those two fields existed have neither; such a record is NOT
+ * respawnable and is skipped (never crashes a sweep).
+ */
+export interface Donation {
+  /** "grn_<nanoid>" — also the donated node's orchestrator containerId. */
+  id: string;
+  /** The grant token that authorized this donation (the quota key). */
+  grantToken: string;
+  /** The REQUESTER's cadre (a foreign party this host merely hosts a node for). */
+  partyId: string;
+  /**
+   * Requester control-network bootstrap multiaddrs — replayed on respawn.
+   * Absent on records written before respawn support; those are not respawnable.
+   */
+  bootstrapNodes?: string[];
+  /**
+   * Requester owner public key(s), base64url — replayed as the node's pinned
+   * seed-trust anchors (`CADRE_OWNER_KEYS`) on respawn. Absent on records written
+   * before respawn support; those are not respawnable.
+   */
+  ownerKeys?: string[];
+  /**
+   * Respawn bookkeeping, owned by the supervisor's backoff. Absent until the
+   * first respawn attempt. Not secret — it rides along in `DonationView` so the
+   * borrower's `GET /grants/:id` shows the counters for free.
+   */
+  respawn?: { attempts: number; lastAttemptAt: string };
+  /** Node profile. Defaults to `storage` so the node participates and is dialable. */
+  profile: 'storage' | 'transaction';
+  status: DonationStatus;
+  /** Orchestrator handle (opaque `pid:token`), set once the child is spawned. */
+  dockerId?: string;
+  /**
+   * Reserved: a donation's live peer identity is read fresh from the node's
+   * `/status` on each `getPeer` call and is NOT persisted here — this field is
+   * currently never written. Kept for a future cache if `/status` fan-out ever
+   * shows up as hot.
+   */
+  peerId?: string;
+  /** The node's loopback `POST /seed` URL. Host-internal — stripped from the wire view. */
+  seedEndpoint?: string;
+  /** Host↔node bearer gating `POST /seed`. Persisted; NEVER leaves the host. */
+  seedToken?: string;
+  createdAt: string;
+  updatedAt: string;
+  /** Failure detail when `status === 'error'`. */
+  error?: string;
+}
+
+/**
+ * Redacted wire shape returned to the grantee: the host-only secrets
+ * (`seedToken`) and host-internal loopback URL (`seedEndpoint`) are stripped.
+ */
+export type DonationView = Omit<Donation, 'seedToken' | 'seedEndpoint'>;
+
+/** On-disk shape of `donations.json`. Keyed by donation id. */
+export interface DonationFile {
+  version: 1;
+  donations: Record<string, Omit<Donation, 'id'>>;
+}
+
+/** Error codes thrown by the donation service / grantee-facing routes. */
+export type DonationErrorCode =
+  | 'unauthorized'        // 401 — missing / unknown grant bearer
+  | 'forbidden'           // 403 — revoked or expired grant
+  | 'quota_exceeded'      // 429 — grant already at its maxNodes cap
+  | 'invalid_request'     // 400 — malformed body
+  | 'not_found'           // 404 — no such donation (or not owned by this grant)
+  | 'invalid_state'       // 409 — op invalid for the donation's current status
+  | 'seed_failed'         // 502 — the node rejected the presented seed
+  | 'peer_unavailable'    // 503 — the node has no peer identity yet
+  | 'orchestrator_error'  // 500 — spawn / stop failure
+  | 'storage_error';      // 500 — donations.json read/write failure
+
+/** Typed donation error carrying a stable `code` for HTTP mapping. */
+export class DonationError extends Error {
+  readonly code: DonationErrorCode;
+
+  constructor(code: DonationErrorCode, message: string) {
+    super(message);
+    this.name = 'DonationError';
+    this.code = code;
+  }
+}
+
+/** Error codes thrown by GrantStore / GrantService. */
+export type GrantErrorCode =
+  | 'not_found'          // unknown token on revoke
+  | 'invalid_label'
+  | 'invalid_max_nodes'
+  | 'invalid_ttl'
+  | 'storage_error';
+
+/** Typed error carrying a stable `code` for HTTP mapping. */
+export class GrantError extends Error {
+  readonly code: GrantErrorCode;
+
+  constructor(code: GrantErrorCode, message: string) {
+    super(message);
+    this.name = 'GrantError';
+    this.code = code;
+  }
+}

package/src/installer/__tests__/identity.test.ts

@@ -1,34 +1,34 @@
-import { afterEach, beforeEach, describe, expect, it } from 'vitest';
-import { mkdtempSync, rmSync, statSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import { join } from 'node:path';
-
-import { generateIdentity, loadIdentity } from '../identity.js';
-
-describe('installer identity', () => {
-  let tmp: string;
-
-  beforeEach(() => {
-    tmp = mkdtempSync(join(tmpdir(), 'cadre-host-id-'));
-  });
-
-  afterEach(() => {
-    rmSync(tmp, { recursive: true, force: true });
-  });
-
-  it('round-trips an Ed25519 keypair through the file', async () => {
-    const path = join(tmp, 'identity.key');
-    const generated = await generateIdentity(path);
-    expect(generated.peerId).toMatch(/^12D3Koo/);
-
-    const loaded = loadIdentity(path);
-    expect(loaded.peerId).toBe(generated.peerId);
-  });
-
-  it.runIf(process.platform !== 'win32')('persists with mode 0600 on POSIX', async () => {
-    const path = join(tmp, 'identity.key');
-    await generateIdentity(path);
-    const mode = statSync(path).mode & 0o777;
-    expect(mode).toBe(0o600);
-  });
-});
+import { afterEach, beforeEach, describe, expect, it } from 'vitest';
+import { mkdtempSync, rmSync, statSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+
+import { generateIdentity, loadIdentity } from '../identity.js';
+
+describe('installer identity', () => {
+  let tmp: string;
+
+  beforeEach(() => {
+    tmp = mkdtempSync(join(tmpdir(), 'cadre-host-id-'));
+  });
+
+  afterEach(() => {
+    rmSync(tmp, { recursive: true, force: true });
+  });
+
+  it('round-trips an Ed25519 keypair through the file', async () => {
+    const path = join(tmp, 'identity.key');
+    const generated = await generateIdentity(path);
+    expect(generated.peerId).toMatch(/^12D3Koo/);
+
+    const loaded = loadIdentity(path);
+    expect(loaded.peerId).toBe(generated.peerId);
+  });
+
+  it.runIf(process.platform !== 'win32')('persists with mode 0600 on POSIX', async () => {
+    const path = join(tmp, 'identity.key');
+    await generateIdentity(path);
+    const mode = statSync(path).mode & 0o777;
+    expect(mode).toBe(0o600);
+  });
+});

package/src/installer/__tests__/paths.test.ts

@@ -1,47 +1,47 @@
-import { describe, expect, it } from 'vitest';
-
-import { defaultDataDir, serviceInstallPath } from '../paths.js';
-
-describe('defaultDataDir', () => {
-  it('honors XDG_DATA_HOME on linux', () => {
-    expect(defaultDataDir('linux', { XDG_DATA_HOME: '/tmp/xdg', HOME: '/home/me' }, '/home/me'))
-      .toBe('/tmp/xdg/cadre-host');
-  });
-
-  it('falls back to ~/.local/share on linux', () => {
-    expect(defaultDataDir('linux', { HOME: '/home/me' }, '/home/me'))
-      .toBe('/home/me/.local/share/cadre-host');
-  });
-
-  it('uses Application Support on darwin', () => {
-    expect(defaultDataDir('darwin', { HOME: '/Users/me' }, '/Users/me'))
-      .toBe('/Users/me/Library/Application Support/CadreHost');
-  });
-
-  it('uses LocalAppData on win32', () => {
-    expect(defaultDataDir('win32', { LocalAppData: 'C:\\Users\\me\\AppData\\Local' }, 'C:\\Users\\me'))
-      .toBe('C:\\Users\\me\\AppData\\Local\\CadreHost');
-  });
-
-  it('falls back to ~/AppData/Local on win32 without LocalAppData', () => {
-    expect(defaultDataDir('win32', {}, 'C:\\Users\\me'))
-      .toBe('C:\\Users\\me\\AppData\\Local\\CadreHost');
-  });
-});
-
-describe('serviceInstallPath', () => {
-  it('honors XDG_CONFIG_HOME on linux', () => {
-    expect(serviceInstallPath('linux', { XDG_CONFIG_HOME: '/tmp/cfg', HOME: '/home/me' }, '/home/me'))
-      .toBe('/tmp/cfg/systemd/user/cadre-host.service');
-  });
-
-  it('uses LaunchAgents on darwin', () => {
-    expect(serviceInstallPath('darwin', { HOME: '/Users/me' }, '/Users/me'))
-      .toBe('/Users/me/Library/LaunchAgents/com.serfab.cadre-host.plist');
-  });
-
-  it('returns a registry-style path on win32 (for logging only)', () => {
-    expect(serviceInstallPath('win32', {}, 'C:\\Users\\me'))
-      .toMatch(/CadreHost/);
-  });
-});
+import { describe, expect, it } from 'vitest';
+
+import { defaultDataDir, serviceInstallPath } from '../paths.js';
+
+describe('defaultDataDir', () => {
+  it('honors XDG_DATA_HOME on linux', () => {
+    expect(defaultDataDir('linux', { XDG_DATA_HOME: '/tmp/xdg', HOME: '/home/me' }, '/home/me'))
+      .toBe('/tmp/xdg/cadre-host');
+  });
+
+  it('falls back to ~/.local/share on linux', () => {
+    expect(defaultDataDir('linux', { HOME: '/home/me' }, '/home/me'))
+      .toBe('/home/me/.local/share/cadre-host');
+  });
+
+  it('uses Application Support on darwin', () => {
+    expect(defaultDataDir('darwin', { HOME: '/Users/me' }, '/Users/me'))
+      .toBe('/Users/me/Library/Application Support/CadreHost');
+  });
+
+  it('uses LocalAppData on win32', () => {
+    expect(defaultDataDir('win32', { LocalAppData: 'C:\\Users\\me\\AppData\\Local' }, 'C:\\Users\\me'))
+      .toBe('C:\\Users\\me\\AppData\\Local\\CadreHost');
+  });
+
+  it('falls back to ~/AppData/Local on win32 without LocalAppData', () => {
+    expect(defaultDataDir('win32', {}, 'C:\\Users\\me'))
+      .toBe('C:\\Users\\me\\AppData\\Local\\CadreHost');
+  });
+});
+
+describe('serviceInstallPath', () => {
+  it('honors XDG_CONFIG_HOME on linux', () => {
+    expect(serviceInstallPath('linux', { XDG_CONFIG_HOME: '/tmp/cfg', HOME: '/home/me' }, '/home/me'))
+      .toBe('/tmp/cfg/systemd/user/cadre-host.service');
+  });
+
+  it('uses LaunchAgents on darwin', () => {
+    expect(serviceInstallPath('darwin', { HOME: '/Users/me' }, '/Users/me'))
+      .toBe('/Users/me/Library/LaunchAgents/com.serfab.cadre-host.plist');
+  });
+
+  it('returns a registry-style path on win32 (for logging only)', () => {
+    expect(serviceInstallPath('win32', {}, 'C:\\Users\\me'))
+      .toMatch(/CadreHost/);
+  });
+});