@sentry/wizard 6.12.0 → 6.13.0

package/dist/test/apple/xcode-manager.test.js

@@ -31,8 +31,11 @@ const os = __importStar(require("node:os"));
 const path = __importStar(require("node:path"));
 const node_process_1 = __importDefault(require("node:process"));
 const vitest_1 = require("vitest");
+const configure_snapshotpreviews_xcode_project_1 = require("../../src/apple/snapshots/configure-snapshotpreviews-xcode-project");
+const sentry_swift_package_1 = require("../../src/apple/sentry-swift-package");
 const templates_1 = require("../../src/apple/templates");
 const xcode_manager_1 = require("../../src/apple/xcode-manager");
+const hosted_test_target_fixture_1 = require("./snapshots/hosted-test-target-fixture");
 vitest_1.vi.mock('node:fs', async () => ({
     __esModule: true,
     ...(await vitest_1.vi.importActual('node:fs')),
@@ -61,6 +64,28 @@ const projectData = {
     },
     keys: [{ dsn: { public: 'https://sentry.io/1234567890' } }],
 };
+const appFrameworksBuildPhaseId = 'D4E604CA2D50CEEC00CAB00F';
+const sentrySwiftPackageProductLinkOptions = {
+    product: sentry_swift_package_1.sentrySwiftPackageProductSpec,
+    existingFrameworkComment: sentry_swift_package_1.SENTRY_SPM_ALREADY_LINKED_FRAMEWORK_COMMENT,
+    successMessage: 'Added Sentry SPM dependency to your project',
+};
+const projectObjectId = 'D4E604C52D50CEEC00CAB00F';
+const productsGroupId = 'D4E604CE2D50CEEC00CAB00F';
+function objectKeysWithoutComments(object) {
+    return Object.keys((object ?? {})).filter((key) => {
+        return !key.endsWith('_comment');
+    });
+}
+function getTargetByName(xcodeProject, targetName) {
+    const target = Object.values(xcodeProject.objects.PBXNativeTarget ?? {}).find((candidate) => {
+        return typeof candidate !== 'string' && candidate.name === targetName;
+    });
+    if (!target) {
+        throw new Error(`Target not found: ${targetName}`);
+    }
+    return target;
+}
 (0, vitest_1.describe)('XcodeManager', () => {
     (0, vitest_1.beforeEach)(() => {
         if (node_process_1.default.platform !== 'darwin') {
@@ -124,6 +149,338 @@ const projectData = {
                 });
             });
         });
+        (0, vitest_1.describe)('target type detection', () => {
+            (0, vitest_1.it)('lists application and unit-test targets by name', () => {
+                // -- Arrange --
+                const xcodeProject = new xcode_manager_1.XcodeProject(singleTargetProjectPath);
+                (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                    projectObjectId,
+                    productsGroupId,
+                });
+                // -- Act & Assert --
+                (0, vitest_1.expect)(xcodeProject.getAllTargets()).toEqual(['Project']);
+                (0, vitest_1.expect)(xcodeProject.getUnitTestTargetNames()).toEqual(['ProjectTests']);
+            });
+            (0, vitest_1.it)('returns multiple unit-test targets by name', () => {
+                // -- Arrange --
+                const xcodeProject = new xcode_manager_1.XcodeProject(singleTargetProjectPath);
+                (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                    name: 'ProjectTests',
+                    projectObjectId,
+                    productsGroupId,
+                });
+                (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                    name: 'ProjectSnapshotTests',
+                    projectObjectId,
+                    productsGroupId,
+                });
+                // -- Act & Assert --
+                (0, vitest_1.expect)(xcodeProject.getUnitTestTargetNames()).toEqual([
+                    'ProjectTests',
+                    'ProjectSnapshotTests',
+                ]);
+            });
+            (0, vitest_1.it)('returns only unit-test targets with TEST_HOST configured', () => {
+                // -- Arrange --
+                const xcodeProject = new xcode_manager_1.XcodeProject(singleTargetProjectPath);
+                (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                    name: 'ProjectTests',
+                    projectObjectId,
+                    productsGroupId,
+                });
+                (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                    name: 'UnhostedProjectTests',
+                    projectObjectId,
+                    productsGroupId,
+                    testHost: '""',
+                });
+                // -- Act & Assert --
+                (0, vitest_1.expect)(xcodeProject.getUnitTestTargetNames()).toEqual([
+                    'ProjectTests',
+                    'UnhostedProjectTests',
+                ]);
+                (0, vitest_1.expect)(xcodeProject.getHostedUnitTestTargetNames()).toEqual([
+                    'ProjectTests',
+                ]);
+            });
+            (0, vitest_1.it)('returns only unit-test targets hosted by the selected application target', () => {
+                // -- Arrange --
+                const xcodeProject = new xcode_manager_1.XcodeProject(singleTargetProjectPath);
+                (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                    name: 'ProjectTests',
+                    projectObjectId,
+                    productsGroupId,
+                });
+                (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                    hostAppName: 'OtherApp',
+                    name: 'OtherAppTests',
+                    projectObjectId,
+                    productsGroupId,
+                });
+                // -- Act & Assert --
+                (0, vitest_1.expect)(xcodeProject.getHostedUnitTestTargetNamesForApplicationTarget('Project')).toEqual(['ProjectTests']);
+            });
+            (0, vitest_1.it)('matches hosted unit-test targets by app product name', () => {
+                // -- Arrange --
+                const xcodeProject = new xcode_manager_1.XcodeProject(singleTargetProjectPath);
+                (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                    name: 'ProjectTests',
+                    projectObjectId,
+                    productsGroupId,
+                    testHost: '"$(BUILT_PRODUCTS_DIR)/SentryWizardSampleBlank.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/SentryWizardSampleBlank"',
+                });
+                // -- Act & Assert --
+                (0, vitest_1.expect)(xcodeProject.getHostedUnitTestTargetNamesForApplicationTarget('Project')).toEqual(['ProjectTests']);
+            });
+            (0, vitest_1.it)('returns no hosted unit-test targets for an unknown application target', () => {
+                // -- Arrange --
+                const xcodeProject = new xcode_manager_1.XcodeProject(singleTargetProjectPath);
+                (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                    name: 'ProjectTests',
+                    projectObjectId,
+                    productsGroupId,
+                });
+                // -- Act & Assert --
+                (0, vitest_1.expect)(xcodeProject.getHostedUnitTestTargetNamesForApplicationTarget('MissingApp')).toEqual([]);
+            });
+        });
+        (0, vitest_1.describe)('ensureSwiftPackageProductLinked', () => {
+            let xcodeProject;
+            let hostedTestTargetIds;
+            (0, vitest_1.beforeEach)(() => {
+                xcodeProject = new xcode_manager_1.XcodeProject(singleTargetProjectPath);
+                hostedTestTargetIds = (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                    projectObjectId,
+                    productsGroupId,
+                });
+            });
+            (0, vitest_1.it)('links a Swift package product only to the selected target', () => {
+                // -- Act --
+                const result = xcodeProject.ensureSwiftPackageProductLinked('ProjectTests', configure_snapshotpreviews_xcode_project_1.snapshottingTestsProductSpec);
+                // -- Assert --
+                (0, vitest_1.expect)(result).toEqual({ changed: true, linked: true });
+                (0, vitest_1.expect)(objectKeysWithoutComments(xcodeProject.objects.XCRemoteSwiftPackageReference)).toHaveLength(1);
+                (0, vitest_1.expect)(objectKeysWithoutComments(xcodeProject.objects.XCSwiftPackageProductDependency)).toHaveLength(1);
+                const appTarget = getTargetByName(xcodeProject, 'Project');
+                const hostedTestTarget = getTargetByName(xcodeProject, 'ProjectTests');
+                (0, vitest_1.expect)(appTarget.packageProductDependencies).toEqual([]);
+                (0, vitest_1.expect)(hostedTestTarget.packageProductDependencies).toEqual([
+                    vitest_1.expect.objectContaining({ comment: 'SnapshottingTests' }),
+                ]);
+                const appFrameworksBuildPhase = xcodeProject.objects.PBXFrameworksBuildPhase?.[appFrameworksBuildPhaseId];
+                const testFrameworksBuildPhase = xcodeProject.objects.PBXFrameworksBuildPhase?.[hostedTestTargetIds.frameworksBuildPhaseId];
+                (0, vitest_1.expect)(typeof appFrameworksBuildPhase !== 'string'
+                    ? appFrameworksBuildPhase?.files
+                    : undefined).toEqual([]);
+                (0, vitest_1.expect)(typeof testFrameworksBuildPhase !== 'string'
+                    ? testFrameworksBuildPhase?.files
+                    : undefined).toEqual([
+                    vitest_1.expect.objectContaining({
+                        comment: 'SnapshottingTests in Frameworks',
+                    }),
+                ]);
+            });
+            (0, vitest_1.it)('is idempotent across repeated runs', () => {
+                // -- Act --
+                const firstResult = xcodeProject.ensureSwiftPackageProductLinked('ProjectTests', configure_snapshotpreviews_xcode_project_1.snapshottingTestsProductSpec);
+                const secondResult = xcodeProject.ensureSwiftPackageProductLinked('ProjectTests', configure_snapshotpreviews_xcode_project_1.snapshottingTestsProductSpec);
+                // -- Assert --
+                (0, vitest_1.expect)(firstResult).toEqual({ changed: true, linked: true });
+                (0, vitest_1.expect)(secondResult).toEqual({ changed: false, linked: true });
+                (0, vitest_1.expect)(objectKeysWithoutComments(xcodeProject.objects.XCRemoteSwiftPackageReference)).toHaveLength(1);
+                (0, vitest_1.expect)(objectKeysWithoutComments(xcodeProject.objects.XCSwiftPackageProductDependency)).toHaveLength(1);
+                (0, vitest_1.expect)(objectKeysWithoutComments(xcodeProject.objects.PBXBuildFile)).toHaveLength(1);
+            });
+            (0, vitest_1.it)('reuses an existing product dependency with a quoted product name', () => {
+                // -- Arrange --
+                const packageRefId = 'EXISTINGPACKAGE000000000001';
+                const productDependencyId = 'EXISTINGPRODUCT000000000001';
+                xcodeProject.objects.XCRemoteSwiftPackageReference = {
+                    [packageRefId]: {
+                        isa: 'XCRemoteSwiftPackageReference',
+                        repositoryURL: `"${configure_snapshotpreviews_xcode_project_1.snapshottingTestsProductSpec.package.repositoryURL}"`,
+                        requirement: configure_snapshotpreviews_xcode_project_1.snapshottingTestsProductSpec.package.requirement,
+                    },
+                    [`${packageRefId}_comment`]: 'XCRemoteSwiftPackageReference "SnapshotPreviews"',
+                };
+                xcodeProject.objects.XCSwiftPackageProductDependency = {
+                    [productDependencyId]: {
+                        isa: 'XCSwiftPackageProductDependency',
+                        package: packageRefId,
+                        productName: '"SnapshottingTests"',
+                    },
+                    [`${productDependencyId}_comment`]: 'SnapshottingTests',
+                };
+                // -- Act --
+                const result = xcodeProject.ensureSwiftPackageProductLinked('ProjectTests', configure_snapshotpreviews_xcode_project_1.snapshottingTestsProductSpec);
+                // -- Assert --
+                (0, vitest_1.expect)(result).toEqual({ changed: true, linked: true });
+                (0, vitest_1.expect)(objectKeysWithoutComments(xcodeProject.objects.XCSwiftPackageProductDependency)).toEqual([productDependencyId]);
+                (0, vitest_1.expect)(getTargetByName(xcodeProject, 'ProjectTests')).toEqual(vitest_1.expect.objectContaining({
+                    packageProductDependencies: [
+                        vitest_1.expect.objectContaining({ value: productDependencyId }),
+                    ],
+                }));
+            });
+            (0, vitest_1.it)('reuses an existing package reference with the same repository URL and updates a lower minimum version', () => {
+                // -- Arrange --
+                xcodeProject.objects.XCRemoteSwiftPackageReference = {
+                    EXISTINGPACKAGE000000000001: {
+                        isa: 'XCRemoteSwiftPackageReference',
+                        repositoryURL: `"${configure_snapshotpreviews_xcode_project_1.snapshottingTestsProductSpec.package.repositoryURL}/"`,
+                        requirement: {
+                            kind: 'upToNextMajorVersion',
+                            minimumVersion: '0.8.0',
+                        },
+                    },
+                    EXISTINGPACKAGE000000000001_comment: 'XCRemoteSwiftPackageReference "SnapshotPreviews"',
+                };
+                // -- Act --
+                const result = xcodeProject.ensureSwiftPackageProductLinked('ProjectTests', configure_snapshotpreviews_xcode_project_1.snapshottingTestsProductSpec);
+                // -- Assert --
+                (0, vitest_1.expect)(result).toEqual({ changed: true, linked: true });
+                (0, vitest_1.expect)(objectKeysWithoutComments(xcodeProject.objects.XCRemoteSwiftPackageReference)).toEqual(['EXISTINGPACKAGE000000000001']);
+                (0, vitest_1.expect)(xcodeProject.objects.XCRemoteSwiftPackageReference?.['EXISTINGPACKAGE000000000001']).toEqual(vitest_1.expect.objectContaining({
+                    requirement: configure_snapshotpreviews_xcode_project_1.snapshottingTestsProductSpec.package.requirement,
+                }));
+                (0, vitest_1.expect)(xcodeProject.objects.XCSwiftPackageProductDependency?.[objectKeysWithoutComments(xcodeProject.objects.XCSwiftPackageProductDependency)[0]]).toEqual(vitest_1.expect.objectContaining({
+                    package: 'EXISTINGPACKAGE000000000001',
+                    productName: 'SnapshottingTests',
+                }));
+            });
+            (0, vitest_1.it)('does not partially mutate package state when the target has no Frameworks build phase', () => {
+                // -- Arrange --
+                const hostedTestTarget = getTargetByName(xcodeProject, 'ProjectTests');
+                hostedTestTarget.buildPhases = [];
+                // -- Act --
+                const result = xcodeProject.ensureSwiftPackageProductLinked('ProjectTests', configure_snapshotpreviews_xcode_project_1.snapshottingTestsProductSpec);
+                // -- Assert --
+                (0, vitest_1.expect)(result).toEqual({ changed: false, linked: false });
+                (0, vitest_1.expect)(xcodeProject.objects.XCRemoteSwiftPackageReference).toBeUndefined();
+                (0, vitest_1.expect)(xcodeProject.objects.XCSwiftPackageProductDependency).toBeUndefined();
+                (0, vitest_1.expect)(xcodeProject.objects.PBXBuildFile).toBeUndefined();
+                (0, vitest_1.expect)(hostedTestTarget.packageProductDependencies).toEqual([]);
+            });
+        });
+        (0, vitest_1.describe)('configureSnapshotPreviewsXcodeProject', () => {
+            (0, vitest_1.it)('links SnapshottingTests to the hosted test target and SnapshotPreferences only to selected preview targets', () => {
+                // -- Arrange --
+                const xcodeProject = new xcode_manager_1.XcodeProject(singleTargetProjectPath);
+                (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                    projectObjectId,
+                    productsGroupId,
+                });
+                // -- Act --
+                const result = (0, configure_snapshotpreviews_xcode_project_1.configureSnapshotPreviewsXcodeProject)({
+                    xcodeProject,
+                    hostedTestTargetName: 'ProjectTests',
+                    previewTargetNames: ['Project'],
+                });
+                // -- Assert --
+                (0, vitest_1.expect)(result).toEqual({
+                    changed: true,
+                    failedSnapshotPreferencesTargetNames: [],
+                    linked: true,
+                });
+                const appTarget = getTargetByName(xcodeProject, 'Project');
+                const hostedTestTarget = getTargetByName(xcodeProject, 'ProjectTests');
+                (0, vitest_1.expect)(appTarget.packageProductDependencies).toEqual([
+                    vitest_1.expect.objectContaining({ comment: 'SnapshotPreferences' }),
+                ]);
+                (0, vitest_1.expect)(hostedTestTarget.packageProductDependencies).toEqual([
+                    vitest_1.expect.objectContaining({ comment: 'SnapshottingTests' }),
+                ]);
+                (0, vitest_1.expect)(objectKeysWithoutComments(xcodeProject.objects.XCSwiftPackageProductDependency)).toHaveLength(2);
+            });
+            (0, vitest_1.it)('does not link SnapshotPreferences when no preview targets are selected', () => {
+                // -- Arrange --
+                const xcodeProject = new xcode_manager_1.XcodeProject(singleTargetProjectPath);
+                (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                    projectObjectId,
+                    productsGroupId,
+                });
+                // -- Act --
+                (0, configure_snapshotpreviews_xcode_project_1.configureSnapshotPreviewsXcodeProject)({
+                    xcodeProject,
+                    hostedTestTargetName: 'ProjectTests',
+                });
+                // -- Assert --
+                const appTarget = getTargetByName(xcodeProject, 'Project');
+                const hostedTestTarget = getTargetByName(xcodeProject, 'ProjectTests');
+                (0, vitest_1.expect)(appTarget.packageProductDependencies).toEqual([]);
+                (0, vitest_1.expect)(hostedTestTarget.packageProductDependencies).toEqual([
+                    vitest_1.expect.objectContaining({ comment: 'SnapshottingTests' }),
+                ]);
+                (0, vitest_1.expect)(objectKeysWithoutComments(xcodeProject.objects.XCSwiftPackageProductDependency)).toHaveLength(1);
+            });
+            (0, vitest_1.it)('continues when SnapshotPreferences cannot be linked to a preview target', () => {
+                // -- Arrange --
+                const xcodeProject = new xcode_manager_1.XcodeProject(singleTargetProjectPath);
+                (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                    projectObjectId,
+                    productsGroupId,
+                });
+                const appTarget = getTargetByName(xcodeProject, 'Project');
+                appTarget.buildPhases = [];
+                // -- Act --
+                const result = (0, configure_snapshotpreviews_xcode_project_1.configureSnapshotPreviewsXcodeProject)({
+                    xcodeProject,
+                    hostedTestTargetName: 'ProjectTests',
+                    previewTargetNames: ['Project'],
+                });
+                // -- Assert --
+                const hostedTestTarget = getTargetByName(xcodeProject, 'ProjectTests');
+                (0, vitest_1.expect)(result).toEqual({
+                    changed: true,
+                    failedSnapshotPreferencesTargetNames: ['Project'],
+                    linked: true,
+                });
+                (0, vitest_1.expect)(appTarget.packageProductDependencies).toEqual([]);
+                (0, vitest_1.expect)(hostedTestTarget.packageProductDependencies).toEqual([
+                    vitest_1.expect.objectContaining({ comment: 'SnapshottingTests' }),
+                ]);
+                (0, vitest_1.expect)(objectKeysWithoutComments(xcodeProject.objects.XCSwiftPackageProductDependency)).toHaveLength(1);
+            });
+            (0, vitest_1.it)('does not mutate package state when the hosted test target is missing', () => {
+                // -- Arrange --
+                const xcodeProject = new xcode_manager_1.XcodeProject(singleTargetProjectPath);
+                // -- Act --
+                const result = (0, configure_snapshotpreviews_xcode_project_1.configureSnapshotPreviewsXcodeProject)({
+                    xcodeProject,
+                    hostedTestTargetName: 'MissingTests',
+                });
+                // -- Assert --
+                (0, vitest_1.expect)(result).toEqual({
+                    changed: false,
+                    failedSnapshotPreferencesTargetNames: [],
+                    linked: false,
+                });
+                (0, vitest_1.expect)(xcodeProject.objects.XCRemoteSwiftPackageReference).toBeUndefined();
+                (0, vitest_1.expect)(xcodeProject.objects.XCSwiftPackageProductDependency).toBeUndefined();
+                (0, vitest_1.expect)(xcodeProject.objects.PBXBuildFile).toBeUndefined();
+            });
+            (0, vitest_1.it)('does not link SnapshotPreferences when the hosted test target is missing', () => {
+                // -- Arrange --
+                const xcodeProject = new xcode_manager_1.XcodeProject(singleTargetProjectPath);
+                // -- Act --
+                const result = (0, configure_snapshotpreviews_xcode_project_1.configureSnapshotPreviewsXcodeProject)({
+                    xcodeProject,
+                    hostedTestTargetName: 'MissingTests',
+                    previewTargetNames: ['Project'],
+                });
+                // -- Assert --
+                const appTarget = getTargetByName(xcodeProject, 'Project');
+                (0, vitest_1.expect)(result).toEqual({
+                    changed: false,
+                    failedSnapshotPreferencesTargetNames: [],
+                    linked: false,
+                });
+                (0, vitest_1.expect)(appTarget.packageProductDependencies).toEqual([]);
+                (0, vitest_1.expect)(xcodeProject.objects.XCRemoteSwiftPackageReference).toBeUndefined();
+                (0, vitest_1.expect)(xcodeProject.objects.XCSwiftPackageProductDependency).toBeUndefined();
+                (0, vitest_1.expect)(xcodeProject.objects.PBXBuildFile).toBeUndefined();
+            });
+        });
         (0, vitest_1.describe)('updateXcodeProject', () => {
             let sourceProjectPath;
             let tempProjectPath;
@@ -167,7 +524,7 @@ const projectData = {
                             const generatedShellScript = (0, templates_1.getRunScriptTemplate)(projectData.organization.slug, projectData.slug, variant.uploadSource, variant.includeHomebrewPath);
                             const expectedShellScript = `"${generatedShellScript.replace(/"/g, '\\"')}"`;
                             // -- Act --
-                            xcodeProject.updateXcodeProject(projectData, 'Project', false, // Ignore SPM reference
+                            xcodeProject.updateXcodeProject(projectData, 'Project', undefined, // Ignore SPM reference
                             variant.uploadSource);
                             // -- Assert --
                             const updatedXcodeProject = new xcode_manager_1.XcodeProject(tempProjectPath);
@@ -207,7 +564,7 @@ const projectData = {
                 (0, vitest_1.describe)('upload source is false', () => {
                     (0, vitest_1.it)('should not update the Xcode project', () => {
                         // -- Act --
-                        xcodeProject.updateXcodeProject(projectData, 'Project', false, // Ignore SPM reference
+                        xcodeProject.updateXcodeProject(projectData, 'Project', undefined, // Ignore SPM reference
                         false);
                         // -- Assert --
                         const expectedXcodeProject = new xcode_manager_1.XcodeProject(sourceProjectPath);
@@ -219,7 +576,7 @@ const projectData = {
                     (0, vitest_1.describe)('named target not found', () => {
                         (0, vitest_1.it)('should not update the flags in the Xcode project', () => {
                             // -- Act --
-                            xcodeProject.updateXcodeProject(projectData, 'Invalid Target Name', false, // Ignore SPM reference
+                            xcodeProject.updateXcodeProject(projectData, 'Invalid Target Name', undefined, // Ignore SPM reference
                             uploadSource);
                             // -- Assert --
                             const originalXcodeProject = new xcode_manager_1.XcodeProject(sourceProjectPath);
@@ -230,7 +587,7 @@ const projectData = {
                         (0, vitest_1.describe)('build configurations is undefined', () => {
                             (0, vitest_1.it)('should not update the Xcode project', () => {
                                 // -- Act --
-                                xcodeProject.updateXcodeProject(projectData, 'Invalid Target Name', false, // Ignore SPM reference
+                                xcodeProject.updateXcodeProject(projectData, 'Invalid Target Name', undefined, // Ignore SPM reference
                                 uploadSource);
                                 // -- Assert --
                                 const originalXcodeProject = new xcode_manager_1.XcodeProject(sourceProjectPath);
@@ -242,7 +599,7 @@ const projectData = {
                                 // -- Arrange --
                                 xcodeProject.objects.XCBuildConfiguration = {};
                                 // -- Act --
-                                xcodeProject.updateXcodeProject(projectData, 'Invalid Target Name', false, // Ignore SPM reference
+                                xcodeProject.updateXcodeProject(projectData, 'Invalid Target Name', undefined, // Ignore SPM reference
                                 uploadSource);
                                 // -- Assert --
                                 (0, vitest_1.expect)(xcodeProject.objects.XCBuildConfiguration).toEqual({});
@@ -255,7 +612,7 @@ const projectData = {
                             const releaseTargetBuildConfigurationListId = 'D4E604DE2D50CEEE00CAB00F';
                             (0, vitest_1.it)('should update the target configuration lists', () => {
                                 // -- Act --
-                                xcodeProject.updateXcodeProject(projectData, 'Project', false, // Ignore SPM reference
+                                xcodeProject.updateXcodeProject(projectData, 'Project', undefined, // Ignore SPM reference
                                 uploadSource);
                                 // -- Assert --
                                 (0, vitest_1.expect)(xcodeProject.objects.XCBuildConfiguration).toBeDefined();
@@ -276,7 +633,7 @@ const projectData = {
                             });
                             (0, vitest_1.it)('should not update the project configuration lists', () => {
                                 // -- Act --
-                                xcodeProject.updateXcodeProject(projectData, 'Project', false, // Ignore SPM reference
+                                xcodeProject.updateXcodeProject(projectData, 'Project', undefined, // Ignore SPM reference
                                 uploadSource);
                                 // -- Assert --
                                 (0, vitest_1.expect)(xcodeProject.objects.XCBuildConfiguration).toBeDefined();
@@ -304,44 +661,76 @@ const projectData = {
                 });
             });
             (0, vitest_1.describe)('add SPM reference', () => {
-                const addSPMReference = true;
-                (0, vitest_1.describe)('framework build phase already contains Sentry', () => {
-                    (0, vitest_1.it)('should not update the Xcode project', () => {
-                        // -- Arrange --
-                        xcodeProject.objects.PBXFrameworksBuildPhase = {
-                            'framework-id': {
-                                isa: 'PBXFrameworksBuildPhase',
-                                files: [
-                                    {
-                                        value: '123',
-                                        comment: 'Sentry in Frameworks',
-                                    },
-                                ],
-                            },
-                        };
-                        // -- Act --
-                        xcodeProject.updateXcodeProject(projectData, 'Project', addSPMReference);
-                        // -- Assert --
-                        const expectedXcodeProject = new xcode_manager_1.XcodeProject(sourceProjectPath);
-                        expectedXcodeProject.objects.PBXFrameworksBuildPhase = {
-                            'framework-id': {
-                                isa: 'PBXFrameworksBuildPhase',
-                                files: [
-                                    {
-                                        value: '123',
-                                        comment: 'Sentry in Frameworks',
-                                    },
-                                ],
-                            },
-                        };
-                        (0, vitest_1.expect)(xcodeProject.objects.PBXFrameworksBuildPhase).toEqual(expectedXcodeProject.objects.PBXFrameworksBuildPhase);
-                        (0, vitest_1.expect)(xcodeProject.objects.XCRemoteSwiftPackageReference).toEqual(expectedXcodeProject.objects.XCRemoteSwiftPackageReference);
-                        (0, vitest_1.expect)(xcodeProject.objects.XCSwiftPackageProductDependency).toEqual(expectedXcodeProject.objects.XCSwiftPackageProductDependency);
+                (0, vitest_1.it)('should treat an existing Sentry framework comment on the selected target as already installed', () => {
+                    // -- Arrange --
+                    const frameworksBuildPhase = xcodeProject.objects.PBXFrameworksBuildPhase?.[appFrameworksBuildPhaseId];
+                    if (!frameworksBuildPhase ||
+                        typeof frameworksBuildPhase === 'string') {
+                        throw new Error('Frameworks build phase is undefined');
+                    }
+                    frameworksBuildPhase.files = [
+                        {
+                            value: '123',
+                            comment: 'Sentry in Frameworks',
+                        },
+                    ];
+                    // -- Act --
+                    xcodeProject.updateXcodeProject(projectData, 'Project', sentrySwiftPackageProductLinkOptions);
+                    // -- Assert --
+                    (0, vitest_1.expect)(frameworksBuildPhase.files).toEqual([
+                        {
+                            value: '123',
+                            comment: 'Sentry in Frameworks',
+                        },
+                    ]);
+                    (0, vitest_1.expect)(xcodeProject.objects.XCRemoteSwiftPackageReference).toBeUndefined();
+                    (0, vitest_1.expect)(xcodeProject.objects.XCSwiftPackageProductDependency).toBeUndefined();
+                });
+                (0, vitest_1.it)('should not treat a Sentry framework comment on another target as installed on the selected target', () => {
+                    // -- Arrange --
+                    const hostedTestTargetIds = (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                        projectObjectId,
+                        productsGroupId,
                     });
+                    const testFrameworksBuildPhase = xcodeProject.objects.PBXFrameworksBuildPhase?.[hostedTestTargetIds.frameworksBuildPhaseId];
+                    if (!testFrameworksBuildPhase ||
+                        typeof testFrameworksBuildPhase === 'string') {
+                        throw new Error('Frameworks build phase is undefined');
+                    }
+                    testFrameworksBuildPhase.files = [
+                        {
+                            value: '123',
+                            comment: 'Sentry in Frameworks',
+                        },
+                    ];
+                    // -- Act --
+                    xcodeProject.updateXcodeProject(projectData, 'Project', sentrySwiftPackageProductLinkOptions);
+                    // -- Assert --
+                    (0, vitest_1.expect)(objectKeysWithoutComments(xcodeProject.objects.XCRemoteSwiftPackageReference)).toHaveLength(1);
+                    const appFrameworksBuildPhase = xcodeProject.objects.PBXFrameworksBuildPhase?.[appFrameworksBuildPhaseId];
+                    (0, vitest_1.expect)(typeof appFrameworksBuildPhase !== 'string'
+                        ? appFrameworksBuildPhase?.files?.filter((file) => {
+                            return file.comment === 'Sentry in Frameworks';
+                        })
+                        : []).toHaveLength(1);
+                });
+                (0, vitest_1.it)('should not duplicate the Sentry SPM dependency on repeated runs', () => {
+                    // -- Act --
+                    xcodeProject.updateXcodeProject(projectData, 'Project', sentrySwiftPackageProductLinkOptions);
+                    xcodeProject.updateXcodeProject(projectData, 'Project', sentrySwiftPackageProductLinkOptions);
+                    // -- Assert --
+                    (0, vitest_1.expect)(objectKeysWithoutComments(xcodeProject.objects.XCRemoteSwiftPackageReference)).toHaveLength(1);
+                    (0, vitest_1.expect)(objectKeysWithoutComments(xcodeProject.objects.XCSwiftPackageProductDependency)).toHaveLength(1);
+                    const frameworksBuildPhase = xcodeProject.objects.PBXFrameworksBuildPhase?.[appFrameworksBuildPhaseId];
+                    (0, vitest_1.expect)(typeof frameworksBuildPhase !== 'string'
+                        ? frameworksBuildPhase?.files?.filter((file) => {
+                            return file.comment === 'Sentry in Frameworks';
+                        })
+                        : []).toHaveLength(1);
                 });
                 (0, vitest_1.it)('should add the SPM reference to the target', () => {
                     // -- Act --
-                    xcodeProject.updateXcodeProject(projectData, 'Project', addSPMReference);
+                    xcodeProject.updateXcodeProject(projectData, 'Project', sentrySwiftPackageProductLinkOptions);
                     // -- Assert --
                     // Get the target
                     const target = xcodeProject.objects.PBXNativeTarget?.['D4E604CC2D50CEEC00CAB00F'];
@@ -373,7 +762,7 @@ const projectData = {
                         repositoryURL: '"https://github.com/getsentry/sentry-cocoa/"',
                         requirement: {
                             kind: 'upToNextMajorVersion',
-                            minimumVersion: '8.0.0',
+                            minimumVersion: '9.0.0',
                         },
                     });
                     (0, vitest_1.expect)(remoteSwiftPackageReferences?.[rspRefKeys[1]]).toBe('XCRemoteSwiftPackageReference "sentry-cocoa"');
@@ -396,6 +785,26 @@ const projectData = {
                         productName: 'Sentry',
                     });
                 });
+                (0, vitest_1.it)('should link Sentry only to the selected target', () => {
+                    // -- Arrange --
+                    const hostedTestTargetIds = (0, hosted_test_target_fixture_1.addHostedUnitTestTarget)(xcodeProject, {
+                        projectObjectId,
+                        productsGroupId,
+                    });
+                    // -- Act --
+                    xcodeProject.updateXcodeProject(projectData, 'Project', sentrySwiftPackageProductLinkOptions);
+                    // -- Assert --
+                    const appTarget = getTargetByName(xcodeProject, 'Project');
+                    const hostedTestTarget = getTargetByName(xcodeProject, 'ProjectTests');
+                    (0, vitest_1.expect)(appTarget.packageProductDependencies).toEqual([
+                        vitest_1.expect.objectContaining({ comment: 'Sentry' }),
+                    ]);
+                    (0, vitest_1.expect)(hostedTestTarget.packageProductDependencies).toEqual([]);
+                    const testFrameworksBuildPhase = xcodeProject.objects.PBXFrameworksBuildPhase?.[hostedTestTargetIds.frameworksBuildPhaseId];
+                    (0, vitest_1.expect)(typeof testFrameworksBuildPhase !== 'string'
+                        ? testFrameworksBuildPhase?.files
+                        : undefined).toEqual([]);
+                });
                 (0, vitest_1.it)('should initialize packageProductDependencies if not present', () => {
                     // -- Arrange --
                     // Ensure the target exists but has no packageProductDependencies initially
@@ -406,7 +815,7 @@ const projectData = {
                         delete target.packageProductDependencies;
                     }
                     // -- Act --
-                    xcodeProject.updateXcodeProject(projectData, 'Project', addSPMReference);
+                    xcodeProject.updateXcodeProject(projectData, 'Project', sentrySwiftPackageProductLinkOptions);
                     // -- Assert --
                     const updatedTarget = xcodeProject.objects.PBXNativeTarget?.[targetKey];
                     (0, vitest_1.expect)(updatedTarget.packageProductDependencies).toBeDefined();