@sentry/warden 0.1.1 → 0.3.0

package/src/cli/fix.test.ts

@@ -1,310 +0,0 @@
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
-import { mkdirSync, writeFileSync, readFileSync, rmSync } from 'node:fs';
-import { join } from 'node:path';
-import { tmpdir } from 'node:os';
-import {
-  applyUnifiedDiff,
-  collectFixableFindings,
-  applyAllFixes,
-} from './fix.js';
-import type { Finding, SkillReport } from '../types/index.js';
-
-describe('applyUnifiedDiff', () => {
-  let testDir: string;
-
-  beforeEach(() => {
-    testDir = join(tmpdir(), `warden-fix-test-${Date.now()}`);
-    mkdirSync(testDir, { recursive: true });
-  });
-
-  afterEach(() => {
-    rmSync(testDir, { recursive: true, force: true });
-  });
-
-  it('applies a single-line replacement', () => {
-    const filePath = join(testDir, 'test.ts');
-    writeFileSync(filePath, 'const x = "hello";\nconst y = "world";\n');
-
-    const diff = `@@ -1,2 +1,2 @@
--const x = "hello";
-+const x = "goodbye";
- const y = "world";`;
-
-    applyUnifiedDiff(filePath, diff);
-
-    const result = readFileSync(filePath, 'utf-8');
-    expect(result).toBe('const x = "goodbye";\nconst y = "world";\n');
-  });
-
-  it('applies a multi-line addition', () => {
-    const filePath = join(testDir, 'test.ts');
-    writeFileSync(filePath, 'function foo() {\n  return 1;\n}\n');
-
-    const diff = `@@ -1,3 +1,5 @@
- function foo() {
-+  // Added comment
-+  const x = 1;
-   return 1;
- }`;
-
-    applyUnifiedDiff(filePath, diff);
-
-    const result = readFileSync(filePath, 'utf-8');
-    expect(result).toBe('function foo() {\n  // Added comment\n  const x = 1;\n  return 1;\n}\n');
-  });
-
-  it('applies a multi-line deletion', () => {
-    const filePath = join(testDir, 'test.ts');
-    writeFileSync(filePath, 'line1\nline2\nline3\nline4\n');
-
-    const diff = `@@ -1,4 +1,2 @@
- line1
--line2
--line3
- line4`;
-
-    applyUnifiedDiff(filePath, diff);
-
-    const result = readFileSync(filePath, 'utf-8');
-    expect(result).toBe('line1\nline4\n');
-  });
-
-  it('applies multiple hunks in reverse order', () => {
-    const filePath = join(testDir, 'test.ts');
-    writeFileSync(filePath, 'a\nb\nc\nd\ne\nf\ng\n');
-
-    // Two hunks: one at line 2, one at line 6
-    const diff = `@@ -2,1 +2,1 @@
--b
-+B
-@@ -6,1 +6,1 @@
--f
-+F`;
-
-    applyUnifiedDiff(filePath, diff);
-
-    const result = readFileSync(filePath, 'utf-8');
-    expect(result).toBe('a\nB\nc\nd\ne\nF\ng\n');
-  });
-
-  it('throws error for non-existent file', () => {
-    const filePath = join(testDir, 'nonexistent.ts');
-    const diff = `@@ -1,1 +1,1 @@
--old
-+new`;
-
-    expect(() => applyUnifiedDiff(filePath, diff)).toThrow('File not found');
-  });
-
-  it('throws error for context mismatch', () => {
-    const filePath = join(testDir, 'test.ts');
-    writeFileSync(filePath, 'actual content\n');
-
-    const diff = `@@ -1,1 +1,1 @@
--expected content
-+new content`;
-
-    expect(() => applyUnifiedDiff(filePath, diff)).toThrow('context mismatch');
-  });
-
-  it('throws error for empty diff', () => {
-    const filePath = join(testDir, 'test.ts');
-    writeFileSync(filePath, 'content\n');
-
-    expect(() => applyUnifiedDiff(filePath, '')).toThrow('No valid hunks');
-  });
-});
-
-describe('collectFixableFindings', () => {
-  it('returns empty array when no findings have fixes', () => {
-    const reports: SkillReport[] = [
-      {
-        skill: 'test',
-        summary: 'Test summary',
-        findings: [
-          {
-            id: '1',
-            severity: 'high',
-            title: 'Test finding',
-            description: 'No fix available',
-          },
-        ],
-      },
-    ];
-
-    const result = collectFixableFindings(reports);
-    expect(result).toEqual([]);
-  });
-
-  it('returns only findings with both diff and location', () => {
-    const fixableFinding: Finding = {
-      id: '1',
-      severity: 'high',
-      title: 'Fixable',
-      description: 'Has fix',
-      location: { path: 'test.ts', startLine: 10 },
-      suggestedFix: { description: 'Fix it', diff: '@@ -10,1 +10,1 @@\n-old\n+new' },
-    };
-
-    const noLocation: Finding = {
-      id: '2',
-      severity: 'high',
-      title: 'No location',
-      description: 'Missing location',
-      suggestedFix: { description: 'Fix it', diff: '@@ -1,1 +1,1 @@\n-old\n+new' },
-    };
-
-    const noDiff: Finding = {
-      id: '3',
-      severity: 'high',
-      title: 'No diff',
-      description: 'Missing diff',
-      location: { path: 'test.ts', startLine: 5 },
-    };
-
-    const reports: SkillReport[] = [
-      {
-        skill: 'test',
-        summary: 'Test',
-        findings: [fixableFinding, noLocation, noDiff],
-      },
-    ];
-
-    const result = collectFixableFindings(reports);
-    expect(result).toHaveLength(1);
-    expect(result[0]?.id).toBe('1');
-  });
-
-  it('sorts findings by file then by line (descending)', () => {
-    const finding1: Finding = {
-      id: '1',
-      severity: 'high',
-      title: 'F1',
-      description: 'D1',
-      location: { path: 'b.ts', startLine: 10 },
-      suggestedFix: { description: 'Fix', diff: '@@ -10,1 +10,1 @@\n-x\n+y' },
-    };
-
-    const finding2: Finding = {
-      id: '2',
-      severity: 'high',
-      title: 'F2',
-      description: 'D2',
-      location: { path: 'a.ts', startLine: 20 },
-      suggestedFix: { description: 'Fix', diff: '@@ -20,1 +20,1 @@\n-x\n+y' },
-    };
-
-    const finding3: Finding = {
-      id: '3',
-      severity: 'high',
-      title: 'F3',
-      description: 'D3',
-      location: { path: 'a.ts', startLine: 5 },
-      suggestedFix: { description: 'Fix', diff: '@@ -5,1 +5,1 @@\n-x\n+y' },
-    };
-
-    const reports: SkillReport[] = [
-      { skill: 'test', summary: 'Test', findings: [finding1, finding2, finding3] },
-    ];
-
-    const result = collectFixableFindings(reports);
-    expect(result).toHaveLength(3);
-    // Sorted: a.ts:20, a.ts:5, b.ts:10
-    expect(result[0]?.id).toBe('2'); // a.ts:20
-    expect(result[1]?.id).toBe('3'); // a.ts:5
-    expect(result[2]?.id).toBe('1'); // b.ts:10
-  });
-});
-
-describe('applyAllFixes', () => {
-  let testDir: string;
-
-  beforeEach(() => {
-    testDir = join(tmpdir(), `warden-fix-test-${Date.now()}`);
-    mkdirSync(testDir, { recursive: true });
-  });
-
-  afterEach(() => {
-    rmSync(testDir, { recursive: true, force: true });
-  });
-
-  it('applies all valid fixes', () => {
-    const filePath = join(testDir, 'test.ts');
-    writeFileSync(filePath, 'line1\nline2\nline3\n');
-
-    const findings: Finding[] = [
-      {
-        id: '1',
-        severity: 'high',
-        title: 'Fix line 2',
-        description: 'Change line 2',
-        location: { path: filePath, startLine: 2 },
-        suggestedFix: { description: 'Fix', diff: '@@ -2,1 +2,1 @@\n-line2\n+LINE2' },
-      },
-    ];
-
-    const summary = applyAllFixes(findings);
-
-    expect(summary.applied).toBe(1);
-    expect(summary.failed).toBe(0);
-    expect(summary.skipped).toBe(0);
-
-    const result = readFileSync(filePath, 'utf-8');
-    expect(result).toBe('line1\nLINE2\nline3\n');
-  });
-
-  it('handles failed fixes and continues', () => {
-    const filePath = join(testDir, 'test.ts');
-    writeFileSync(filePath, 'actual\n');
-
-    const findings: Finding[] = [
-      {
-        id: '1',
-        severity: 'high',
-        title: 'Bad fix',
-        description: 'Wrong context',
-        location: { path: filePath, startLine: 1 },
-        suggestedFix: { description: 'Fix', diff: '@@ -1,1 +1,1 @@\n-wrong\n+new' },
-      },
-    ];
-
-    const summary = applyAllFixes(findings);
-
-    expect(summary.applied).toBe(0);
-    expect(summary.failed).toBe(1);
-    expect(summary.results[0]?.error).toContain('mismatch');
-  });
-
-  it('applies multiple fixes to same file in correct order', () => {
-    const filePath = join(testDir, 'test.ts');
-    writeFileSync(filePath, 'a\nb\nc\nd\ne\n');
-
-    // Findings already sorted by line descending
-    const findings: Finding[] = [
-      {
-        id: '1',
-        severity: 'high',
-        title: 'Fix line 4',
-        description: 'Change d',
-        location: { path: filePath, startLine: 4 },
-        suggestedFix: { description: 'Fix', diff: '@@ -4,1 +4,1 @@\n-d\n+D' },
-      },
-      {
-        id: '2',
-        severity: 'high',
-        title: 'Fix line 2',
-        description: 'Change b',
-        location: { path: filePath, startLine: 2 },
-        suggestedFix: { description: 'Fix', diff: '@@ -2,1 +2,1 @@\n-b\n+B' },
-      },
-    ];
-
-    const summary = applyAllFixes(findings);
-
-    expect(summary.applied).toBe(2);
-    expect(summary.failed).toBe(0);
-
-    const result = readFileSync(filePath, 'utf-8');
-    expect(result).toBe('a\nB\nc\nD\ne\n');
-  });
-});

package/src/cli/fix.ts

@@ -1,387 +0,0 @@
-/**
- * Fix application functionality for the warden CLI.
- */
-
-import { readFileSync, writeFileSync, existsSync } from 'node:fs';
-import chalk from 'chalk';
-import figures from 'figures';
-import type { Finding, SkillReport } from '../types/index.js';
-import { parsePatch, type DiffHunk } from '../diff/index.js';
-import { pluralize, type Reporter } from './output/index.js';
-import { ICON_CHECK } from './output/icons.js';
-import { Verbosity } from './output/verbosity.js';
-
-export interface FixResult {
-  success: boolean;
-  finding: Finding;
-  error?: string;
-}
-
-export interface FixSummary {
-  applied: number;
-  skipped: number;
-  failed: number;
-  results: FixResult[];
-}
-
-/**
- * Apply a unified diff to a file.
- * Hunks are applied in reverse order by line number to prevent line shift issues.
- */
-export function applyUnifiedDiff(filePath: string, diff: string): void {
-  if (!existsSync(filePath)) {
-    throw new Error(`File not found: ${filePath}`);
-  }
-
-  const hunks = parsePatch(diff);
-  if (hunks.length === 0) {
-    throw new Error('No valid hunks found in diff');
-  }
-
-  const content = readFileSync(filePath, 'utf-8');
-  let lines = content.split('\n');
-
-  // Sort hunks by oldStart in descending order to apply from bottom to top
-  const sortedHunks = [...hunks].sort((a, b) => b.oldStart - a.oldStart);
-
-  for (const hunk of sortedHunks) {
-    lines = applyHunk(lines, hunk);
-  }
-
-  writeFileSync(filePath, lines.join('\n'));
-}
-
-/**
- * Apply a single hunk to the file content lines.
- */
-function applyHunk(lines: string[], hunk: DiffHunk): string[] {
-  const result = [...lines];
-
-  // Parse hunk lines into operations
-  const oldLines: string[] = [];
-  const newLines: string[] = [];
-
-  for (const line of hunk.lines) {
-    if (line.startsWith('-')) {
-      oldLines.push(line.slice(1));
-    } else if (line.startsWith('+')) {
-      newLines.push(line.slice(1));
-    } else if (line.startsWith(' ') || line === '') {
-      // Context line - should match in both
-      const contextLine = line.startsWith(' ') ? line.slice(1) : line;
-      oldLines.push(contextLine);
-      newLines.push(contextLine);
-    }
-  }
-
-  // The start index is 0-based (hunk.oldStart is 1-based)
-  const startIndex = hunk.oldStart - 1;
-
-  // Verify the old lines match (context check)
-  for (let i = 0; i < oldLines.length; i++) {
-    const lineIndex = startIndex + i;
-    if (lineIndex >= result.length) {
-      throw new Error(`Hunk context mismatch: line ${lineIndex + 1} doesn't exist`);
-    }
-    if (result[lineIndex] !== oldLines[i]) {
-      throw new Error(
-        `Hunk context mismatch at line ${lineIndex + 1}: ` +
-        `expected "${oldLines[i]}", got "${result[lineIndex]}"`
-      );
-    }
-  }
-
-  // Replace the old lines with new lines
-  result.splice(startIndex, oldLines.length, ...newLines);
-
-  return result;
-}
-
-/**
- * Collect all fixable findings from skill reports.
- * A finding is fixable if it has both a suggestedFix.diff and a location.path.
- * Findings are sorted by file, then by line number (descending).
- */
-export function collectFixableFindings(reports: SkillReport[]): Finding[] {
-  const fixable: Finding[] = [];
-
-  for (const report of reports) {
-    for (const finding of report.findings) {
-      if (finding.suggestedFix?.diff && finding.location?.path) {
-        fixable.push(finding);
-      }
-    }
-  }
-
-  // Sort by file, then by line number descending
-  // Note: location is guaranteed non-null by the filter above
-  return fixable.sort((a, b) => {
-    const aLoc = a.location;
-    const bLoc = b.location;
-    if (!aLoc || !bLoc) return 0;
-    const pathCompare = aLoc.path.localeCompare(bLoc.path);
-    if (pathCompare !== 0) return pathCompare;
-    // Descending by line number
-    return bLoc.startLine - aLoc.startLine;
-  });
-}
-
-/**
- * Apply all fixes without prompting.
- */
-export function applyAllFixes(findings: Finding[]): FixSummary {
-  const results: FixResult[] = [];
-  let applied = 0;
-  let failed = 0;
-
-  for (const finding of findings) {
-    const location = finding.location;
-    const suggestedFix = finding.suggestedFix;
-    if (!location || !suggestedFix?.diff) continue;
-
-    try {
-      applyUnifiedDiff(location.path, suggestedFix.diff);
-      results.push({ success: true, finding });
-      applied++;
-    } catch (err) {
-      const error = err instanceof Error ? err.message : String(err);
-      results.push({ success: false, finding, error });
-      failed++;
-    }
-  }
-
-  return {
-    applied,
-    skipped: 0,
-    failed,
-    results,
-  };
-}
-
-/**
- * Format a diff for display with colors.
- */
-function formatDiffForDisplay(diff: string): string[] {
-  return diff.split('\n').map((line) => {
-    if (line.startsWith('+') && !line.startsWith('+++')) {
-      return chalk.green(line);
-    } else if (line.startsWith('-') && !line.startsWith('---')) {
-      return chalk.red(line);
-    } else if (line.startsWith('@@')) {
-      return chalk.cyan(line);
-    }
-    return line;
-  });
-}
-
-/**
- * Read a single keypress from stdin in raw mode.
- */
-async function readSingleKey(): Promise<string> {
-  return new Promise((resolve) => {
-    const stdin = process.stdin;
-    const wasRaw = stdin.isRaw;
-
-    stdin.setRawMode(true);
-    stdin.resume();
-
-    stdin.once('data', (data) => {
-      stdin.setRawMode(wasRaw);
-      stdin.pause();
-
-      const key = data.toString();
-
-      // Handle Ctrl+C
-      if (key === '\x03') {
-        process.stderr.write('\n');
-        process.exit(130);
-      }
-
-      resolve(key.toLowerCase());
-    });
-  });
-}
-
-/**
- * Prompt the user for a yes/no/quit response.
- * Accepts single keypress without requiring Enter.
- */
-async function promptYNQ(message: string): Promise<'y' | 'n' | 'q'> {
-  process.stderr.write(message);
-
-  const key = await readSingleKey();
-  process.stderr.write(key + '\n');
-
-  switch (key) {
-    case 'y':
-      return 'y';
-    case 'q':
-      return 'q';
-    default:
-      return 'n';
-  }
-}
-
-/**
- * Prompt the user for a yes/no response.
- * Accepts single keypress without requiring Enter.
- */
-async function promptYN(message: string): Promise<boolean> {
-  process.stderr.write(message);
-
-  const key = await readSingleKey();
-  process.stderr.write(key + '\n');
-
-  return key === 'y';
-}
-
-/**
- * Run the interactive fix flow.
- * Displays each fix with a colored diff and prompts the user.
- */
-export async function runInteractiveFixFlow(
-  findings: Finding[],
-  reporter: Reporter
-): Promise<FixSummary> {
-  const results: FixResult[] = [];
-  let applied = 0;
-  let skipped = 0;
-  let failed = 0;
-
-  // Ask if user wants to apply fixes
-  reporter.blank();
-  const shouldProceed = await promptYN(
-    chalk.bold(`${findings.length} ${pluralize(findings.length, 'fix', 'fixes')} available. Apply fixes? [y/N] `)
-  );
-
-  if (!shouldProceed) {
-    return {
-      applied: 0,
-      skipped: findings.length,
-      failed: 0,
-      results: findings.map((f) => ({ success: false, finding: f })),
-    };
-  }
-
-  reporter.blank();
-
-  for (let idx = 0; idx < findings.length; idx++) {
-    const finding = findings[idx];
-    if (!finding) continue;
-
-    const location = finding.location;
-    const suggestedFix = finding.suggestedFix;
-    if (!location || !suggestedFix?.diff) continue;
-
-    // Display fix info
-    console.error(chalk.bold(`Fix for: ${finding.title}`));
-    console.error(chalk.dim(`  ${location.path}:${location.startLine}`));
-
-    if (suggestedFix.description) {
-      console.error(`  ${suggestedFix.description}`);
-    }
-
-    console.error('');
-
-    // Display the diff
-    const diffLines = formatDiffForDisplay(suggestedFix.diff);
-    for (const line of diffLines) {
-      console.error(`  ${line}`);
-    }
-
-    console.error('');
-
-    // Prompt for this fix
-    const response = await promptYNQ('Apply this fix? [y/n/q] ');
-
-    if (response === 'q') {
-      // Quit - mark remaining as skipped
-      skipped++;
-      results.push({ success: false, finding });
-
-      // Skip remaining
-      for (let i = idx + 1; i < findings.length; i++) {
-        const remainingFinding = findings[i];
-        if (remainingFinding) {
-          skipped++;
-          results.push({ success: false, finding: remainingFinding });
-        }
-      }
-      break;
-    }
-
-    if (response === 'n') {
-      skipped++;
-      results.push({ success: false, finding });
-      console.error(chalk.yellow(`${figures.arrowRight} Skipped`));
-      console.error('');
-      continue;
-    }
-
-    // Apply the fix
-    try {
-      applyUnifiedDiff(location.path, suggestedFix.diff);
-      applied++;
-      results.push({ success: true, finding });
-      console.error(chalk.green(`${ICON_CHECK} Applied fix for: ${finding.title}`));
-    } catch (err) {
-      const error = err instanceof Error ? err.message : String(err);
-      failed++;
-      results.push({ success: false, finding, error });
-      console.error(chalk.red(`${figures.cross} Failed: ${error}`));
-    }
-
-    console.error('');
-  }
-
-  return {
-    applied,
-    skipped,
-    failed,
-    results,
-  };
-}
-
-/**
- * Render the fix summary.
- */
-export function renderFixSummary(summary: FixSummary, reporter: Reporter): void {
-  if (summary.applied === 0 && summary.failed === 0 && summary.skipped === 0) {
-    return;
-  }
-
-  reporter.blank();
-
-  if (reporter.verbosity === Verbosity.Quiet) {
-    // Quiet mode: just counts
-    const parts: string[] = [];
-    if (summary.applied > 0) parts.push(`${summary.applied} applied`);
-    if (summary.skipped > 0) parts.push(`${summary.skipped} skipped`);
-    if (summary.failed > 0) parts.push(`${summary.failed} failed`);
-    console.log(`Fixes: ${parts.join(', ')}`);
-    return;
-  }
-
-  console.error(chalk.bold('FIXES'));
-
-  const parts: string[] = [];
-  if (summary.applied > 0) {
-    parts.push(chalk.green(`${summary.applied} applied`));
-  }
-  if (summary.skipped > 0) {
-    parts.push(chalk.yellow(`${summary.skipped} skipped`));
-  }
-  if (summary.failed > 0) {
-    parts.push(chalk.red(`${summary.failed} failed`));
-  }
-
-  console.error(parts.join('  '));
-
-  // Show failed fix details
-  const failedResults = summary.results.filter((r) => !r.success && r.error);
-  for (const result of failedResults) {
-    console.error(
-      chalk.red(`  ${figures.cross} ${result.finding.title}: ${result.error}`)
-    );
-  }
-}