@sentry/replay 8.0.0-alpha.1 → 8.0.0-alpha.2

package/esm/index.js

@@ -1,6 +1,6 @@
 import { _nullishCoalesce, _optionalChain } from '@sentry/utils';
 import { addBreadcrumb, getClient, isSentryRequestUrl, addEventProcessor, prepareEvent, getIsolationScope, getCurrentScope, setContext, captureException, spanToJSON, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE } from '@sentry/core';
-import { GLOBAL_OBJ, normalize, fill, htmlTreeAsString, browserPerformanceTimeOrigin, logger, uuid4, dropUndefinedKeys, stringMatchesSomePattern, SENTRY_XHR_DATA_KEY, addClickKeypressInstrumentationHandler, addHistoryInstrumentationHandler, createEnvelope, createEventEnvelopeHeaders, getSdkMetadataForEnvelopeHeader, updateRateLimits, isRateLimited, consoleSandbox, isBrowser } from '@sentry/utils';
+import { GLOBAL_OBJ, normalize, fill, htmlTreeAsString, browserPerformanceTimeOrigin, logger, uuid4, dropUndefinedKeys, stringMatchesSomePattern, SENTRY_XHR_DATA_KEY, addClickKeypressInstrumentationHandler, addHistoryInstrumentationHandler, createEnvelope, createEventEnvelopeHeaders, getSdkMetadataForEnvelopeHeader, resolvedSyncPromise, updateRateLimits, isRateLimited, consoleSandbox, isBrowser } from '@sentry/utils';
 import { addPerformanceInstrumentationHandler, addLcpInstrumentationHandler } from '@sentry-internal/tracing';
 
 // exporting a separate copy of `WINDOW` rather than exporting the one from `@sentry/browser`
@@ -5708,10 +5708,6 @@ function isFeedbackEvent(event) {
  * Returns a listener to be added to `client.on('afterSendErrorEvent, listener)`.
  */
 function handleAfterSendEvent(replay) {
-  // Custom transports may still be returning `Promise<void>`, which means we cannot expect the status code to be available there
-  // TODO (v8): remove this check as it will no longer be necessary
-  const enforceStatusCode = isBaseTransportSend();
-
   return (event, sendResponse) => {
     if (!replay.isEnabled() || (!isErrorEvent(event) && !isTransactionEvent(event))) {
       return;
@@ -5722,7 +5718,7 @@ function handleAfterSendEvent(replay) {
     // We only want to do stuff on successful error sending, otherwise you get error replays without errors attached
     // If not using the base transport, we allow `undefined` response (as a custom transport may not implement this correctly yet)
     // If we do use the base transport, we skip if we encountered an non-OK status code
-    if (enforceStatusCode && (!statusCode || statusCode < 200 || statusCode >= 300)) {
+    if (!statusCode || statusCode < 200 || statusCode >= 300) {
       return;
     }
 
@@ -5778,22 +5774,6 @@ function handleErrorEvent(replay, event) {
   });
 }
 
-function isBaseTransportSend() {
-  const client = getClient();
-  if (!client) {
-    return false;
-  }
-
-  const transport = client.getTransport();
-  if (!transport) {
-    return false;
-  }
-
-  return (
-    (transport.send ).__sentry__baseTransport__ || false
-  );
-}
-
 /**
  * Returns a listener to be added to `client.on('afterSendErrorEvent, listener)`.
  */
@@ -7460,7 +7440,7 @@ async function sendReplayRequest({
   const dsn = client && client.getDsn();
 
   if (!client || !transport || !dsn || !session.sampled) {
-    return;
+    return resolvedSyncPromise({});
   }
 
   const baseEvent = {
@@ -7481,7 +7461,7 @@ async function sendReplayRequest({
     // Taken from baseclient's `_processEvent` method, where this is handled for errors/transactions
     client.recordDroppedEvent('event_processor', 'replay', baseEvent);
     logInfo('An event processor returned `null`, will not send event.');
-    return;
+    return resolvedSyncPromise({});
   }
 
   /*
@@ -7543,11 +7523,6 @@ async function sendReplayRequest({
     throw error;
   }
 
-  // TODO (v8): we can remove this guard once transport.send's type signature doesn't include void anymore
-  if (!response) {
-    return response;
-  }
-
   // If the status code is invalid, we want to immediately stop & not retry
   if (typeof response.statusCode === 'number' && (response.statusCode < 200 || response.statusCode >= 300)) {
     throw new TransportStatusCodeError(response.statusCode);