@sentry/profiling-node 8.54.0 → 9.0.0-alpha.0

package/README.md

@@ -12,8 +12,7 @@
 
 ## Installation
 
-Profiling works as an extension of tracing so you will need both @sentry/node and @sentry/profiling-node installed. The
-minimum required major version of @sentry/node that supports profiling is 7.x.
+Profiling works as an extension of tracing so you will need both @sentry/node and @sentry/profiling-node installed.
 
 ```bash
 # Using yarn
@@ -84,7 +83,7 @@ After the binaries are built, you should see them inside the profiling-node/lib
 
 ### Prebuilt binaries
 
-We currently ship prebuilt binaries for a few of the most common platforms and node versions (v16-22).
+We currently ship prebuilt binaries for a few of the most common platforms and node versions (v18-22).
 
 - macOS x64
 - Linux ARM64 (musl)

package/lib/cjs/index.js

@@ -1,10 +1,4 @@
-var {
-  _nullishCoalesce,
-  _optionalChain,
-  _optionalChainDelete
-} = require('@sentry/core');
-
-Object.defineProperty(exports, '__esModule', { value: true });
+Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
 
 const core = require('@sentry/core');
 const node_module = require('node:module');
@@ -228,7 +222,6 @@ const CpuProfilerBindings = new Bindings();
 const NODE_VERSION = core.parseSemver(process.versions.node) ;
 const NODE_MAJOR = NODE_VERSION.major;
 
-function _nullishCoalesce$1(lhs, rhsFn) { if (lhs != null) { return lhs; } else { return rhsFn(); } }function _optionalChain$1(ops) { let lastAccessLHS = undefined; let value = ops[0]; let i = 1; while (i < ops.length) { const op = ops[i]; const fn = ops[i + 1]; i += 2; if ((op === 'optionalAccess' || op === 'optionalCall') && value == null) { return undefined; } if (op === 'access' || op === 'optionalAccess') { lastAccessLHS = value; value = fn(value); } else if (op === 'call' || op === 'optionalCall') { value = fn((...args) => value.call(lastAccessLHS, ...args)); lastAccessLHS = undefined; } } return value; }
 // We require the file because if we import it, it will be included in the bundle.
 // I guess tsc does not check file contents when it's imported.
 const PROFILER_THREAD_ID_STRING = String(worker_threads.threadId);
@@ -236,16 +229,12 @@ const PROFILER_THREAD_NAME = worker_threads.isMainThread ? 'main' : 'worker';
 const FORMAT_VERSION = '1';
 const CONTINUOUS_FORMAT_VERSION = '2';
 
-// Os machine was backported to 16.18, but this was not reflected in the types
-// @ts-expect-error ignore missing
-const machine = typeof os.machine === 'function' ? os.machine() : os.arch();
-
 // Machine properties (eval only once)
 const PLATFORM = os.platform();
 const RELEASE = os.release();
 const VERSION = os.version();
 const TYPE = os.type();
-const MODEL = machine;
+const MODEL = os.machine();
 const ARCH = os.arch();
 
 /**
@@ -297,12 +286,12 @@ function createProfilingEvent(client, profile, event) {
   }
 
   return createProfilePayload(client, profile, {
-    release: _nullishCoalesce$1(event.release, () => ( '')),
-    environment: _nullishCoalesce$1(event.environment, () => ( '')),
-    event_id: _nullishCoalesce$1(event.event_id, () => ( '')),
-    transaction: _nullishCoalesce$1(event.transaction, () => ( '')),
+    release: event.release ?? '',
+    environment: event.environment ?? '',
+    event_id: event.event_id ?? '',
+    transaction: event.transaction ?? '',
     start_timestamp: event.start_timestamp ? event.start_timestamp * 1000 : Date.now(),
-    trace_id: _nullishCoalesce$1(_optionalChain$1([event, 'access', _ => _.contexts, 'optionalAccess', _2 => _2['trace'], 'optionalAccess', _3 => _3['trace_id']]), () => ( '')),
+    trace_id: event.contexts?.['trace']?.['trace_id'] ?? '',
     profile_id: profile.profile_id,
   });
 }
@@ -331,7 +320,7 @@ function createProfilePayload(
   // Log a warning if the profile has an invalid traceId (should be uuidv4).
   // All profiles and transactions are rejected if this is the case and we want to
   // warn users that this is happening if they enable debug flag
-  if (trace_id && trace_id.length !== 32) {
+  if (trace_id?.length !== 32) {
     DEBUG_BUILD && core.logger.log(`[Profiling] Invalid traceId: ${trace_id} on profiled event`);
   }
 
@@ -399,7 +388,7 @@ function createProfileChunkPayload(
   // Log a warning if the profile has an invalid traceId (should be uuidv4).
   // All profiles and transactions are rejected if this is the case and we want to
   // warn users that this is happening if they enable debug flag
-  if (trace_id && trace_id.length !== 32) {
+  if (trace_id?.length !== 32) {
     DEBUG_BUILD && core.logger.log(`[Profiling] Invalid traceId: ${trace_id} on profiled event`);
   }
 
@@ -408,8 +397,8 @@ function createProfileChunkPayload(
   const profile = {
     chunk_id: chunk_id,
     client_sdk: {
-      name: _nullishCoalesce$1(_optionalChain$1([sdk, 'optionalAccess', _4 => _4.name]), () => ( 'sentry.javascript.node')),
-      version: _nullishCoalesce$1(_optionalChain$1([sdk, 'optionalAccess', _5 => _5.version]), () => ( '0.0.0')),
+      name: sdk?.name ?? 'sentry.javascript.node',
+      version: sdk?.version ?? '0.0.0',
     },
     profiler_id: profiler_id,
     platform: 'node',
@@ -441,9 +430,9 @@ function createProfilingChunkEvent(
   }
 
   return createProfileChunkPayload(client, profile, {
-    release: _nullishCoalesce$1(options.release, () => ( '')),
-    environment: _nullishCoalesce$1(options.environment, () => ( '')),
-    trace_id: _nullishCoalesce$1(identifiers.trace_id, () => ( '')),
+    release: options.release ?? '',
+    environment: options.environment ?? '',
+    trace_id: identifiers.trace_id ?? '',
     chunk_id: identifiers.chunk_id,
     profiler_id: identifiers.profiler_id,
     sdk,
@@ -561,7 +550,7 @@ function findProfiledTransactionsFromEnvelope(envelope) {
       }
 
       // @ts-expect-error profile_id is not part of the metadata type
-      const profile_id = _optionalChain$1([(event.contexts ), 'optionalAccess', _6 => _6['profile'], 'optionalAccess', _7 => _7['profile_id']]);
+      const profile_id = (event.contexts )?.['profile']?.['profile_id'];
 
       if (event && profile_id) {
         events.push(item[j] );
@@ -615,7 +604,7 @@ function makeProfileChunkEnvelope(
 function applyDebugMetadata(client, resource_paths) {
   const options = client.getOptions();
 
-  if (!options || !options.stackParser) {
+  if (!options?.stackParser) {
     return [];
   }
 
@@ -664,10 +653,6 @@ function maybeProfileSpan(
     profilesSampleRate = profilesSampler({
       name: spanName,
       attributes: data,
-      transactionContext: {
-        name: spanName,
-        parentSampled,
-      },
       parentSampled,
       ...customSamplingContext,
     });
@@ -746,7 +731,7 @@ function stopSpanProfile(span, profile_id) {
   return profile;
 }
 
-var ProfileFormat;(function (ProfileFormat) {
+var ProfileFormat; (function (ProfileFormat) {
   const THREAD = 0; ProfileFormat[ProfileFormat["THREAD"] = THREAD] = "THREAD";
   const CHUNK = 1; ProfileFormat[ProfileFormat["CHUNK"] = CHUNK] = "CHUNK";
 })(ProfileFormat || (ProfileFormat = {}));
@@ -783,8 +768,7 @@ function setupAutomatedSpanProfiling(client) {
       const options = client.getOptions();
       // Not intended for external use, hence missing types, but we want to profile a couple of things at Sentry that
       // currently exceed the default timeout set by the SDKs.
-      const maxProfileDurationMs =
-        (options._experiments && options._experiments['maxProfileDurationMs']) || MAX_PROFILE_DURATION_MS;
+      const maxProfileDurationMs = options._experiments?.maxProfileDurationMs || MAX_PROFILE_DURATION_MS;
 
       if (PROFILE_TIMEOUTS[profile_id]) {
         global.clearTimeout(PROFILE_TIMEOUTS[profile_id]);
@@ -842,8 +826,8 @@ function setupAutomatedSpanProfiling(client) {
     const profilesToAddToEnvelope = [];
 
     for (const profiledTransaction of profiledTransactionEvents) {
-      const profileContext = _optionalChain([profiledTransaction, 'access', _ => _.contexts, 'optionalAccess', _2 => _2['profile']]);
-      const profile_id = _optionalChain([profileContext, 'optionalAccess', _3 => _3['profile_id']]);
+      const profileContext = profiledTransaction.contexts?.['profile'];
+      const profile_id = profileContext?.['profile_id'];
 
       if (!profile_id) {
         throw new TypeError('[Profiling] cannot find profile for a transaction without a profile context');
@@ -851,7 +835,7 @@ function setupAutomatedSpanProfiling(client) {
 
       // Remove the profile from the transaction context before sending, relay will take care of the rest.
       if (profileContext) {
-         _optionalChainDelete([profiledTransaction, 'access', _4 => _4.contexts, 'optionalAccess', _5 => delete _5['profile']]);
+        delete profiledTransaction.contexts?.['profile'];
       }
 
       const cpuProfile = takeFromProfileQueue(profile_id);
@@ -869,6 +853,11 @@ function setupAutomatedSpanProfiling(client) {
       client.emit('preprocessEvent', profile, {
         event_id: profiledTransaction.event_id,
       });
+
+      // @ts-expect-error profile does not inherit from Event
+      client.emit('postprocessEvent', profile, {
+        event_id: profiledTransaction.event_id,
+      });
     }
 
     addProfilesToEnvelope(envelope, profilesToAddToEnvelope);
@@ -951,7 +940,7 @@ class ContinuousProfiler {constructor() { ContinuousProfiler.prototype.__init.ca
    * Stops profiling of the current chunks and flushes the profile to Sentry
    */
    _chunkStop() {
-    if (_optionalChain([this, 'access', _6 => _6._chunkData, 'optionalAccess', _7 => _7.timer])) {
+    if (this._chunkData?.timer) {
       global.clearTimeout(this._chunkData.timer);
       this._chunkData.timer = undefined;
       DEBUG_BUILD && core.logger.log(`[Profiling] Stopping profiling chunk: ${this._chunkData.id}`);
@@ -961,9 +950,9 @@ class ContinuousProfiler {constructor() { ContinuousProfiler.prototype.__init.ca
         core.logger.log('[Profiling] Failed to collect profile, sentry client was never attached to the profiler.');
       return;
     }
-    if (!_optionalChain([this, 'access', _8 => _8._chunkData, 'optionalAccess', _9 => _9.id])) {
+    if (!this._chunkData?.id) {
       DEBUG_BUILD &&
-        core.logger.log(`[Profiling] Failed to collect profile for: ${_optionalChain([this, 'access', _10 => _10._chunkData, 'optionalAccess', _11 => _11.id])}, the chunk_id is missing.`);
+        core.logger.log(`[Profiling] Failed to collect profile for: ${this._chunkData?.id}, the chunk_id is missing.`);
       return;
     }
 
@@ -987,7 +976,7 @@ class ContinuousProfiler {constructor() { ContinuousProfiler.prototype.__init.ca
       this._client,
       this._client.getOptions(),
       profile,
-      _optionalChain([this, 'access', _12 => _12._client, 'access', _13 => _13.getSdkMetadata, 'call', _14 => _14(), 'optionalAccess', _15 => _15.sdk]),
+      this._client.getSdkMetadata()?.sdk,
       {
         chunk_id: this._chunkData.id,
         trace_id: this._chunkData.startTraceID,
@@ -1030,7 +1019,7 @@ class ContinuousProfiler {constructor() { ContinuousProfiler.prototype.__init.ca
     const metadata = this._client.getSdkMetadata();
     const tunnel = this._client.getOptions().tunnel;
 
-    const envelope = makeProfileChunkEnvelope(chunk, _optionalChain([metadata, 'optionalAccess', _16 => _16.sdk]), tunnel, dsn);
+    const envelope = makeProfileChunkEnvelope(chunk, metadata?.sdk, tunnel, dsn);
     transport.send(envelope).then(null, reason => {
       DEBUG_BUILD && core.logger.error('Error while sending profile chunk envelope:', reason);
     });
@@ -1111,7 +1100,7 @@ class ContinuousProfiler {constructor() { ContinuousProfiler.prototype.__init.ca
    * Assigns thread_id and thread name context to a profiled event.
    */
    _assignThreadIdContext(event) {
-    if (!_optionalChain([event, 'optionalAccess', _17 => _17['contexts'], 'optionalAccess', _18 => _18['profile']])) {
+    if (!event?.['contexts']?.['profile']) {
       return;
     }
 
@@ -1122,9 +1111,9 @@ class ContinuousProfiler {constructor() { ContinuousProfiler.prototype.__init.ca
     // @ts-expect-error the trace fallback value is wrong, though it should never happen
     // and in case it does, we dont want to override whatever was passed initially.
     event.contexts['trace'] = {
-      ...(_nullishCoalesce(_optionalChain([event, 'access', _19 => _19.contexts, 'optionalAccess', _20 => _20['trace']]), () => ( {}))),
+      ...(event.contexts?.['trace'] ?? {}),
       data: {
-        ...(_nullishCoalesce(_optionalChain([event, 'access', _21 => _21.contexts, 'optionalAccess', _22 => _22['trace'], 'optionalAccess', _23 => _23['data']]), () => ( {}))),
+        ...(event.contexts?.['trace']?.['data'] ?? {}),
         ['thread.id']: PROFILER_THREAD_ID_STRING,
         ['thread.name']: PROFILER_THREAD_NAME,
       },