@sentry/junior-memory 0.124.1 → 0.124.2

package/dist/api.d.ts

@@ -1,8 +1,9 @@
 /**
- * Authenticated REST resources for personal memories.
+ * Authenticated REST resources for viewer-visible memories.
  *
  * HTTP identity is one verified viewer. Linked platform actors are resolved
- * behind the route boundary and used only to authorize personal scopes.
+ * behind the route boundary and used only to authorize personal and public
+ * workspace scopes.
  */
 import { z } from "zod";
 import { type PluginRouteApp, type PluginUserPageActor } from "@sentry/junior-plugin-api";
@@ -18,6 +19,10 @@ export declare const memoryApiSchema: z.ZodObject<{
         knowledge: "knowledge";
     }>;
     observedAt: z.ZodISODateTime;
+    visibility: z.ZodEnum<{
+        public: "public";
+        private: "private";
+    }>;
 }, z.core.$strict>;
 export declare const memoryListResponseSchema: z.ZodObject<{
     memories: z.ZodArray<z.ZodObject<{
@@ -31,15 +36,18 @@ export declare const memoryListResponseSchema: z.ZodObject<{
             knowledge: "knowledge";
         }>;
         observedAt: z.ZodISODateTime;
+        visibility: z.ZodEnum<{
+            public: "public";
+            private: "private";
+        }>;
     }, z.core.$strict>>;
     nextCursor: z.ZodOptional<z.ZodString>;
 }, z.core.$strict>;
 export declare const memoryDashboardResponseSchema: z.ZodObject<{
     days: z.ZodArray<z.ZodObject<{
         date: z.ZodISODate;
-        knowledge: z.ZodNumber;
-        preference: z.ZodNumber;
-        procedure: z.ZodNumber;
+        personal: z.ZodNumber;
+        public: z.ZodNumber;
     }, z.core.$strict>>;
     generatedAt: z.ZodISODateTime;
     stats: z.ZodObject<{
@@ -49,8 +57,10 @@ export declare const memoryDashboardResponseSchema: z.ZodObject<{
         embedded: z.ZodNumber;
         explicit: z.ZodNumber;
         knowledge: z.ZodNumber;
+        personal: z.ZodNumber;
         preference: z.ZodNumber;
         procedure: z.ZodNumber;
+        public: z.ZodNumber;
     }, z.core.$strict>;
 }, z.core.$strict>;
 export type MemoryApi = z.output<typeof memoryApiSchema>;
@@ -60,6 +70,6 @@ interface MemoryApiOptions {
     actors(email: string): Promise<PluginUserPageActor[]>;
     db: MemoryDb;
 }
-/** Create the authenticated personal-memory REST app. */
+/** Create the authenticated viewer-memory REST app. */
 export declare function createMemoryApi(options: MemoryApiOptions): PluginRouteApp;
 export {};

package/dist/index.js

@@ -496,12 +496,12 @@ function visibleScopePredicate(scopes) {
   );
 }
 function activeVisiblePredicate(args) {
-  const scopePredicate = visibleScopePredicate(args.scopes);
-  if (!scopePredicate) {
+  const scopePredicate2 = visibleScopePredicate(args.scopes);
+  if (!scopePredicate2) {
     return void 0;
   }
   return and(
-    scopePredicate,
+    scopePredicate2,
     isNull(juniorMemoryMemories.archivedAtMs),
     isNull(juniorMemoryMemories.supersededAtMs),
     isNull(juniorMemoryMemories.supersededById),
@@ -571,12 +571,12 @@ async function findByIdempotencyKey(args) {
   return void 0;
 }
 async function archiveExpiredMemoryBatch(args) {
-  const scopePredicate = visibleScopePredicate(args.scopes);
-  if (!scopePredicate) {
+  const scopePredicate2 = visibleScopePredicate(args.scopes);
+  if (!scopePredicate2) {
     return { archivedCount: 0 };
   }
   const predicates = [
-    scopePredicate,
+    scopePredicate2,
     isNull(juniorMemoryMemories.archivedAtMs),
     isNull(juniorMemoryMemories.supersededAtMs),
     isNull(juniorMemoryMemories.supersededById),
@@ -1765,6 +1765,7 @@ import { z as z5 } from "zod";
 import { and as and2, asc as asc2, desc as desc2, eq as eq2, gt as gt2, ilike, like as like2, lt, or as or2, sql as sql3 } from "drizzle-orm";
 import { z as z4 } from "zod";
 var nonEmptyStringSchema3 = z4.string().min(1);
+var memoryVisibilitySchema = z4.enum(["private", "public"]);
 var personalMemoryCursorSchema = z4.object({
   createdAtMs: z4.number().finite(),
   id: nonEmptyStringSchema3
@@ -1774,7 +1775,8 @@ var personalMemoryPageInputSchema = z4.object({
   kind: z4.enum(MEMORY_KINDS).optional(),
   limit: z4.number().int().min(1).max(50),
   origin: z4.enum(["automatic", "explicit"]).optional(),
-  query: z4.string().max(200).optional()
+  query: z4.string().max(200).optional(),
+  visibility: memoryVisibilitySchema.optional()
 }).strict();
 var personalMemoryTimelineInputSchema = z4.object({
   days: z4.number().int().min(1).max(365)
@@ -1796,7 +1798,26 @@ function personalScopes(runtimeContexts) {
     ).values()
   ];
 }
-function personalScopePredicate(scopes) {
+function publicWorkspaceScopes(runtimeContexts) {
+  return [
+    ...new Map(
+      runtimeContexts.flatMap((context) => {
+        if (context.source.platform !== "slack" || !context.actor) {
+          return [];
+        }
+        if (context.actor.platform !== "slack") {
+          return [];
+        }
+        const scope = {
+          scope: "conversation",
+          scopeKey: `slack:${context.actor.teamId}`
+        };
+        return [[`${scope.scope}:${scope.scopeKey}`, scope]];
+      })
+    ).values()
+  ];
+}
+function scopePredicate(scopes) {
   if (scopes.length === 0) return void 0;
   return or2(
     ...scopes.map(
@@ -1822,21 +1843,50 @@ function memoryOrigin(idempotencyKey) {
   if (idempotencyKey?.startsWith("tool:")) return "explicit";
   return "other";
 }
+function memoryVisibility(scope) {
+  return scope === "personal" ? "private" : "public";
+}
 function personalMemoryRecord(row) {
+  const memory = parseMemoryRow(row);
   return {
-    ...parseMemoryRow(row),
+    ...memory,
     origin: memoryOrigin(row.idempotencyKey),
-    sourcePlatform: row.sourcePlatform
+    sourcePlatform: row.sourcePlatform,
+    visibility: memoryVisibility(memory.scope)
+  };
+}
+function emptyStats() {
+  return {
+    active: 0,
+    automatic: 0,
+    createdThirtyDays: 0,
+    embedded: 0,
+    explicit: 0,
+    knowledge: 0,
+    personal: 0,
+    preference: 0,
+    procedure: 0,
+    public: 0
   };
 }
 function createPersonalMemoryCollection(db, runtimeContexts, options = {}) {
-  const scopes = personalScopes(runtimeContexts);
+  const privateScopes = personalScopes(runtimeContexts);
+  const publicScopes = publicWorkspaceScopes(runtimeContexts);
+  const allScopes = [...privateScopes, ...publicScopes];
   const getNowMs = () => options.now?.() ?? Date.now();
+  function scopesForVisibility(visibility) {
+    if (visibility === "private") return privateScopes;
+    if (visibility === "public") return publicScopes;
+    return allScopes;
+  }
   return {
     async archive(id) {
       const memoryId = nonEmptyStringSchema3.parse(id);
       const nowMs = getNowMs();
-      const predicate = activeVisiblePredicate({ nowMs, scopes });
+      const predicate = activeVisiblePredicate({
+        nowMs,
+        scopes: privateScopes
+      });
       if (!predicate) {
         throw new PersonalMemoryNotFoundError();
       }
@@ -1853,7 +1903,7 @@ function createPersonalMemoryCollection(db, runtimeContexts, options = {}) {
     async get(id) {
       const memoryId = nonEmptyStringSchema3.parse(id);
       const nowMs = getNowMs();
-      const predicate = activeVisiblePredicate({ nowMs, scopes });
+      const predicate = activeVisiblePredicate({ nowMs, scopes: allScopes });
       if (!predicate) {
         throw new PersonalMemoryNotFoundError();
       }
@@ -1861,11 +1911,12 @@ function createPersonalMemoryCollection(db, runtimeContexts, options = {}) {
       if (!rows[0]) {
         throw new PersonalMemoryNotFoundError();
       }
-      return parseMemoryRow(rows[0]);
+      return personalMemoryRecord(rows[0]);
     },
     async list(input) {
       input = personalMemoryPageInputSchema.parse(input);
       const nowMs = getNowMs();
+      const scopes = scopesForVisibility(input.visibility);
       await archiveExpiredMemoryBatch({ db, nowMs, scopes });
       const active = activeVisiblePredicate({ nowMs, scopes });
       if (!active) {
@@ -1905,19 +1956,10 @@ function createPersonalMemoryCollection(db, runtimeContexts, options = {}) {
     },
     async stats() {
       const nowMs = getNowMs();
-      await archiveExpiredMemoryBatch({ db, nowMs, scopes });
-      const active = activeVisiblePredicate({ nowMs, scopes });
+      await archiveExpiredMemoryBatch({ db, nowMs, scopes: allScopes });
+      const active = activeVisiblePredicate({ nowMs, scopes: allScopes });
       if (!active) {
-        return {
-          active: 0,
-          automatic: 0,
-          createdThirtyDays: 0,
-          embedded: 0,
-          explicit: 0,
-          knowledge: 0,
-          preference: 0,
-          procedure: 0
-        };
+        return emptyStats();
       }
       const [counts] = await db.select({
         active: sql3`count(*)`.mapWith(Number),
@@ -1936,11 +1978,17 @@ function createPersonalMemoryCollection(db, runtimeContexts, options = {}) {
         knowledge: sql3`count(*) filter (where ${juniorMemoryMemories.kind} = 'knowledge')`.mapWith(
           Number
         ),
+        personal: sql3`count(*) filter (where ${juniorMemoryMemories.scope} = 'personal')`.mapWith(
+          Number
+        ),
         preference: sql3`count(*) filter (where ${juniorMemoryMemories.kind} = 'preference')`.mapWith(
           Number
         ),
         procedure: sql3`count(*) filter (where ${juniorMemoryMemories.kind} = 'procedure')`.mapWith(
           Number
+        ),
+        public: sql3`count(*) filter (where ${juniorMemoryMemories.scope} = 'conversation')`.mapWith(
+          Number
         )
       }).from(juniorMemoryMemories).leftJoin(
         juniorMemoryEmbeddings,
@@ -1953,34 +2001,32 @@ function createPersonalMemoryCollection(db, runtimeContexts, options = {}) {
         embedded: counts?.embedded ?? 0,
         explicit: counts?.explicit ?? 0,
         knowledge: counts?.knowledge ?? 0,
+        personal: counts?.personal ?? 0,
         preference: counts?.preference ?? 0,
-        procedure: counts?.procedure ?? 0
+        procedure: counts?.procedure ?? 0,
+        public: counts?.public ?? 0
       };
     },
     async timeline(input) {
       input = personalMemoryTimelineInputSchema.parse(input);
       const todayMs = Date.parse(`${utcDate(getNowMs())}T00:00:00.000Z`);
       const startMs = todayMs - (input.days - 1) * DAY_MS;
-      const ownership = personalScopePredicate(scopes);
+      const ownership = scopePredicate(allScopes);
       if (!ownership) {
         return Array.from({ length: input.days }, (_, index2) => ({
           date: utcDate(startMs + index2 * DAY_MS),
-          knowledge: 0,
-          preference: 0,
-          procedure: 0
+          personal: 0,
+          public: 0
         }));
       }
       const rows = await db.select({
         date: sql3`to_char(to_timestamp(${juniorMemoryMemories.createdAtMs} / 1000.0) AT TIME ZONE 'UTC', 'YYYY-MM-DD')`.as(
           "date"
         ),
-        knowledge: sql3`count(*) filter (where ${juniorMemoryMemories.kind} = 'knowledge')`.mapWith(
-          Number
-        ),
-        preference: sql3`count(*) filter (where ${juniorMemoryMemories.kind} = 'preference')`.mapWith(
+        personal: sql3`count(*) filter (where ${juniorMemoryMemories.scope} = 'personal')`.mapWith(
           Number
         ),
-        procedure: sql3`count(*) filter (where ${juniorMemoryMemories.kind} = 'procedure')`.mapWith(
+        public: sql3`count(*) filter (where ${juniorMemoryMemories.scope} = 'conversation')`.mapWith(
           Number
         )
       }).from(juniorMemoryMemories).where(
@@ -1994,9 +2040,8 @@ function createPersonalMemoryCollection(db, runtimeContexts, options = {}) {
         const row = byDate.get(date);
         return {
           date,
-          knowledge: row?.knowledge ?? 0,
-          preference: row?.preference ?? 0,
-          procedure: row?.procedure ?? 0
+          personal: row?.personal ?? 0,
+          public: row?.public ?? 0
         };
       });
     }
@@ -2010,7 +2055,8 @@ var cursorSchema = z5.object({
   kind: z5.enum(["preference", "procedure", "knowledge"]).optional(),
   origin: z5.enum(["automatic", "explicit"]).optional(),
   query: z5.string().max(200).optional(),
-  version: z5.literal(1)
+  version: z5.literal(1),
+  visibility: z5.enum(["private", "public"]).optional()
 }).strict();
 var InvalidMemoryCursorError = class extends Error {
   constructor() {
@@ -2045,7 +2091,7 @@ function decodeCursor(value, input) {
     const parsed = cursorSchema.parse(
       JSON.parse(Buffer.from(value, "base64url").toString("utf8"))
     );
-    if (parsed.query !== input.query || parsed.kind !== input.kind || parsed.origin !== input.origin) {
+    if (parsed.query !== input.query || parsed.kind !== input.kind || parsed.origin !== input.origin || parsed.visibility !== input.visibility) {
       throw new InvalidMemoryCursorError();
     }
     return { createdAtMs: parsed.createdAtMs, id: parsed.id };
@@ -2060,6 +2106,7 @@ function encodeCursor(cursor, input) {
       ...input.query ? { query: input.query } : {},
       ...input.kind ? { kind: input.kind } : {},
       ...input.origin ? { origin: input.origin } : {},
+      ...input.visibility ? { visibility: input.visibility } : {},
       version: 1
     }),
     "utf8"
@@ -2082,7 +2129,8 @@ function createViewerMemories(db, actors) {
       const filters = {
         ...input.kind ? { kind: input.kind } : {},
         ...input.origin ? { origin: input.origin } : {},
-        ...query ? { query } : {}
+        ...query ? { query } : {},
+        ...input.visibility ? { visibility: input.visibility } : {}
       };
       const page = await collection.list({
         cursor: decodeCursor(input.cursor, filters),
@@ -2110,7 +2158,8 @@ var memoryApiSchema = z6.object({
   expiresAt: z6.iso.datetime().optional(),
   id: z6.string().min(1),
   kind: z6.enum(["preference", "procedure", "knowledge"]),
-  observedAt: z6.iso.datetime()
+  observedAt: z6.iso.datetime(),
+  visibility: z6.enum(["private", "public"])
 }).strict();
 var memoryListResponseSchema = z6.object({
   memories: z6.array(memoryApiSchema),
@@ -2118,9 +2167,8 @@ var memoryListResponseSchema = z6.object({
 }).strict();
 var memoryDashboardDaySchema = z6.object({
   date: z6.iso.date(),
-  knowledge: z6.number().int().min(0),
-  preference: z6.number().int().min(0),
-  procedure: z6.number().int().min(0)
+  personal: z6.number().int().min(0),
+  public: z6.number().int().min(0)
 }).strict();
 var memoryDashboardResponseSchema = z6.object({
   days: z6.array(memoryDashboardDaySchema).length(90),
@@ -2132,8 +2180,10 @@ var memoryDashboardResponseSchema = z6.object({
     embedded: z6.number().int().min(0),
     explicit: z6.number().int().min(0),
     knowledge: z6.number().int().min(0),
+    personal: z6.number().int().min(0),
     preference: z6.number().int().min(0),
-    procedure: z6.number().int().min(0)
+    procedure: z6.number().int().min(0),
+    public: z6.number().int().min(0)
   }).strict()
 }).strict();
 var memoryListQuerySchema = z6.object({
@@ -2154,7 +2204,8 @@ function apiMemory(memory) {
     ...memory.expiresAtMs !== void 0 ? { expiresAt: new Date(memory.expiresAtMs).toISOString() } : {},
     id: memory.id,
     kind: memory.kind,
-    observedAt: new Date(memory.observedAtMs).toISOString()
+    observedAt: new Date(memory.observedAtMs).toISOString(),
+    visibility: memory.visibility
   };
 }
 function viewerEmail(context) {
@@ -3281,25 +3332,26 @@ function originLabel(origin) {
   if (origin === "explicit") return "Explicit";
   return "Other";
 }
+function visibilityLabel(visibility) {
+  return visibility === "public" ? "Public" : "Private";
+}
 function pageFilter(filter) {
-  if (filter === "preferences") return { kind: "preference" };
-  if (filter === "automatic") return { origin: "automatic" };
-  if (filter === "explicit") return { origin: "explicit" };
+  if (filter === "private") return { visibility: "private" };
+  if (filter === "public") return { visibility: "public" };
   return {};
 }
 function pageEmptyText(input) {
   if (input.query) return "No memories matched your search.";
-  if (input.filter === "preferences") return "No preferences yet.";
-  if (input.filter === "automatic") return "No learned memories yet.";
-  if (input.filter === "explicit") return "No saved memories yet.";
-  return "No personal memories yet.";
+  if (input.filter === "private") return "No private memories yet.";
+  if (input.filter === "public") return "No public memories yet.";
+  return "No memories yet.";
 }
 function createMemoryUserPage() {
   return {
     id: "memories",
     label: "Memories",
     navigation: "primary",
-    description: "Personal facts and preferences Junior remembers about you.",
+    description: "Personal and public memories Junior can use across conversations.",
     async read(ctx, input) {
       const memories = createViewerMemories(
         ctx.db,
@@ -3317,7 +3369,7 @@ function createMemoryUserPage() {
         ...page.nextCursor ? { nextCursor: page.nextCursor } : {},
         searchPlaceholder: "Search memories",
         records: page.memories.map((memory) => ({
-          actions: [
+          actions: memory.visibility === "private" ? [
             {
               confirmation: "Forget this memory?",
               href: `/api/plugins/memory/memories/${encodeURIComponent(memory.id)}`,
@@ -3325,14 +3377,17 @@ function createMemoryUserPage() {
               method: "DELETE",
               tone: "danger"
             }
-          ],
+          ] : [],
           id: memory.id,
           title: memory.content,
           metadata: [
             { label: "Type", value: titleCase(memory.kind) },
             { label: "Learned", value: originLabel(memory.origin) },
             { label: "Source", value: titleCase(memory.sourcePlatform) },
-            { label: "Visibility", value: "Only you" },
+            {
+              label: "Visibility",
+              value: visibilityLabel(memory.visibility)
+            },
             { label: "Remembered", value: rememberedDate(memory.createdAtMs) },
             { label: "Observed", value: rememberedDate(memory.observedAtMs) },
             {