@sentry/junior-github 0.235.0 → 0.237.0

package/README.md

@@ -25,6 +25,15 @@ export const plugins = defineJuniorPlugins([
 
 Full setup guide: https://junior.sentry.dev/extend/github-plugin/
 
+The plugin tries to assign new pull requests to the current requester's linked
+GitHub account. Assignment is optional. Missing handles, system actors, identity
+lookup errors, and assignment failures do not stop creation or fail the tool.
+If assignment is not possible, the pull request can remain unassigned.
+
+The plugin saves the created pull request before it tries assignment. Retrying
+the same tool call returns the saved pull request without retrying assignment,
+creating another pull request, or replacing existing assignees.
+
 The plugin owns its signed webhook route, deployment, pull request, and release
 events, and normalized pull request and issue outcome projections.
 Those projections also feed native code-change records used by the dashboard

package/dist/{chunk-XP2336UO.js → chunk-UB3DDGLH.js}

@@ -1224,6 +1224,27 @@ async function loadCheckSuiteFacts(args) {
   return facts.failingChecks || facts.pullRequestFactsByNumber ? facts : void 0;
 }
 
+// src/webhooks/ownership.ts
+var GITHUB_BOT_NOREPLY_EMAIL = /^(?<userId>[1-9]\d*)\+(?<login>[^@]+\[bot\])@users\.noreply\.github\.com$/i;
+function parseGitHubBotIdentity(value) {
+  const match = GITHUB_BOT_NOREPLY_EMAIL.exec(value?.trim() ?? "");
+  if (!match?.groups) return void 0;
+  return {
+    login: match.groups.login,
+    userId: Number(match.groups.userId)
+  };
+}
+function botLoginFromEmail(value) {
+  return parseGitHubBotIdentity(value)?.login;
+}
+function isBotLogin(login, botEmail) {
+  const botLogin = botLoginFromEmail(botEmail)?.toLowerCase();
+  return Boolean(botLogin && login?.trim().toLowerCase() === botLogin);
+}
+function botUserIdFromEmail(value) {
+  return parseGitHubBotIdentity(value)?.userId;
+}
+
 // src/webhooks/events.ts
 function gitHubEventKey2(deliveryId, eventType) {
   return `github:${deliveryId}:${eventType}`;
@@ -1403,14 +1424,15 @@ var issueCommentWebhookSchema = z2.object({
   }),
   repository: repositorySchema2
 });
-function normalizeIssueCommentEvents(deliveryId, body) {
+function normalizeIssueCommentEvents(deliveryId, body, botEmail) {
   const parsed = issueCommentWebhookSchema.safeParse(body);
   if (!parsed.success || parsed.data.action !== "created") return [];
+  const author = parsed.data.comment.user?.login;
+  if (isBotLogin(author, botEmail)) return [];
   const input = {
     number: parsed.data.issue.number,
     repo: parsed.data.repository.full_name
   };
-  const author = parsed.data.comment.user?.login;
   if (parsed.data.issue.pull_request) {
     const eventType = "pull_request.comment.created";
     const resource = gitHubPullRequestResource(input);
@@ -1531,9 +1553,10 @@ var pullRequestReviewCommentWebhookSchema = z2.object({
   }),
   repository: repositorySchema2
 });
-function normalizePullRequestReviewCommentEvent(deliveryId, body) {
+function normalizePullRequestReviewCommentEvent(deliveryId, body, botEmail) {
   const parsed = pullRequestReviewCommentWebhookSchema.safeParse(body);
   if (!parsed.success || parsed.data.action !== "created") return [];
+  if (isBotLogin(parsed.data.comment.user?.login, botEmail)) return [];
   const eventType = "pull_request.review_comment.created";
   const repo = parsed.data.repository.full_name;
   const resource = gitHubPullRequestResource({
@@ -1585,9 +1608,10 @@ var pullRequestReviewWebhookSchema = z2.object({
     user: z2.object({ login: z2.string().optional() }).optional()
   })
 });
-function normalizePullRequestReviewEvent(deliveryId, body) {
+function normalizePullRequestReviewEvent(deliveryId, body, botEmail) {
   const parsed = pullRequestReviewWebhookSchema.safeParse(body);
   if (!parsed.success || parsed.data.action !== "submitted") return [];
+  if (isBotLogin(parsed.data.review.user?.login, botEmail)) return [];
   const reviewState = parsed.data.review.state.toUpperCase();
   const eventType = reviewState === "APPROVED" ? "pull_request.review.approved" : reviewState === "CHANGES_REQUESTED" ? "pull_request.review.changes_requested" : reviewState === "COMMENTED" ? "pull_request.review.commented" : void 0;
   if (!eventType) return [];
@@ -1811,11 +1835,23 @@ function normalizeGitHubEvents(args) {
     case "issues":
       return normalizeIssueEvents(args.deliveryId, args.body);
     case "pull_request_review":
-      return normalizePullRequestReviewEvent(args.deliveryId, args.body);
+      return normalizePullRequestReviewEvent(
+        args.deliveryId,
+        args.body,
+        args.botEmail
+      );
     case "issue_comment":
-      return normalizeIssueCommentEvents(args.deliveryId, args.body);
+      return normalizeIssueCommentEvents(
+        args.deliveryId,
+        args.body,
+        args.botEmail
+      );
     case "pull_request_review_comment":
-      return normalizePullRequestReviewCommentEvent(args.deliveryId, args.body);
+      return normalizePullRequestReviewCommentEvent(
+        args.deliveryId,
+        args.body,
+        args.botEmail
+      );
     case "check_suite":
       return normalizeCheckSuiteEvents(
         args.deliveryId,
@@ -1847,6 +1883,9 @@ export {
   GITHUB_RELEASE_SUGGESTED_EVENTS,
   gitHubReleaseSourceSubscribable,
   gitHubRepositorySubscribable,
+  botLoginFromEmail,
+  isBotLogin,
+  botUserIdFromEmail,
   GITHUB_APP_ID_ENV,
   GITHUB_APP_PRIVATE_KEY_ENV,
   GITHUB_INSTALLATION_ID_ENV,

package/dist/index.js

@@ -19,6 +19,8 @@ import {
   HTTP_READ_METHODS,
   USER_TOKEN_GRANTS,
   USER_WRITE_REQUIREMENTS,
+  botLoginFromEmail,
+  botUserIdFromEmail,
   createPermissionCache,
   credentialUnavailable,
   gitHubDeploymentSourceSubscribable,
@@ -29,6 +31,7 @@ import {
   gitHubRepositorySubscribable,
   githubRepositoryFromUrl,
   githubRequest,
+  isBotLogin,
   isRecord,
   issueInstallationCredential,
   issueInstallationToken,
@@ -43,7 +46,7 @@ import {
   readGrantPermissions,
   requireEnv,
   resolveUserAccount
-} from "./chunk-XP2336UO.js";
+} from "./chunk-UB3DDGLH.js";
 
 // src/plugin.ts
 import {
@@ -1353,6 +1356,44 @@ async function createGitHubPullRequest(ctx, request) {
     url: pullRequest.html_url
   };
 }
+async function assignPullRequestRequester(ctx, input, result) {
+  if (!ctx.actor || ctx.actor.platform === "system") return;
+  try {
+    const requester = await ctx.users.resolveActor();
+    const assignee = requester?.user?.identities.find((identity) => identity.provider === "github")?.handle?.trim();
+    if (!assignee) return;
+    const repo = parseRepo4(input.repo);
+    const response = await ctx.egress.fetch({
+      provider: "github",
+      operation: "github.pull.assign",
+      request: new Request(
+        `https://api.github.com/repos/${encodeURIComponent(repo.owner)}/${encodeURIComponent(repo.name)}/issues/${result.number}/assignees`,
+        {
+          method: "POST",
+          headers: {
+            Accept: "application/vnd.github+json",
+            "Content-Type": "application/json",
+            "X-GitHub-Api-Version": "2022-11-28"
+          },
+          body: JSON.stringify({ assignees: [assignee] })
+        }
+      )
+    });
+    if (!response.ok) {
+      ctx.log.warn("github.pull_request.assign_after_create.rejected", {
+        number: result.number,
+        repo: input.repo,
+        status: response.status
+      });
+    }
+  } catch (error) {
+    ctx.log.warn("github.pull_request.assign_after_create.failed", {
+      error: error instanceof Error ? error.message : String(error),
+      number: result.number,
+      repo: input.repo
+    });
+  }
+}
 function gitHubPullRequestToolResult(input, result, canSubscribe, omitSuggestedEvents) {
   const repo = parseRepo4(input.repo);
   const subscribable = canSubscribe ? gitHubPullRequestSubscribable({
@@ -1431,7 +1472,7 @@ function createGitHubPullRequestTool(ctx, subscriptionConfig) {
       openWorldHint: true,
       readOnlyHint: false
     },
-    description: "Create a GitHub pull request with a runtime-owned conversation footer. Use this instead of shelling out to gh pr create when creating pull requests.",
+    description: "Create a GitHub pull request with a runtime-owned conversation footer and assign it to the requester's linked GitHub account when available. Use this instead of shelling out to gh pr create when creating pull requests.",
     exposure: "direct",
     inputSchema: createPullRequestToolInputSchema,
     outputSchema: gitHubPullRequestOutputSchema,
@@ -1485,33 +1526,39 @@ function createGitHubPullRequestTool(ctx, subscriptionConfig) {
             pendingState,
             GITHUB_PULL_REQUEST_CREATE_IDEMPOTENCY_TTL_MS
           );
+          let result;
           try {
-            const result = await createGitHubPullRequest(ctx, request);
-            Object.assign(pendingState, { status: "completed", ...result });
-            try {
-              await ctx.state.set(
-                key,
-                pendingState,
-                GITHUB_PULL_REQUEST_CREATE_IDEMPOTENCY_TTL_MS
-              );
-            } catch (error) {
-              throw new Error(
-                "GitHub pull request was created, but the runtime could not persist the completed pull request state.",
-                { cause: error }
-              );
-            }
-            return await gitHubPullRequestStructuredResult(
-              ctx,
-              parsedInput,
-              result,
-              subscriptionConfig
-            );
+            result = await createGitHubPullRequest(ctx, request);
           } catch (error) {
             if (isEgressAuthRequired2(error) || isDefinitiveGitHubPullRequestCreateRejection(error)) {
               await ctx.state.delete(key);
             }
             throw error;
           }
+          const completedState = {
+            ...pendingState,
+            status: "completed",
+            ...result
+          };
+          try {
+            await ctx.state.set(
+              key,
+              completedState,
+              GITHUB_PULL_REQUEST_CREATE_IDEMPOTENCY_TTL_MS
+            );
+          } catch (error) {
+            throw new Error(
+              "GitHub pull request was created, but the runtime could not persist the completed pull request state.",
+              { cause: error }
+            );
+          }
+          await assignPullRequestRequester(ctx, parsedInput, result);
+          return await gitHubPullRequestStructuredResult(
+            ctx,
+            parsedInput,
+            result,
+            subscriptionConfig
+          );
         }
       );
     }
@@ -2217,25 +2264,6 @@ import {
   pluginToolOutputSchema as pluginToolOutputSchema10
 } from "@sentry/junior-plugin-api";
 import { z as z11 } from "zod";
-
-// src/webhooks/ownership.ts
-var GITHUB_BOT_NOREPLY_EMAIL = /^(?<userId>[1-9]\d*)\+(?<login>[^@]+\[bot\])@users\.noreply\.github\.com$/i;
-function parseGitHubBotIdentity(value) {
-  const match = GITHUB_BOT_NOREPLY_EMAIL.exec(value?.trim() ?? "");
-  if (!match?.groups) return void 0;
-  return {
-    login: match.groups.login,
-    userId: Number(match.groups.userId)
-  };
-}
-function botLoginFromEmail(value) {
-  return parseGitHubBotIdentity(value)?.login;
-}
-function botUserIdFromEmail(value) {
-  return parseGitHubBotIdentity(value)?.userId;
-}
-
-// src/tools/update-pull-request-feedback.ts
 var STATUS_TO_REACTION_CONTENT = {
   reviewing: "eyes",
   addressed: "+1",
@@ -3184,15 +3212,13 @@ function normalizeGitHubIssueOutcome(args) {
   if (!openedAt || !updatedAt) {
     throw new Error("GitHub issue lifecycle timestamps are invalid");
   }
-  const authorLogin = issue.user.login.trim().toLowerCase();
-  const botLogin = botLoginFromEmail(args.botEmail)?.toLowerCase();
-  if (parsed.action === "opened" && !botLogin) {
+  if (parsed.action === "opened" && !botLoginFromEmail(args.botEmail)) {
     throw new Error(
       "The configured GitHub App bot email must encode a [bot] login in GitHub's noreply format to classify issue ownership"
     );
   }
   const hasOwnershipMarker = Boolean(
-    botLogin && authorLogin === botLogin && issue.body?.includes(GITHUB_SESSION_FOOTER_START)
+    isBotLogin(issue.user.login, args.botEmail) && issue.body?.includes(GITHUB_SESSION_FOOTER_START)
   );
   const candidateOwned = hasOwnershipMarker && (parsed.action === "opened" || parsed.action === "closed");
   const closedAt = timestamp2(issue.closed_at);
@@ -3239,12 +3265,12 @@ var issueConversationSchema = z17.object({
 );
 function normalizeGitHubIssueConversations(args) {
   const parsed = issueConversationSchema.safeParse(args.body);
-  const botLogin = botLoginFromEmail(args.botEmail)?.toLowerCase();
-  if (!parsed.success || !botLogin) return void 0;
-  const authorLogin = parsed.data.issue.user.login.trim().toLowerCase();
-  if (authorLogin !== botLogin) return void 0;
-  const senderLogin = parsed.data.sender?.login.trim().toLowerCase();
-  if (senderLogin && senderLogin !== botLogin) return void 0;
+  if (!parsed.success) return void 0;
+  if (!isBotLogin(parsed.data.issue.user.login, args.botEmail)) {
+    return void 0;
+  }
+  const sender = parsed.data.sender;
+  if (sender && !isBotLogin(sender.login, args.botEmail)) return void 0;
   const conversationIds = githubConversationIds(parsed.data.issue.body);
   return conversationIds.length > 0 ? {
     conversationIds,
@@ -3358,15 +3384,13 @@ function normalizeGitHubPullRequestOutcome(args) {
   if (!openedAt || !updatedAt) {
     throw new Error("GitHub pull request lifecycle timestamps are invalid");
   }
-  const authorLogin = pullRequest.user.login.trim().toLowerCase();
-  const botLogin = botLoginFromEmail(args.botEmail)?.toLowerCase();
-  if (parsed.action === "opened" && !botLogin) {
+  if (parsed.action === "opened" && !botLoginFromEmail(args.botEmail)) {
     throw new Error(
       "The configured GitHub App bot email must encode a [bot] login in GitHub's noreply format to classify pull request ownership"
     );
   }
   const hasOwnershipMarker = Boolean(
-    botLogin && authorLogin === botLogin && pullRequest.body?.includes(GITHUB_SESSION_FOOTER_START)
+    isBotLogin(pullRequest.user.login, args.botEmail) && pullRequest.body?.includes(GITHUB_SESSION_FOOTER_START)
   );
   const candidateOwned = hasOwnershipMarker && (parsed.action === "opened" || parsed.action === "closed");
   const state = parsed.action !== "closed" ? "open" : pullRequest.merged ? "merged" : "closed_unmerged";
@@ -3391,9 +3415,8 @@ function normalizeGitHubPullRequestOutcome(args) {
 }
 function normalizeGitHubPullRequestConversations(args) {
   const parsed = pullRequestConversationSchema.safeParse(args.body);
-  const botLogin = botLoginFromEmail(args.botEmail)?.toLowerCase();
-  if (!parsed.success || !botLogin) return void 0;
-  if (parsed.data.pull_request.user.login.trim().toLowerCase() !== botLogin || parsed.data.sender.login.trim().toLowerCase() !== botLogin) {
+  if (!parsed.success) return void 0;
+  if (!isBotLogin(parsed.data.pull_request.user.login, args.botEmail) || !isBotLogin(parsed.data.sender.login, args.botEmail)) {
     return void 0;
   }
   const conversationIds = githubConversationIds(parsed.data.pull_request.body);
@@ -3404,9 +3427,8 @@ function normalizeGitHubPullRequestConversations(args) {
 }
 function normalizeGitHubPullRequestLinkedIssues(args) {
   const parsed = pullRequestConversationSchema.safeParse(args.body);
-  const botLogin = botLoginFromEmail(args.botEmail)?.toLowerCase();
-  if (!parsed.success || !botLogin) return void 0;
-  if (parsed.data.pull_request.user.login.trim().toLowerCase() !== botLogin || parsed.data.sender.login.trim().toLowerCase() !== botLogin) {
+  if (!parsed.success) return void 0;
+  if (!isBotLogin(parsed.data.pull_request.user.login, args.botEmail) || !isBotLogin(parsed.data.sender.login, args.botEmail)) {
     return void 0;
   }
   const linkedIssues = githubLinkedIssues(
@@ -3613,6 +3635,7 @@ function createGitHubWebhookRoute(args) {
       }) : void 0;
       const events = normalizeGitHubEvents({
         body,
+        botEmail,
         ...checkSuiteFacts ? { checkSuiteFacts } : void 0,
         deliveryId,
         eventName
@@ -3673,8 +3696,7 @@ var MAX_PAGES = 3;
 var MAX_LISTED_COMMITS = 250;
 async function classifyGitHubPullRequestCommitComposition(args) {
   const botEmail = args.botEmail.trim().toLowerCase();
-  const botLogin = botLoginFromEmail(botEmail)?.toLowerCase();
-  if (!botEmail || !botLogin) {
+  if (!botEmail || !botLoginFromEmail(botEmail)) {
     throw new Error(
       "The configured GitHub App bot email cannot classify pull request commits"
     );
@@ -3688,9 +3710,8 @@ async function classifyGitHubPullRequestCommitComposition(args) {
     inspectedCommits += commits.length;
     for (const commit of commits) {
       foundCommit = true;
-      const authorLogin = commit.authorLogin?.trim().toLowerCase();
       const authorEmail = commit.authorEmail?.trim().toLowerCase();
-      if (authorLogin !== botLogin && authorEmail !== botEmail) {
+      if (!isBotLogin(commit.authorLogin, botEmail) && authorEmail !== botEmail) {
         return "mixed";
       }
     }

package/dist/testing.js

@@ -1,6 +1,6 @@
 import {
   normalizeGitHubEvents
-} from "./chunk-XP2336UO.js";
+} from "./chunk-UB3DDGLH.js";
 export {
   normalizeGitHubEvents
 };

package/dist/webhooks/events.d.ts

@@ -2,10 +2,15 @@ import type { EventInput } from "@sentry/junior-plugin-api";
 import { type GitHubCheckSuiteFacts } from "./check-suite.js";
 export type { GitHubCheckSuiteFacts, GitHubCheckSuitePullRequestFacts, GitHubFailingCheck, } from "./check-suite.js";
 export { buildCheckSuiteEvent, buildCheckSuiteUrl, loadCheckSuiteFacts, needsCheckSuitePullRequestFacts, parseCheckSuiteFactsTarget, parseCheckSuitePublishTargets, selectFailingChecks, } from "./check-suite.js";
-/** Read the check suite target used to load missing suite facts. */
-/** Normalize one verified GitHub delivery into conversation events. */
+/**
+ * Normalize one verified GitHub delivery into conversation events.
+ *
+ * Comments and reviews written by the configured bot are dropped, so Junior
+ * does not react to or act on its own feedback.
+ */
 export declare function normalizeGitHubEvents(args: {
     body: unknown;
+    botEmail?: string;
     checkSuiteFacts?: GitHubCheckSuiteFacts;
     deliveryId: string;
     eventName: string;

package/dist/webhooks/ownership.d.ts

@@ -1,4 +1,6 @@
 /** Derive the provider login encoded in a standard GitHub noreply address. */
 export declare function botLoginFromEmail(value: string | undefined): string | undefined;
+/** Check whether a GitHub login is the bot encoded in the configured bot email. */
+export declare function isBotLogin(login: string | null | undefined, botEmail: string | undefined): boolean;
 /** Derive the GitHub user id encoded in a standard GitHub noreply address. */
 export declare function botUserIdFromEmail(value: string | undefined): number | undefined;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/junior-github",
-  "version": "0.235.0",
+  "version": "0.237.0",
   "private": false,
   "publishConfig": {
     "access": "public"
@@ -31,7 +31,7 @@
     "@sinclair/typebox": "^0.34.49",
     "drizzle-orm": "^0.45.2",
     "zod": "^4.5.4",
-    "@sentry/junior-plugin-api": "0.235.0"
+    "@sentry/junior-plugin-api": "0.237.0"
   },
   "devDependencies": {
     "@oxlint/plugins": "1.79.0",