@sentry/junior-github 0.122.1 → 0.124.0

package/LICENSE

@@ -0,0 +1,201 @@
+Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+   any Contribution intentionally submitted for inclusion in the Work
+   by You to the Licensor shall be under the terms and conditions of
+   this License, without any additional terms or conditions.
+   Notwithstanding the above, nothing herein shall supersede or modify
+   the terms of any separate license agreement you may have executed
+   with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+   names, trademarks, service marks, or product names of the Licensor,
+   except as required for reasonable and customary use in describing the
+   origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+   agreed to in writing, Licensor provides the Work (and each
+   Contributor provides its Contributions) on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+   implied, including, without limitation, any warranties or conditions
+   of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+   PARTICULAR PURPOSE. You are solely responsible for determining the
+   appropriateness of using or redistributing the Work and assume any
+   risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+   whether in tort (including negligence), contract, or otherwise,
+   unless required by applicable law (such as deliberate and grossly
+   negligent acts) or agreed to in writing, shall any Contributor be
+   liable to You for damages, including any direct, indirect, special,
+   incidental, or consequential damages of any character arising as a
+   result of this License or out of the use or inability to use the
+   Work (including but not limited to damages for loss of goodwill,
+   work stoppage, computer failure or malfunction, or any and all
+   other commercial damages or losses), even if such Contributor
+   has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+   the Work or Derivative Works thereof, You may choose to offer,
+   and charge a fee for, acceptance of support, warranty, indemnity,
+   or other liability obligations and/or rights consistent with this
+   License. However, in accepting such obligations, You may act only
+   on Your own behalf and on Your sole responsibility, not on behalf
+   of any other Contributor, and only if You agree to indemnify,
+   defend, and hold each Contributor harmless for any liability
+   incurred by, or claims asserted against, such Contributor by reason
+   of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright [yyyy] [name of copyright owner]
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

package/SETUP.md

@@ -1,6 +1,6 @@
 # GitHub plugin setup
 
-This plugin exposes three skills — `github-code` (clone, source-code investigation, pull requests), `github-issues` (issue workflows), and `attach-github-assets` (local image/video uploads for GitHub markdown). Junior uses GitHub App installation tokens for reads, workflow dispatches, allowlisted issue and pull request writes, and Git branch pushes. Human OAuth is reserved for explicitly personal operations such as pull request reviews and user-attachment uploads.
+This plugin exposes two skills — `github-code` (clone, source-code investigation, pull requests) and `github-issues` (issue workflows). Junior uses GitHub App installation tokens for reads, workflow dispatches, allowlisted issue and pull request writes, and Git branch pushes. Human OAuth is reserved for explicitly personal operations such as pull request reviews and user-attachment uploads.
 
 ## 1) Create/install GitHub App
 

package/dist/index.js

@@ -216,7 +216,7 @@ function actorLabel(actor) {
 function appendGitHubRequesterAttribution(body, actor) {
   const label = actorLabel(actor);
   const attribution = label ? `${GITHUB_REQUEST_ATTRIBUTION_START}
-Requested by ${label} via Junior.
+Requested by ${label}.
 ${GITHUB_REQUEST_ATTRIBUTION_END}` : void 0;
   const normalizedBody = body.trimEnd();
   const existing = new RegExp(
@@ -449,6 +449,12 @@ async function annotateIssue(ctx, input, result) {
 }
 function createGitHubIssueTool(ctx) {
   return definePluginTool({
+    annotations: {
+      destructiveHint: false,
+      idempotentHint: true,
+      openWorldHint: true,
+      readOnlyHint: false
+    },
     description: "Create a GitHub issue with a runtime-owned Junior conversation footer. Use this instead of shelling out to gh issue create when creating issues.",
     inputSchema: createIssueToolInputSchema,
     outputSchema: gitHubIssueOutputSchema,
@@ -625,6 +631,12 @@ function repositoryUrl(repo, path) {
 }
 function createGitHubGetDeploymentTool(ctx) {
   return definePluginTool2({
+    annotations: {
+      destructiveHint: false,
+      idempotentHint: true,
+      openWorldHint: true,
+      readOnlyHint: true
+    },
     description: "Get the latest GitHub deployment and status for an exact repository and full commit SHA, optionally limited to one environment. The result remains subscribable when no deployment exists yet, so use it before waiting for a deployment outcome.",
     inputSchema,
     outputSchema,
@@ -991,6 +1003,12 @@ function gitHubPullRequestStructuredResult(input, result) {
 }
 function createGitHubPullRequestTool(ctx) {
   return definePluginTool3({
+    annotations: {
+      destructiveHint: false,
+      idempotentHint: true,
+      openWorldHint: true,
+      readOnlyHint: false
+    },
     description: "Create a GitHub pull request with a runtime-owned Junior conversation footer. Use this instead of shelling out to gh pr create when creating pull requests.",
     inputSchema: createPullRequestToolInputSchema,
     outputSchema: gitHubPullRequestOutputSchema,
@@ -1119,6 +1137,12 @@ async function readJson2(response) {
 }
 function createGitHubGetPullRequestTool(ctx) {
   return definePluginTool4({
+    annotations: {
+      destructiveHint: false,
+      idempotentHint: true,
+      openWorldHint: true,
+      readOnlyHint: true
+    },
     description: "Get a GitHub pull request. Use this when an existing PR may need resource-event monitoring; the result includes a subscribable hint when GitHub webhooks are configured.",
     inputSchema: inputSchema2,
     outputSchema: outputSchema2,
@@ -1249,6 +1273,12 @@ function githubApiErrorMessage3(payload) {
 }
 function createGitHubUpdatePullRequestTool(ctx) {
   return definePluginTool5({
+    annotations: {
+      destructiveHint: true,
+      idempotentHint: true,
+      openWorldHint: true,
+      readOnlyHint: false
+    },
     description: "Update an existing GitHub pull request's title, body, base branch, or open/closed state. Use this instead of raw GitHub API calls when changing PR metadata.",
     inputSchema: inputSchema3,
     outputSchema: outputSchema3,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/junior-github",
-  "version": "0.122.1",
+  "version": "0.124.0",
   "private": false,
   "publishConfig": {
     "access": "public"
@@ -31,7 +31,7 @@
     "@sinclair/typebox": "^0.34.49",
     "drizzle-orm": "^0.45.2",
     "zod": "^4.4.3",
-    "@sentry/junior-plugin-api": "0.122.1"
+    "@sentry/junior-plugin-api": "0.124.0"
   },
   "devDependencies": {
     "@types/node": "^25.9.1",

package/skills/github-issues/SKILL.md

@@ -57,7 +57,8 @@ Follow [references/research-rules.md](references/research-rules.md) for cross-ty
 - Prefer flat bullet lists over headed sections for simple issues. Remove empty sections.
 - Generalize session framing — strip channel references, slash commands, Slack thread IDs, user @mentions, and transcript fragments; replace with the underlying technical problem.
 - Compress source material. Research notes, hypotheses, or transcripts become a short summary + scoped bullets — never paste raw investigation into the body.
-- Do not add desired outcome, expected behavior, or acceptance criteria unless the thread explicitly requests them.
+- Do not add desired outcome, expected behavior, acceptance criteria, fixes, implementation steps, approaches, or options unless the user explicitly asks to preserve a specific proposal.
+- Never infer a solution from research. If a user-provided proposal must be preserved, attribute it as a proposal and keep it separate from verified diagnosis.
 - Preserve material source references inline.
 
 **Source attribution:**
@@ -74,6 +75,7 @@ Before running the `gh` create/edit command, check each gate. If any fails, revi
 - Title length ≤ 60 characters.
 - No session framing remains (channel refs, slash commands, @mentions, Slack thread IDs).
 - Body structure matches complexity — no empty sections, no restated title, no raw research dump.
+- No invented or unattributed solution, implementation step, approach, or option appears in the title or body.
 
 Run [references/issue-quality-checklist.md](references/issue-quality-checklist.md) for holistic soft-signal review when the draft warrants it.
 
@@ -93,5 +95,5 @@ Run [references/issue-quality-checklist.md](references/issue-quality-checklist.m
 
 - Require explicit confirmation only for close/reopen or destructive broad rewrites.
 - Do not overwrite issue fields unless explicitly requested. Prefer partial updates over full body replacement.
-- For `bug` issues, do not present a fix as definitive unless root-cause evidence is explicit.
+- Keep ticket handoffs diagnosis-first. Root-cause evidence can establish what is wrong; it does not justify inventing what should be built or changed.
 - If repository or installation access is missing, stop and return a concrete remediation message.

package/skills/github-issues/references/issue-bug.md

@@ -30,7 +30,7 @@ Research informs what goes in the issue, not how structured it looks.
 3. Separate verified facts from unknowns — label each explicitly.
 4. Form root-cause hypotheses linked to evidence, with confidence (`high`, `medium`, `low`).
 
-Include fix suggestions only when the thread discusses fixes. Do not present a fix as certain without explicit evidence.
+Do not add fix suggestions. If the user explicitly asks to preserve a specific proposal from the source context, attribute it as proposed and keep it separate from verified facts and root-cause hypotheses.
 
 ## Context generalization
 

package/skills/github-issues/references/issue-examples.md

@@ -35,12 +35,10 @@ Good structure — problem-specific sections:
 > 2. First message acquires the lock
 > 3. Second message sets its dedup key, fails lock acquisition
 >
-> ## Expected behavior
+> ## Unknowns
 >
-> Either:
->
-> - **Option A**: Acquire lock before setting dedup key
-> - **Option B**: Clear dedup key on lock failure
+> - Whether lock contention is the only path that consumes the dedup slot without processing
+> - Whether the behavior reproduces across all message entry points
 >
 > ## Workaround
 >
@@ -71,7 +69,7 @@ Bad framing:
 
 > It would be nice to have better config reloading.
 
-Good framing — current state, gap, options:
+Good framing — current state, gap, and impact:
 
 > ## Current behavior
 >
@@ -81,12 +79,9 @@ Good framing — current state, gap, options:
 >
 > Config changes during incidents require redeploying, adding 2-3 minutes to mitigation.
 >
-> ## Options
+> ## Impact
 >
-> | Approach                    | Tradeoff                           |
-> | --------------------------- | ---------------------------------- |
-> | File watch + hot reload     | Simple, but no atomicity guarantee |
-> | Config service with polling | Consistent, but adds a dependency  |
+> During incidents, each config change adds 2-3 minutes of mitigation delay and requires an operator to coordinate the restart.
 
 ## Principles
 
@@ -94,7 +89,6 @@ Good framing — current state, gap, options:
 - Include code snippets when they clarify the pattern
 - Quantify scope precisely ("8 of 9", not "many")
 - Cross-reference related issues and PRs
-- Show concrete options with tradeoffs, not vague "should be fixed"
 - Use tables for structured comparisons
 
 ## Anti-patterns
@@ -102,7 +96,8 @@ Good framing — current state, gap, options:
 - Over-structured issues: using ## Summary, ## Impact, ## Root Cause headings for a 3-line bug
 - Adding "Expected behavior" or "Desired outcome" when the thread didn't state one
 - Restating the title as the first sentence of the body
-- Confident fix claims without root-cause evidence
+- Invented fixes, implementation steps, approaches, or options, even when the root cause is verified
+- Unattributed proposals mixed into verified diagnosis
 - Speculative detail mixed into verified facts
 - Dumping a list of URLs without inline context
 - Session-specific content (slash commands, channel references, raw transcript framing, or unrelated user chatter)

package/skills/github-issues/references/issue-feature.md

@@ -4,11 +4,11 @@ Load when issue type is `feature`. Cross-type rules (title length, delegated foo
 
 ## Primary goal
 
-Propose an intentional improvement with clear current-state analysis and practical options.
+Describe an intentional improvement through verified current-state analysis, the gap, and its impact without prescribing implementation.
 
 ## Shape
 
-A flat bullet list is fine for simple features. Use headed sections only when tradeoffs need detailed framing.
+A flat bullet list is fine for simple features. Use headed sections only when the current-state evidence and impact need detailed framing.
 
 **Summary** — up to 3 sentences describing the improvement. Short imperative title (e.g. "Support SAML SSO for enterprise orgs").
 
@@ -16,15 +16,14 @@ A flat bullet list is fine for simple features. Use headed sections only when tr
 
 - **Current behavior** — how the system works today
 - **Gap** — why current behavior is insufficient, with concrete impact
-- **Options** — viable approaches with tradeoffs (include only when the thread discusses alternatives)
 
-For simple features, skip sections and use flat bullets describing the gap and desired capability.
+For simple features, skip sections and use flat bullets describing the current behavior, gap, and impact.
 
 ## Research guidance
 
 1. Analyze current behavior and why it's insufficient.
 2. Gather prior art when available — include links and what each proves. If none found, omit rather than stating "none found."
-3. Frame options with tradeoffs when the thread discusses alternatives.
+3. Do not generate approaches or options. Preserve a specific proposal only when the user explicitly asks, attribute it, and keep it separate from the gap analysis.
 
 ## Context generalization
 

package/skills/github-issues/references/issue-quality-checklist.md

@@ -15,7 +15,8 @@ Soft-signal review beyond the hard gates in `SKILL.md` § Verify draft. Use when
 ## Anti-patterns to avoid
 
 - Overlong, sprawling bodies with no clear sections.
-- Confident solution claims that are weakly evidenced.
+- Invented fixes, implementation steps, approaches, or options, regardless of diagnostic confidence.
+- User-provided proposals presented without attribution or mixed into verified diagnosis.
 - Speculative detail mixed into verified sections.
 
 ## External guidance

package/skills/github-issues/references/issue-task.md

@@ -17,12 +17,12 @@ A task can be just a title + 2-3 bullets. Use headed sections only when scope is
 - **Background** — why this task exists, with code snippets if relevant
 - **Scope** — what's included and excluded, quantify when possible
 
-For simple tasks, skip sections and use flat bullets for scope and next step.
+For simple tasks, skip sections and use flat bullets for background and scope.
 
 ## Research guidance
 
 - Minimal research by default. Prefer first-party repository context when available.
-- Include implementation steps only when the thread discusses approach. Otherwise, state the goal and scope.
+- Do not generate implementation steps or approaches. Preserve a specific user-provided plan only when explicitly requested, attribute it, and keep it separate from verified scope.
 - Include dependencies or risks only when material.
 
 ## Context generalization

package/skills/attach-github-assets/LICENSE

@@ -1,21 +0,0 @@
-MIT License
-
-Copyright (c) 2026 Intercom
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.

package/skills/attach-github-assets/SKILL.md

@@ -1,41 +0,0 @@
----
-name: attach-github-assets
-description: Upload concrete local images or videos to GitHub user attachments and return markdown-ready links. Use when a user asks to attach a local screenshot, recording, image, or video to a GitHub pull request, issue, body, or comment. Do not use for remote URLs or when no local file path is available.
----
-
-# Attach GitHub Assets
-
-Upload each user-provided local file with `scripts/upload.sh`. Do not replace the upload with a description of what the user could do manually.
-
-## Preconditions
-
-Proceed only when both are true:
-
-- The request identifies a concrete local path for a supported image or video.
-- The destination is a GitHub pull request, issue, body, or comment.
-
-Supported extensions: `png`, `jpg`, `jpeg`, `gif`, `webp`, `svg`, `mov`, `mp4`, `webm`.
-
-Do not upload remote URLs, invent paths, or invoke this skill speculatively. If the request contains no local path, return `no-op: no local file path`.
-
-## Upload
-
-Run from this skill's working directory, once per file:
-
-```bash
-bash scripts/upload.sh "<file-path>" [owner/repo]
-```
-
-- Pass the explicit `owner/repo` when the user supplied one.
-- Otherwise the script resolves the repository from `github.repo` config, then the current checkout's `origin` remote.
-- The script is non-interactive, prints one asset URL on stdout, and prints an actionable error on stderr when it fails.
-- Do not batch files into one invocation. If one upload fails, report that file's exact error and do not claim it uploaded.
-
-## Return markdown
-
-For each successful upload:
-
-- Images: `![filename](asset-url)`
-- Videos: put the asset URL on its own line so GitHub renders it.
-
-Return only the markdown-ready results plus any per-file failures the user needs to act on.

package/skills/attach-github-assets/SOURCES.md

@@ -1,31 +0,0 @@
-# Sources
-
-## Inventory
-
-- `intercom/2x-skills@59213af`, `plugins/pr-tools/skills/attach-github-assets/SKILL.md` — upstream runtime intent and supported use cases; primary source; high confidence; MIT.
-- `intercom/2x-skills@59213af`, `plugins/pr-tools/skills/attach-github-assets/scripts/upload.sh` — upstream endpoint, MIME mapping, and response contract; primary implementation source; high confidence; MIT.
-- `intercom/2x-skills@59213af`, `plugins/pr-tools/LICENSE` — upstream copyright and license notice; authoritative legal source; high confidence.
-- `packages/junior-github/src/credential-support.ts` — local GitHub credential boundary; authoritative local source; high confidence.
-- `packages/junior-github/src/plugin.ts` — local GitHub egress boundary; authoritative local source; high confidence.
-- `packages/junior-github/skills/github-code/SKILL.md` — local repository targeting and credential guidance; authoritative local convention; high confidence.
-- GitHub REST API documentation — no documented user-attachment upload operation found; official source; medium confidence for absence.
-
-## Decisions
-
-- **Adopted:** preserve the upstream one-file-per-upload behavior, supported formats, markdown output, and upload endpoint.
-- **Adopted:** preserve the upstream MIT license in the skill directory as explicitly required.
-- **Replaced:** direct `gh auth token` access with Junior's host-managed requesting-user OAuth credential injection so credentials never enter script output or files.
-- **Replaced:** numeric repository-id override with explicit `owner/repo`; the script resolves the id through authenticated `gh api`.
-- **Narrowed:** automatic activation requires a concrete local path and GitHub destination.
-- **Verified:** a live upload with the repository-scoped installation credential returned HTTP 500; the endpoint's upstream implementation uses a user token.
-
-## Coverage
-
-- Happy path: local image/video, repository resolution, successful URL extraction.
-- Failures: missing path, missing file, unsupported type, unresolved repository, non-201 response, missing URL.
-- Safety: no guessed paths, no remote URLs, no token retrieval, one upload per invocation.
-- Portability: the skill is intentionally Junior GitHub-plugin-specific; relative script paths use the skill working directory supplied by `loadSkill`.
-
-## Stopping Rationale
-
-Further retrieval was low-yield: the upstream implementation, local plugin credential boundary, local skill conventions, tests, and package registration behavior cover the runtime contract. The upload endpoint remains undocumented by GitHub, so the implementation records that limitation rather than inventing a public API guarantee.

package/skills/attach-github-assets/SPEC.md

@@ -1,48 +0,0 @@
-# Attach GitHub Assets Specification
-
-## Intent
-
-Upload local image and video files to GitHub's user-attachment service and return markdown-ready links for pull requests and issues.
-
-## Scope
-
-In scope:
-
-- Concrete local image and video paths.
-- GitHub pull request and issue bodies or comments.
-- Repository resolution from an explicit target, Junior config, or the current checkout.
-
-Out of scope:
-
-- Remote URLs, arbitrary file types, or speculative screenshot requests.
-- Editing a pull request or issue after upload; the calling workflow owns placement.
-- Persisting or printing GitHub credentials.
-
-## Runtime Contract
-
-- Run `scripts/upload.sh` once per local file.
-- Return image markdown or a bare video URL.
-- Surface per-file failures exactly enough for the user to act.
-- Use the GitHub plugin's requesting-user OAuth credential injection; do not retrieve tokens in the script.
-
-## Reference Architecture
-
-- `SKILL.md` contains trigger, execution, and output rules.
-- `scripts/upload.sh` performs deterministic validation, repository resolution, and upload.
-- `LICENSE` preserves the upstream MIT license and copyright notice.
-
-## Validation
-
-- `pnpm skills:check` validates skill structure.
-- Shell syntax and mocked upload smoke checks cover deterministic script behavior.
-- GitHub plugin tests cover credential routing to `uploads.github.com`.
-
-## Known Limitations
-
-- GitHub's user-attachment endpoint is not part of the documented public REST API.
-- A real upload requires the requesting user to authorize the GitHub App.
-
-## Maintenance Notes
-
-- Keep supported extensions synchronized between `SKILL.md` and `scripts/upload.sh`.
-- Preserve `LICENSE` when adapting or moving the skill.

package/skills/attach-github-assets/scripts/upload.sh

@@ -1,83 +0,0 @@
-#!/usr/bin/env bash
-set -euo pipefail
-
-file_path="${1:-}"
-repository="${2:-}"
-
-if [[ -z "$file_path" ]]; then
-  echo "Usage: upload.sh <file-path> [owner/repo]" >&2
-  exit 1
-fi
-
-if [[ ! -f "$file_path" ]]; then
-  echo "Error: File not found: $file_path" >&2
-  exit 1
-fi
-
-filename=$(basename "$file_path")
-extension="${filename##*.}"
-extension=$(printf '%s' "$extension" | tr '[:upper:]' '[:lower:]')
-
-case "$extension" in
-  png) mime_type="image/png" ;;
-  jpg|jpeg) mime_type="image/jpeg" ;;
-  gif) mime_type="image/gif" ;;
-  webp) mime_type="image/webp" ;;
-  svg) mime_type="image/svg+xml" ;;
-  mov) mime_type="video/quicktime" ;;
-  mp4) mime_type="video/mp4" ;;
-  webm) mime_type="video/webm" ;;
-  *)
-    echo "Error: Unsupported file type '.$extension'. Supported: png, jpg, jpeg, gif, webp, svg, mov, mp4, webm" >&2
-    exit 1
-    ;;
-esac
-
-if [[ -z "$repository" ]] && command -v jr-rpc >/dev/null 2>&1; then
-  repository=$(jr-rpc config get github.repo 2>/dev/null || true)
-fi
-
-if [[ -z "$repository" ]]; then
-  remote_url=$(git remote get-url origin 2>/dev/null || true)
-  case "$remote_url" in
-    git@github.com:*) repository="${remote_url#git@github.com:}" ;;
-    https://github.com/*) repository="${remote_url#https://github.com/}" ;;
-  esac
-  repository="${repository%.git}"
-fi
-
-if [[ ! "$repository" =~ ^[^/[:space:]]+/[^/[:space:]]+$ ]]; then
-  echo "Error: Could not resolve a GitHub repository. Pass owner/repo as the second argument or configure github.repo." >&2
-  exit 1
-fi
-
-repository_id=$(gh api "repos/$repository" --jq '.id')
-encoded_name=$(printf '%s' "$filename" | jq -sRr @uri)
-encoded_mime=$(printf '%s' "$mime_type" | jq -sRr @uri)
-response_file=$(mktemp)
-trap 'rm -f "$response_file"' EXIT
-
-http_code=$(curl --silent --show-error \
-  --output "$response_file" \
-  --write-out '%{http_code}' \
-  --request POST \
-  --header 'Content-Type: application/octet-stream' \
-  --header 'Accept: application/json' \
-  --header 'X-GitHub-Api-Version: 2022-11-28' \
-  --data-binary "@$file_path" \
-  "https://uploads.github.com/user-attachments/assets?name=$encoded_name&content_type=$encoded_mime&repository_id=$repository_id")
-
-if [[ "$http_code" != "201" ]]; then
-  echo "Error: Upload failed with HTTP $http_code" >&2
-  cat "$response_file" >&2
-  exit 1
-fi
-
-asset_url=$(jq -r '.url // empty' "$response_file")
-if [[ -z "$asset_url" ]]; then
-  echo "Error: GitHub upload response did not include an asset URL." >&2
-  cat "$response_file" >&2
-  exit 1
-fi
-
-printf '%s\n' "$asset_url"