@sentry/junior-dashboard 0.279.0 → 0.280.0

package/src/client/pages/memory/memoryDashboard.ts

@@ -1,5 +1,5 @@
 import { useQuery } from "@tanstack/react-query";
-import { z } from "zod";
+import * as z from "zod";
 
 import { fetchDashboardJson } from "../../http";
 

package/src/client/pages/memory/memoryRecord.ts

@@ -1,5 +1,5 @@
 import { useQuery } from "@tanstack/react-query";
-import { z } from "zod";
+import * as z from "zod";
 
 import { fetchDashboardJson } from "../../http";
 import type { PluginUserPageRecord } from "../user/pluginUserPageData";

package/src/client/pages/settings/ConnectionsPage.tsx

@@ -1,6 +1,6 @@
 import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
 import { Plug } from "lucide-react";
-import type { z } from "zod";
+import type * as z from "zod";
 import {
   connectionListSchema,
   disconnectConnectionResponseSchema,

package/src/client/pages/user/PluginUserPage.tsx

@@ -27,12 +27,6 @@ import {
   type PluginUserPageRecordAction,
 } from "./pluginUserPageData";
 
-/** Build the canonical dashboard path for a plugin-owned page. */
-export function pluginUserPagePath(pluginName: string, pageId: string): string {
-  if (pluginName === "memory" && pageId === "memories") return "/memories";
-  return `/plugins/${encodeURIComponent(pluginName)}/${encodeURIComponent(pageId)}`;
-}
-
 /** Render the memory library for its first-class permalink route. */
 export function MemoryPermalinkRoute(props: { pages: PluginUserPageLink[] }) {
   const page = props.pages.find(

package/src/client/pages/user/pluginUserPageRoutes.ts

@@ -0,0 +1,5 @@
+/** Build the canonical dashboard path for a plugin-owned page. */
+export function pluginUserPagePath(pluginName: string, pageId: string): string {
+  if (pluginName === "memory" && pageId === "memories") return "/memories";
+  return `/plugins/${encodeURIComponent(pluginName)}/${encodeURIComponent(pageId)}`;
+}

package/src/client/primaryNav.ts

@@ -1,7 +1,7 @@
 import type { PluginUserPageLink } from "@sentry/junior-plugin-api";
 
 import type { DashboardHeaderNavItem } from "./components/layout/DashboardHeader";
-import { pluginUserPagePath } from "./pages/user/PluginUserPage";
+import { pluginUserPagePath } from "./pages/user/pluginUserPageRoutes";
 
 const AUTH_PRIMARY_NAV_PREFIXES = [
   "/admin",

package/src/client/review-desk/reviewItemFormat.ts

@@ -1,4 +1,4 @@
-import { z } from "zod";
+import * as z from "zod";
 import type {
   ConversationReportEvent,
   ReviewItemPayload,

package/src/mock-reporting/fixtures.ts

@@ -393,6 +393,7 @@ function activeConversation(nowMs: number): ConversationDetailReport {
         kind: "resource_link",
         key: "getsentry/payments#42",
         label: "getsentry/payments#42",
+        objectType: "code_change",
         plugin: "github",
         status: "open",
         url: "https://github.com/getsentry/payments/pull/42",
@@ -685,6 +686,7 @@ function dashboardQaConversation(nowMs: number): ConversationDetailReport {
         kind: "resource_link",
         key: "getsentry/getsentry#21571",
         label: "getsentry/getsentry#21571",
+        objectType: "code_change",
         plugin: "github",
         status: "merged",
         url: "https://github.com/getsentry/getsentry/pull/21571",
@@ -695,6 +697,7 @@ function dashboardQaConversation(nowMs: number): ConversationDetailReport {
         kind: "resource_link",
         key: "getsentry/getsentry#21572",
         label: "getsentry/getsentry#21572",
+        objectType: "code_change",
         plugin: "github",
         status: "open",
         url: "https://github.com/getsentry/getsentry/pull/21572",
@@ -705,6 +708,7 @@ function dashboardQaConversation(nowMs: number): ConversationDetailReport {
         kind: "resource_link",
         key: "getsentry/getsentry#21569",
         label: "getsentry/getsentry#21569",
+        objectType: "code_change",
         plugin: "github",
         status: "draft",
         url: "https://github.com/getsentry/getsentry/pull/21569",
@@ -715,6 +719,7 @@ function dashboardQaConversation(nowMs: number): ConversationDetailReport {
         kind: "resource_link",
         key: "getsentry/sentry#121727",
         label: "getsentry/sentry#121727",
+        objectType: "code_change",
         plugin: "github",
         status: "merged",
         url: "https://github.com/getsentry/sentry/pull/121727",
@@ -1180,6 +1185,7 @@ function longConversation(nowMs: number): ConversationDetailReport {
         kind: "resource_link",
         key: "getsentry/junior#2201",
         label: "getsentry/junior#2201",
+        objectType: "code_change",
         plugin: "github",
         status: "draft",
         url: "https://github.com/getsentry/junior/pull/2201",
@@ -1190,6 +1196,7 @@ function longConversation(nowMs: number): ConversationDetailReport {
         kind: "resource_link",
         key: "getsentry/payments#91",
         label: "getsentry/payments#91",
+        objectType: "code_change",
         plugin: "github",
         status: "open",
         url: "https://github.com/getsentry/payments/pull/91",
@@ -1200,6 +1207,7 @@ function longConversation(nowMs: number): ConversationDetailReport {
         kind: "resource_link",
         key: "getsentry/relay#44",
         label: "getsentry/relay#44",
+        objectType: "code_change",
         plugin: "github",
         status: "merged",
         url: "https://github.com/getsentry/relay/pull/44",
@@ -1268,6 +1276,7 @@ function incidentConversation(nowMs: number): ConversationDetailReport {
         kind: "resource_link",
         key: "getsentry/payments#77",
         label: "getsentry/payments#77",
+        objectType: "code_change",
         plugin: "github",
         status: "merged",
         url: "https://github.com/getsentry/payments/pull/77",
@@ -1278,6 +1287,7 @@ function incidentConversation(nowMs: number): ConversationDetailReport {
         kind: "resource_link",
         key: "getsentry/payments#61",
         label: "getsentry/payments#61",
+        objectType: "task",
         plugin: "github",
         status: "closed",
         url: "https://github.com/getsentry/payments/issues/61",
@@ -2281,6 +2291,39 @@ export function readMockConversationEvents(
   };
 }
 
+/**
+ * Return the page around a linked event or Turn. Mock transcripts fit one
+ * page, so it holds every event of the Conversation.
+ */
+export function readMockConversationEventsAround(
+  conversationId: string,
+  link: { event: number } | { turn: string },
+): ConversationEventPage | "turn-not-found" | undefined {
+  const conversation = mockConversations(NOW_MS).find(
+    (candidate) => candidate.conversationId === conversationId,
+  );
+  if (!conversation) return undefined;
+  if (
+    "turn" in link &&
+    !conversation.events.some(
+      ({ data }) =>
+        data.type === "turn_lifecycle" &&
+        data.state === "started" &&
+        data.turnId === link.turn,
+    )
+  ) {
+    return "turn-not-found";
+  }
+  return {
+    events: conversation.events,
+    eventHistory: conversation.eventHistory,
+    generatedAt: NOW,
+    ...(conversation.previousCursor
+      ? { previousCursor: conversation.previousCursor }
+      : undefined),
+  };
+}
+
 function mockBeforeCursor(conversationId: string, seq: number): string {
   return `mock:before:${encodeURIComponent(conversationId)}:${seq}`;
 }

package/src/mock-reporting/routes.ts

@@ -42,6 +42,8 @@ import {
   automationParamsSchema,
   automationSummarySchema,
   automationRunListSchema,
+  conversationCatchUpBodySchema,
+  conversationCatchUpSchema,
 } from "@sentry/junior/api/schema";
 import { mockChartPng } from "./chart-png";
 import {
@@ -56,6 +58,7 @@ import {
   readMockConversationChildAgents,
   readMockConversationDetail,
   readMockConversationEvents,
+  readMockConversationEventsAround,
   readMockConversationFeed,
   readMockConversationPendingMessages,
   readMockConversationStats,
@@ -198,14 +201,30 @@ export function createMockReportingApi(): Hono<{
     if (!params.success) {
       return errorResponse("Invalid route parameters.", 400);
     }
-    // Mock details fit one page and have no unread cursor, so mock history
-    // only pages backward.
-    if (!query.success || !("before" in query.data)) {
+    if (!query.success) {
       return errorResponse("Invalid query parameters.", 400);
     }
     if (!readMockConversationDetail(params.data.conversationId)) {
       return errorResponse("Conversation not found.", 404);
     }
+    if ("event" in query.data || "turn" in query.data) {
+      const around = readMockConversationEventsAround(
+        params.data.conversationId,
+        "event" in query.data
+          ? { event: query.data.event }
+          : { turn: query.data.turn },
+      );
+      return around === "turn-not-found"
+        ? errorResponse("Turn not found.", 404)
+        : around
+          ? jsonResponse(conversationEventPageSchema, around)
+          : errorResponse("Conversation not found.", 404);
+    }
+    // Mock details fit one page and have no unread cursor, so mock history
+    // pages only backward from cursors.
+    if (!("before" in query.data)) {
+      return errorResponse("Invalid query parameters.", 400);
+    }
     const report = readMockConversationEvents(
       params.data.conversationId,
       query.data.before,
@@ -287,6 +306,24 @@ export function createMockReportingApi(): Hono<{
       ? jsonResponse(conversationReadPositionSchema, result)
       : errorResponse("Conversation not found.", 404);
   });
+  app.post("/conversations/:conversationId/catch-up", async (c) => {
+    const params = conversationParamsSchema.safeParse(c.req.param());
+    if (!params.success) {
+      return errorResponse("Invalid route parameters.", 400);
+    }
+    const body = conversationCatchUpBodySchema.safeParse(await c.req.json());
+    if (!body.success) {
+      return errorResponse("Invalid request body.", 400);
+    }
+    if (!readMockConversationDetail(params.data.conversationId)) {
+      return errorResponse("Conversation not found.", 404);
+    }
+    return jsonResponse(conversationCatchUpSchema, {
+      needsYou: "Review the Safari fix on PR #12.",
+      summary:
+        "CI failed on Safari after you left. Junior pushed a fix to PR #12, and the checks pass now.",
+    });
+  });
   app.patch("/conversations/:conversationId/archive", async (c) => {
     const params = conversationParamsSchema.safeParse(c.req.param());
     if (!params.success) {

package/src/public-assets.ts

@@ -1,7 +1,8 @@
-import { existsSync, readdirSync, readFileSync, statSync } from "node:fs";
+import { existsSync, readFileSync } from "node:fs";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
-import { dashboardClientFile, dashboardPublicAssets } from "./assets";
+import * as z from "zod";
+import { dashboardClientManifest, dashboardPublicAssets } from "./assets";
 
 /**
  * URL prefix for the content-hashed dashboard browser files. `juniorNitro()`
@@ -33,28 +34,35 @@ function publicDir(): string | undefined {
   ].find((dir) => existsSync(dir));
 }
 
+/** File under `dist` where the client build names its entry and imports. */
+export const DASHBOARD_CLIENT_MANIFEST_FILE = "client-manifest.json";
+
+/** The client entry and every file it imports statically. */
+export const dashboardClientManifestSchema = z.object({
+  entry: z.string().regex(DASHBOARD_CLIENT_ENTRY_NAME),
+  imports: z.array(z.string().regex(DASHBOARD_PUBLIC_ASSET_NAME)),
+});
+
+/** The dashboard client entry and every file it imports statically. */
+export type DashboardClientManifest = z.infer<
+  typeof dashboardClientManifestSchema
+>;
+
 /**
- * Name the dashboard client entry. Without embedded assets, read the build
- * output on each call, so a client rebuild never leaves the page on a deleted
- * file.
+ * Read the client manifest. Without embedded assets, read the build output on
+ * each call, so a client rebuild never leaves the page on a deleted file.
  */
-export function dashboardClientFileName(): string {
-  if (dashboardClientFile) return dashboardClientFile;
+export function readDashboardClientManifest(): DashboardClientManifest {
+  if (dashboardClientManifest) return dashboardClientManifest;
   const dir = publicDir();
-  // A watch rebuild can leave older entries next to the new one.
-  const newest = dir
-    ? readdirSync(dir)
-        .filter((file) => DASHBOARD_CLIENT_ENTRY_NAME.test(file))
-        .map((file) => ({
-          file,
-          mtimeMs: statSync(path.join(dir, file)).mtimeMs,
-        }))
-        .sort((a, b) => b.mtimeMs - a.mtimeMs)[0]
-    : undefined;
-  if (!newest) {
+  const manifestPath =
+    dir && path.join(dir, "..", DASHBOARD_CLIENT_MANIFEST_FILE);
+  if (!manifestPath || !existsSync(manifestPath)) {
     throw new Error("Junior dashboard client bundle was not found");
   }
-  return newest.file;
+  return dashboardClientManifestSchema.parse(
+    JSON.parse(readFileSync(manifestPath, "utf8")),
+  );
 }
 
 function readPublicAsset(file: string): string | undefined {
@@ -63,7 +71,7 @@ function readPublicAsset(file: string): string | undefined {
     return dashboardPublicAssets[file];
   }
   // An embedded build has every file it can serve.
-  if (dashboardClientFile) return undefined;
+  if (dashboardClientManifest) return undefined;
   const dir = publicDir();
   const assetPath = dir ? path.join(dir, file) : undefined;
   return assetPath && existsSync(assetPath)

package/src/shell.ts

@@ -11,7 +11,7 @@ import {
 import { dashboardRainbowProgressClass } from "./dashboardLoader";
 import {
   DASHBOARD_ASSETS_PATH,
-  dashboardClientFileName,
+  readDashboardClientManifest,
 } from "./public-assets";
 import { DASHBOARD_THEME_COLORS, DASHBOARD_THEME_SCRIPT } from "./theme";
 
@@ -217,6 +217,15 @@ export function renderDashboard(
   const bootstrapScript = bootstrap
     ? `window.__JUNIOR_DASHBOARD_BOOTSTRAP__ = ${scriptJson(bootstrap)};`
     : "";
+  const client = readDashboardClientManifest();
+  // Without these hints, the browser finds the chunks only after the entry
+  // has downloaded and parsed, one round trip later.
+  const clientPreloads = client.imports
+    .map(
+      (file) =>
+        `<link rel="modulepreload" href="${DASHBOARD_ASSETS_PATH}/${file}" />`,
+    )
+    .join("\n  ");
   return new Response(
     `<!DOCTYPE html>
 <html lang="en">
@@ -231,6 +240,7 @@ export function renderDashboard(
   <meta name="apple-mobile-web-app-title" content="${escapeHtml(agentName)}" />
   <link rel="manifest" href="${DASHBOARD_MANIFEST_PATH}" />
   <link rel="apple-touch-icon" href="${DASHBOARD_INSTALL_ICON_PATH}" />
+  ${clientPreloads}
   <title>${escapeHtml(agentName)}</title>
   ${renderSentryHead(sentry)}
   <style>
@@ -297,7 +307,7 @@ export function renderDashboard(
       });
     })();
   </script>
-  <script type="module" src="${DASHBOARD_ASSETS_PATH}/${encodeURIComponent(dashboardClientFileName())}"></script>
+  <script type="module" src="${DASHBOARD_ASSETS_PATH}/${client.entry}"></script>
 </body>
 </html>`,
     {