@sentry/junior-dashboard 0.270.0 → 0.271.0

package/src/client/pages/{SettingsPage.tsx → settings/SettingsPage.tsx}

@@ -8,17 +8,16 @@ import {
 import {
   dashboardIdentitySchema,
   type DashboardIdentity,
-} from "../../api/schema";
-import { Button } from "../components/ui/button";
-import { Input } from "../components/ui/input";
-import { Textarea } from "../components/ui/textarea";
-import { Field, FieldDescription, FieldLabel } from "../components/ui/field";
-import { InlineError } from "../components/InlineError";
-import { Card } from "../components/layout/Card";
-import { useDocumentTitle } from "../documentTitle";
-import { DashboardApiError, fetchDashboardJson, patch, put } from "../http";
-import { dashboardContainerClass } from "../styles";
-import type { DashboardCoreData } from "../types";
+} from "../../../api/schema";
+import { Button } from "../../components/ui/button";
+import { Input } from "../../components/ui/input";
+import { Textarea } from "../../components/ui/textarea";
+import { Field, FieldDescription, FieldLabel } from "../../components/ui/field";
+import { InlineError } from "../../components/InlineError";
+import { Card } from "../../components/layout/Card";
+import { DashboardApiError, fetchDashboardJson, patch, put } from "../../http";
+import type { DashboardCoreData } from "../../types";
+import { SettingsPageLayout } from "./SettingsPageLayout";
 
 const dashboardCoreQueryKey = ["dashboard", "core"] as const;
 const userCustomizationQueryKey = ["dashboard", "user-customization"] as const;
@@ -30,7 +29,6 @@ type SettingsPageProps = {
 
 /** Let the signed-in user manage their dashboard profile. */
 export function SettingsPage({ identity }: SettingsPageProps) {
-  useDocumentTitle("Settings");
   const queryClient = useQueryClient();
   const [displayName, setDisplayName] = useState(identity.user.name ?? "");
   useEffect(() => {
@@ -61,52 +59,48 @@ export function SettingsPage({ identity }: SettingsPageProps) {
   }
 
   return (
-    <div className={`${dashboardContainerClass} px-4 py-8 md:px-8`}>
-      <section className="mx-auto w-full max-w-3xl">
-        <h1 className="m-0 text-2xl font-bold">Settings</h1>
-        <p className="mt-2 mb-0 max-w-2xl text-sm text-dashboard-text-muted">
-          Manage your profile and preferences.
-        </p>
-
-        <form className="mt-6" onSubmit={submit}>
-          <Card className="mb-0" padding="md" variant="raised">
-            <h2 className="m-0 text-lg font-bold">Profile</h2>
-            <Field className="mt-5">
-              <FieldLabel htmlFor="display-name">Display name</FieldLabel>
-              <Input
-                autoComplete="name"
-                id="display-name"
-                maxLength={80}
-                onChange={(event) => {
-                  setDisplayName(event.target.value);
-                  if (updateProfile.isError || updateProfile.isSuccess) {
-                    updateProfile.reset();
-                  }
-                }}
-                value={displayName}
-              />
-              <FieldDescription id="display-name-help">
-                Your display name is shown with your conversations and activity.
-              </FieldDescription>
-            </Field>
-            <div className="mt-5 flex items-center gap-3">
-              <Button disabled={!canSave} type="submit">
-                {updateProfile.isPending ? "Saving…" : "Save changes"}
-              </Button>
-              {updateProfile.isSuccess ? (
-                <p className="m-0 text-sm text-emerald-300">Changes saved.</p>
-              ) : null}
-              {updateProfile.isError ? (
-                <InlineError>
-                  Could not save your display name. Try again.
-                </InlineError>
-              ) : null}
-            </div>
-          </Card>
-        </form>
-        <CustomizationForm />
-      </section>
-    </div>
+    <SettingsPageLayout
+      description="Manage your profile and preferences."
+      title="General"
+    >
+      <form onSubmit={submit}>
+        <Card className="mb-0" padding="md" variant="raised">
+          <h2 className="m-0 text-lg font-bold">Profile</h2>
+          <Field className="mt-5">
+            <FieldLabel htmlFor="display-name">Display name</FieldLabel>
+            <Input
+              autoComplete="name"
+              id="display-name"
+              maxLength={80}
+              onChange={(event) => {
+                setDisplayName(event.target.value);
+                if (updateProfile.isError || updateProfile.isSuccess) {
+                  updateProfile.reset();
+                }
+              }}
+              value={displayName}
+            />
+            <FieldDescription id="display-name-help">
+              Your display name is shown with your conversations and activity.
+            </FieldDescription>
+          </Field>
+          <div className="mt-5 flex items-center gap-3">
+            <Button disabled={!canSave} type="submit">
+              {updateProfile.isPending ? "Saving…" : "Save changes"}
+            </Button>
+            {updateProfile.isSuccess ? (
+              <p className="m-0 text-sm text-emerald-300">Changes saved.</p>
+            ) : null}
+            {updateProfile.isError ? (
+              <InlineError>
+                Could not save your display name. Try again.
+              </InlineError>
+            ) : null}
+          </div>
+        </Card>
+      </form>
+      <CustomizationForm />
+    </SettingsPageLayout>
   );
 }
 
@@ -146,9 +140,7 @@ function CustomizationForm() {
   }
   if (savedText === undefined) {
     return customizationQuery.isError ? (
-      <InlineError className="mt-6">
-        Could not load your customization.
-      </InlineError>
+      <InlineError>Could not load your customization.</InlineError>
     ) : null;
   }
   const canSave =
@@ -162,7 +154,7 @@ function CustomizationForm() {
   }
 
   return (
-    <form className="mt-6" onSubmit={submit}>
+    <form onSubmit={submit}>
       <Card className="mb-0" padding="md" variant="raised">
         <h2 className="m-0 text-lg font-bold">Customization</h2>
         <Field className="mt-5">

package/src/client/pages/settings/SettingsPageLayout.tsx

@@ -0,0 +1,45 @@
+import type { ReactNode } from "react";
+
+import { PageHeader } from "../../components/layout/PageHeader";
+import { PageLayout } from "../../components/layout/PageLayout";
+import { SectionIntro } from "../../components/layout/SectionIntro";
+import { SegmentedNav } from "../../components/SegmentedNav";
+
+const settingsNavigationItems = [
+  { end: true, label: "General", to: "/settings" },
+  { label: "API Tokens", to: "/settings/api-tokens" },
+  { label: "Identities", to: "/settings/connections" },
+  { label: "MCP", to: "/settings/mcp" },
+];
+
+/**
+ * Place one Settings section under the Settings heading and its page links.
+ * Settings opens from the profile menu, not the app navigation, so its page
+ * links sit in the page instead of the header chrome.
+ */
+export function SettingsPageLayout(props: {
+  children: ReactNode;
+  description: ReactNode;
+  title: string;
+}) {
+  return (
+    <PageLayout>
+      <div className="grid w-full max-w-3xl min-w-0 gap-8">
+        <PageHeader
+          documentTitle={props.title}
+          navigation={
+            <SegmentedNav
+              ariaLabel="Settings navigation"
+              items={settingsNavigationItems}
+            />
+          }
+          title="Settings"
+        />
+        <section className="grid min-w-0 gap-5">
+          <SectionIntro description={props.description} title={props.title} />
+          {props.children}
+        </section>
+      </div>
+    </PageLayout>
+  );
+}

package/src/client/primaryNav.ts

@@ -51,7 +51,7 @@ export function buildPrimaryNavItems(input: {
           {
             count: input.reviewCount,
             key: "review",
-            label: "Review desk",
+            label: "Inbox",
             to: "/review",
           },
         ]